Fix for self-hosted-image

Allow additional options when running tune2fs -j on ext3 images and use that to specify -m 0.5 for self-hosted-image.

Note these patches should be applied on top of Saul's recent self-hosted-image patch once that is merged.

The following changes since commit 7c794db563cc35f6deaab1dd0fef35015d47e567:

self-hosted-image: Increase space for build and allow builder user sudo access (2012-04-04 16:16:27 +0100)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/self
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/self

Paul Eggleton (2):
classes/image_types: add IMAGE_TUNE2FS_ext3
self-hosted-image: decrease reserved space to 0.5%

 meta/classes/image_types.bbclass              |    4 +++-
 meta/recipes-core/images/self-hosted-image.bb |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

1.7.5.4

Add a variable that allows additional options to be passed to tune2fs, such as -m to control the amount of space reserved for root.

This could potentially be added for other filesystems, but right now we need it only for ext3 for self-hosted-image.

---
 meta/classes/image_types.bbclass |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

index b590ae1..152e5b4 100644
@@ -132,9 +132,11 @@ IMAGE_CMD_ext2 () {
 	rmdir ${DEPLOY_DIR_IMAGE}/tmp.gz-${PN}
 }
 
+IMAGE_TUNE2FS_ext3 ?= ""
+
 IMAGE_CMD_ext3 () {
 	genext2fs -b $ROOTFS_SIZE -d ${IMAGE_ROOTFS} ${EXTRA_IMAGECMD} ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3
-	tune2fs -j ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3
+	tune2fs -j ${IMAGE_TUNE2FS_ext3} ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3
 }
 
 oe_mkext4fs () {

1.7.5.4

The default amount of reserved space for ext2/3 is 5% - this amounts to about 2GB of a 40GB filesystem that the builder user can't make use of. We don't need this much reserved so peg it back to 0.5% which should be more than enough.

---
 meta/recipes-core/images/self-hosted-image.bb |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

index d2faa66..17ae9ce 100644
@@ -4,7 +4,7 @@ LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 
-PR = "r9"
+PR = "r10"
 
 CORE_IMAGE_EXTRA_INSTALL = "\
     task-self-hosted \

@@ -14,6 +14,8 @@ IMAGE_FEATURES += "x11-mini package-management"
 
 # Ensure there's enough space to do a core-image-sato build, with rm_work enabled
 IMAGE_ROOTFS_EXTRA_SPACE = "41943040"
+# We don't need to reserve much space for root, 0.5% is more than enough
+IMAGE_TUNE2FS_ext3 = "-m 0.5"
 
 # Do a quiet boot with limited console messages
 APPEND += "quiet"

1.7.5.4

I'd prefer something like

IMG_POSTCMD_<fstype>

So it is generic enough to not be confusing for other filesystems.

Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Please look at my comment about a possible alternative way of doing it, in a more generic one.

Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Are you suggesting this would hold the entire post-command to be run? If not, what other post command could we be referring to in the case of other filesystems? (tune2fs being valid for ext2, ext3 and ext4).

Cheers,
Paul

Paul Eggleton
Intel Open Source Technology Centre

Yes; it is more generic and for someone using it, it makes no difference in complexity et all.

Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Actually it does, but I can see some value in it. v2 on the way.

Cheers,
Paul

Paul Eggleton
Intel Open Source Technology Centre