Skip to contentSkip to conversation

beagleboard.conf: fix hardcode of virtual/xserver

PATCH Applied Robert Yang 2 participants 3 messages Apr 10, 2012 – Apr 11, 2012

lore
Share & tools
lore
#0 lore raw

cover beagleboard.conf: fix hardcode of virtual/xserver

The following changes since commit 190f6d791d51aaa4cfb9f1cf932bc205ff674fb5:

runqemu-internal: Add console=tty for qemuppc and NFS (2012-04-06 01:12:47 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/beagle
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/beagle

Robert Yang (1):
beagleboard.conf: fix hardcode of virtual/xserver

 meta-yocto/conf/machine/beagleboard.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
#1 lore raw

PATCH 1/1 beagleboard.conf: fix hardcode of virtual/xserver

Here is the message from the bug 2260:

meta-yocto/conf/machine/beagleboard.conf hardcodes the virtual/xserver provider, i.e., it includes the following:

PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg-lite"

I don't think machine conf is the correct place for selecting what is essentially a distro feature, but at least this should use the '?=' operator; as is to select a different provider one must provide a complete beagleboard.conf file.

[YOCTO #2260]

---
 meta-yocto/conf/machine/beagleboard.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta-yocto/conf/machine/beagleboard.conf +2 -2
index fa2f8e7..06a0ecd 100644
@@ -2,8 +2,8 @@
 #@NAME: Beagleboard machine
 #@DESCRIPTION: Machine configuration for the http://beagleboard.org/ board 
 
-PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg-lite"
-XSERVER = "xserver-xorg-lite \
+PREFERRED_PROVIDER_virtual/xserver ?= "xserver-xorg-lite"
+XSERVER ?= "xserver-xorg-lite \
            xf86-input-evdev \
            xf86-input-mouse \
            xf86-video-omapfb \
Signature · 1 line
1.7.1
Applied
#2 lore raw
In reply to Robert Yang
Quoted 11 lines · Robert Yang

The following changes since commit 190f6d791d51aaa4cfb9f1cf932bc205ff674fb5:

   runqemu-internal: Add console=tty for qemuppc and NFS (2012-04-06 01:12:47 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/beagle
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/beagle

Robert Yang (1):
beagleboard.conf: fix hardcode of virtual/xserver

Quoted 8 lines
  meta-yocto/conf/machine/beagleboard.conf |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Merged into Poky master

Thanks
Sau!