Replace HobNotebook with gtk.Notebook, comments invited
cover Replace HobNotebook with gtk.Notebook, comments invited
*** This series prevents users of distros with old Gtk+ releases using Hob ***
This is a follow-on from my RFC of yesterday with a similar title. Sadly I hadn't realised that one of the API calls I am using is not available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget).
This change will prevent CentOS 6 users from being able to use Hob.
I spent some time in Gtk+ internals trying to figure out if we can emulate the behaviour on older versions but the GtkNotebook widget internals were enhanced significantly to support the set_action_widget API.
I've submitted the change as an RFC regardless, it's ready to merge if we're willing to make the sacrifice.
The primary motivation for making this change, and making it so late in the cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit widgets.
An added benefit is that standard toolkit widgets generally integrate better into the users OS thanks to inheriting their standard theme.
Tested on:
Fedora 16 (x86_64) - PASS
CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 (x86_64) - Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - PASS
Per the final patch in the series the changes here require gtk+-2.20 or newer and pygtk 2.22 or newer.
Cheers,
Joshua
The following changes since commit 434fdb3913cc78e2e9cdeede4c4fa7f1c8ef8892:
Hob: Added required packages for toolchain. (2012-04-13 12:00:12 +0100)
are available in the git repository at:
git://github.com/incandescant/bitbake gtk2.20
https://github.com/incandescant/bitbake/tree/gtk2.20
Joshua Lock (4):
lib/bb/ui/crumbs/: replace custom HobNotebook lib/bb/ui/crumbs/hobwidget: use light text in HobIndicator lib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down width
hob: update required pygtk to 2.22.0 and gtk+ to 2.20.0
lib/bb/ui/crumbs/builddetailspage.py | 6 +- lib/bb/ui/crumbs/hobwidget.py | 499 +++++++--------------------- lib/bb/ui/crumbs/imageconfigurationpage.py | 2 - lib/bb/ui/crumbs/packageselectionpage.py | 3 +- lib/bb/ui/crumbs/recipeselectionpage.py | 5 +- lib/bb/ui/hob.py | 2 +- 6 files changed, 120 insertions(+), 397 deletions(-)
Signature · 1 line
1.7.7.6
PATCH 1/4 lib/bb/ui/crumbs/: replace custom HobNotebook
The custom HobNotebook widget was implemented to address perceived deficiencies in the gtk.Notebook API.
Recent inspection reveals that the API is capable of all that Hob requires of it and therefore maintaining a custom class to provide similar functionality does not make sense.
Addresses [YOCTO #2276]
--- lib/bb/ui/crumbs/builddetailspage.py | 6 +- lib/bb/ui/crumbs/hobwidget.py | 499 +++++++----------------------- lib/bb/ui/crumbs/packageselectionpage.py | 3 +- lib/bb/ui/crumbs/recipeselectionpage.py | 5 +- 4 files changed, 119 insertions(+), 394 deletions(-)
lib/bb/ui/crumbs/builddetailspage.py +3 -3
@@ -144,7 +144,7 @@ class BuildDetailsPage (HobPage): self.scrolled_view_config = gtk.ScrolledWindow () self.scrolled_view_config.set_policy(gtk.POLICY_NEVER, gtk.POLICY_ALWAYS) self.scrolled_view_config.add(self.config_tv) - self.notebook.append_page(self.scrolled_view_config, gtk.Label("Build configuration")) + self.notebook.append_page(self.scrolled_view_config, "Build configuration") self.failure_tv = BuildFailureTreeView() self.failure_model = self.builder.handler.build.model.failure_model()
@@ -152,14 +152,14 @@ class BuildDetailsPage (HobPage): self.scrolled_view_failure = gtk.ScrolledWindow () self.scrolled_view_failure.set_policy(gtk.POLICY_NEVER, gtk.POLICY_ALWAYS) self.scrolled_view_failure.add(self.failure_tv) - self.notebook.append_page(self.scrolled_view_failure, gtk.Label("Issues")) + self.notebook.append_page(self.scrolled_view_failure, "Issues") self.build_tv = RunningBuildTreeView(readonly=True, hob=True) self.build_tv.set_model(self.builder.handler.build.model) self.scrolled_view_build = gtk.ScrolledWindow () self.scrolled_view_build.set_policy(gtk.POLICY_NEVER, gtk.POLICY_ALWAYS) self.scrolled_view_build.add(self.build_tv) - self.notebook.append_page(self.scrolled_view_build, gtk.Label("Log")) + self.notebook.append_page(self.scrolled_view_build, "Log") self.builder.handler.build.model.connect_after("row-changed", self.scroll_to_present_row, self.scrolled_view_build.get_vadjustment(), self.build_tv)
lib/bb/ui/crumbs/hobwidget.py +114 -385
542 lines not on this page · raw message
lib/bb/ui/crumbs/packageselectionpage.py +1 -2
@@ -120,8 +120,7 @@ class PackageSelectionPage (HobPage): if page['name'] == "Included": tab.connect("button-release-event", self.button_click_cb) tab.connect("cell-fadeinout-stopped", self.after_fadeout_checkin_include) - label = gtk.Label(page['name']) - self.ins.append_page(tab, label) + self.ins.append_page(tab, page['name']) self.tables.append(tab) self.ins.set_entry("Search packages:")
lib/bb/ui/crumbs/recipeselectionpage.py +1 -4
@@ -153,10 +153,7 @@ class RecipeSelectionPage (HobPage): if page['name'] == "Included": tab.connect("button-release-event", self.button_click_cb) tab.connect("cell-fadeinout-stopped", self.after_fadeout_checkin_include) - label = gtk.Label(page['name']) - label.set_selectable(False) - label.set_tooltip_text(page['tooltip']) - self.ins.append_page(tab, label) + self.ins.append_page(tab, page['name'], page['tooltip']) self.tables.append(tab) self.ins.set_entry("Search recipes:")
Signature · 1 line
1.7.7.6
PATCH 2/4 lib/bb/ui/crumbs/hobwidget: use light text in HobIndicator
In reply to Joshua LockDark text on a dark background is difficult to read. Further the design document uses white text.
--- lib/bb/ui/crumbs/hobwidget.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
lib/bb/ui/crumbs/hobwidget.py +1 -1
@@ -429,7 +429,7 @@ class HobIndicator(gtk.DrawingArea): x = (w/2)-(textw/2) + 1 y = (h/2) - (texth/2) + 1 ctx.move_to(x, y) - self.window.draw_layout(self.style.fg_gc[gtk.STATE_NORMAL], int(x), int(y), layout) + self.window.draw_layout(self.style.light_gc[gtk.STATE_NORMAL], int(x), int(y), layout) def set_count(self, count): self.count = count
Signature · 1 line
1.7.7.6
PATCH 3/4 lib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down width
In reply to Joshua LockThe width of the combo boxes drop down should match the combo box itself.
--- lib/bb/ui/crumbs/imageconfigurationpage.py | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
lib/bb/ui/crumbs/imageconfigurationpage.py +0 -2
@@ -147,7 +147,6 @@ class ImageConfigurationPage (HobPage): self.machine_title_desc.set_markup(mark) self.machine_combo = gtk.combo_box_new_text() - self.machine_combo.set_wrap_width(1) self.machine_combo.connect("changed", self.machine_combo_changed_cb) icon_file = hic.ICON_LAYERS_DISPLAY_FILE
@@ -196,7 +195,6 @@ class ImageConfigurationPage (HobPage): self.image_title_desc.set_markup(mark) self.image_combo = gtk.combo_box_new_text() - self.image_combo.set_wrap_width(1) self.image_combo_id = self.image_combo.connect("changed", self.image_combo_changed_cb) self.image_desc = gtk.Label()
Signature · 1 line
1.7.7.6
PATCH 4/4 hob: update required pygtk to 2.22.0 and gtk+ to 2.20.0
In reply to Joshua Lock--- lib/bb/ui/hob.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
lib/bb/ui/hob.py +1 -1
@@ -30,7 +30,7 @@ try: pygtk.require('2.0') # to be certain we don't have gtk+ 1.x !?! gtkver = gtk.gtk_version pygtkver = gtk.pygtk_version - if gtkver < (2, 18, 0) or pygtkver < (2, 16, 0): + if gtkver < (2, 20, 0) or pygtkver < (2, 22, 0): sys.exit("%s,\nYou have Gtk+ %s and PyGtk %s." % (requirements, ".".join(map(str, gtkver)), ".".join(map(str, pygtkver))))
Signature · 1 line
1.7.7.6
Quoted 23 lines · Joshua Lock
*** This series prevents users of distros with old Gtk+ releases using Hob ***
This is a follow-on from my RFC of yesterday with a similar title. Sadly I hadn't realised that one of the API calls I am using is not available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget).
This change will prevent CentOS 6 users from being able to use Hob.
I spent some time in Gtk+ internals trying to figure out if we can emulate the behaviour on older versions but the GtkNotebook widget internals were enhanced significantly to support the
set_action_widgetAPI.I've submitted the change as an RFC regardless, it's ready to merge if we're willing to make the sacrifice.
The primary motivation for making this change, and making it so late in the cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit widgets.
An added benefit is that standard toolkit widgets generally integrate better into the users OS thanks to inheriting their standard theme.
Quoted 8 lines
Tested on:
Fedora 16 (x86_64) - PASS
CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 (x86_64) - Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - PASSPer the final patch in the series the changes here require gtk+-2.20 or newer and pygtk 2.22 or newer.
Since we don't have a good external-python tarball solution in place yet, I'm going to have to hold off these patches until after the current release.
Cheers,
Richard
Quoted 30 lines · Richard Purdie
Quoted 29 lines · Joshua Lock
*** This series prevents users of distros with old Gtk+ releases using Hob ***
This is a follow-on from my RFC of yesterday with a similar title. Sadly I hadn't realised that one of the API calls I am using is not available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget).
This change will prevent CentOS 6 users from being able to use Hob.
I spent some time in Gtk+ internals trying to figure out if we can emulate the behaviour on older versions but the GtkNotebook widget internals were enhanced significantly to support the
set_action_widgetAPI.I've submitted the change as an RFC regardless, it's ready to merge if we're willing to make the sacrifice.
The primary motivation for making this change, and making it so late in the cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit widgets.
An added benefit is that standard toolkit widgets generally integrate better into the users OS thanks to inheriting their standard theme.
Tested on:
Fedora 16 (x86_64) - PASS
CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 (x86_64) - Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - PASS
Quoted 6 lines
Quoted 2 lines
Per the final patch in the series the changes here require gtk+-2.20 or newer and pygtk 2.22 or newer.
Since we don't have a good external-python tarball solution in place yet, I'm going to have to hold off these patches until after the current release.
This makes perfect sense and I agree with the decision.
Thanks,
Joshua
Signature · 3 lines
Joshua Lock
Yocto Project
Intel Open Source Technology CentreHi Richard,
There are still some issues in these patches, but I think we can check in first and I also have some fixes which depends on the check-in. I will submit the patches to fix them as long as they are pulled in.
Please to review. Thanks!
--
Liming
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Richard Purdie
Sent: Saturday, April 14, 2012 6:23 PM
To: Joshua Lock
Cc: [email protected]
Subject: Re: [bitbake-devel] [PATCH 0/4] Replace HobNotebook with gtk.Notebook, comments invited
Quoted 24 lines · Joshua Lock
*** This series prevents users of distros with old Gtk+ releases using Hob ***
This is a follow-on from my RFC of yesterday with a similar title.
Sadly I hadn't realised that one of the API calls I am using is not available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget).This change will prevent CentOS 6 users from being able to use Hob.
I spent some time in Gtk+ internals trying to figure out if we can emulate the behaviour on older versions but the GtkNotebook widget internals were enhanced significantly to support the
set_action_widgetAPI.I've submitted the change as an RFC regardless, it's ready to merge if we're willing to make the sacrifice.
The primary motivation for making this change, and making it so late in the cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit widgets.
An added benefit is that standard toolkit widgets generally integrate better into the users OS thanks to inheriting their standard theme.
Quoted 7 lines
Tested on:
Fedora 16 (x86_64) - PASS
CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 (x86_64)
- Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - PASSPer the final patch in the series the changes here require gtk+-2.20 or newer and pygtk 2.22 or newer.
Since we don't have a good external-python tarball solution in place yet, I'm going to have to hold off these patches until after the current release.
Cheers,
Richard
_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel
Hi Joshua,
Sorry for my reply is so late. I know it will be concerned in the version 1.3.
I had tested your patches in 'poky-contrib/josh/hob_next', It's has the same functions as our current version, I agree to merge to current version.
Thanks
--
Liming
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Joshua Lock
Sent: Sunday, April 15, 2012 3:44 AM
To: Richard Purdie
Cc: [email protected]
Subject: Re: [bitbake-devel] [PATCH 0/4] Replace HobNotebook with gtk.Notebook, comments invited
Quoted 31 lines · Richard Purdie
Quoted 30 lines · Joshua Lock
*** This series prevents users of distros with old Gtk+ releases using Hob ***
This is a follow-on from my RFC of yesterday with a similar title.
Sadly I hadn't realised that one of the API calls I am using is not available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget).This change will prevent CentOS 6 users from being able to use Hob.
I spent some time in Gtk+ internals trying to figure out if we can emulate the behaviour on older versions but the GtkNotebook widget internals were enhanced significantly to support the
set_action_widgetAPI.I've submitted the change as an RFC regardless, it's ready to merge if we're willing to make the sacrifice.
The primary motivation for making this change, and making it so late in the cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit widgets.
An added benefit is that standard toolkit widgets generally integrate better into the users OS thanks to inheriting their standard theme.
Tested on:
Fedora 16 (x86_64) - PASS
CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 (x86_64) - Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - PASS
Quoted 6 lines
Quoted 2 lines
Per the final patch in the series the changes here require gtk+-2.20 or newer and pygtk 2.22 or newer.
Since we don't have a good external-python tarball solution in place yet, I'm going to have to hold off these patches until after the current release.
This makes perfect sense and I agree with the decision.
Thanks,
Joshua
--
Joshua Lock
Yocto Project
Intel Open Source Technology Centre
_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel
Quoted 30 lines · Richard Purdie
Quoted 29 lines · Joshua Lock
*** This series prevents users of distros with old Gtk+ releases using Hob ***
This is a follow-on from my RFC of yesterday with a similar title. Sadly I hadn't realised that one of the API calls I am using is not available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget).
This change will prevent CentOS 6 users from being able to use Hob.
I spent some time in Gtk+ internals trying to figure out if we can emulate the behaviour on older versions but the GtkNotebook widget internals were enhanced significantly to support the
set_action_widgetAPI.I've submitted the change as an RFC regardless, it's ready to merge if we're willing to make the sacrifice.
The primary motivation for making this change, and making it so late in the cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit widgets.
An added benefit is that standard toolkit widgets generally integrate better into the users OS thanks to inheriting their standard theme.
Tested on:
Fedora 16 (x86_64) - PASS
CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 (x86_64) - Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - PASS
Quoted 6 lines
Quoted 2 lines
Per the final patch in the series the changes here require gtk+-2.20 or newer and pygtk 2.22 or newer.
Since we don't have a good external-python tarball solution in place yet, I'm going to have to hold off these patches until after the current release.
I've not gone ahead and merged these since they still seem to apply and basically worked when I tested them just now.
Cheers,
Richard
Quoted 7 lines · LimingX L
Hi Richard,
There are still some issues in these patches, but I think we can check in first and I also have some fixes which depends on the check-in. I will submit the patches to fix them as long as they are pulled in.
Please to review. Thanks!
I've merged this, please send the other fixes for review.
Cheers,
Richard
Josh, I just found I can't run Hob on my Ubuntu 10.04 after I checked out the latest master.
Since Ubuntu 10.04 is a long-term-support version, can we do something to make Hob compatible with that? What kind of failure did you meet on Ubuntu 10.04?
--
Shane
Joshua Lock wrote on 2012-04-14:
Quoted 55 lines
*** This series prevents users of distros with old Gtk+ releases using Hob ***
This is a follow-on from my RFC of yesterday with a similar title. Sadly I hadn't realised that one of the API calls I am using is not available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget).
This change will prevent CentOS 6 users from being able to use Hob.
I spent some time in Gtk+ internals trying to figure out if we can emulate the behaviour on older versions but the GtkNotebook widget internals were enhanced significantly to support the
set_action_widgetAPI.I've submitted the change as an RFC regardless, it's ready to merge if we're willing to make the sacrifice.
The primary motivation for making this change, and making it so late in the cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit widgets.
An added benefit is that standard toolkit widgets generally integrate better into the users OS thanks to inheriting their standard theme.
Tested on:
Fedora 16 (x86_64) - PASS
CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 (x86_64) - Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - PASSPer the final patch in the series the changes here require gtk+-2.20 or newer and pygtk 2.22 or newer.
Cheers,
JoshuaThe following changes since commit
434fdb3913cc78e2e9cdeede4c4fa7f1c8ef8892:Hob: Added required packages for toolchain. (2012-04-13 12:00:12 +0100)
are available in the git repository at:
git://github.com/incandescant/bitbakegtk2.20
https://github.com/incandescant/bitbake/tree/gtk2.20
Joshua Lock (4):
lib/bb/ui/crumbs/: replace custom HobNotebooklib/bb/ui/crumbs/hobwidget: use light text in HobIndicatorlib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down width
hob: update required pygtk to 2.22.0 and gtk+ to 2.20.0lib/bb/ui/crumbs/builddetailspage.py | 6 +- lib/bb/ui/crumbs/hobwidget.py | 499 +++++++--------------------- lib/bb/ui/crumbs/imageconfigurationpage.py | 2 - lib/bb/ui/crumbs/packageselectionpage.py | 3 +- lib/bb/ui/crumbs/recipeselectionpage.py | 5 +- lib/bb/ui/hob.py | 2 +- 6 files changed, 120 insertions(+),397 deletions(-)
Hi Shane,
Quoted 3 lines · Shane
Josh, I just found I can't run Hob on my Ubuntu 10.04 after I checked out the latest master.
Since Ubuntu 10.04 is a long-term-support version, can we do something to make Hob compatible with that?
The plan is to provide an external-python-tarball with a full Gtk+ & PyGtk nativesdk stack built by OE-Core/Poky and installed into a standalone sysroot on the users host.
Whilst I have a branch based on some work by Richard to achieve this it hasn't been submitted to upstream as I haven't figured out a clean way to handle things on the SDK host which would usually require a postinstall in the target rootfs.
Aside: I really can't see a clean way around requiring postinst type functionality for the SDK targets, particularly in the pagno case here. I'm currently ruminating on supercharging the toolchain scripts to handle this.
Quoted 1 line
What kind of failure did you meet on Ubuntu 10.04?
IIRC the set_action_widget() API I referred to in the original email isn't available in the version of Gtk+ and PyGtk that was shipped with Ubuntu 10.04.
This is required to add the search entry to the gtk.Notebook.
Cheers,
Joshua
Quoted 62 lines
--
ShaneJoshua Lock wrote on 2012-04-14:
Quoted 55 lines
*** This series prevents users of distros with old Gtk+ releases using Hob ***
This is a follow-on from my RFC of yesterday with a similar title. Sadly I hadn't realised that one of the API calls I am using is not available in the version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget).
This change will prevent CentOS 6 users from being able to use Hob.
I spent some time in Gtk+ internals trying to figure out if we can emulate the behaviour on older versions but the GtkNotebook widget internals were enhanced significantly to support the
set_action_widgetAPI.I've submitted the change as an RFC regardless, it's ready to merge if we're willing to make the sacrifice.
The primary motivation for making this change, and making it so late in the cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit widgets.
An added benefit is that standard toolkit widgets generally integrate better into the users OS thanks to inheriting their standard theme.
Tested on:
Fedora 16 (x86_64) - PASS
CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old Ubuntu 10.04 (x86_64) - Fail: pygtk version too old Ubuntu 12.04 Beta (x86_64) - PASSPer the final patch in the series the changes here require gtk+-2.20 or newer and pygtk 2.22 or newer.
Cheers,
JoshuaThe following changes since commit
434fdb3913cc78e2e9cdeede4c4fa7f1c8ef8892:Hob: Added required packages for toolchain. (2012-04-13 12:00:12 +0100)
are available in the git repository at:
git://github.com/incandescant/bitbakegtk2.20
https://github.com/incandescant/bitbake/tree/gtk2.20
Joshua Lock (4):
lib/bb/ui/crumbs/: replace custom HobNotebooklib/bb/ui/crumbs/hobwidget: use light text in HobIndicatorlib/bb/ui/crumbs/imageconfiguration: fix combo boxes drop-down width
hob: update required pygtk to 2.22.0 and gtk+ to 2.20.0lib/bb/ui/crumbs/builddetailspage.py | 6 +- lib/bb/ui/crumbs/hobwidget.py | 499 +++++++--------------------- lib/bb/ui/crumbs/imageconfigurationpage.py | 2 - lib/bb/ui/crumbs/packageselectionpage.py | 3 +- lib/bb/ui/crumbs/recipeselectionpage.py | 5 +- lib/bb/ui/hob.py | 2 +- 6 files changed, 120 insertions(+),397 deletions(-)
Signature · 3 lines
Joshua Lock
Yocto Project
Intel Open Source Technology Centre