Skip to contentSkip to conversation

Allow Hob to run with sanity checks disabled

PATCH New Joshua Lock 1 participant 3 messages Apr 23, 2012

lore
Share & tools
lore
#0 lore raw

cover Allow Hob to run with sanity checks disabled

Currently sanity check failures prevent Hob from launching, however we want users to be able to change the various sanity failure causing settings - such as proxy configuration - from the GUI.

This change and a related set of changes to BitBake allow Hob to start with the sanity checks disabled and enable them once the GUI is in place to a) report errors and b) affect settings.

In tandem with an BitBake change fixes [YOCTO #2361].

Regards,

Joshua

The following changes since commit b19af63a201933038a044f29570710fe38365f28:

self-hosted-image: Update poky revision to point at the 1.2 release branch (2012-04-22 16:07:44 +0100)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib josh/hob
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/hob

Joshua Lock (2):
sanity.bbclass: add variable to disable the sanity checks scripts/hob: disable sanity checks when launching

 meta/classes/sanity.bbclass |    2 +-
 scripts/hob                 |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.7.6
#1 lore raw

PATCH 1/2 sanity.bbclass: add variable to disable the sanity checks

It's useful for Hob to be able to disable the sanity checks completely without marking them as passed so that the user can get into the GUI to configure their settings, etc.

Add a variable, DISABLE_SANITY_CHECKS, to do so.

---
 meta/classes/sanity.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/sanity.bbclass +1 -1
index 9cd04c4..c3d4e58 100644
@@ -453,7 +453,7 @@ def check_sanity(e):
 
 addhandler check_sanity_eventhandler
 python check_sanity_eventhandler() {
-    if bb.event.getName(e) == "ConfigParsed" and e.data.getVar("BB_WORKERCONTEXT", True) != "1":
+    if bb.event.getName(e) == "ConfigParsed" and e.data.getVar("BB_WORKERCONTEXT", True) != "1" and e.data.getVar("DISABLE_SANITY_CHECKS", True) != "1":
         check_sanity(e)
 
     return
Signature · 1 line
1.7.7.6
#2 lore raw

PATCH 2/2 scripts/hob: disable sanity checks when launching

In reply to Joshua Lock

This enables us to use the GUI to change any settings which might cause sanity checks to fail, such as the proxy configuration.

---
 scripts/hob |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
scripts/hob +2 -1
index ee80cb3..4a821cb 100755
@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
-bitbake -u hob
+export BB_ENV_EXTRAWHITE="DISABLE_SANITY_CHECKS $BB_ENV_EXTRAWHITE"
+DISABLE_SANITY_CHECKS=1 bitbake -u hob
 
 ret=$?
 exit $ret
Signature · 1 line
1.7.7.6