Skip to contentSkip to conversation

pinctrl: SPEAr Updates

RFC Superseded Viresh Kumar 4 participants 7 messages Apr 27, 2012 – May 9, 2012 1 message not in the archive

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover pinctrl: SPEAr Updates

Hi Linus,

This patchset mainly focuses on providing support to configure SPEAr pads as gpios. For this i have added a gpiolib based driver and few changes in other SPEAr pinctrl drivers.

It also contains minor fixes.

I haven't tested it till now, only compile tested. I wanted to get a first level of review, so posting this set.

One thing currently broken is: Passing gpio base via DT.

Viresh Kumar (5):
pinctrl: SPEAr: Don't set all non muxreg bits on pinctrl_disable
pinctrl: SPEAr1310: Fix pin numbers for clcd_high_res
pinctrl: SPEAr: Add plgpio driver
pinctrl: SPEAr: Add gpio ranges support
SPEAr: Add plgpio node in device tree dtsi files

 arch/arm/boot/dts/spear1310.dtsi          |   16 +
 arch/arm/boot/dts/spear1340.dtsi          |   15 +
 arch/arm/boot/dts/spear310.dtsi           |   14 +
 arch/arm/boot/dts/spear320.dtsi           |   15 +
 drivers/pinctrl/spear/Kconfig             |   11 +
 drivers/pinctrl/spear/Makefile            |    1 +
 drivers/pinctrl/spear/pinctrl-plgpio.c    |  736 ++++++++++++++++++++++++++
 drivers/pinctrl/spear/pinctrl-spear.c     |   98 +++-
 drivers/pinctrl/spear/pinctrl-spear.h     |   15 +
 drivers/pinctrl/spear/pinctrl-spear1310.c |  813 ++++++++++++++++++++++++++++-
 drivers/pinctrl/spear/pinctrl-spear1340.c |    9 +
 drivers/pinctrl/spear/pinctrl-spear300.c  |    2 +
 drivers/pinctrl/spear/pinctrl-spear310.c  |    2 +
 drivers/pinctrl/spear/pinctrl-spear320.c  |    2 +
 drivers/pinctrl/spear/pinctrl-spear3xx.c  |  121 +++++
 15 files changed, 1857 insertions(+), 13 deletions(-)
 create mode 100644 drivers/pinctrl/spear/pinctrl-plgpio.c
Signature · 1 line
1.7.9
#2 lore raw

RFC 4/5 pinctrl: SPEAr: Add gpio ranges support

In reply to a message not in the archive
Quoted 2 lines · Viresh Kumar

Most of SPEAr SoCs, which support pinctrl, can configure & use pads as gpio. This patch gpio enable support for SPEAr pinctrl drivers.

OK...

Quoted 10 lines

+static struct spear_gpio_pingroup spear1310_gpio_pingroup[] = {
+ ? ? ? {
+ ? ? ? ? ? ? ? .pins = i2c0_pins,
+ ? ? ? ? ? ? ? .npins = ARRAY_SIZE(i2c0_pins),
+ ? ? ? ? ? ? ? .muxreg = {
+ ? ? ? ? ? ? ? ? ? ? ? .reg = PAD_FUNCTION_EN_0,
+ ? ? ? ? ? ? ? ? ? ? ? .mask = PMX_I2C0_MASK,
+ ? ? ? ? ? ? ? ? ? ? ? .val = 0,
+ ? ? ? ? ? ? ? },
+ ? ? ? }, {

Quoted 8 lines

+ ? ? ? ? ? ? ? .pins = ssp0_pins,
+ ? ? ? ? ? ? ? .npins = ARRAY_SIZE(ssp0_pins),
+ ? ? ? ? ? ? ? .muxreg = {
+ ? ? ? ? ? ? ? ? ? ? ? .reg = PAD_FUNCTION_EN_0,
+ ? ? ? ? ? ? ? ? ? ? ? .mask = PMX_SSP0_MASK,
+ ? ? ? ? ? ? ? ? ? ? ? .val = 0,
+ ? ? ? ? ? ? ? },
+ ? ? ? }, {

(...)

Hm first I wonder what i2c0 and ssp0 have to do with GPIO... Well whatever, maybe split out a special patch just adding the groups?

Please cut down this code by using a clever macro:

#define SPEAR_PCTL_GRP(a,b) \

{ \
    .pins =  a##_pins, \
    .npins = ARRAY_SIZE(a##_pins), \
    .muxreg = { \
        .reg = PAD_FUNCTION_EN_2, \
        .mask PMX_##b##_MASK, \
        .val = 0, \
    }, \
}

Then:

static struct spear_gpio_pingroup spear1310_gpio_pingroup[] = {
    SPEAR_PCTL_GRP(i2c0, I2C0),
    SPEAR_PCTL_GRP(ssp0, SSP0),
    SPEAR_PCTL_GRP(ssp0_cs0, SSP0_CS0),
    (...)
};

(You get the picture.)

Quoted 8 lines

+static struct spear_gpio_pingroup spear3xx_gpio_pingroup[] = {
+ ? ? ? {
+ ? ? ? ? ? ? ? .pins = firda_pins,
+ ? ? ? ? ? ? ? .npins = ARRAY_SIZE(firda_pins),
+ ? ? ? ? ? ? ? .muxreg = {
+ ? ? ? ? ? ? ? ? ? ? ? .mask = PMX_FIRDA_MASK,
+ ? ? ? ? ? ? ? ? ? ? ? .val = PMX_FIRDA_MASK,
+ ? ? ? ? ? ? ? },

Quoted 8 lines

+ ? ? ? }, {
+ ? ? ? ? ? ? ? .pins = i2c_pins,
+ ? ? ? ? ? ? ? .npins = ARRAY_SIZE(i2c_pins),
+ ? ? ? ? ? ? ? .muxreg = {
+ ? ? ? ? ? ? ? ? ? ? ? .mask = PMX_I2C_MASK,
+ ? ? ? ? ? ? ? ? ? ? ? .val = PMX_I2C_MASK,
+ ? ? ? ? ? ? ? },
+ ? ? ? }, {

And do the same thing here.

Yours,
Linus Walleij

#7 lore raw

cover pinctrl: SPEAr Updates

In reply to Viresh Kumar
Quoted 10 lines · Viresh Kumar

This patchset mainly focuses on providing support to configure SPEAr pads as gpios. For this i have added a gpiolib based driver and few changes in other SPEAr pinctrl drivers.

It also contains minor fixes.

I haven't tested it till now, only compile tested. I wanted to get a first level of review, so posting this set.

One thing currently broken is: Passing gpio base via DT.

Overall this looks good, just want you to use macros as commented in one patch.

Yours,
Linus Walleij

#3 lore raw

RFC 4/5 pinctrl: SPEAr: Add gpio ranges support

In reply to Linus Walleij
Quoted 19 lines · Linus Walleij

Hm first I wonder what i2c0 and ssp0 have to do with GPIO... Well whatever, maybe split out a special patch just adding the groups?

Please cut down this code by using a clever macro:

#define SPEAR_PCTL_GRP(a,b) \

{ \
    .pins =  a##_pins, \
    .npins = ARRAY_SIZE(a##_pins), \
    .muxreg = { \
        .reg = PAD_FUNCTION_EN_2, \
        .mask PMX_##b##_MASK, \
        .val = 0, \
    }, \
}

Then:

Quoted 8 lines
static struct spear_gpio_pingroup spear1310_gpio_pingroup[] = {
    SPEAR_PCTL_GRP(i2c0, I2C0),
    SPEAR_PCTL_GRP(ssp0, SSP0),
    SPEAR_PCTL_GRP(ssp0_cs0, SSP0_CS0),
    (...)
};

(You get the picture.)

If you allow me to give my 2 cents, I would recommend the exact opposite in general: resist the urge to use complex macros for everything!

When that gets too hard, please at least use macros that do not concatenate C identifies because that makes it really hard to grep for where a constant gets used.

A more acceptable macro would be

#define SPEAR_PCTL_GRP(_pins, _mask) \

{ \
	.pins =  _pins, \
	.npins = ARRAY_SIZE(_pins), \
	.muxreg = { \
	        .reg = PAD_FUNCTION_EN_2, \
	        .mask _val, \
	        .val = 0, \
	}, \
}

but open-coding is generally ok too. Note that you can sometimes save a lot of lines if you don't first define all those constants as macros but treat a table like this as the place where you put the raw numbers from the data sheet, if that the only code location in which they are used.

Arnd

#6 lore raw

RFC 4/5 pinctrl: SPEAr: Add gpio ranges support

In reply to Linus Walleij
Quoted 20 lines · Linus Walleij
Quoted 10 lines · Viresh Kumar

+static struct spear_gpio_pingroup spear1310_gpio_pingroup[] = {
+ ? ? ? {
+ ? ? ? ? ? ? ? .pins = i2c0_pins,
+ ? ? ? ? ? ? ? .npins = ARRAY_SIZE(i2c0_pins),
+ ? ? ? ? ? ? ? .muxreg = {
+ ? ? ? ? ? ? ? ? ? ? ? .reg = PAD_FUNCTION_EN_0,
+ ? ? ? ? ? ? ? ? ? ? ? .mask = PMX_I2C0_MASK,
+ ? ? ? ? ? ? ? ? ? ? ? .val = 0,
+ ? ? ? ? ? ? ? },
+ ? ? ? }, {

Quoted 8 lines

+ ? ? ? ? ? ? ? .pins = ssp0_pins,
+ ? ? ? ? ? ? ? .npins = ARRAY_SIZE(ssp0_pins),
+ ? ? ? ? ? ? ? .muxreg = {
+ ? ? ? ? ? ? ? ? ? ? ? .reg = PAD_FUNCTION_EN_0,
+ ? ? ? ? ? ? ? ? ? ? ? .mask = PMX_SSP0_MASK,
+ ? ? ? ? ? ? ? ? ? ? ? .val = 0,
+ ? ? ? ? ? ? ? },
+ ? ? ? }, {

Quoted 1 line

Hm first I wonder what i2c0 and ssp0 have to do with GPIO...

I didn't wanted to create new Arrays for exactly the same pins. so used earlier ones that belonged to peripherals.

Quoted 2 lines

Well whatever, maybe split out a special patch just adding the groups?

If i don't use them in that patch, we will get compilation warnings after it.

Quoted 15 lines

Please cut down this code by using a clever macro:

#define SPEAR_PCTL_GRP(a,b) \
{ \
? ?.pins = ?a##_pins, \
? ?.npins = ARRAY_SIZE(a##_pins), \
? ?.muxreg = { \
? ? ? ?.reg = PAD_FUNCTION_EN_2, \
? ? ? ?.mask PMX_##b##_MASK, \
? ? ? ?.val = 0, \
? ?}, \
}

Then:

Quoted 8 lines

static struct spear_gpio_pingroup spear1310_gpio_pingroup[] = { ? ?SPEAR_PCTL_GRP(i2c0, I2C0),
? ?SPEAR_PCTL_GRP(ssp0, SSP0),
? ?SPEAR_PCTL_GRP(ssp0_cs0, SSP0_CS0),
? ?(...)
};

(You get the picture.)

Yes. Will do.

#4 lore raw

RFC 4/5 pinctrl: SPEAr: Add gpio ranges support

In reply to Arnd Bergmann
Quoted 49 lines · Arnd Bergmann
Quoted 19 lines · Linus Walleij

Hm first I wonder what i2c0 and ssp0 have to do with GPIO... Well whatever, maybe split out a special patch just adding the groups?

Please cut down this code by using a clever macro:

#define SPEAR_PCTL_GRP(a,b) \
{ \
? ? .pins = ?a##_pins, \
? ? .npins = ARRAY_SIZE(a##_pins), \
? ? .muxreg = { \
? ? ? ? .reg = PAD_FUNCTION_EN_2, \
? ? ? ? .mask PMX_##b##_MASK, \
? ? ? ? .val = 0, \
? ? }, \
}

Then:

Quoted 8 lines

static struct spear_gpio_pingroup spear1310_gpio_pingroup[] = { ? ? SPEAR_PCTL_GRP(i2c0, I2C0),
? ? SPEAR_PCTL_GRP(ssp0, SSP0),
? ? SPEAR_PCTL_GRP(ssp0_cs0, SSP0_CS0),
? ? (...)
};

(You get the picture.)

If you allow me to give my 2 cents, I would recommend the exact opposite in general: resist the urge to use complex macros for everything!

When that gets too hard, please at least use macros that do not concatenate C identifies because that makes it really hard to grep for where a constant gets used.

A more acceptable macro would be

#define SPEAR_PCTL_GRP(_pins, _mask) \
{ \
? ? ? ?.pins = ?_pins, \
? ? ? ?.npins = ARRAY_SIZE(_pins), \
? ? ? ?.muxreg = { \
? ? ? ? ? ? ? ?.reg = PAD_FUNCTION_EN_2, \
? ? ? ? ? ? ? ?.mask _val, \
? ? ? ? ? ? ? ?.val = 0, \
? ? ? ?}, \
}

Quoted 5 lines

but open-coding is generally ok too. Note that you can sometimes save a lot of lines if you don't first define all those constants as macros but treat a table like this as the place where you put the raw numbers from the data sheet, if that the only code location in which they are used.

Hmm. Will try to do something better.

--
viresh

#5 lore raw

RFC 4/5 pinctrl: SPEAr: Add gpio ranges support

Quoted 9 lines · viresh kumar
Quoted 5 lines · Arnd Bergmann

but open-coding is generally ok too. Note that you can sometimes save a lot of lines if you don't first define all those constants as macros but treat a table like this as the place where you put the raw numbers from the data sheet, if that the only code location in which they are used.

Hmm. Will try to do something better.

No big deal, you can keep the table as long as I don't get Torvalds backfire on me for introducing too many lines of code. I'm a bit sensitive about that but it's not like it's super-important.

I've come to accept the fact that pin controller have many lines of code, since they bascially contain the tables that other platforms put in BIOS firmware, and these systems typically don't have BIOS:es so...

Thanks,
Linus Walleij