Skip to contentSkip to conversation

sanity.bbclass: Avoid empty $PATH components

PATCH Applied Peter Seebach 2 participants 3 messages May 9, 2012 – May 11, 2012

lore
Share & tools
lore
#0 lore raw

cover sanity.bbclass: Avoid empty $PATH components

Empty components (including $PATHs starting or ending with a colon) have the same harmful effects as a "." in $PATH.

The following changes since commit 8de7f8045f28aecfe796afcdb013c557ce9d1372:
Martin Jansa (1):
kmod: fix upgrade path from module-init-tools

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib seebs/cleanup
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/cleanup

Peter Seebach (1):
sanity.bbclass: Detect empty $PATH components too

 meta/classes/sanity.bbclass |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
#1 lore raw

PATCH 1/1 sanity.bbclass: Detect empty $PATH components too

Empty components in $PATH have the same effect as a . in $PATH, and are a common side-effect of inserting a misspelled or unset shell variable in $PATH.

---
 meta/classes/sanity.bbclass |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
meta/classes/sanity.bbclass +3 -2
index 687ddeb..1384592 100644
@@ -298,8 +298,9 @@ def check_sanity(e):
         if not check_app_exists("qemu-arm", e.data):
             messages = messages + "qemu-native was in ASSUME_PROVIDED but the QEMU binaries (qemu-arm) can't be found in PATH"
 
-    if "." in data.getVar('PATH', e.data, True).split(":"):
-        messages = messages + "PATH contains '.' which will break the build, please remove this"
+    paths = data.getVar('PATH', e.data, True).split(":")
+    if "." in paths or "" in paths:
+        messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
 
     if data.getVar('TARGET_ARCH', e.data, True) == "arm":
         # This path is no longer user-readable in modern (very recent) Linux
Signature · 1 line
1.7.0.4
Applied
#2 lore raw
In reply to Peter Seebach
Quoted 15 lines · Peter Seebach

Empty components (including $PATHs starting or ending with a colon) have the same harmful effects as a "." in $PATH.

The following changes since commit 8de7f8045f28aecfe796afcdb013c557ce9d1372:
Martin Jansa (1):
kmod: fix upgrade path from module-init-tools

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib seebs/cleanup
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/cleanup

Peter Seebach (1):
sanity.bbclass: Detect empty $PATH components too

Quoted 10 lines
  meta/classes/sanity.bbclass |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Merged into OE-Core

Thanks
Sau!