Skip to contentSkip to conversation

kmod: fix installation path of pkgconfig files

PATCH In review Otavio Salvador 4 participants 9 messages May 14, 2012 – May 15, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Otavio Salvador

author
#1 lore raw

PATCH 1/1 kmod: fix installation path of pkgconfig files

The pkgconfig files need to be installed in ${libdir} instead of ${base_libdir}.

Signed-off-by Otavio Salvador <[email protected]>
---
 meta/recipes-kernel/kmod/kmod_git.bb |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
meta/recipes-kernel/kmod/kmod_git.bb +5 -1
index d9c4d8b..7b4a45a 100644
@@ -3,7 +3,7 @@
 
 require kmod.inc
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 PROVIDES += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
 RPROVIDES_${PN} += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"

@@ -34,6 +34,10 @@ do_install_append () {
 
         # install depmod.d file for search/ dir
         install -Dm644 "${WORKDIR}/depmod-search.conf" "${D}${base_libdir}/depmod.d/search.conf"
+
+		# fix pkgconfig installation path
+		install -dm755 ${D}${libdir}
+		mv ${D}${base_libdir}/pkgconfig ${D}{libdir}
 }
 
 pkg_postinst_kmod() {
Signature · 1 line
1.7.2.5
#2 lore raw

Op 14 mei 2012, om 15:47 heeft Otavio Salvador het volgende geschreven:

Quoted 2 lines

The pkgconfig files need to be installed in ${libdir} instead of ${base_libdir}.

Thanks for the patch, I was working on something similar :) I talked with the kmod and udev people and they asked why we want kmod libs in /lib instead of /usr/lib. I didn't have an answer to that, does anyone else have a decent one? If not, let's not mess with $prefix and remove all the do_install changes.

regards,

Koen

author
#3 lore raw
Quoted 7 lines · Koen Kooi

Op 14 mei 2012, om 15:47 heeft Otavio Salvador het volgende geschreven:

Quoted 2 lines

The pkgconfig files need to be installed in ${libdir} instead of ${base_libdir}.

Thanks for the patch, I was working on something similar :) I talked with the kmod and udev people and they asked why we want kmod libs in /lib instead of /usr/lib. I didn't have an answer to that, does anyone else have a decent one? If not, let's not mess with $prefix and remove all the do_install changes.

OE-Core try to allow the use of /usr in a separated partition so it seems it is a requirement for it to work in initrdless systems.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#4 lore raw
Quoted 7 lines · Otavio Salvador
Quoted 6 lines · Koen Kooi

Op 14 mei 2012, om 15:47 heeft Otavio Salvador het volgende geschreven:

Quoted 2 lines

The pkgconfig files need to be installed in ${libdir} instead of ${base_libdir}.

Quoted 8 lines
Quoted 1 line

Thanks for the patch, I was working on something similar :) I talked

with the kmod and udev people and they asked why we want kmod libs in /lib instead of /usr/lib. I didn't have an answer to that, does anyone else have a decent one? If not, let's not mess with $prefix and remove all the do_install changes.

OE-Core try to allow the use of /usr in a separated partition so it seems it is a requirement for it to work in initrdless systems.

I've heard requests from people that / be bootable with /usr being mounted later. For something like kmod, there is therefore a case for putting the library in base_libdir, not libdir. Not doing so sounds like a bit of a cop-out from the maintainers.

Cheers,

Richard

#5 lore raw

Op 15 mei 2012, om 19:55 heeft Richard Purdie het volgende geschreven:

Quoted 14 lines · Otavio Salvador
Quoted 13 lines · Koen Kooi
Quoted 7 lines

Op 14 mei 2012, om 15:47 heeft Otavio Salvador het volgende geschreven:

Quoted 2 lines

The pkgconfig files need to be installed in ${libdir} instead of ${base_libdir}.

Thanks for the patch, I was working on something similar :) I talked

with the kmod and udev people and they asked why we want kmod libs in /lib instead of /usr/lib. I didn't have an answer to that, does anyone else have a decent one? If not, let's not mess with $prefix and remove all the do_install changes.

Quoted 7 lines
Quoted 2 lines

OE-Core try to allow the use of /usr in a separated partition so it seems it is a requirement for it to work in initrdless systems.

I've heard requests from people that / be bootable with /usr being mounted later. For something like kmod, there is therefore a case for putting the library in base_libdir, not libdir. Not doing so sounds like a bit of a cop-out from the maintainers.

Good luck with booting a split /usr without udev. Can we *please* get the .pc in the right place so udev builds before trying to fix pie-in-the-sky things like split /usr?

#6 lore raw
In reply to Richard Purdie
Quoted 5 lines · Richard Purdie

I've heard requests from people that / be bootable with /usr being mounted later. For something like kmod, there is therefore a case for putting the library in base_libdir, not libdir. Not doing so sounds like a bit of a cop-out from the maintainers.

I think this should not be made so mandatory in OE-Core IMO since none of modern systems would do something like that.

author
#7 lore raw
Quoted 2 lines · Khem Raj

I think this should not be made so mandatory in OE-Core IMO since none of modern systems would do something like that.

I agree with you Khem; I think that systems that require this ought to use a initramfs or initrd image for it. I see no it as not worth to support it and the amount of hassle to support it is not worth it.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
author
#8 lore raw

PATCH 1/1 kmod: fix installation path of pkgconfig files

In reply to Otavio Salvador

The pkgconfig files need to be installed in ${libdir} instead of ${base_libdir}.

Signed-off-by Otavio Salvador <[email protected]>
---
 meta/recipes-kernel/kmod/kmod_git.bb |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
meta/recipes-kernel/kmod/kmod_git.bb +5 -1
index d9c4d8b..a4a284e 100644
@@ -3,7 +3,7 @@
 
 require kmod.inc
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 PROVIDES += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
 RPROVIDES_${PN} += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"

@@ -34,6 +34,10 @@ do_install_append () {
 
         # install depmod.d file for search/ dir
         install -Dm644 "${WORKDIR}/depmod-search.conf" "${D}${base_libdir}/depmod.d/search.conf"
+
+        # fix pkgconfig installation path
+        install -dm755 ${D}${libdir}
+        mv ${D}${base_libdir}/pkgconfig ${D}${libdir}
 }
 
 pkg_postinst_kmod() {
Signature · 1 line
1.7.2.5
author
#9 lore raw
Quoted 4 lines · Otavio Salvador

The pkgconfig files need to be installed in ${libdir} instead of ${base_libdir}.

Signed-off-by Otavio Salvador <[email protected]>

This patch is near but still doesn't work as expected. I am working on that.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br