Skip to contentSkip to conversation

Bridging PCI to amba

PATCH Superseded Alessandro Rubini 3 participants 5 messages May 28, 2012 – Jun 20, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover Bridging PCI to amba

V2: accepted comments I got on V1; rewritten the driver to be generic;
made it tristate instead of boolean. Rebased on new next.

This patch set introduces use of AMBA devices under a PCI bridge. The device table in the driver include all the devices that we'll be able to run using AMBA drivers.

To compile AMBA under x86, though I need <asm/sizes.h>, which is moved to <linux/sizes.h> as suggested earlier.

I'm hereby volunteering to handle the moving of the various users of <asm/sizes.h> to <linux/sizes.h>; this set only moves the ARM core files and the ones that I need under x86.

The whole patch set is sent to the same set of recipients:
all relevant lists, Russell King (for arm), Greg-KH (for uart) and Arnd Bergmann (for generic include).

With this set in place (plus a clok API not included here) I have 4 serial ports working.

Success strings:
spusa.root# uname -r
3.4.0-next-20120528-00016-g1e5853d

spusa.root# dmesg | grep ttyA
amba-0000:03:00.5: ttyAMA0 at MMIO 0xcf400000 (irq = 64) is a PL011 rev3 amba-0000:03:00.6: ttyAMA1 at MMIO 0xcec00000 (irq = 65) is a PL011 rev3 amba-0000:03:00.7: ttyAMA2 at MMIO 0xce400000 (irq = 66) is a PL011 rev3 amba-0000:04:00.5: ttyAMA3 at MMIO 0xd3400000 (irq = 71) is a PL011 rev3

spusa.root# grep -B2 pl011 /proc/iomem

           ce400000-ce7fffff : 0000:03:00.7
             ce400000-ce400fff : amba-0000:03:00.7
             ce400000-ce400fff : uart-pl011
   --
           cec00000-ceffffff : 0000:03:00.6
             cec00000-cec00fff : amba-0000:03:00.6
             cec00000-cec00fff : uart-pl011
   --
           cf400000-cf7fffff : 0000:03:00.5
             cf400000-cf400fff : amba-0000:03:00.5
             cf400000-cf400fff : uart-pl011
   --
           d3400000-d37fffff : 0000:04:00.5
             d3400000-d3400fff : amba-0000:04:00.5
             d3400000-d3400fff : uart-pl011

Alessandro Rubini (6):
sizes.h: move from asm-generic to <linux/sizes.h>
amba: use the new linux/sizes.h
ARM: use the new linux/sizes.h
serial: use the new linux/sizes.h
x86: add CONFIG_ARM_AMBA, selected by STA2X11 drivers/amba: add support for a PCI bridge

 arch/arm/include/asm/memory.h   |    2 +-
 arch/arm/mm/dma-mapping.c       |    2 +-
 arch/arm/mm/init.c              |    2 +-
 arch/arm/mm/ioremap.c           |    2 +-
 arch/arm/mm/mmu.c               |    2 +-
 arch/x86/Kconfig                |    4 ++
 drivers/Kconfig                 |    2 +
 drivers/amba/Kconfig            |   10 ++++
 drivers/amba/Makefile           |    1 +
 drivers/amba/bus.c              |    2 +-
 drivers/amba/pci-amba.c         |   95 +++++++++++++++++++++++++++++++++++++++
 drivers/tty/serial/amba-pl011.c |    2 +-
 include/asm-generic/sizes.h     |   49 +-------------------
 include/linux/sizes.h           |   47 +++++++++++++++++++
 14 files changed, 168 insertions(+), 54 deletions(-)
 create mode 100644 drivers/amba/Kconfig
 create mode 100644 drivers/amba/pci-amba.c
 create mode 100644 include/linux/sizes.h
Signature · 1 line
1.7.7.2
Acked-by on the v2 series
#1 lore raw
Quoted 2 lines · Alessandro Rubini

V2: accepted comments I got on V1; rewritten the driver to be generic; made it tristate instead of boolean. Rebased on new next.

This looks good to me.

I think this patch set could go through Arnd as arch maintainer? It's fun with these cross-arch things. You'll need an ACK from Russell first.

Yours,
Linus Walleij

maintainer
#2 lore raw
Quoted 11 lines · Linus Walleij
Quoted 2 lines · Alessandro Rubini

V2: accepted comments I got on V1; rewritten the driver to be generic;
made it tristate instead of boolean. Rebased on new next.

This looks good to me.

I think this patch set could go through Arnd as arch maintainer? It's fun with these cross-arch things. You'll need an ACK from Russell first.

I don't think it has much to do with code I maintain. Russell as the Primecell maintainer is the right person to take it through his tree.

Arnd

#3 lore raw
Quoted 1 line

Date: Mon, 11 Jun 2012 15:28:22 +0000

Arnd Bergmann:

Quoted 3 lines

I don't think it has much to do with code I maintain. Russell as the Primecell maintainer is the right person to take it through his tree.

Russell, is there some action I shall take? I suspect your email-based patch system is over by now, or should I send patches in there?

thanks
/alessandro

#4 lore raw
Quoted 9 lines · Alessandro Rubini
Quoted 1 line

Date: Mon, 11 Jun 2012 15:28:22 +0000

Arnd Bergmann:

Quoted 3 lines

I don't think it has much to do with code I maintain. Russell as the Primecell maintainer is the right person to take it through his tree.

Russell, is there some action I shall take? I suspect your email-based patch system is over by now, or should I send patches in there?

I'm always using the web interface, it works like a charm:
http://www.arm.linux.org.uk/developer/patches/

Yours,
Linus Walleij