Skip to contentSkip to conversation

First pass of rpcbind improvements

PATCH Applied Christopher Larson 5 participants 9 messages Jun 2, 2012 – Aug 29, 2012

lore
Share & tools
lore

Christopher Larson

author
#0 lore raw

cover First pass of rpcbind improvements

The following changes since commit e3113827810e98eb1b012f0b280fb917199704c1:

webkit-gtk: Use glib as unicode backend to avoid browser crash (2012-05-30 17:37:58 +0100)

are available in the git repository at:

git://github.com/kergoth/oe-core rpcbind-1

for you to fetch changes up to acae76c50ae66d8167038782cc623f5de64e1365:

task-core-basic: drop portmap (2012-06-01 22:02:50 -0400)

----------------------------------------------------------------
Christopher Larson (2):
rpcbind: add and use startup script, move binaries
task-core-basic: drop portmap

 meta/recipes-extended/rpcbind/rpcbind/init.d   |   85 ++++++++++++++++++++++++
 meta/recipes-extended/rpcbind/rpcbind_0.2.0.bb |   18 ++++-
 meta/recipes-extended/tasks/task-core-basic.bb |    1 -
 3 files changed, 101 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-extended/rpcbind/rpcbind/init.d
Signature · 1 line
1.7.10.3
author
#1 lore raw

PATCH 1/2 rpcbind: add and use startup script, move binaries

- Add init script from debian, tweaked for us
- Move binaries from bindir to sbindir, as debian does

Signed-off-by Christopher Larson <[email protected]>
---
 meta/recipes-extended/rpcbind/rpcbind/init.d   |   85 ++++++++++++++++++++++++
 meta/recipes-extended/rpcbind/rpcbind_0.2.0.bb |   18 ++++-
 2 files changed, 101 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-extended/rpcbind/rpcbind/init.d
meta/recipes-extended/rpcbind/rpcbind/init.d new file +85 -0
new file mode 100644
index 0000000..5c756bb
@@ -0,0 +1,85 @@
+#!/bin/sh
+#
+# start/stop rpcbind daemon.
+
+### BEGIN INIT INFO
+# Provides:          rpcbind
+# Required-Start:    $network
+# Required-Stop:     $network
+# Default-Start:     S 2 3 4 5
+# Default-Stop:      0 1 6
+# Short-Description: RPC portmapper replacement
+# Description:       rpcbind is a server that converts RPC (Remote
+#                    Procedure Call) program numbers into DARPA
+#                    protocol port numbers. It must be running in
+#                    order to make RPC calls. Services that use
+#                    RPC include NFS and NIS.
+### END INIT INFO
+
+test -f /sbin/rpcbind || exit 0
+
+OPTIONS=""
+if [ -f /etc/default/rpcbind ]
+then
+    . /etc/default/rpcbind
+elif [ -f /etc/rpcbind.conf ]
+then
+    . /etc/rpcbind.conf
+fi
+
+start ()
+{
+    echo -n "Starting rpcbind daemon..."
+    if pidof /sbin/rpcbind >/dev/null; then
+        echo "already running."
+        exit 0
+    fi
+    start-stop-daemon --start --quiet --exec /sbin/rpcbind -- "$@"
+    if [ $? -eq 0 ]; then
+        echo "done."
+    else
+        echo "failed."
+    fi
+}
+
+stop ()
+{
+    echo "Stopping rpcbind daemon..."
+    if ! pidof /sbin/rpcbind >/dev/null; then
+        echo "not running."
+        exit 0
+    fi
+    start-stop-daemon --stop --quiet --exec /sbin/rpcbind
+    if [ $? -eq 0 ]; then
+        echo "done."
+    else
+        echo "failed."
+    fi
+}
+
+case "$1" in
+    start)
+        start $OPTIONS
+        ;;
+    stop)
+        stop
+        ;;
+    force-reload)
+        stop
+        start $OPTIONS
+        ;;
+    restart)
+        stop
+        start $OPTIONS
+        ;;
+    status)
+        pidof /sbin/rpcbind >/dev/null
+        exit $?
+        ;;
+    *)
+        echo "Usage: /etc/init.d/rpcbind {start|stop|force-reload|restart|status}"
+        exit 1
+        ;;
+esac
+
+exit 0
meta/recipes-extended/rpcbind/rpcbind_0.2.0.bb +16 -2
index 62f6667..9fb4f51 100644
@@ -11,12 +11,26 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b46486e4c4a416602693a711bb5bfa39 \
                     file://src/rpcinfo.c;beginline=1;endline=27;md5=f8a8cd2cb25ac5aa16767364fb0e3c24"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/rpcbind/rpcbind-${PV}.tar.bz2 \
+           file://init.d \
            file://fix_host_path.patch \
           "
 
 SRC_URI[md5sum] = "1a77ddb1aaea8099ab19c351eeb26316"
 SRC_URI[sha256sum] = "c92f263e0353887f16379d7708ef1fb4c7eedcf20448bc1e4838f59497a00de3"
 
-PR = "r2"
+PR = "r3"
 
-inherit autotools
+inherit autotools update-rc.d
+
+INITSCRIPT_NAME = "rpcbind"
+INITSCRIPT_PARAMS = "start 43 S . start 32 0 6 . stop 81 1 ."
+
+do_install_append () {
+    mv ${D}${bindir} ${D}${sbindir}
+
+    install -d ${D}${sysconfdir}/init.d
+    sed -e 's,/etc/,${sysconfdir}/,g' \
+        -e 's,/sbin/,${sbindir}/,g' \
+        ${WORKDIR}/init.d > ${D}${sysconfdir}/init.d/rpcbind
+    chmod 0755 ${D}${sysconfdir}/init.d/rpcbind
+}
Signature · 1 line
1.7.10.3
author
#2 lore raw

PATCH 2/2 task-core-basic: drop portmap

In reply to Christopher Larson

Both rpcbind and portmap are RPC port mappers. Having both is redundant. Chose rpcbind over portmap as rpcbind supports ipv6, nfs4, and builds without the glibc rpc headers, which have been obsoleted in glibc 2.14.

Signed-off-by Christopher Larson <[email protected]>
---
 meta/recipes-extended/tasks/task-core-basic.bb |    1 -
 1 file changed, 1 deletion(-)
meta/recipes-extended/tasks/task-core-basic.bb +0 -1
index 8bab0db..a810d37 100644
@@ -148,7 +148,6 @@ RDEPENDS_task-core-sys-services = "\
     nfs-utils \
     pciutils \
     libpcre \
-    portmap \
     rpcbind \
     sysfsutils \
     tcp-wrappers \
Signature · 1 line
1.7.10.3
Applied
#8 lore raw
In reply to Christopher Larson
Quoted 4 lines · Christopher Larson

The following changes since commit e3113827810e98eb1b012f0b280fb917199704c1:

 webkit-gtk: Use glib as unicode backend to avoid browser crash (2012-05-30 17:37:58 +0100)

Quoted 8 lines

are available in the git repository at:

 git://github.com/kergoth/oe-core rpcbind-1

for you to fetch changes up to acae76c50ae66d8167038782cc623f5de64e1365:

 task-core-basic: drop portmap (2012-06-01 22:02:50 -0400)

Merged into OE-Core

Thanks

-b

Quoted 19 lines

----------------------------------------------------------------
Christopher Larson (2):
     rpcbind: add and use startup script, move binaries
     task-core-basic: drop portmap

 meta/recipes-extended/rpcbind/rpcbind/init.d   |   85 ++++++++++++++++++++++++ meta/recipes-extended/rpcbind/rpcbind_0.2.0.bb |   18 ++++- meta/recipes-extended/tasks/task-core-basic.bb |    1 -

 3 files changed, 101 insertions(+), 3 deletions(-)

 create mode 100644 meta/recipes-extended/rpcbind/rpcbind/init.d

--
1.7.10.3

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 3 lines
Elizabeth Flanagan
Yocto Project
Build and Release
#3 lore raw

Re: [PATCH 2/2] task-core-basic: drop portmap

In reply to Christopher Larson
Quoted 15 lines · On Friday 01 June 2012 19:24:54 Christopher Larson wrote:

Both rpcbind and portmap are RPC port mappers. Having both is redundant. Chose rpcbind over portmap as rpcbind supports ipv6, nfs4, and builds without the glibc rpc headers, which have been obsoleted in glibc 2.14.

Signed-off-by Christopher Larson <[email protected]>
---
 meta/recipes-extended/tasks/task-core-basic.bb |    1 -
 1 file changed, 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-extended/tasks/task-core-basic.bb index 8bab0db..a810d37 100644

meta/recipes-extended/tasks/task-core-basic.bb RDEPENDS_task-core-sys-services = "\ · line 153

Quoted 7 lines
meta/recipes-extended/tasks/task-core-basic.bb +0 -1
@@ -148,7 +148,6 @@ RDEPENDS_task-core-sys-services = "\
     nfs-utils \
     pciutils \
     libpcre \
-    portmap \
     rpcbind \
     sysfsutils \
     tcp-wrappers \

I came across this while digging back through the history in master. Does this mean we ought to be switching to rpcbind in our other tasks which currently bring in portmap (e.g. task-base-nfs, task-core-apps-console)?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#6 lore raw

Re: [PATCH 2/2] task-core-basic: drop portmap

In reply to Christopher Larson

Op 2 jun. 2012, om 04:24 heeft Christopher Larson <[email protected]> het volgende geschreven:

Quoted 15 lines

Both rpcbind and portmap are RPC port mappers. Having both is redundant. Chose rpcbind over portmap as rpcbind supports ipv6, nfs4, and builds without the glibc rpc headers, which have been obsoleted in glibc 2.14.

Signed-off-by Christopher Larson <[email protected]>

---
meta/recipes-extended/tasks/task-core-basic.bb | 1 -

1 file changed, 1 deletion(-)
meta/recipes-extended/tasks/task-core-basic.bb +0 -0
index 8bab0db..a810d37 100644

meta/recipes-extended/tasks/task-core-basic.bb RDEPENDS_task-core-sys-services = "\ · line 153

Quoted 7 lines
meta/recipes-extended/tasks/task-core-basic.bb +0 -1
@@ -148,7 +148,6 @@ RDEPENDS_task-core-sys-services = "\
    nfs-utils \
    pciutils \
    libpcre \
-    portmap \
    rpcbind \
    sysfsutils \
    tcp-wrappers \

Missing PR bump

#7 lore raw

Re: [PATCH 2/2] task-core-basic: drop portmap

Quoted 1 line · On Tuesday 28 August 2012 17:22:02 Koen Kooi wrote:

Op 2 jun. 2012, om 04:24 heeft Christopher Larson <[email protected]> het

volgende geschreven:

Quoted 20 lines
Quoted 20 lines

Both rpcbind and portmap are RPC port mappers. Having both is redundant. Chose rpcbind over portmap as rpcbind supports ipv6, nfs4, and builds without the glibc rpc headers, which have been obsoleted in glibc 2.14.

Signed-off-by Christopher Larson <[email protected]>

---
meta/recipes-extended/tasks/task-core-basic.bb | 1 -

1 file changed, 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-extended/tasks/task-core-basic.bb index 8bab0db..a810d37 100644

meta/recipes-extended/tasks/task-core-basic.bb +0 -0
@@ -148,7 +148,6 @@ RDEPENDS_task-core-sys-services = "\
 
    nfs-utils \
    pciutils \
    libpcre \
Quoted 7 lines
Quoted 5 lines
meta/recipes-extended/tasks/task-core-basic.bb +0 -1
-    portmap \
 

    rpcbind \
    sysfsutils \
    tcp-wrappers \

Missing PR bump

The patch you're replying to was posted ages ago and has already been merged...

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#4 lore raw

Re: [PATCH 2/2] task-core-basic: drop portmap

In reply to Paul Eggleton
Quoted 10 lines · Paul Eggleton
Quoted 5 lines
     libpcre \
-    portmap \
     rpcbind \
     sysfsutils \
     tcp-wrappers \

I came across this while digging back through the history in master. Does this mean we ought to be switching to rpcbind in our other tasks which currently bring in portmap (e.g. task-base-nfs, task-core-apps-console)?

I guess yes because rpcbind is more featureful than portmap. its better to use rpcbind as default portmapper. Things like ipv6, nfsv4

author
#5 lore raw

Re: [PATCH 2/2] task-core-basic: drop portmap

Quoted 8 lines · Khem Raj
Quoted 6 lines · Paul Eggleton
Quoted 5 lines
     libpcre \
-    portmap \
     rpcbind \
     sysfsutils \
     tcp-wrappers \
Quoted 7 lines
Quoted 4 lines

I came across this while digging back through the history in master. Does this mean we ought to be switching to rpcbind in our other tasks which currently bring in portmap (e.g. task-base-nfs, task-core-apps-console)?

I guess yes because rpcbind is more featureful than portmap. its better to use rpcbind as default portmapper. Things like ipv6, nfsv4

Yeah, I think that would be best. It is worth noting that task-base and portmap are in recipes-core, while rpcbind is, iirc, in recipes-support, so such a change would probably be best done when also swapping the locations of the two recipes.

Signature · 1 line
Christopher Larson