misc IMAGE_FEATURE fixings
cover misc IMAGE_FEATURE fixings
This patch set fixed the bug [YOCTO #2605].
It allows to login to openssh with empty password if the IMAGE_FEATURE debug-tweak feature is set.
It processes conflicting IMAGE_FEATURE features, i.e. ssh-server-dropbear and ssh-server-openssh.
It also adds a new IMAGE_FEATURE 'eclipse-support' for developing user applications using Eclipse plugin.
The following changes since commit 6d761ae17ddbd3d936e7fe985b40825ad62b2418:
James Limbouris (1):
debian.bbclass: invoke target objdump
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib llu/bug2605
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=llu/bug2605
Lianhao Lu (3):
classes/image: Allow openssh empty passwords login. image/core-image: Handle conflicting IMAGE_FEATURES. core-image/misc: Added new IMAGE_FEATURE eclipse-support.
meta/classes/core-image.bbclass | 15 ++++++++++- meta/classes/image.bbclass | 26 +++++++++++++++++++- meta/conf/multilib.conf | 1 + .../tasks/task-core-eclipse-support.bb | 17 +++++++++++++ meta/recipes-sato/images/core-image-sato-sdk.bb | 4 ++- 5 files changed, 60 insertions(+), 3 deletions(-) create mode 100644 meta/recipes-core/tasks/task-core-eclipse-support.bb
PATCH 1/3 classes/image: Allow openssh empty passwords login.
Allow empty passwords login so that the default root user can login in through openssh.
--- meta/classes/core-image.bbclass | 2 ++ meta/classes/image.bbclass | 10 +++++++++- 2 files changed, 11 insertions(+), 1 deletions(-)
meta/classes/core-image.bbclass +2 -0
@@ -69,4 +69,6 @@ ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; " # Zap the root password if debug-tweaks feature is not enabled ROOTFS_POSTPROCESS_COMMAND += '${@base_contains("IMAGE_FEATURES", "debug-tweaks", "", "zap_root_password ; ",d)}' +# Allow openssh accept empty password login if both debug-tweaks and ssh-server-openssh are enabled +ROOTFS_POSTPROCESS_COMMAND += '${@base_contains("IMAGE_FEATURES", "debug-tweaks ssh-server-openssh", "openssh_allow_empty_password; ", "",d)}'
meta/classes/image.bbclass +9 -1
@@ -318,6 +318,14 @@ zap_root_password () { mv ${IMAGE_ROOTFS}/etc/passwd.new ${IMAGE_ROOTFS}/etc/passwd } +# allow openssh accept login with empty password string +openssh_allow_empty_password () { + if [ -e ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config ]; then + sed 's#.*PermitEmptyPasswords.*#PermitEmptyPasswords yes#' ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config >${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config.new + mv -f ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config.new ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config + fi +} + # Turn any symbolic /sbin/init link into a file remove_init_link () { if [ -h ${IMAGE_ROOTFS}/sbin/init ]; then
@@ -372,7 +380,7 @@ rootfs_trim_schemas () { done } -EXPORT_FUNCTIONS zap_root_password remove_init_link do_rootfs make_zimage_symlink_relative set_image_autologin rootfs_update_timestamp rootfs_no_x_startup +EXPORT_FUNCTIONS zap_root_password remove_init_link do_rootfs make_zimage_symlink_relative set_image_autologin rootfs_update_timestamp rootfs_no_x_startup openssh_allow_empty_password do_fetch[noexec] = "1" do_unpack[noexec] = "1"
Signature · 1 line
1.7.0.4
PATCH 2/3 image/core-image: Handle conflicting IMAGE_FEATURES.
IMAGE_FEATURES such as 'ssh-server-dropbear' and 'ssh-server-openssh' can't be both enabled. User can use the following variables to define the relationship of image features:
IMAGE_FEATURES_REPLACES_foo = "bar" means including image feature "foo" would replace the image feature "bar".
IMAGE_FEATURES_CONFLICTS_foo = "bar" means including both image features "foo" and "bar" would cause an parsing error.
--- meta/classes/core-image.bbclass | 11 ++++++++++- meta/classes/image.bbclass | 16 ++++++++++++++++ meta/recipes-sato/images/core-image-sato-sdk.bb | 2 ++ 3 files changed, 28 insertions(+), 1 deletions(-)
meta/classes/core-image.bbclass +10 -1
@@ -47,6 +47,14 @@ PACKAGE_GROUP_ssh-server-openssh = "task-core-ssh-openssh" PACKAGE_GROUP_package-management = "${ROOTFS_PKGMANAGE}" PACKAGE_GROUP_qt4-pkgs = "task-core-qt-demos" + +# IMAGE_FEAETURES_REPLACES_foo = 'bar1 bar2' +# Including image feature foo would replace the image features bar1 and bar2 +IMAGE_FEATURES_REPLACES_ssh-server-openssh = "ssh-server-dropbear" + +# IMAGE_FEATURES_CONFLICTS_foo = 'bar1 bar2' +# An error exception would be raised if both image features foo and bar1(or bar2) are included + CORE_IMAGE_BASE_INSTALL = '\ task-core-boot \ task-base-extended \
@@ -60,7 +68,8 @@ IMAGE_INSTALL ?= "${CORE_IMAGE_BASE_INSTALL}" X11_IMAGE_FEATURES = "x11-base apps-x11-core package-management" ENHANCED_IMAGE_FEATURES = "${X11_IMAGE_FEATURES} apps-x11-games apps-x11-pimlico package-management" -SATO_IMAGE_FEATURES = "${ENHANCED_IMAGE_FEATURES} x11-sato ssh-server-dropbear" +SSHSERVER_IMAGE_FEATURES ??= "ssh-server-dropbear" +SATO_IMAGE_FEATURES = "${ENHANCED_IMAGE_FEATURES} x11-sato ${SSHSERVER_IMAGE_FEATURES}" inherit image
meta/classes/image.bbclass +16 -0
@@ -92,6 +92,22 @@ python () { if d.getVar('BB_WORKERCONTEXT', True) is not None: runtime_mapping_rename("PACKAGE_INSTALL", d) runtime_mapping_rename("PACKAGE_INSTALL_ATTEMPTONLY", d) + + #Check for replaces image features + features = set(oe.data.typed_value('IMAGE_FEATURES', d)) + remain_features = features.copy() + for feature in features: + replaces = set((d.getVar("IMAGE_FEATURES_REPLACES_%s" % feature, True) or "").split()) + remain_features -= replaces + + #Check for conflict image features + for feature in remain_features: + conflicts = set((d.getVar("IMAGE_FEATURES_CONFLICTS_%s" % feature, True) or "").split()) + temp = conflicts & remain_features + if temp: + raise bb.parse.SkipPackage("%s contains conflicting IMAGE_FEATURES %s %s" % (d.getVar('PN', True), feature, ' '.join(list(temp)))) + + d.setVar('IMAGE_FEATURES', ' '.join(list(remain_features))) } #
meta/recipes-sato/images/core-image-sato-sdk.bb +2 -0
@@ -8,6 +8,8 @@ form a standalone SDK." IMAGE_FEATURES += "apps-console-core ${SATO_IMAGE_FEATURES} dev-pkgs tools-sdk qt4-pkgs" EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks" +SSHSERVER_IMAGE_FEATURES = "ssh-server-openssh" + LICENSE = "MIT" inherit core-image
Signature · 1 line
1.7.0.4
PATCH 3/3 core-image/misc: Added new IMAGE_FEATURE eclipse-support.
In reply to Lianhao LuAdded a new IMAGE_FEATURES eclipse-support to support developing user applications through Eclipse plugin.
--- meta/classes/core-image.bbclass | 2 ++ meta/conf/multilib.conf | 1 + .../tasks/task-core-eclipse-support.bb | 17 +++++++++++++++++ meta/recipes-sato/images/core-image-sato-sdk.bb | 2 +- 4 files changed, 21 insertions(+), 1 deletions(-) create mode 100644 meta/recipes-core/tasks/task-core-eclipse-support.bb
meta/classes/core-image.bbclass +2 -0
@@ -28,6 +28,7 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3 # - ssh-server-dropbear - SSH server (dropbear) # - ssh-server-openssh - SSH server (openssh) # - debug-tweaks - makes an image suitable for development +# - eclipse-support - Support Eclipse plugin # PACKAGE_GROUP_apps-console-core = "task-core-apps-console" PACKAGE_GROUP_x11-mini = "task-core-x11-mini"
@@ -46,6 +47,7 @@ PACKAGE_GROUP_ssh-server-dropbear = "task-core-ssh-dropbear" PACKAGE_GROUP_ssh-server-openssh = "task-core-ssh-openssh" PACKAGE_GROUP_package-management = "${ROOTFS_PKGMANAGE}" PACKAGE_GROUP_qt4-pkgs = "task-core-qt-demos" +PACKAGE_GROUP_eclipse-support = "task-core-eclipse-support task-core-tools-debug task-core-tools-profile" # IMAGE_FEAETURES_REPLACES_foo = 'bar1 bar2'
meta/conf/multilib.conf +1 -0
@@ -618,6 +618,7 @@ BBCLASSEXTEND_append_pn-task-core-basic = " ${MULTILIBS}" BBCLASSEXTEND_append_pn-task-core-boot = " ${MULTILIBS}" BBCLASSEXTEND_append_pn-task-core-clutter = " ${MULTILIBS}" BBCLASSEXTEND_append_pn-task-core-console = " ${MULTILIBS}" +BBCLASSEXTEND_append_pn-task-core-eclipse-support = " ${MULTILIBS}" BBCLASSEXTEND_append_pn-task-core-gtk-directfb = " ${MULTILIBS}" BBCLASSEXTEND_append_pn-task-core-lsb = " ${MULTILIBS}" BBCLASSEXTEND_append_pn-task-core-nfs = " ${MULTILIBS}"
meta/recipes-core/tasks/task-core-eclipse-support.bb new file +17 -0
@@ -0,0 +1,17 @@ +DESCRIPTION = "Agent for Eclipse plugin task for Poky" +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \ + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" +PR = "r0" + +PACKAGES = "\ + ${PN} \ + ${PN}-dev \ + ${PN}-dbg \ + " + +ALLOW_EMPTY = "1" + +RDEPENDS_${PN} = "tcf-agent \ + openssh-sftp-server \ + "
meta/recipes-sato/images/core-image-sato-sdk.bb +1 -1
@@ -5,7 +5,7 @@ DESCRIPTION = "Image with Sato support that includes everything within \ core-image-sato plus meta-toolchain, development headers and libraries to \ form a standalone SDK." -IMAGE_FEATURES += "apps-console-core ${SATO_IMAGE_FEATURES} dev-pkgs tools-sdk qt4-pkgs" +IMAGE_FEATURES += "apps-console-core ${SATO_IMAGE_FEATURES} dev-pkgs tools-sdk qt4-pkgs eclipse-support" EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks" SSHSERVER_IMAGE_FEATURES = "ssh-server-openssh"
Signature · 1 line
1.7.0.4
Re: [PATCH 1/3] classes/image: Allow openssh empty passwords login.
In reply to Lianhao LuQuoted 25 lines · Lianhao Lu
Allow empty passwords login so that the default root user can login in through openssh.
Signed-off-by Lianhao Lu<[email protected]>--- meta/classes/core-image.bbclass | 2 ++ meta/classes/image.bbclass | 10 +++++++++- 2 files changed, 11 insertions(+), 1 deletions(-)meta/classes/core-image.bbclass +2
-0@@ -69,4 +69,6 @@ ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; " # Zap the root password if debug-tweaks feature is not enabled ROOTFS_POSTPROCESS_COMMAND += '${@base_contains("IMAGE_FEATURES", "debug-tweaks", "", "zap_root_password ; ",d)}' +# Allow openssh accept empty password login if both debug-tweaks and ssh-server-openssh are enabled +ROOTFS_POSTPROCESS_COMMAND += '${@base_contains("IMAGE_FEATURES", "debug-tweaks ssh-server-openssh", "openssh_allow_empty_password; ", "",d)}'meta/classes/image.bbclass +0
-0
meta/classes/image.bbclass zap_root_password () { · line 326
Quoted 9 lines
meta/classes/image.bbclass +6
-0@@ -318,6 +318,14 @@ zap_root_password () { mv ${IMAGE_ROOTFS}/etc/passwd.new ${IMAGE_ROOTFS}/etc/passwd } +# allow openssh accept login with empty password string +openssh_allow_empty_password () { + if [ -e ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config ]; then + sed 's#.*PermitEmptyPasswords.*#PermitEmptyPasswords yes#' ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config>${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config.new + mv -f ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config.new ${IMAGE_ROOTFS}${sysconfdir}/ssh/sshd_config + fi
Why not use sed -i here?
Sau!
Quoted 14 lines
meta/classes/image.bbclass +3
-1+} + # Turn any symbolic /sbin/init link into a file remove_init_link () { if [ -h ${IMAGE_ROOTFS}/sbin/init ]; then@@ -372,7 +380,7 @@ rootfs_trim_schemas () { done } -EXPORT_FUNCTIONS zap_root_password remove_init_link do_rootfs make_zimage_symlink_relative set_image_autologin rootfs_update_timestamp rootfs_no_x_startup +EXPORT_FUNCTIONS zap_root_password remove_init_link do_rootfs make_zimage_symlink_relative set_image_autologin rootfs_update_timestamp rootfs_no_x_startup openssh_allow_empty_password do_fetch[noexec] = "1" do_unpack[noexec] = "1"