nfs regression workaround

PATCH Applied Kevin Strasser 2 participants 5 messages Sep 28, 2012 – Oct 10, 2012

Share & tools

Kevin Strasser

author

2012-09-28 19:43 UTC #0 lore raw

cover nfs regression workaround

The new recovery mechanism used by nfs in 3.4 kernels is currently failing when building baryon against poky 1.3_M3. This workaround causes nfs to revert back to the old recovery mechanism.

The issue is discussed in more detail here:
https://lkml.org/lkml/2012/6/11/243

The following changes since commit e4efadec4a1ded0a66fa67c7cca868b7a4b6221b:

talloc: specify the version of LGPL and include the license text (2012-09-27 16:54:08 -0700)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib strassek/baryon-nfsd-regression
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=strassek/baryon-nfsd-regression

Kevin Strasser (1):
nfs-utils: workaround for nfsd regression in the 3.4 kernel

 .../nfs-utils/nfs-utils_1.2.3.bbappend             |    8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend

Signature · 1 line

1.7.9.5

Kevin Strasser

author

2012-09-28 19:44 UTC #1 lore raw

PATCH 1/1 nfs-utils: workaround for nfsd regression in the 3.4 kernel

The version of nfsd used in 3.4 kernels tries to upcall the new reboot-recovery daemon and gets stuck if it is not found. This causes client mounts to fail and prints the following error message during boot:

"NFSD: starting 90-second grace period
NFSD: Unable to end grace period: -110"

If the directory "/var/lib/nfs/v4recovery" exists, nfsd will revert back to the old method.

Signed-off-by Kevin Strasser <[email protected]>

---
 .../nfs-utils/nfs-utils_1.2.3.bbappend             |    8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend

recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend new file +8 -0

new file mode 100644
index 0000000..2c91a93
@@ -0,0 +1,8 @@
+PR = "r5"
+
+# Work around linux 3.4 nfsd regression
+do_install_prepend () {
+	install -d ${D}/var/lib/nfs/v4recovery
+}
+
+FILES_${PN} += "/var/lib/nfs/v4recovery"

Signature · 1 line

1.7.9.5

Paul Eggleton

2012-09-30 15:12 UTC #2 lore raw

Re: [meta-baryon][PATCH 1/1] nfs-utils: workaround for nfsd regression in the 3.4 kernel

Hi Kevin,

Quoted 24 lines · On Friday 28 September 2012 12:44:06 Kevin Strasser wrote:

The version of nfsd used in 3.4 kernels tries to upcall the new reboot-recovery daemon and gets stuck if it is not found. This causes client mounts to fail and prints the following error message during boot:
"NFSD: starting 90-second grace period
NFSD: Unable to end grace period: -110"
If the directory "/var/lib/nfs/v4recovery" exists, nfsd will revert back to the old method.
Signed-off-by Kevin Strasser <[email protected]>
---
 .../nfs-utils/nfs-utils_1.2.3.bbappend             |    8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend
(quoted diff) +0 -0
b/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend new file mode 100644
index 0000000..2c91a93

recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend line 1

Quoted 1 line

recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend new file +1 -0
@@ -0,0 +1,8 @@
+PR = "r5"

This needs to be:

PRINC = "1"

or, to ensure other layers can also increment the value:

PRINC := "${@int(PRINC) + 1}"

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

[email protected]

author

2012-10-01 17:26 UTC #3 lore raw

Re: [meta-baryon][PATCH 1/1] nfs-utils: workaround for nfsd regression in the 3.4 kernel

Quoted 32 lines

Hi Kevin,
Quoted 25 lines · On Friday 28 September 2012 12:44:06 Kevin Strasser wrote:
The version of nfsd used in 3.4 kernels tries to upcall the new reboot-recovery daemon and gets stuck if it is not found. This causes client mounts to fail and prints the following error message during boot:
"NFSD: starting 90-second grace period
NFSD: Unable to end grace period: -110"
If the directory "/var/lib/nfs/v4recovery" exists, nfsd will revert back to the old method.
Signed-off-by Kevin Strasser <[email protected]>
---
 .../nfs-utils/nfs-utils_1.2.3.bbappend             |    8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644
recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend
(quoted diff) +0 -0
b/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend new file mode 100644
index 0000000..2c91a93
recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend line 1
Quoted 1 line
recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend new file +1 -0
@@ -0,0 +1,8 @@
+PR = "r5"
This needs to be:

Quoted 5 lines

PRINC = "1"
or, to ensure other layers can also increment the value:
PRINC := "${@int(PRINC) + 1}"

OK, that makes sense. I've made the changes and pushed them again to:

git://git.yoctoproject.org/poky-contrib strassek/baryon-nfsd-regression
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=strassek/baryon-nfsd-regression

While we are on the subject, do you think this is something that should be added to poky?

-Kevin

Paul Eggleton

Applied

2012-10-10 17:16 UTC #4 lore raw

Re: [meta-baryon][PATCH 1/1] nfs-utils: workaround for nfsd regression in the 3.4 kernel

Quoted 38 lines · On Monday 01 October 2012 10:25:47 [email protected] wrote:

Quoted 38 lines
Hi Kevin,
Quoted 27 lines · On Friday 28 September 2012 12:44:06 Kevin Strasser wrote:
The version of nfsd used in 3.4 kernels tries to upcall the new reboot-recovery daemon and gets stuck if it is not found. This causes client mounts to fail and prints the following error message during boot:
"NFSD: starting 90-second grace period
NFSD: Unable to end grace period: -110"
If the directory "/var/lib/nfs/v4recovery" exists, nfsd will revert back to the old method.
Signed-off-by Kevin Strasser <[email protected]>
---
 .../nfs-utils/nfs-utils_1.2.3.bbappend             |    8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644
recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend
(quoted diff) +0 -0
b/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend new file mode 100644
index 0000000..2c91a93
recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend line 1
Quoted 1 line
recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bbappend new file +1 -0
@@ -0,0 +1,8 @@
+PR = "r5"
This needs to be:
PRINC = "1"
or, to ensure other layers can also increment the value:

Quoted 8 lines

Quoted 1 line
PRINC := "${@int(PRINC) + 1}"
OK, that makes sense. I've made the changes and pushed them again to:
git://git.yoctoproject.org/poky-contrib strassek/baryon-nfsd-regression
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=strassek/baryon-nf
sd-regression

Merged to meta-baryon master, thanks.

Quoted 2 lines

While we are on the subject, do you think this is something that should be added to poky?

Quite possibly. Would you mind opening up a bug for the issue?

Thanks,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre