ntp fixes

People can't blindly use pool.ntp.org, especially if they are building for a product or something that could be used in a product, so at least try to get people to do the right thing and not use pool.ntp.org by default.

Signed-off-by Paul Eggleton <[email protected]>

---
 meta-networking/recipes-support/ntp/ntp.inc |   12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

meta-networking/recipes-support/ntp/ntp.inc +0 -0

index d20bc2e..b54608a 100644

meta-networking/recipes-support/ntp/ntp.inc +4 -1

+
 do_install_append() {
 	install -d ${D}/${sysconfdir}/init.d
 	install -m 644 ${WORKDIR}/ntp.conf ${D}/${sysconfdir}
 	install -m 755 ${WORKDIR}/ntpd ${D}/${sysconfdir}/init.d
 	install -d ${D}/${sysconfdir}/network/if-up.d
 	install -m 755 ${WORKDIR}/ntpdate ${D}/${sysconfdir}/network/if-up.d
+
+	sed -i "s/pool.ntp.org/${NTP_SERVERS}/g" ${D}/${sysconfdir}/ntp.conf ${D}/${sysconfdir}/network/if-up.d/ntpdate
 }
 
 PACKAGES += "ntpdate ${PN}-bin ${PN}-tickadj ${PN}-utils"

@@ -71,7 +81,7 @@ else
         if ! grep -q -s ntpdate /var/spool/cron/root; then
                 echo "adding crontab"
                 test -d /var/spool/cron || mkdir -p /var/spool/cron
-                echo "30 * * * *    /usr/bin/ntpdate -b -s -u pool.ntp.org" >> /var/spool/cron/root
+                echo "30 * * * *    /usr/bin/ntpdate -b -s -u ${NTP_SERVERS}" >> /var/spool/cron/root
         fi
 fi
 }

Signature · 7 lines

1.7.9.5


_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Quoted 27 lines · Paul Eggleton

People can't blindly use pool.ntp.org, especially if they are building for a product or something that could be used in a product, so at least try to get people to do the right thing and not use pool.ntp.org by default.

Signed-off-by Paul Eggleton <[email protected]>

---

 meta-networking/recipes-support/ntp/ntp.inc |   12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

(quoted diff) +0 -0

b/meta-networking/recipes-support/ntp/ntp.inc index d20bc2e..b54608a 100644

meta-networking/recipes-support/ntp/ntp.inc +0 -0

@@ -33,12 +33,22 @@ PACKAGECONFIG[openssl] =

"--with-openssl-libdir=${STAGING_LIBDIR} \>

                           --without-openssl --without-crypto, \
                           openssl"

meta-networking/recipes-support/ntp/ntp.inc +6 -0

+# This should be set in the distro configuration
+NTP_SERVERS ??= ""
+
+python __anonymous() {
+    if not d.getVar("NTP_SERVERS", True):
+        raise bb.parse.SkipPackage("Please set NTP_SERVERS in order to

Quoted 1 line

build ntp - see http://www.openembedded.org/wiki/NTP for details") +}

Cannot we move this logic to target?

I mean ntpdate can be usefull for end-user even without this cron job.

We can add something like
/etc/default/ntp
NTP_SERVERS=""

And change cron job as well as that systemd .service file we talked about before to show
"Please set correct NPT_SERVERS in /etc/default/ntp"
instead of failing (in systemd .service file case) or not being able to build ntpdate package unless you have distro with own ntp pool.

On other hand distro with own ntp pool can provide own value in /etc/default/ntp with .bbappend, so their users won't ever see this on target.

The following changes since commit 9637cb304f1e9116b037d0afd69014836a2fa512:

Revert "ntp: Clean up recipes" (2012-11-21 08:32:18 -0500)

are available in the git repository at:

git://git.openembedded.org/meta-openembedded-contrib paule/ntp
http://cgit.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h=paule/ntp

Paul Eggleton (2):
ntp: cleanup recipes and fix SSL support
ntp: make servers configurable and default to none configured

Quoted 43 lines · On Wednesday 21 November 2012 18:37:54 Martin Jansa wrote:

Quoted 27 lines · Paul Eggleton

People can't blindly use pool.ntp.org, especially if they are building for a product or something that could be used in a product, so at least try to get people to do the right thing and not use pool.ntp.org by default.

Signed-off-by Paul Eggleton <[email protected]>

---

  meta-networking/recipes-support/ntp/ntp.inc |   12 +++++++++++-
  1 file changed, 11 insertions(+), 1 deletion(-)

(quoted diff) +0 -0

b/meta-networking/recipes-support/ntp/ntp.inc index d20bc2e..b54608a 100644

meta-networking/recipes-support/ntp/ntp.inc +0 -0

@@ -33,12 +33,22 @@ PACKAGECONFIG[openssl] =

"--with-openssl-libdir=${STAGING_LIBDIR} \>

                            --without-openssl --without-crypto, \
                            openssl"

meta-networking/recipes-support/ntp/ntp.inc +6 -0

+# This should be set in the distro configuration
+NTP_SERVERS ??= ""
+
+python __anonymous() {
+    if not d.getVar("NTP_SERVERS", True):
+        raise bb.parse.SkipPackage("Please set NTP_SERVERS in order to

Quoted 1 line

build ntp - see http://www.openembedded.org/wiki/NTP for details") +}

Cannot we move this logic to target?

I mean ntpdate can be usefull for end-user even without this cron job.

We can add something like
/etc/default/ntp
NTP_SERVERS=""

And change cron job as well as that systemd .service file we talked about before to show
"Please set correct NPT_SERVERS in /etc/default/ntp"
instead of failing (in systemd .service file case) or not being able to build ntpdate package unless you have distro with own ntp pool.

Quoted 3 lines

On other hand distro with own ntp pool can provide own value in /etc/default/ntp with .bbappend, so their users won't ever see this on target.

Sure, this is an alternative approach. It will work for everything except ntp.conf, although for that we can just clear out that value in the file and get the distro to set their own custom version if they're going to use ntpd.

Cheers,
Paul