sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch
Subsystems (3)
PATCH 1/1 sctp: jsctp_sf_eat_sack: fix jprobes function signature mismatch
In reply to a message not in the archiveCommit 24cb81a6a (sctp: Push struct net down into all of the state machine functions) introduced the net structure into all state machine functions, but jsctp_sf_eat_sack was not updated, hence when SCTP association probing is enabled in the kernel, any simple SCTP client/server program from userspace will panic the kernel.
--- net/sctp/probe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/sctp/probe.c +2 -1
@@ -122,7 +122,8 @@ static const struct file_operations sctpprobe_fops = { .llseek = noop_llseek, }; -sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep, +sctp_disposition_t jsctp_sf_eat_sack(struct net *net, + const struct sctp_endpoint *ep, const struct sctp_association *asoc, const sctp_subtype_t type, void *arg,
Signature · 1 line
1.7.11.7
Quoted 6 lines · Daniel Borkmann
Commit
24cb81a6a(sctp: Push struct net down into all of the state machine functions) introduced the net structure into all state machine functions, butjsctp_sf_eat_sackwas not updated, hence when SCTP association probing is enabled in the kernel, any simple SCTP client/server program from userspace will panic the kernel.
Aha!!! That makes a lot more sense...
Thanks
-vlad
Quoted 22 lines
Cc Vlad Yasevich <[email protected]>Signed-off-by Daniel Borkmann <[email protected]>--- net/sctp/probe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)net/sctp/probe.c +2
-1@@ -122,7 +122,8 @@ static const struct file_operations sctpprobe_fops = { .llseek = noop_llseek, }; -sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep, +sctp_disposition_t jsctp_sf_eat_sack(struct net *net, + const struct sctp_endpoint *ep, const struct sctp_association *asoc, const sctp_subtype_t type, void *arg,
Quoted 11 lines · Vlad Yasevich
Quoted 7 lines · Daniel Borkmann
Commit
24cb81a6a(sctp: Push struct net down into all of the state machine functions) introduced the net structure into all state machine functions, butjsctp_sf_eat_sackwas not updated, hence when SCTP association probing is enabled in the kernel, any simple SCTP client/server program from userspace will panic the kernel.Aha!!! That makes a lot more sense...
Indeed. ;-)
Quoted 3 lines
Acked-by Vlad Yasevich <[email protected]>Thanks
From: Daniel Borkmann <[email protected]>
Date: Sat, 15 Dec 2012 21:12:43 +0100
Quoted 9 lines
Commit
24cb81a6a(sctp: Push struct net down into all of the state machine functions) introduced the net structure into all state machine functions, butjsctp_sf_eat_sackwas not updated, hence when SCTP association probing is enabled in the kernel, any simple SCTP client/server program from userspace will panic the kernel.Cc Vlad Yasevich <[email protected]>Signed-off-by Daniel Borkmann <[email protected]>
Applied.