Skip to contentSkip to conversation

systemd Integration

RFC PATCH Superseded Radu Moisan 5 participants 17 messages Dec 20, 2012 – Jan 4, 2013

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

cover systemd Integration

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit 958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14 17:31:31 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

Enrico Scholz (1):
systemd: move disable operation into prerm() script

Holger Hans Peter Freyther (2):
systemd: Make the main systemd files proper CONFFILES
systemd: Introduce a create-volatile to create tmp directories

Khem Raj (1):
systemd: Fix build when base_libdir is not /lib

Martin Donnelly (2):
cgroups: Add INSANE_SKIP to avoid warning about .so file Remove sysvinit mount related services if systemd is enabled

Martin Jansa (2):
systemd-systemctl-native: fix FILESPATH to find systemctl
systemd: add PACKAGES_DYNAMIC

Radu Moisan (20):
Systemd initial integration
Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES Automatically set PREFERRED_PROVIDER_udev
Add systemd_base.bbclass
Include systemd-compat-units and avahi-systemd Inherit the systemd_base class
set default.target to multi-user.target
wpa-supplicant: Fix indentation
dropbear: Fix indentation and cleanup
systemd: Some more cleanup
systemd: disable source rcS-default
polkit: merge together the two instances of PACKAGECONFIG
systemd-native: update FILESPATH with *-native directory
systemd: Remove gitpkgv.bbclass
systemd: (temporary) remove dependency on cairo
initscripts: Cleanup recipe
systemd: disable sysfs.service
xserver-nodm-init: add systemd support
util-linux: Enable systemd support
lighttpd: Remove automake patch

 meta/classes/base.bbclass                          |    7 +
 meta/classes/systemd.bbclass                       |    1 +
 meta/classes/systemd_base.bbclass                  |  218 +++++++++++++
 meta/conf/distro/include/default-distrovars.inc    |    3 +-
 meta/recipes-bsp/keymaps/files/keymaps.service     |    9 +
 meta/recipes-bsp/keymaps/keymaps_1.0.bb            |    9 +-
 meta/recipes-connectivity/avahi/avahi.inc          |   10 +-
 meta/recipes-connectivity/connman/connman.inc      |    6 +
 meta/recipes-connectivity/connman/connman_1.4.bb   |    3 +-
 meta/recipes-connectivity/dhcp/dhcp.inc            |   15 +-
 meta/recipes-connectivity/dhcp/files/dhcpd.service |   12 +
 .../dhcp/files/dhcrelay.service                    |   10 +
 .../openssh/openssh-6.0p1/sshd.socket              |   11 +
 .../openssh/openssh-6.0p1/[email protected]            |    9 +
 .../openssh/openssh-6.0p1/sshdgenkeys.service      |   10 +
 meta/recipes-connectivity/openssh/openssh_6.0p1.bb |   14 +-
 .../wpa-supplicant/wpa-supplicant-1.0.inc          |   74 +++--
 .../wpa-supplicant/wpa-supplicant_1.0.bb           |    2 +-
 meta/recipes-core/busybox/busybox.inc              |   18 ++
 meta/recipes-core/busybox/busybox_1.20.2.bb        |    4 +-
 .../busybox/files/busybox-klogd.service.in         |    8 +
 .../busybox/files/busybox-syslog.service.in        |   13 +
 meta/recipes-core/dropbear/dropbear.inc            |   81 ++---
 .../recipes-core/dropbear/dropbear/dropbear.socket |   10 +
 .../dropbear/dropbear/[email protected]            |    9 +
 .../dropbear/dropbear/dropbearkey.service          |   10 +
 .../initscripts-1.0/{urandom => urandom.sh}        |    0
 meta/recipes-core/initscripts/initscripts_1.0.bb   |  166 +++++-----
 meta/recipes-core/libcgroup/libcgroup_0.37.1.bb    |    1 +
 .../packagegroups/packagegroup-base.bb             |    4 +-
 .../packagegroups/packagegroup-core-boot.bb        |    8 +-
 meta/recipes-core/systemd/systemd-compat-units.bb  |   59 ++++
 .../systemd/systemd-compat-units/machineid.service |   16 +
 .../systemd-compat-units/run-postinsts.service     |   17 +
 .../systemd/systemd-machine-units_1.0.bb           |   14 +
 meta/recipes-core/systemd/systemd-serialgetty.bb   |   46 +++
 .../systemd/systemd-serialgetty/LICENSE            |  339 ++++++++++++++++++++
 .../systemd-serialgetty/[email protected]      |   32 ++
 meta/recipes-core/systemd/systemd-speed-hacks.bb   |   18 ++
 .../systemd/systemd-systemctl-native.bb            |   20 ++
 .../systemd/systemd-systemctl-native/systemctl     |  126 ++++++++
 .../systemd/systemd/create-volatile.conf           |   10 +
 meta/recipes-core/systemd/systemd/gtk-doc.make     |  230 +++++++++++++
 meta/recipes-core/systemd/systemd/modprobe.rules   |   17 +
 .../systemd/systemd/optional_secure_getenv.patch   |   19 ++
 .../systemd/set_default_target_to_multi-user.patch |   13 +
 .../systemd-pam-configure-check-uclibc.patch       |   26 ++
 .../systemd/systemd/systemd-pam-fix-execvpe.patch  |   26 ++
 .../systemd/systemd-pam-fix-fallocate.patch        |   82 +++++
 .../systemd/systemd-pam-fix-getty-unit.patch       |   35 ++
 .../systemd/systemd/systemd-pam-fix-mkostemp.patch |  166 ++++++++++
 .../systemd/systemd/systemd-pam-fix-msformat.patch |  335 +++++++++++++++++++
 .../recipes-core/systemd/systemd/touchscreen.rules |   18 ++
 meta/recipes-core/systemd/systemd/var-run.conf     |    4 +
 meta/recipes-core/systemd/systemd_git.bb           |  251 +++++++++++++++
 meta/recipes-core/util-linux/util-linux.inc        |    9 +-
 meta/recipes-extended/cronie/cronie/crond.service  |   10 +
 meta/recipes-extended/cronie/cronie_1.4.8.bb       |   10 +-
 .../lighttpd/files/lighttpd.service                |   13 +
 meta/recipes-extended/lighttpd/lighttpd_1.4.32.bb  |   11 +-
 meta/recipes-extended/pam/libpam_1.1.6.bb          |    5 +-
 meta/recipes-extended/polkit/polkit_0.104.bb       |   11 +-
 meta/recipes-graphics/x11-common/x11-common_0.1.bb |    4 +-
 .../x11-common/xserver-nodm-init.bb                |   19 +-
 .../x11-common/xserver-nodm-init/xserver-nodm.conf |    1 +
 .../xserver-nodm-init/xserver-nodm.service         |    9 +
 66 files changed, 2604 insertions(+), 172 deletions(-)
 create mode 100644 meta/classes/systemd.bbclass
 create mode 100644 meta/classes/systemd_base.bbclass
 create mode 100644 meta/recipes-bsp/keymaps/files/keymaps.service
 create mode 100644 meta/recipes-connectivity/dhcp/files/dhcpd.service
 create mode 100644 meta/recipes-connectivity/dhcp/files/dhcrelay.service
 create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd.socket
 create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/[email protected]
 create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshdgenkeys.service
 create mode 100644 meta/recipes-core/busybox/files/busybox-klogd.service.in
 create mode 100644 meta/recipes-core/busybox/files/busybox-syslog.service.in
 create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear.socket
 create mode 100644 meta/recipes-core/dropbear/dropbear/[email protected]
 create mode 100644 meta/recipes-core/dropbear/dropbear/dropbearkey.service
 rename meta/recipes-core/initscripts/initscripts-1.0/{urandom => urandom.sh} (100%)
 create mode 100644 meta/recipes-core/systemd/systemd-compat-units.bb
 create mode 100644 meta/recipes-core/systemd/systemd-compat-units/machineid.service
 create mode 100644 meta/recipes-core/systemd/systemd-compat-units/run-postinsts.service
 create mode 100644 meta/recipes-core/systemd/systemd-machine-units_1.0.bb
 create mode 100644 meta/recipes-core/systemd/systemd-serialgetty.bb
 create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/LICENSE
 create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/[email protected]
 create mode 100644 meta/recipes-core/systemd/systemd-speed-hacks.bb
 create mode 100644 meta/recipes-core/systemd/systemd-systemctl-native.bb
 create mode 100755 meta/recipes-core/systemd/systemd-systemctl-native/systemctl
 create mode 100644 meta/recipes-core/systemd/systemd/create-volatile.conf
 create mode 100644 meta/recipes-core/systemd/systemd/gtk-doc.make
 create mode 100644 meta/recipes-core/systemd/systemd/modprobe.rules
 create mode 100644 meta/recipes-core/systemd/systemd/optional_secure_getenv.patch
 create mode 100644 meta/recipes-core/systemd/systemd/set_default_target_to_multi-user.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-configure-check-uclibc.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-execvpe.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-getty-unit.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-mkostemp.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-msformat.patch
 create mode 100644 meta/recipes-core/systemd/systemd/touchscreen.rules
 create mode 100644 meta/recipes-core/systemd/systemd/var-run.conf
 create mode 100644 meta/recipes-core/systemd/systemd_git.bb
 create mode 100644 meta/recipes-extended/cronie/cronie/crond.service
 create mode 100644 meta/recipes-extended/lighttpd/files/lighttpd.service
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 8 lines · Radu Moisan

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit 958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14 17:31:31 +0000)

Sorry to say, this is still too far behind master, you really need to rebase right to HEAD of master (or HEAD of oe-core), I tried to apply this to the master and it failed to apply.

Quoted 33 lines

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

Enrico Scholz (1):
systemd: move disable operation into prerm() script

Holger Hans Peter Freyther (2):
systemd: Make the main systemd files proper CONFFILES
systemd: Introduce a create-volatile to create tmp directories

Khem Raj (1):
systemd: Fix build when base_libdir is not /lib

Martin Donnelly (2):
cgroups: Add INSANE_SKIP to avoid warning about .so file Remove sysvinit mount related services if systemd is enabled

Martin Jansa (2):
systemd-systemctl-native: fix FILESPATH to find systemctl
systemd: add PACKAGES_DYNAMIC

Radu Moisan (20):
Systemd initial integration
Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
Automatically set PREFERRED_PROVIDER_udev
Add systemd_base.bbclass
Include systemd-compat-units and avahi-systemd
Inherit the systemd_base class
set default.target to multi-user.target
wpa-supplicant: Fix indentation
dropbear: Fix indentation and cleanup

Quoted 8 lines

systemd: Some more cleanup
systemd: disable source rcS-default
polkit: merge together the two instances of PACKAGECONFIG
systemd-native: update FILESPATH with *-native directory
systemd: Remove gitpkgv.bbclass
systemd: (temporary) remove dependency on cairo
initscripts: Cleanup recipe
systemd: disable sysfs.service

Are you going to collapse all the systemd changes and clean up the commit messages?

Sau!

Quoted 114 lines

xserver-nodm-init: add systemd support
util-linux: Enable systemd support
lighttpd: Remove automake patch

  meta/classes/base.bbclass                          |    7 +
  meta/classes/systemd.bbclass                       |    1 +
  meta/classes/systemd_base.bbclass                  |  218 +++++++++++++
  meta/conf/distro/include/default-distrovars.inc    |    3 +-
  meta/recipes-bsp/keymaps/files/keymaps.service     |    9 +
  meta/recipes-bsp/keymaps/keymaps_1.0.bb            |    9 +-
  meta/recipes-connectivity/avahi/avahi.inc          |   10 +-
  meta/recipes-connectivity/connman/connman.inc      |    6 +
  meta/recipes-connectivity/connman/connman_1.4.bb   |    3 +-
  meta/recipes-connectivity/dhcp/dhcp.inc            |   15 +-
  meta/recipes-connectivity/dhcp/files/dhcpd.service |   12 +
  .../dhcp/files/dhcrelay.service                    |   10 +
  .../openssh/openssh-6.0p1/sshd.socket              |   11 +
  .../openssh/openssh-6.0p1/[email protected]            |    9 +
  .../openssh/openssh-6.0p1/sshdgenkeys.service      |   10 +
  meta/recipes-connectivity/openssh/openssh_6.0p1.bb |   14 +-
  .../wpa-supplicant/wpa-supplicant-1.0.inc          |   74 +++--
  .../wpa-supplicant/wpa-supplicant_1.0.bb           |    2 +-
  meta/recipes-core/busybox/busybox.inc              |   18 ++
  meta/recipes-core/busybox/busybox_1.20.2.bb        |    4 +-
  .../busybox/files/busybox-klogd.service.in         |    8 +
  .../busybox/files/busybox-syslog.service.in        |   13 +
  meta/recipes-core/dropbear/dropbear.inc            |   81 ++---
  .../recipes-core/dropbear/dropbear/dropbear.socket |   10 +
  .../dropbear/dropbear/[email protected]            |    9 +
  .../dropbear/dropbear/dropbearkey.service          |   10 +
  .../initscripts-1.0/{urandom => urandom.sh}        |    0
  meta/recipes-core/initscripts/initscripts_1.0.bb   |  166 +++++-----
  meta/recipes-core/libcgroup/libcgroup_0.37.1.bb    |    1 +
  .../packagegroups/packagegroup-base.bb             |    4 +-
  .../packagegroups/packagegroup-core-boot.bb        |    8 +-
  meta/recipes-core/systemd/systemd-compat-units.bb  |   59 ++++
  .../systemd/systemd-compat-units/machineid.service |   16 +
  .../systemd-compat-units/run-postinsts.service     |   17 +
  .../systemd/systemd-machine-units_1.0.bb           |   14 +
  meta/recipes-core/systemd/systemd-serialgetty.bb   |   46 +++
  .../systemd/systemd-serialgetty/LICENSE            |  339 ++++++++++++++++++++
  .../systemd-serialgetty/[email protected]      |   32 ++
  meta/recipes-core/systemd/systemd-speed-hacks.bb   |   18 ++
  .../systemd/systemd-systemctl-native.bb            |   20 ++
  .../systemd/systemd-systemctl-native/systemctl     |  126 ++++++++
  .../systemd/systemd/create-volatile.conf           |   10 +
  meta/recipes-core/systemd/systemd/gtk-doc.make     |  230 +++++++++++++
  meta/recipes-core/systemd/systemd/modprobe.rules   |   17 +
  .../systemd/systemd/optional_secure_getenv.patch   |   19 ++
  .../systemd/set_default_target_to_multi-user.patch |   13 +
  .../systemd-pam-configure-check-uclibc.patch       |   26 ++
  .../systemd/systemd/systemd-pam-fix-execvpe.patch  |   26 ++
  .../systemd/systemd-pam-fix-fallocate.patch        |   82 +++++
  .../systemd/systemd-pam-fix-getty-unit.patch       |   35 ++
  .../systemd/systemd/systemd-pam-fix-mkostemp.patch |  166 ++++++++++
  .../systemd/systemd/systemd-pam-fix-msformat.patch |  335 +++++++++++++++++++
  .../recipes-core/systemd/systemd/touchscreen.rules |   18 ++
  meta/recipes-core/systemd/systemd/var-run.conf     |    4 +
  meta/recipes-core/systemd/systemd_git.bb           |  251 +++++++++++++++
  meta/recipes-core/util-linux/util-linux.inc        |    9 +-
  meta/recipes-extended/cronie/cronie/crond.service  |   10 +
  meta/recipes-extended/cronie/cronie_1.4.8.bb       |   10 +-
  .../lighttpd/files/lighttpd.service                |   13 +
  meta/recipes-extended/lighttpd/lighttpd_1.4.32.bb  |   11 +-
  meta/recipes-extended/pam/libpam_1.1.6.bb          |    5 +-
  meta/recipes-extended/polkit/polkit_0.104.bb       |   11 +-
  meta/recipes-graphics/x11-common/x11-common_0.1.bb |    4 +-
  .../x11-common/xserver-nodm-init.bb                |   19 +-
  .../x11-common/xserver-nodm-init/xserver-nodm.conf |    1 +
  .../xserver-nodm-init/xserver-nodm.service         |    9 +
  66 files changed, 2604 insertions(+), 172 deletions(-)

create mode 100644 meta/classes/systemd.bbclass
create mode 100644 meta/classes/systemd_base.bbclass
create mode 100644 meta/recipes-bsp/keymaps/files/keymaps.service
create mode 100644 meta/recipes-connectivity/dhcp/files/dhcpd.service
create mode 100644 meta/recipes-connectivity/dhcp/files/dhcrelay.service create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd.socket create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/[email protected] create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshdgenkeys.service create mode 100644 meta/recipes-core/busybox/files/busybox-klogd.service.in create mode 100644 meta/recipes-core/busybox/files/busybox-syslog.service.in create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear.socket
create mode 100644 meta/recipes-core/dropbear/dropbear/[email protected] create mode 100644 meta/recipes-core/dropbear/dropbear/dropbearkey.service rename meta/recipes-core/initscripts/initscripts-1.0/{urandom => urandom.sh} (100%) create mode 100644 meta/recipes-core/systemd/systemd-compat-units.bb
create mode 100644 meta/recipes-core/systemd/systemd-compat-units/machineid.service create mode 100644 meta/recipes-core/systemd/systemd-compat-units/run-postinsts.service create mode 100644 meta/recipes-core/systemd/systemd-machine-units_1.0.bb create mode 100644 meta/recipes-core/systemd/systemd-serialgetty.bb
create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/LICENSE create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/[email protected] create mode 100644 meta/recipes-core/systemd/systemd-speed-hacks.bb
create mode 100644 meta/recipes-core/systemd/systemd-systemctl-native.bb create mode 100755 meta/recipes-core/systemd/systemd-systemctl-native/systemctl create mode 100644 meta/recipes-core/systemd/systemd/create-volatile.conf create mode 100644 meta/recipes-core/systemd/systemd/gtk-doc.make
create mode 100644 meta/recipes-core/systemd/systemd/modprobe.rules
create mode 100644 meta/recipes-core/systemd/systemd/optional_secure_getenv.patch create mode 100644 meta/recipes-core/systemd/systemd/set_default_target_to_multi-user.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-configure-check-uclibc.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-execvpe.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-getty-unit.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-mkostemp.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-msformat.patch create mode 100644 meta/recipes-core/systemd/systemd/touchscreen.rules
create mode 100644 meta/recipes-core/systemd/systemd/var-run.conf
create mode 100644 meta/recipes-core/systemd/systemd_git.bb
create mode 100644 meta/recipes-extended/cronie/cronie/crond.service
create mode 100644 meta/recipes-extended/lighttpd/files/lighttpd.service create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service

#2 lore raw
Quoted 11 lines · Saul Wold
Quoted 9 lines · Radu Moisan

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit 958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14
17:31:31 +0000)

Sorry to say, this is still too far behind master, you really need to rebase right to HEAD of master (or HEAD of oe-core), I tried to apply this to the master and it failed to apply.

I'll rebase on master today.

Quoted 42 lines
Quoted 34 lines

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

Enrico Scholz (1):
systemd: move disable operation into prerm() script

Holger Hans Peter Freyther (2):
systemd: Make the main systemd files proper CONFFILES
systemd: Introduce a create-volatile to create tmp directories

Khem Raj (1):
systemd: Fix build when base_libdir is not /lib

Martin Donnelly (2):
cgroups: Add INSANE_SKIP to avoid warning about .so file Remove sysvinit mount related services if systemd is enabled

Martin Jansa (2):
systemd-systemctl-native: fix FILESPATH to find systemctl
systemd: add PACKAGES_DYNAMIC

Radu Moisan (20):
Systemd initial integration
Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
Automatically set PREFERRED_PROVIDER_udev
Add systemd_base.bbclass
Include systemd-compat-units and avahi-systemd
Inherit the systemd_base class
set default.target to multi-user.target
wpa-supplicant: Fix indentation
dropbear: Fix indentation and cleanup

Quoted 8 lines

systemd: Some more cleanup
systemd: disable source rcS-default
polkit: merge together the two instances of PACKAGECONFIG
systemd-native: update FILESPATH with *-native directory
systemd: Remove gitpkgv.bbclass
systemd: (temporary) remove dependency on cairo
initscripts: Cleanup recipe
systemd: disable sysfs.service

Quoted 2 lines

Are you going to collapse all the systemd changes and clean up the commit messages?

Wouldn't it be harder to review? I can do it anytime, if you think it is the right way to go.

Radu

#7 lore raw
In reply to Radu Moisan
Quoted 7 lines · Radu Moisan

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit 958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14 17:31:31 +0000)

That's 95 patches away from poky master, please fetch origin and rebase.

Quoted 4 lines

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

The short log looks like this:

86470e3 Systemd initial integration
d1fa1fa Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES d7f6847 Automatically set PREFERRED_PROVIDER_udev
a2edc09 Add systemd_base.bbclass
ccc83ce Include systemd-compat-units and avahi-systemd addb2bc Inherit the systemd_base class
2426a47 set default.target to multi-user.target
42cbe6f wpa-supplicant: Fix indentation
e715fa0 dropbear: Fix indentation and cleanup
83311c9 systemd: Some more cleanup
f091e53 systemd: disable source rcS-default
a7dc429 polkit: merge together the two instances of PACKAGECONFIG 14165c9 systemd-native: update FILESPATH with *-native directory eaa960c systemd: Remove gitpkgv.bbclass
6220483 systemd: (temporary) remove dependency on cairo 1527d71 cgroups: Add INSANE_SKIP to avoid warning about .so file 0bd67a2 initscripts: Cleanup recipe
4aeecde systemd: disable sysfs.service
9869ffd Remove sysvinit mount related services if systemd is enabled 3b0884e systemd: Make the main systemd files proper CONFFILES 43609a3 systemd-systemctl-native: fix FILESPATH to find systemctl 901deef xserver-nodm-init: add systemd support
9427b9f systemd: add PACKAGES_DYNAMIC
02cde59 util-linux: Enable systemd support
3f07f4c lighttpd: Remove automake patch
7428e54 systemd: Introduce a create-volatile to create tmp directories 1b0886e systemd: Fix build when base_libdir is not /lib 60da63d systemd: move disable operation into prerm() script

First, in a branch for review you don't want to have "fix this", "delete that", and so on. If a file was added in one commit and removed later, squash them together so the file doesn't exist. If you fix whitespace, squash them together so it was always fixed.

Next the mantra is single, obvious changes. The first change should be to introduce the systemd packages, then the integration into the build, then the fixes to individual packages.

Any patches that are not related to systemd (eg lighttpd: Remove automake patch) should be submitted separately.

Ross

#3 lore raw
In reply to Radu Moisan
Quoted 2 lines · Radu Moisan

Wouldn't it be harder to review? I can do it anytime, if you think it is the right way to go.

It's much harder to review a patch which has corrections later.

Ross

#6 lore raw
In reply to Radu Moisan
Quoted 5 lines · Radu Moisan
Quoted 3 lines

Are you going to collapse all the systemd changes and clean up the commit messages?

Wouldn't it be harder to review? I can do it anytime, if you think it is the right way to go.

Yes it does. Another thing it should have in commit log is the Meta-OE revision compared so we can diff and check of more changes need to be done.

--
Otavio Salvador O.S. Systems
E-mail: [email protected] http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

#8 lore raw
In reply to Burton, Ross
Quoted 47 lines · Ross
Quoted 7 lines · Radu Moisan

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit 958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14 17:31:31 +0000)

That's 95 patches away from poky master, please fetch origin and rebase.

Quoted 4 lines

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

The short log looks like this:

86470e3 Systemd initial integration
d1fa1fa Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES d7f6847 Automatically set PREFERRED_PROVIDER_udev
a2edc09 Add systemd_base.bbclass
ccc83ce Include systemd-compat-units and avahi-systemd addb2bc Inherit the systemd_base class
2426a47 set default.target to multi-user.target
42cbe6f wpa-supplicant: Fix indentation
e715fa0 dropbear: Fix indentation and cleanup
83311c9 systemd: Some more cleanup
f091e53 systemd: disable source rcS-default
a7dc429 polkit: merge together the two instances of PACKAGECONFIG 14165c9 systemd-native: update FILESPATH with *-native directory eaa960c systemd: Remove gitpkgv.bbclass
6220483 systemd: (temporary) remove dependency on cairo 1527d71 cgroups: Add INSANE_SKIP to avoid warning about .so file 0bd67a2 initscripts: Cleanup recipe
4aeecde systemd: disable sysfs.service
9869ffd Remove sysvinit mount related services if systemd is enabled 3b0884e systemd: Make the main systemd files proper CONFFILES 43609a3 systemd-systemctl-native: fix FILESPATH to find systemctl 901deef xserver-nodm-init: add systemd support
9427b9f systemd: add PACKAGES_DYNAMIC
02cde59 util-linux: Enable systemd support
3f07f4c lighttpd: Remove automake patch
7428e54 systemd: Introduce a create-volatile to create tmp directories 1b0886e systemd: Fix build when base_libdir is not /lib 60da63d systemd: move disable operation into prerm() script

Quoted 5 lines

First, in a branch for review you don't want to have "fix this", "delete that", and so on. If a file was added in one commit and removed later, squash them together so the file doesn't exist. If you fix whitespace, squash them together so it was always fixed.

Just to be clear about whitespace changes, they should go in a separate and distinct "whitespace changes" commit, that way reviewers aren't trying to hunt down the non-whitespace changes.

Sau!

Quoted 15 lines

Next the mantra is single, obvious changes. The first change should be to introduce the systemd packages, then the integration into the build, then the fixes to individual packages.

Any patches that are not related to systemd (eg lighttpd: Remove automake patch) should be submitted separately.

Ross

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

#4 lore raw
In reply to Burton, Ross
Quoted 5 lines · Ross
Quoted 2 lines · Radu Moisan

Wouldn't it be harder to review? I can do it anytime, if you think it is the right way to go.

It's much harder to review a patch which has corrections later.

Sorry but it is not clear what you mean; do you prefer him to squash all changes in a single patch or have an initial patch and queue patches above this with the fixes?

--
Otavio Salvador O.S. Systems
E-mail: [email protected] http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

#5 lore raw
Quoted 3 lines · Otavio Salvador

Sorry but it is not clear what you mean; do you prefer him to squash all changes in a single patch or have an initial patch and queue patches above this with the fixes?

I prefer a logical series of correct patches, which will probably involve squashing into a single commit and then splitting the pieces out afterwards.

(with a reference to what version of meta-oe the series was based on)

Ross

#9 lore raw
In reply to Radu Moisan
Quoted 44 lines · Radu Moisan

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit 958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14 17:31:31 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

Enrico Scholz (1):
systemd: move disable operation into prerm() script

Holger Hans Peter Freyther (2):
systemd: Make the main systemd files proper CONFFILES
systemd: Introduce a create-volatile to create tmp directories

Khem Raj (1):
systemd: Fix build when base_libdir is not /lib

Martin Donnelly (2):
cgroups: Add INSANE_SKIP to avoid warning about .so file Remove sysvinit mount related services if systemd is enabled

Martin Jansa (2):
systemd-systemctl-native: fix FILESPATH to find systemctl
systemd: add PACKAGES_DYNAMIC

Radu Moisan (20):
Systemd initial integration
Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES Automatically set PREFERRED_PROVIDER_udev
Add systemd_base.bbclass
Include systemd-compat-units and avahi-systemd Inherit the systemd_base class
set default.target to multi-user.target
wpa-supplicant: Fix indentation
dropbear: Fix indentation and cleanup
systemd: Some more cleanup
systemd: disable source rcS-default
polkit: merge together the two instances of PACKAGECONFIG

Quoted 9 lines

systemd-native: update FILESPATH with *-native directory
systemd: Remove gitpkgv.bbclass
systemd: (temporary) remove dependency on cairo
initscripts: Cleanup recipe
systemd: disable sysfs.service
xserver-nodm-init: add systemd support
util-linux: Enable systemd support
lighttpd: Remove automake patch

Please be sure to build this with the INCOMPATIBLE_LICENSE = "GPLv3" settig, I saw the following issues on the Autobuilder.

Quoted 12 lines

NOTE: Resolving any missing task queue dependencies
ERROR: Nothing PROVIDES 'xz' (but /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-non-gpl3/build/meta/recipes-core/systemd/systemd_git.bb DEPENDS on or otherwise requires it)
ERROR: xz was skipped: incompatible with license GPLv2+ & GPLv3+ & LGPLv2.1+
ERROR: Nothing RPROVIDES 'udev-systemd' (but /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-non-gpl3/build/meta/recipes-core/systemd/systemd_git.bb RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'udev-systemd'
NOTE: Runtime target 'udev-systemd' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['udev-systemd']
ERROR: Nothing RPROVIDES 'systemd' (but /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-non-gpl3/build/meta/recipes-core/systemd/systemd_git.bb RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'systemd'
NOTE: Runtime target 'systemd' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['systemd']

Quoted 8 lines

ERROR: Nothing RPROVIDES 'systemd-dev' (but /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-non-gpl3/build/meta/recipes-core/systemd/systemd_git.bb RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'systemd-dev'
NOTE: Runtime target 'systemd-dev' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['systemd-dev']
NOTE: Runtime target 'systemd-serialgetty' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['systemd-serialgetty']
NOTE: Preparing runqueue
NOTE: Executing SetScene Tasks

Also, you do not provide very clear information at the beginning, but I assume to enable systemd, it's just setting DISTRO_FEATURE += "systemd", or is there more?

Sau!

Quoted 110 lines
  meta/classes/base.bbclass                          |    7 +
  meta/classes/systemd.bbclass                       |    1 +
  meta/classes/systemd_base.bbclass                  |  218 +++++++++++++
  meta/conf/distro/include/default-distrovars.inc    |    3 +-
  meta/recipes-bsp/keymaps/files/keymaps.service     |    9 +
  meta/recipes-bsp/keymaps/keymaps_1.0.bb            |    9 +-
  meta/recipes-connectivity/avahi/avahi.inc          |   10 +-
  meta/recipes-connectivity/connman/connman.inc      |    6 +
  meta/recipes-connectivity/connman/connman_1.4.bb   |    3 +-
  meta/recipes-connectivity/dhcp/dhcp.inc            |   15 +-
  meta/recipes-connectivity/dhcp/files/dhcpd.service |   12 +
  .../dhcp/files/dhcrelay.service                    |   10 +
  .../openssh/openssh-6.0p1/sshd.socket              |   11 +
  .../openssh/openssh-6.0p1/[email protected]            |    9 +
  .../openssh/openssh-6.0p1/sshdgenkeys.service      |   10 +
  meta/recipes-connectivity/openssh/openssh_6.0p1.bb |   14 +-
  .../wpa-supplicant/wpa-supplicant-1.0.inc          |   74 +++--
  .../wpa-supplicant/wpa-supplicant_1.0.bb           |    2 +-
  meta/recipes-core/busybox/busybox.inc              |   18 ++
  meta/recipes-core/busybox/busybox_1.20.2.bb        |    4 +-
  .../busybox/files/busybox-klogd.service.in         |    8 +
  .../busybox/files/busybox-syslog.service.in        |   13 +
  meta/recipes-core/dropbear/dropbear.inc            |   81 ++---
  .../recipes-core/dropbear/dropbear/dropbear.socket |   10 +
  .../dropbear/dropbear/[email protected]            |    9 +
  .../dropbear/dropbear/dropbearkey.service          |   10 +
  .../initscripts-1.0/{urandom => urandom.sh}        |    0
  meta/recipes-core/initscripts/initscripts_1.0.bb   |  166 +++++-----
  meta/recipes-core/libcgroup/libcgroup_0.37.1.bb    |    1 +
  .../packagegroups/packagegroup-base.bb             |    4 +-
  .../packagegroups/packagegroup-core-boot.bb        |    8 +-
  meta/recipes-core/systemd/systemd-compat-units.bb  |   59 ++++
  .../systemd/systemd-compat-units/machineid.service |   16 +
  .../systemd-compat-units/run-postinsts.service     |   17 +
  .../systemd/systemd-machine-units_1.0.bb           |   14 +
  meta/recipes-core/systemd/systemd-serialgetty.bb   |   46 +++
  .../systemd/systemd-serialgetty/LICENSE            |  339 ++++++++++++++++++++
  .../systemd-serialgetty/[email protected]      |   32 ++
  meta/recipes-core/systemd/systemd-speed-hacks.bb   |   18 ++
  .../systemd/systemd-systemctl-native.bb            |   20 ++
  .../systemd/systemd-systemctl-native/systemctl     |  126 ++++++++
  .../systemd/systemd/create-volatile.conf           |   10 +
  meta/recipes-core/systemd/systemd/gtk-doc.make     |  230 +++++++++++++
  meta/recipes-core/systemd/systemd/modprobe.rules   |   17 +
  .../systemd/systemd/optional_secure_getenv.patch   |   19 ++
  .../systemd/set_default_target_to_multi-user.patch |   13 +
  .../systemd-pam-configure-check-uclibc.patch       |   26 ++
  .../systemd/systemd/systemd-pam-fix-execvpe.patch  |   26 ++
  .../systemd/systemd-pam-fix-fallocate.patch        |   82 +++++
  .../systemd/systemd-pam-fix-getty-unit.patch       |   35 ++
  .../systemd/systemd/systemd-pam-fix-mkostemp.patch |  166 ++++++++++
  .../systemd/systemd/systemd-pam-fix-msformat.patch |  335 +++++++++++++++++++
  .../recipes-core/systemd/systemd/touchscreen.rules |   18 ++
  meta/recipes-core/systemd/systemd/var-run.conf     |    4 +
  meta/recipes-core/systemd/systemd_git.bb           |  251 +++++++++++++++
  meta/recipes-core/util-linux/util-linux.inc        |    9 +-
  meta/recipes-extended/cronie/cronie/crond.service  |   10 +
  meta/recipes-extended/cronie/cronie_1.4.8.bb       |   10 +-
  .../lighttpd/files/lighttpd.service                |   13 +
  meta/recipes-extended/lighttpd/lighttpd_1.4.32.bb  |   11 +-
  meta/recipes-extended/pam/libpam_1.1.6.bb          |    5 +-
  meta/recipes-extended/polkit/polkit_0.104.bb       |   11 +-
  meta/recipes-graphics/x11-common/x11-common_0.1.bb |    4 +-
  .../x11-common/xserver-nodm-init.bb                |   19 +-
  .../x11-common/xserver-nodm-init/xserver-nodm.conf |    1 +
  .../xserver-nodm-init/xserver-nodm.service         |    9 +
  66 files changed, 2604 insertions(+), 172 deletions(-)

create mode 100644 meta/classes/systemd.bbclass
create mode 100644 meta/classes/systemd_base.bbclass
create mode 100644 meta/recipes-bsp/keymaps/files/keymaps.service
create mode 100644 meta/recipes-connectivity/dhcp/files/dhcpd.service
create mode 100644 meta/recipes-connectivity/dhcp/files/dhcrelay.service create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd.socket create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/[email protected] create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshdgenkeys.service create mode 100644 meta/recipes-core/busybox/files/busybox-klogd.service.in create mode 100644 meta/recipes-core/busybox/files/busybox-syslog.service.in create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear.socket
create mode 100644 meta/recipes-core/dropbear/dropbear/[email protected] create mode 100644 meta/recipes-core/dropbear/dropbear/dropbearkey.service rename meta/recipes-core/initscripts/initscripts-1.0/{urandom => urandom.sh} (100%) create mode 100644 meta/recipes-core/systemd/systemd-compat-units.bb
create mode 100644 meta/recipes-core/systemd/systemd-compat-units/machineid.service create mode 100644 meta/recipes-core/systemd/systemd-compat-units/run-postinsts.service create mode 100644 meta/recipes-core/systemd/systemd-machine-units_1.0.bb create mode 100644 meta/recipes-core/systemd/systemd-serialgetty.bb
create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/LICENSE create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/[email protected] create mode 100644 meta/recipes-core/systemd/systemd-speed-hacks.bb
create mode 100644 meta/recipes-core/systemd/systemd-systemctl-native.bb create mode 100755 meta/recipes-core/systemd/systemd-systemctl-native/systemctl create mode 100644 meta/recipes-core/systemd/systemd/create-volatile.conf create mode 100644 meta/recipes-core/systemd/systemd/gtk-doc.make
create mode 100644 meta/recipes-core/systemd/systemd/modprobe.rules
create mode 100644 meta/recipes-core/systemd/systemd/optional_secure_getenv.patch create mode 100644 meta/recipes-core/systemd/systemd/set_default_target_to_multi-user.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-configure-check-uclibc.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-execvpe.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-getty-unit.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-mkostemp.patch create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-msformat.patch create mode 100644 meta/recipes-core/systemd/systemd/touchscreen.rules
create mode 100644 meta/recipes-core/systemd/systemd/var-run.conf
create mode 100644 meta/recipes-core/systemd/systemd_git.bb
create mode 100644 meta/recipes-extended/cronie/cronie/crond.service
create mode 100644 meta/recipes-extended/lighttpd/files/lighttpd.service create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service

#10 lore raw
Quoted 56 lines · Saul Wold
Quoted 45 lines · Radu Moisan

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit 958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14
17:31:31 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

Enrico Scholz (1):
systemd: move disable operation into prerm() script

Holger Hans Peter Freyther (2):
systemd: Make the main systemd files proper CONFFILES
systemd: Introduce a create-volatile to create tmp directories

Khem Raj (1):
systemd: Fix build when base_libdir is not /lib

Martin Donnelly (2):
cgroups: Add INSANE_SKIP to avoid warning about .so file Remove sysvinit mount related services if systemd is enabled

Martin Jansa (2):
systemd-systemctl-native: fix FILESPATH to find systemctl
systemd: add PACKAGES_DYNAMIC

Radu Moisan (20):
Systemd initial integration
Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES Automatically set PREFERRED_PROVIDER_udev
Add systemd_base.bbclass
Include systemd-compat-units and avahi-systemd Inherit the systemd_base class
set default.target to multi-user.target
wpa-supplicant: Fix indentation
dropbear: Fix indentation and cleanup
systemd: Some more cleanup
systemd: disable source rcS-default
polkit: merge together the two instances of PACKAGECONFIG

Quoted 9 lines

systemd-native: update FILESPATH with *-native directory
systemd: Remove gitpkgv.bbclass
systemd: (temporary) remove dependency on cairo
initscripts: Cleanup recipe
systemd: disable sysfs.service
xserver-nodm-init: add systemd support
util-linux: Enable systemd support
lighttpd: Remove automake patch

Quoted 1 line

Please be sure to build this with the INCOMPATIBLE_LICENSE = "GPLv3" settig, I saw the following issues on the Autobuilder.

I've seen a patch from Martin Ertsaas <mailto:[email protected]> which will allow us to compile systemd without xz. I'll take a look over it.

Quoted 22 lines
Quoted 13 lines

NOTE: Resolving any missing task queue dependencies
ERROR: Nothing PROVIDES 'xz' (but /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-non-gpl3/build/meta/recipes-core/systemd/systemd_git.bb DEPENDS on or otherwise requires it)
ERROR: xz was skipped: incompatible with license GPLv2+ & GPLv3+ & LGPLv2.1+
ERROR: Nothing RPROVIDES 'udev-systemd' (but /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-non-gpl3/build/meta/recipes-core/systemd/systemd_git.bb RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'udev-systemd'
NOTE: Runtime target 'udev-systemd' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['udev-systemd']
ERROR: Nothing RPROVIDES 'systemd' (but /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-non-gpl3/build/meta/recipes-core/systemd/systemd_git.bb RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'systemd'
NOTE: Runtime target 'systemd' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['systemd']

Quoted 8 lines

ERROR: Nothing RPROVIDES 'systemd-dev' (but /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-non-gpl3/build/meta/recipes-core/systemd/systemd_git.bb RDEPENDS on or otherwise requires it)
ERROR: No eligible RPROVIDERs exist for 'systemd-dev'
NOTE: Runtime target 'systemd-dev' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['systemd-dev']
NOTE: Runtime target 'systemd-serialgetty' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['systemd-serialgetty']
NOTE: Preparing runqueue
NOTE: Executing SetScene Tasks

Quoted 2 lines

Also, you do not provide very clear information at the beginning, but I assume to enable systemd, it's just setting DISTRO_FEATURE += "systemd", or is there more?

DISTRO_FEATURES_INITMAN = "systemd" it's all you need. DISTRO_FEATURE += "systemd" might also work in some extent since I'm checking against DISTRO_FEATURES, however there are variables like VIRTUAL_RUNTIME_init_manager (which is inherited legacy) which get set from DISTRO_FEATURES_INITMAN. The way to go is with DISTRO_FEATURES_INITMAN.

Radu

Radu

#11 lore raw
Quoted 10 lines · On Friday 28 December 2012 16:24:36 Radu Moisan wrote:
Quoted 3 lines · Saul Wold

Also, you do not provide very clear information at the beginning, but I assume to enable systemd, it's just setting DISTRO_FEATURE += "systemd", or is there more?

DISTRO_FEATURES_INITMAN = "systemd" it's all you need. DISTRO_FEATURE += "systemd" might also work in some extent since I'm checking against DISTRO_FEATURES, however there are variables like VIRTUAL_RUNTIME_init_manager (which is inherited legacy) which get set from DISTRO_FEATURES_INITMAN. The way to go is with DISTRO_FEATURES_INITMAN.

Can you explain why we need another variable for this?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#12 lore raw
Quoted 11 lines · Paul Eggleton
Quoted 9 lines · On Friday 28 December 2012 16:24:36 Radu Moisan wrote:
Quoted 3 lines · Saul Wold

Also, you do not provide very clear information at the beginning, but I assume to enable systemd, it's just setting DISTRO_FEATURE += "systemd", or is there more?

DISTRO_FEATURES_INITMAN = "systemd" it's all you need. DISTRO_FEATURE += "systemd" might also work in some extent since I'm checking against DISTRO_FEATURES, however there are variables like VIRTUAL_RUNTIME_init_manager (which is inherited legacy) which get set from DISTRO_FEATURES_INITMAN. The way to go is with DISTRO_FEATURES_INITMAN.

Can you explain why we need another variable for this?

Initially I went for VIRTUAL-RUNTIME_init_manager, but Richard suggested I should get rid of lower case ambiguity and he proposed DISTRO_FEATURES_INITMAN.

Radu

#13 lore raw
In reply to Saul Wold
Quoted 56 lines · Saul Wold
Quoted 45 lines · Radu Moisan

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit 958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14
17:31:31 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

Enrico Scholz (1):
systemd: move disable operation into prerm() script

Holger Hans Peter Freyther (2):
systemd: Make the main systemd files proper CONFFILES
systemd: Introduce a create-volatile to create tmp directories

Khem Raj (1):
systemd: Fix build when base_libdir is not /lib

Martin Donnelly (2):
cgroups: Add INSANE_SKIP to avoid warning about .so file Remove sysvinit mount related services if systemd is enabled

Martin Jansa (2):
systemd-systemctl-native: fix FILESPATH to find systemctl
systemd: add PACKAGES_DYNAMIC

Radu Moisan (20):
Systemd initial integration
Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES Automatically set PREFERRED_PROVIDER_udev
Add systemd_base.bbclass
Include systemd-compat-units and avahi-systemd Inherit the systemd_base class
set default.target to multi-user.target
wpa-supplicant: Fix indentation
dropbear: Fix indentation and cleanup
systemd: Some more cleanup
systemd: disable source rcS-default
polkit: merge together the two instances of PACKAGECONFIG

Quoted 9 lines

systemd-native: update FILESPATH with *-native directory
systemd: Remove gitpkgv.bbclass
systemd: (temporary) remove dependency on cairo
initscripts: Cleanup recipe
systemd: disable sysfs.service
xserver-nodm-init: add systemd support
util-linux: Enable systemd support
lighttpd: Remove automake patch

Quoted 2 lines

Please be sure to build this with the INCOMPATIBLE_LICENSE = "GPLv3" settig, I saw the following issues on the Autobuilder.

I've rebuilt systemd without xz dependency and now I can build core-image-minimal with INCOMPATIBLE_LICENSE = "GPLv3", however core-image-sato would not build. Do we want sato to build with GPLv3 incompatibility flag set? I couldn't build sato this way on master either, but I didn't try a clean build so I'm not 100% sure about that.

Radu

#14 lore raw
Quoted 63 lines · Radu Moisan
Quoted 57 lines · Saul Wold
Quoted 46 lines · Radu Moisan

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit
958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14
17:31:31 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

Enrico Scholz (1):
systemd: move disable operation into prerm() script

Holger Hans Peter Freyther (2):
systemd: Make the main systemd files proper CONFFILES
systemd: Introduce a create-volatile to create tmp directories

Khem Raj (1):
systemd: Fix build when base_libdir is not /lib

Martin Donnelly (2):
cgroups: Add INSANE_SKIP to avoid warning about .so file Remove sysvinit mount related services if systemd is enabled

Martin Jansa (2):
systemd-systemctl-native: fix FILESPATH to find systemctl
systemd: add PACKAGES_DYNAMIC

Radu Moisan (20):
Systemd initial integration
Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES Automatically set PREFERRED_PROVIDER_udev
Add systemd_base.bbclass
Include systemd-compat-units and avahi-systemd Inherit the systemd_base class
set default.target to multi-user.target
wpa-supplicant: Fix indentation
dropbear: Fix indentation and cleanup
systemd: Some more cleanup
systemd: disable source rcS-default
polkit: merge together the two instances of PACKAGECONFIG

Quoted 9 lines

systemd-native: update FILESPATH with *-native directory
systemd: Remove gitpkgv.bbclass
systemd: (temporary) remove dependency on cairo
initscripts: Cleanup recipe
systemd: disable sysfs.service
xserver-nodm-init: add systemd support
util-linux: Enable systemd support
lighttpd: Remove automake patch

Quoted 3 lines

Please be sure to build this with the INCOMPATIBLE_LICENSE = "GPLv3" settig, I saw the following issues on the Autobuilder.

Quoted 6 lines

I've rebuilt systemd without xz dependency and now I can build core-image-minimal with INCOMPATIBLE_LICENSE = "GPLv3", however core-image-sato would not build. Do we want sato to build with GPLv3 incompatibility flag set? I couldn't build sato this way on master either, but I didn't try a clean build so I'm not 100% sure about that.

Sato will not build with non-GPLv3. The other image that can build non-GPLv3 is core-image-basic, it pulls in much more LSB full commands, non-busybox.

Sau!

Quoted 3 lines

Radu

#15 lore raw
Quoted 65 lines · Saul Wold
Quoted 64 lines · Radu Moisan
Quoted 61 lines · Saul Wold
Quoted 47 lines · Radu Moisan

I've rebased my branch, again :), with some cleanups here and there I also pushed a few patches suggested by Martin.
Feel free to comment on everything.

The following changes since commit
958162e96b4a4f23bca94500b5f20975633dd5c6:

bitbake: hob: use base image only if it was set (2012-12-14
17:31:31 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib rmoisan/systemd
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

Enrico Scholz (1):
systemd: move disable operation into prerm() script

Holger Hans Peter Freyther (2):
systemd: Make the main systemd files proper CONFFILES
systemd: Introduce a create-volatile to create tmp directories

Khem Raj (1):
systemd: Fix build when base_libdir is not /lib

Martin Donnelly (2):
cgroups: Add INSANE_SKIP to avoid warning about .so file Remove sysvinit mount related services if systemd is enabled

Martin Jansa (2):
systemd-systemctl-native: fix FILESPATH to find systemctl
systemd: add PACKAGES_DYNAMIC

Radu Moisan (20):
Systemd initial integration
Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES Automatically set PREFERRED_PROVIDER_udev
Add systemd_base.bbclass
Include systemd-compat-units and avahi-systemd Inherit the systemd_base class
set default.target to multi-user.target
wpa-supplicant: Fix indentation
dropbear: Fix indentation and cleanup
systemd: Some more cleanup
systemd: disable source rcS-default
polkit: merge together the two instances of PACKAGECONFIG

Quoted 9 lines

systemd-native: update FILESPATH with *-native directory
systemd: Remove gitpkgv.bbclass
systemd: (temporary) remove dependency on cairo
initscripts: Cleanup recipe
systemd: disable sysfs.service
xserver-nodm-init: add systemd support
util-linux: Enable systemd support
lighttpd: Remove automake patch

Please be sure to build this with the INCOMPATIBLE_LICENSE = "GPLv3" settig, I saw the following issues on the Autobuilder.

Quoted 8 lines
Quoted 6 lines

I've rebuilt systemd without xz dependency and now I can build core-image-minimal with INCOMPATIBLE_LICENSE = "GPLv3", however core-image-sato would not build. Do we want sato to build with GPLv3 incompatibility flag set? I couldn't build sato this way on master either, but I didn't try a clean build so I'm not 100% sure about that.

Sato will not build with non-GPLv3. The other image that can build non-GPLv3 is core-image-basic, it pulls in much more LSB full commands, non-busybox.

I tried to build core-image-basic with incompatible license flag set to GPLv3. It crashes in bash (3.2.48) complaining about undefined reference to `xopen' and 'xread'. I tried to dig a little bit into this but got nowhere. There are no references in code for xopen & xread. I don't understand why the linker is looking for these functions while in the code open & read are called.

Radu

#16 lore raw
Quoted 16 lines · Radu Moisan
Quoted 14 lines · Saul Wold
Quoted 13 lines · Radu Moisan
Quoted 4 lines · Saul Wold

Please be sure to build this with the INCOMPATIBLE_LICENSE = "GPLv3" settig, I saw the following issues on the Autobuilder.

I've rebuilt systemd without xz dependency and now I can build core-image-minimal with INCOMPATIBLE_LICENSE = "GPLv3", however core-image-sato would not build. Do we want sato to build with GPLv3 incompatibility flag set? I couldn't build sato this way on master either, but I didn't try a clean build so I'm not 100% sure about that.

Quoted 4 lines
Quoted 2 lines

Sato will not build with non-GPLv3. The other image that can build non-GPLv3 is core-image-basic, it pulls in much more LSB full commands, non-busybox.

I tried to build core-image-basic with incompatible license flag set to GPLv3. It crashes in bash (3.2.48) complaining about undefined reference to `xopen' and 'xread'. I tried to dig a little bit into this but got nowhere. There are no references in code for xopen & xread. I don't understand why the linker is looking for these functions while in the code open & read are called.

Forgot to mention that this is happening also on master branch.

Radu