Skip to contentSkip to conversation

cpts fixes for v3.8-rc2

PATCH In review Richard Cochran 3 participants 5 messages Dec 24, 2012 – Dec 26, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover cpts fixes for v3.8-rc2

Changed in v2:
Use clk_prepare_enable instead of clk_prepare + clk_enable.

The new cpts driver has two small issues, but it otherwise seems to be working in -rc1.

Thanks,
Richard

Richard Cochran (2):
cpts: fix build error by removing useless code.
cpts: fix a run time warn_on.

 drivers/net/ethernet/ti/cpts.c |    3 +--
 drivers/net/ethernet/ti/cpts.h |    1 -
 2 files changed, 1 insertions(+), 3 deletions(-)
Signature · 1 line
1.7.2.5
#1 lore raw

PATCH v2 1/2 cpts: fix build error by removing useless code.

The cpts driver tries to obtain the input clock frequency by calling the clock's internal 'recalc' method. Since <plat/clock.h> has been removed, this code can no longer compile.

However, the driver never makes use of the frequency value, so this patch fixes the issue by removing the offending code altogether.

---
 drivers/net/ethernet/ti/cpts.c |    1 -
 drivers/net/ethernet/ti/cpts.h |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/ethernet/ti/cpts.c +0 -1
index 5e62c1a..5ab8fb4 100644
@@ -248,7 +248,6 @@ static void cpts_clk_init(struct cpts *cpts)
 		return;
 	}
 	clk_enable(cpts->refclk);
-	cpts->freq = cpts->refclk->recalc(cpts->refclk);
 }
 
 static void cpts_clk_release(struct cpts *cpts)
drivers/net/ethernet/ti/cpts.h +0 -1
index e1bba3a..fe993cd 100644
@@ -120,7 +120,6 @@ struct cpts {
 	struct delayed_work overflow_work;
 	int phc_index;
 	struct clk *refclk;
-	unsigned long freq;
 	struct list_head events;
 	struct list_head pool;
 	struct cpts_event pool_data[CPTS_MAX_EVENTS];
Signature · 1 line
1.7.2.5
#2 lore raw

PATCH v2 2/2 cpts: fix a run time warn_on.

In reply to Richard Cochran

This patch fixes a warning in clk_enable by calling clk_prepare_enable instead.

---
 drivers/net/ethernet/ti/cpts.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ethernet/ti/cpts.c +1 -1
index 5ab8fb4..463597f 100644
@@ -247,7 +247,7 @@ static void cpts_clk_init(struct cpts *cpts)
 		cpts->refclk = NULL;
 		return;
 	}
-	clk_enable(cpts->refclk);
+	clk_prepare_enable(cpts->refclk);
 }
 
 static void cpts_clk_release(struct cpts *cpts)
Signature · 1 line
1.7.2.5
Acked-by on the v2 series
#3 lore raw
In reply to Richard Cochran
Quoted 9 lines · Richard Cochran

Changed in v2:
Use clk_prepare_enable instead of clk_prepare + clk_enable.

The new cpts driver has two small issues, but it otherwise seems to be working in -rc1.

Thanks,
Richard

Quoted 8 lines

Richard Cochran (2):
cpts: fix build error by removing useless code.
cpts: fix a run time warn_on.

  drivers/net/ethernet/ti/cpts.c |    3 +--
  drivers/net/ethernet/ti/cpts.h |    1 -
  2 files changed, 1 insertions(+), 3 deletions(-)

Looks good to me.

maintainer
#4 lore raw
In reply to Richard Cochran

From: Richard Cochran <[email protected]>
Date: Mon, 24 Dec 2012 08:19:08 +0100

Quoted 5 lines

Changed in v2:
Use clk_prepare_enable instead of clk_prepare + clk_enable.

The new cpts driver has two small issues, but it otherwise seems to be working in -rc1.

Both applied, thanks.