Skip to contentSkip to conversation

yocto-bsp: add basic connectivity check

PATCH New [email protected] 1 participant 2 messages Jan 15, 2013

lore
Share & tools
lore

[email protected]

author
#0 lore raw

cover yocto-bsp: add basic connectivity check

From: Tom Zanussi <[email protected]>

This patchset adds a basic connectivity check meant to detect basic connectivity and git configuration issues for yocto-bsp.

The check can be skipped by adding the new -s option to the yocto-bsp create command-line.

The following changes since commit 5ba0919b5bcadba47f59a3b342aaa27048f0ff18:

scripts/lib/bsp/engine.py: add handling for JSON strings (2013-01-11 14:18:17 -0600)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib.git tzanussi/yocto-bsp-git-check
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/yocto-bsp-git-check

Tom Zanussi (1):
yocto-bsp: add basic git connectivity check

 scripts/lib/bsp/tags.py |  2 +-
 scripts/yocto-bsp       | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.11.4
author
#1 lore raw

PATCH 1/1 yocto-bsp: add basic git connectivity check

From: Tom Zanussi <[email protected]>

yocto-bsp create does a 'git ls-remote
git://git.yoctoproject.org/linux-yocto-3.4.git *heads*' to get the set of existing branches from the kernel repo.

If the user isn't connected to the network, or if git isn't configured sanely, yocto-bsp fails with an ugly Python backtrace.

We should try to avoid this by doing a basic sanity check for those things before actually running the command.

The sanity check can be avoided by specifying -s on the yocto-bsp command-line:

 $ yocto-bsp create -s test qemu

Fixes [YOCTO #3279]

Signed-off-by Tom Zanussi <[email protected]>
---
 scripts/lib/bsp/tags.py |  2 +-
 scripts/yocto-bsp       | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)
scripts/lib/bsp/tags.py +1 -1
index 256b25c..6d5feb0 100644
@@ -41,7 +41,7 @@ INPUT_TYPE_PROPERTY = "type"
 
 SRC_URI_FILE = "file://"
 
-
+GIT_CHECK_URI = "git://git.yoctoproject.org/linux-yocto-dev.git"
scripts/yocto-bsp +13 -0
index 126fc8d..d269861 100755
@@ -58,6 +58,8 @@ def yocto_bsp_create_subcommand(args, usage_str):
                       help = "name of file containing the values for BSP properties as a JSON file")
     parser.add_option("-c", "--codedump", dest = "codedump", action = "store_true",
                       default = False, help = "dump the generated code to bspgen.out")
+    parser.add_option("-s", "--skip-git-check", dest = "git_check", action = "store_false",
+                      default = True, help = "skip the git connectivity check")
     (options, args) = parser.parse_args(args)
 
     if len(args) != 2:

@@ -73,6 +75,17 @@ def yocto_bsp_create_subcommand(args, usage_str):
     else:
         bsp_output_dir = "meta-" + machine
 
+    if options.git_check and not options.properties_file:
+        print "Checking basic git connectivity..."
+        if not verify_git_repo(GIT_CHECK_URI):
+            print "Couldn't verify git connectivity, exiting\n"
+            print "Details: couldn't access %s" % GIT_CHECK_URI
+            print "         (this most likely indicates a network connectivity problem or"
+            print "         a misconfigured git intallation)"
+            sys.exit(1)
+        else:
+            print "Done.\n"
+
     yocto_bsp_create(machine, karch, scripts_path, bsp_output_dir, options.codedump, options.properties_file)
Signature · 1 line
1.7.11.4