Skip to contentSkip to conversation

kern-tools: fix custom repository BSP generation

PATCH In review Bruce Ashfield 2 participants 3 messages Apr 15, 2013 – Apr 16, 2013

lore
Share & tools
lore
#0 lore raw

cover kern-tools: fix custom repository BSP generation

Richard,

As was reported on the oe-core mailing list earlier today, custom BSPs (other than the ones generated by the BSP tooling) that relied on generated BSP descriptions started failing.

I did the following one line patch to fix them.

Updating the SCRCREV to pick up the following fix

updateme: use absolute path for generated BSP descriptions

When a custom BSP is used, a top level BSP is generated by the tools and fed to the build system just as a user defined BSP would be located and passed. The location of the generated file is placed in the top_tgt file, which is used by subsequent stages. A relative path was being placed into top_tgt, which binds the build to a particular directory structure and working directory.

The location of parts of the build have changed, and this relative path is no longer accurate. Changing it to an absolute path solve the build issues related to custom BSPs.

There's no risk to existing kernels, or built binary images. The only thing that runs this code is BSP generation routines that are triggered by linux-yocto-custom.

If there's any room in 1.4, this one-line would be a good idea!

Cheers,

Bruce

The following changes since commit 45c8cc1a58e7868f4603be08a86fef178edfc926:

poky.conf: add Poky 1.4 and CentOS 6.4 to SANITY_TESTED_DISTROS (2013-04-15 17:21:28 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib zedd/kernel
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel

Bruce Ashfield (1):
kern-tools: fix custom repository BSP generation

 meta/recipes-kernel/kern-tools/kern-tools-native_git.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 kern-tools: fix custom repository BSP generation

Updating the SCRCREV to pick up the following fix

updateme: use absolute path for generated BSP descriptions

When a custom BSP is used, a top level BSP is generated by the tools and fed to the build system just as a user defined BSP would be located and passed. The location of the generated file is placed in the top_tgt file, which is used by subsequent stages. A relative path was being placed into top_tgt, which binds the build to a particular directory structure and working directory.

The location of parts of the build have changed, and this relative path is no longer accurate. Changing it to an absolute path solve the build issues related to custom BSPs.

---
 meta/recipes-kernel/kern-tools/kern-tools-native_git.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/kern-tools/kern-tools-native_git.bb +1 -1
index acef4b5..be58847 100644
@@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://git/tools/kgit;beginline=5;endline=9;md5=d8d1d729a70c
 
 DEPENDS = "git-native guilt-native"
 
-SRCREV = "7a3170d96e142ce85a958f5b22e45f68f785f58d"
+SRCREV = "71ffb08c20022610363e68f9243350b7da020825"
 PR = "r12"
 PV = "0.1+git${SRCPV}"
 
Signature · 1 line
1.7.10.4
#2 lore raw
In reply to Bruce Ashfield
Quoted 29 lines · Bruce Ashfield

Richard,

As was reported on the oe-core mailing list earlier today, custom BSPs (other than the ones generated by the BSP tooling) that relied on generated BSP descriptions started failing.

I did the following one line patch to fix them.

Updating the SCRCREV to pick up the following fix

updateme: use absolute path for generated BSP descriptions

When a custom BSP is used, a top level BSP is generated by the
tools and fed
to the build system just as a user defined BSP would be located and passed. The location of the generated file is placed in the top_tgt
file,
which is used by subsequent stages. A relative path was being
placed into
top_tgt, which binds the build to a particular directory structure
and
working directory.

The location of parts of the build have changed, and this relative
path is
no longer accurate. Changing it to an absolute path solve the build
issues
related to custom BSPs.

Quoted 6 lines

There's no risk to existing kernels, or built binary images. The only thing that runs this code is BSP generation routines that are triggered by linux-yocto-custom.

If there's any room in 1.4, this one-line would be a good idea!

As Bruce states that there's no risk for existing kernels, I hope that you'll take this one, as linux-yocto-custom currently is broken (at least when using it together with only a defconfig).

Cheers,
Anders

Signature · 4 lines
Anders Darander
EPO guidelines 1978: "If the contribution to the known art resides
solely in a computer program then the subject matter is not
patentable in whatever manner it may be presented in the claims."