replace genext2fs with populate-extfs.sh

The max length of debugfs argument is 256 which is too short, the arguments are two paths, the PATH_MAX is 4096 according to /usr/include/linux/limits.h, use 2048 (4096 / 2) is a reasonable value.

[YOCTO #3848]

Signed-off-by Robert Yang <[email protected]>

---
 .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 ++++++++++++++++++++
 .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    1 +
 2 files changed, 29 insertions(+)
 create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch new file +28 -0

new file mode 100644
index 0000000..db6814d
@@ -0,0 +1,28 @@
+debugfs.c: the max length of debugfs argument is too short
+
+The max length of debugfs argument is 256 which is too short, the
+arguments are two paths, the PATH_MAX is 4096 according to
+/usr/include/linux/limits.h, use 2048 (4096 / 2) is a reasonable value.
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ debugfs/debugfs.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
+--- a/debugfs/debugfs.c
++++ b/debugfs/debugfs.c
+@@ -2282,7 +2282,7 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[])
+ static int source_file(const char *cmd_file, int ss_idx)
+ {
+ 	FILE		*f;
+-	char		buf[256];
++	char		buf[2048];
+ 	char		*cp;
+ 	int		exit_status = 0;
+ 	int		retval;
+-- 
+1.7.11.2
+

meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb +1 -0

index 3a4f5a8..898ee88 100644
@@ -4,6 +4,7 @@ PR = "r0"
 
 SRC_URI += "file://acinclude.m4 \
             file://remove.ldconfig.call.patch \
+            file://debugfs-too-short.patch \
 "
 
 SRC_URI[md5sum] = "a1ec22ef003688dae9f76c74881b22b9"

Let debugfs do sparse copy when src is a sparse file, just like "cp --sparse=auto"

[YOCTO #3848]

Signed-off-by Robert Yang <[email protected]>

---
 .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114 ++++++++++++++++++++
 .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    1 +
 2 files changed, 115 insertions(+)
 create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +11 -0

new file mode 100644
index 0000000..f20fcaf
@@ -0,0 +1,114 @@
+debugfs.c: do sparse copy when src is a sparse file
+
+Let debugfs do sparse copy when src is a sparse file, just like
+"cp --sparse=auto"
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ debugfs/debugfs.c | 54 ++++++++++++++++++++++++++++++++++++++++++++----------
+ 1 file changed, 44 insertions(+), 10 deletions(-)

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +8 -0

++#ifndef IO_BUFSIZE
++#define IO_BUFSIZE 32*1024
++#endif
++
++/* Block size for `st_blocks'. */
++#ifndef S_BLKSIZE
++#define S_BLKSIZE 512
++#endif

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +14 -0

+ {
+ 	ext2_file_t	e2_file;
+ 	errcode_t	retval;
+ 	int		got;
+ 	unsigned int	written;
+-	char		buf[8192];
++	char		buf[bufsiz];
+ 	char		*ptr;
+ 
+ 	retval = ext2fs_file_open(current_fs, newfile,
+@@ -1582,14 +1592,30 @@ static errcode_t copy_file(int fd, ext2_ino_t newfile)
+ 			goto fail;
+ 		}
+ 		ptr = buf;

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +15 -0

++				if (count < 0) {
++					/* The whole block is zero, make a hole */
++					retval = ext2fs_file_lseek(e2_file, got, EXT2_SEEK_CUR, 0);
++					if (retval)
++						goto fail;
++					got = 0;
++				}
++			}
++			/* Normal copy */
++			if (got > 0) {
++				retval = ext2fs_file_write(e2_file, ptr, got, &written);
++				if (retval)
++					goto fail;
++				got -= written;
++				ptr += written;

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +9 -0

++			bufsiz = statbuf.st_blksize;
++		}
++		retval = copy_file(fd, newfile, bufsiz, make_holes);
+ 		if (retval)
+ 			com_err("copy_file", retval, 0);
+ 	}
+-- 
+1.7.11.2
+

meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb +1 -0

index 898ee88..b547036 100644
@@ -5,6 +5,7 @@ PR = "r0"
 SRC_URI += "file://acinclude.m4 \
             file://remove.ldconfig.call.patch \
             file://debugfs-too-short.patch \
+            file://sparse_copy.patch \
 "
 
 SRC_URI[md5sum] = "a1ec22ef003688dae9f76c74881b22b9"

Quoted 33 lines · Robert Yang

Let debugfs do sparse copy when src is a sparse file, just like "cp --sparse=auto"

[YOCTO #3848]

Signed-off-by Robert Yang <[email protected]>

---
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114 ++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    1 +
  2 files changed, 115 insertions(+)

create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +15 -0

new file mode 100644
index 0000000..f20fcaf
@@ -0,0 +1,114 @@
+debugfs.c: do sparse copy when src is a sparse file
+
+Let debugfs do sparse copy when src is a sparse file, just like
+"cp --sparse=auto"
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ debugfs/debugfs.c | 54 ++++++++++++++++++++++++++++++++++++++++++++----------
+ 1 file changed, 44 insertions(+), 10 deletions(-)
+
+diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
+index 5cdc86a..015bfad 100644
+--- a/debugfs/debugfs.c

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch line 21

Quoted 6 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +6 -0

++++ b/debugfs/debugfs.c
+@@ -37,6 +37,16 @@ extern char *optarg;
+ #include "../version.h"
+ #include "jfs_user.h"
+
++/* 32KiB is the minimium blksize to best minimize system call overhead. */

Why is that? Can you defend that to Ted and the ext4 developers?

Quoted 8 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +8 -0

++#ifndef IO_BUFSIZE
++#define IO_BUFSIZE 32*1024
++#endif
++
++/* Block size for `st_blocks'. */
++#ifndef S_BLKSIZE
++#define S_BLKSIZE 512
++#endif

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch line 39

Quoted 10 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +10 -0

++
+ ss_request_table *extra_cmds;
+ const char *debug_prog_name;
+ int sci_idx;
+@@ -1559,13 +1569,13 @@ void do_find_free_inode(int argc, char *argv[])
+ }
+
+ #ifndef READ_ONLY
+-static errcode_t copy_file(int fd, ext2_ino_t newfile)
++static errcode_t copy_file(int fd, ext2_ino_t newfile, int bufsiz, int make_holes)

Don't trim off single vowels in variable names. bufsize is fine.

Quoted 14 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +14 -0

+ {
+ 	ext2_file_t	e2_file;
+ 	errcode_t	retval;
+ 	int		got;
+ 	unsigned int	written;
+-	char		buf[8192];
++	char		buf[bufsiz];
+ 	char		*ptr;
+
+ 	retval = ext2fs_file_open(current_fs, newfile,
+@@ -1582,14 +1592,30 @@ static errcode_t copy_file(int fd, ext2_ino_t newfile)
+ 			goto fail;
+ 		}
+ 		ptr = buf;

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch line 63

Quoted 10 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +10 -0

++		char *cp = ptr;
+ 		while (got > 0) {
+-			retval = ext2fs_file_write(e2_file, ptr,
+-						   got, &written);
+-			if (retval)
+-				goto fail;
+-
+-			got -= written;
+-			ptr += written;
++			int count = got;

Why declare this inside the while loop?

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch line 68

Quoted 5 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +5 -0

++			if (make_holes) {
++				/* Check whether all is zero */
++				while (count-- && *cp++ == 0) {
++					continue;
++				}

Could you improve this a bit by using larger chunks? u32 maybe? You could ensure the bufsize rounds up to that, or just enforce it.

Quoted 16 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +15 -0

++				if (count < 0) {
++					/* The whole block is zero, make a hole */
++					retval = ext2fs_file_lseek(e2_file, got, EXT2_SEEK_CUR, 0);
++					if (retval)
++						goto fail;
++					got = 0;
++				}
++			}
++			/* Normal copy */
++			if (got > 0) {
++				retval = ext2fs_file_write(e2_file, ptr, got, &written);
++				if (retval)
++					goto fail;
++				got -= written;
++				ptr += written;

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch line 93

Quoted 10 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +10 -0

++			}
+ 		}
+ 	}
+ 	retval = ext2fs_file_close(e2_file);
+@@ -1608,6 +1634,8 @@ void do_write(int argc, char *argv[])
+ 	ext2_ino_t	newfile;
+ 	errcode_t	retval;
+ 	struct ext2_inode inode;
++	int make_holes = 0;
++	int bufsiz = IO_BUFSIZE;

bufsize

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch line 105

Quoted 12 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +12 -0

+
+ 	if (common_args_process(argc, argv, 3, 3, "write",
+ 				"<native file> <new file>", CHECK_FS_RW))
+@@ -1672,7 +1700,13 @@ void do_write(int argc, char *argv[])
+ 		return;
+ 	}
+ 	if (LINUX_S_ISREG(inode.i_mode)) {
+-		retval = copy_file(fd, newfile);
++		if (statbuf.st_blocks < statbuf.st_size / S_BLKSIZE) {
++			make_holes = 1;
++			/* Use the I/O blocksize (st_blksize) as the buffer
++			 * size when copy sparse file */

"when copying sparse files"

Also, multiline comments should probably look like this:

/*
* Use I/O blocksize as buffer size when
* copying sparse files.
*/

Although, honestly, this doesn't add any information. It is obvious that is what the code does. It isn't obvious WHY that is necessary, a comment to that effect might be worthwhile, but as is, this one can just be removed.

Thanks,

Darren

Quoted 22 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch new file +9 -0

++			bufsiz = statbuf.st_blksize;
++		}
++		retval = copy_file(fd, newfile, bufsiz, make_holes);
+ 		if (retval)
+ 			com_err("copy_file", retval, 0);
+ 	}
+--
+1.7.11.2
+

meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb +1 -0

index 898ee88..b547036 100644
@@ -5,6 +5,7 @@ PR = "r0"
  SRC_URI += "file://acinclude.m4 \
              file://remove.ldconfig.call.patch \
              file://debugfs-too-short.patch \
+            file://sparse_copy.patch \
  "
 
  SRC_URI[md5sum] = "a1ec22ef003688dae9f76c74881b22b9"

meta/classes/image_types.bbclass +0 -4

-oe_mkext4fs () {
-	genext2fs -b $ROOTFS_SIZE -d ${IMAGE_ROOTFS} ${EXTRA_IMAGECMD} $1
-	tune2fs -O extents,uninit_bg,dir_index,has_journal $1
-	e2fsck -yfDC0 $1 || chk=$?

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)

    a) The image file size is the same as before (529M)
    b) The disk usage is a little different: (du -sh)
              before       now 
       ext2:  364M         388M
       ext3:  381M         404M
       ext4:  380M         387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit 3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

 meta/classes/image_types.bbclass                   |   46 ++++----
 .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
 .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 ++++++++++++++++
 .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114 ++++++++++++++++++++
 .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
 5 files changed, 257 insertions(+), 28 deletions(-)
 create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
 create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
 create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

Have these been reviewed on the ext mailing list already?

--
Darren

Quoted 60 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit 3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   |   46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 ++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114 ++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

Hi Darren,

No, I haven't sent them to the ext mailing list, can we merge them in oe-core and then back port to the ext community ? Or I should send them to the ext mailing list first ?

// Robert

Quoted 67 lines · Darren Hart

Have these been reviewed on the ext mailing list already?

--
Darren

Quoted 60 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit 3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   |   46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 ++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114 ++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

Always discuss them upstream first. If they are accepted upstream, THEN, we can roll them into oe-core if we don't want to bring in everything that landed before them too. But always discuss changes to a project to the project before doing so in oe-core.

Thanks,

Darren

Quoted 77 lines · Robert Yang

Hi Darren,

No, I haven't sent them to the ext mailing list, can we merge them in oe-core and then back port to the ext community ? Or I should send them to the ext mailing list first ?

// Robert

Quoted 67 lines · Darren Hart

Have these been reviewed on the ext mailing list already?

--
Darren

Quoted 60 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit 3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

    grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

   meta/classes/image_types.bbclass                   |   46 ++++----
   .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
   .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 ++++++++++++++++
   .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114 ++++++++++++++++++++
   .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
   5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

Quoted 5 lines · Darren Hart

Always discuss them upstream first. If they are accepted upstream, THEN, we can roll them into oe-core if we don't want to bring in everything that landed before them too. But always discuss changes to a project to the project before doing so in oe-core.

Thanks, got it, I will send the following 2 to ext mailing list if you are fine with them.

[PATCH 1/4] e2fsprogs: the max length of debugfs argument is too short [PATCH 2/4] e2fsprogs: let debugfs do sparse copy

// Robert

Quoted 83 lines

Thanks,

Darren

Quoted 77 lines · Robert Yang

Hi Darren,

No, I haven't sent them to the ext mailing list, can we merge them in oe-core and then back port to the ext community ? Or I should send them to the ext mailing list first ?

// Robert

Quoted 67 lines · Darren Hart

Have these been reviewed on the ext mailing list already?

--
Darren

Quoted 60 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit 3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

    grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

   meta/classes/image_types.bbclass                   |   46 ++++----
   .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
   .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 ++++++++++++++++
   .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114 ++++++++++++++++++++
   .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
   5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

Quoted 12 lines · Robert Yang

Quoted 5 lines · Darren Hart

Always discuss them upstream first. If they are accepted upstream, THEN, we can roll them into oe-core if we don't want to bring in everything that landed before them too. But always discuss changes to a project to the project before doing so in oe-core.

Thanks, got it, I will send the following 2 to ext mailing list if you are fine with them.

Quoted 2 lines

[PATCH 1/4] e2fsprogs: the max length of debugfs argument is too short [PATCH 2/4] e2fsprogs: let debugfs do sparse copy

If you would like my review, I'll have a look at them tomorrow morning and get you some feedback. Too tired to think straight any longer :-)

--
Darren

Quoted 86 lines

// Robert

Quoted 83 lines

Thanks,

Darren

Quoted 77 lines · Robert Yang

Hi Darren,

No, I haven't sent them to the ext mailing list, can we merge them in oe-core and then back port to the ext community ? Or I should send them to the ext mailing list first ?

// Robert

Quoted 67 lines · Darren Hart

Have these been reviewed on the ext mailing list already?

--
Darren

Quoted 60 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit 3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

     grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):

     e2fsprogs: the max length of debugfs argument is too short
     e2fsprogs: let debugfs do sparse copy
     e2fsprogs: add populate-extfs.sh
     image_types.bbclass: replace genext2fs with populate-extfs.sh

    meta/classes/image_types.bbclass                   |   46 ++++----
    .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
    .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 ++++++++++++++++
    .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114 ++++++++++++++++++++
    .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
    5 files changed, 257 insertions(+), 28 deletions(-)
    create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
    create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
    create mode 100644 meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)

    a) The image file size is the same as before (529M)
    b) The disk usage is a little different: (du -sh)
              before       now
       ext2:  364M         388M
       ext3:  381M         404M
       ext4:  380M         387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

 meta/classes/image_types.bbclass                   |   46 ++++----
 .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
 .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 ++++++++++++++++
 .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114
++++++++++++++++++++
 .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
 5 files changed, 257 insertions(+), 28 deletions(-)
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
 create mode 100644

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB    DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 75 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   |   46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 ++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114
++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Hi Jonathan Liu,

What's your configuration, please, I tried a core-image-minimal building just now, didn't notice this error. Did the error come after these patches applied ?

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 261 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB    DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 79 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common
file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs
when it
supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   |   46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 
++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114
++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

Signature · 7 lines

1.7.10.4


_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Quoted 6 lines · Robert Yang

Hi Jonathan Liu,

What's your configuration, please, I tried a core-image-minimal building just now, didn't notice this error. Did the error come after these patches applied ?

Yes, the errors occured after applying your patches.

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11" IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 265 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 257 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB    DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 75 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   |   46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       |   28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   |   93 ++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   |  114
++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb |    4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Regards,
Jonathan

Quoted 7 lines · Jonathan Liu

Quoted 6 lines · Robert Yang

Hi Jonathan Liu,

What's your configuration, please, I tried a core-image-minimal building just now, didn't notice this error. Did the error come after these patches applied ?

Quoted 2 lines

Yes, the errors occured after applying your patches.

Thanks, I will try a build with these configuration tonight, and see the result tomorrow.

// Robert

Quoted 295 lines

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11" IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 269 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 261 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB    DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 79 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the
common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs
when it
supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   | 46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       | 28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   | 93 
++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   | 114
++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

Signature · 7 lines

1.7.10.4


_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Regards,
Jonathan

Quoted 10 lines · Robert Yang

Quoted 7 lines · Jonathan Liu

Quoted 6 lines · Robert Yang

Hi Jonathan Liu,

What's your configuration, please, I tried a core-image-minimal building just now, didn't notice this error. Did the error come after these patches applied ?

Quoted 7 lines

Quoted 2 lines

Yes, the errors occured after applying your patches.

Thanks, I will try a build with these configuration tonight, and see the result tomorrow.

// Robert

I can reproduce the fsck errors using the following:

meta: f7afeeb75993b159bb8959e0309bc5eb3978a8fb

conf/local.conf:
BB_NUMBER_THREADS = "8"
PARALLEL_MAKE = "-j 8"
MACHINE ??= "qemux86"
DISTRO ?= "poky"
PACKAGE_CLASSES = "package_ipk" EXTRA_IMAGE_FEATURES = "debug-tweaks" USER_CLASSES ?= "buildstats image-mklibs image-prelink" PATCHRESOLVE = "noop"

BB_DISKMON_DIRS = "\
     STOPTASKS,${TMPDIR},1G,100K \
     STOPTASKS,${DL_DIR},1G,100K \
     STOPTASKS,${SSTATE_DIR},1G,100K \
     ABORT,${TMPDIR},100M,1K \
     ABORT,${DL_DIR},100M,1K \
     ABORT,${SSTATE_DIR},100M,1K"

CONF_VERSION = "1"
DISTRO_FEATURES_append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
IMAGE_FSTYPES = "ext4"

# bitbake core-image-minimal
# fsck.ext4 -fn tmp/deploy/images/core-image-minimal-qemux86.ext4

Regards,
Jonathan

Quoted 291 lines

Quoted 291 lines

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11" IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 265 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 257 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB    DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 75 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   | 46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       | 28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   | 93 ++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   | 114
++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Regards,
Jonathan

Quoted 17 lines · Jonathan Liu

Quoted 16 lines · Robert Yang

Quoted 9 lines · Jonathan Liu

Quoted 6 lines · Robert Yang

Hi Jonathan Liu,

What's your configuration, please, I tried a core-image-minimal building just now, didn't notice this error. Did the error come after these patches applied ?

Yes, the errors occured after applying your patches.

Thanks, I will try a build with these configuration tonight, and see the result tomorrow.

Quoted 2 lines

Quoted 1 line

// Robert

I can reproduce the fsck errors using the following:

Thanks, I can reproduce it with your setting, will do more investigation on it later.

// Robert

Quoted 331 lines

meta: f7afeeb75993b159bb8959e0309bc5eb3978a8fb

conf/local.conf:
BB_NUMBER_THREADS = "8"
PARALLEL_MAKE = "-j 8"
MACHINE ??= "qemux86"
DISTRO ?= "poky"
PACKAGE_CLASSES = "package_ipk" EXTRA_IMAGE_FEATURES = "debug-tweaks" USER_CLASSES ?= "buildstats image-mklibs image-prelink" PATCHRESOLVE = "noop"

BB_DISKMON_DIRS = "\
     STOPTASKS,${TMPDIR},1G,100K \
     STOPTASKS,${DL_DIR},1G,100K \
     STOPTASKS,${SSTATE_DIR},1G,100K \
     ABORT,${TMPDIR},100M,1K \
     ABORT,${DL_DIR},100M,1K \
     ABORT,${SSTATE_DIR},100M,1K"

CONF_VERSION = "1"
DISTRO_FEATURES_append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
IMAGE_FSTYPES = "ext4"

# bitbake core-image-minimal
# fsck.ext4 -fn tmp/deploy/images/core-image-minimal-qemux86.ext4

Regards,
Jonathan

Quoted 298 lines

Quoted 298 lines

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11" IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 272 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 264 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 82 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the
common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no
impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs
when it
supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to
1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   | 46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       | 28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   | 93 
++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   | 114
++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

Signature · 7 lines

1.7.10.4


_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core 

Regards,
Jonathan

Quoted 20 lines · Robert Yang

Quoted 17 lines · Jonathan Liu

Quoted 16 lines · Robert Yang

Quoted 9 lines · Jonathan Liu

Quoted 6 lines · Robert Yang

Hi Jonathan Liu,

What's your configuration, please, I tried a core-image-minimal building just now, didn't notice this error. Did the error come after these patches applied ?

Yes, the errors occured after applying your patches.

Thanks, I will try a build with these configuration tonight, and see the result tomorrow.

Quoted 7 lines

Quoted 2 lines

Quoted 1 line

// Robert

I can reproduce the fsck errors using the following:

Thanks, I can reproduce it with your setting, will do more investigation on it later.

// Robert

Any updates?

Regards,
Jonathan

Quoted 324 lines

Quoted 324 lines

meta: f7afeeb75993b159bb8959e0309bc5eb3978a8fb

conf/local.conf:
BB_NUMBER_THREADS = "8"
PARALLEL_MAKE = "-j 8"
MACHINE ??= "qemux86"
DISTRO ?= "poky"
PACKAGE_CLASSES = "package_ipk" EXTRA_IMAGE_FEATURES = "debug-tweaks" USER_CLASSES ?= "buildstats image-mklibs image-prelink" PATCHRESOLVE = "noop"

BB_DISKMON_DIRS = "\
     STOPTASKS,${TMPDIR},1G,100K \
     STOPTASKS,${DL_DIR},1G,100K \
     STOPTASKS,${SSTATE_DIR},1G,100K \
     ABORT,${TMPDIR},100M,1K \
     ABORT,${DL_DIR},100M,1K \
     ABORT,${SSTATE_DIR},100M,1K"

CONF_VERSION = "1"
DISTRO_FEATURES_append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
IMAGE_FSTYPES = "ext4"

# bitbake core-image-minimal
# fsck.ext4 -fn tmp/deploy/images/core-image-minimal-qemux86.ext4

Regards,
Jonathan

Quoted 291 lines

Quoted 291 lines

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11" IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 265 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 257 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 75 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   | 46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       | 28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   | 93 ++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   | 114
++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Regards,
Jonathan

Any updates?

Regards,
Jonathan

Quoted 324 lines

Quoted 324 lines

meta: f7afeeb75993b159bb8959e0309bc5eb3978a8fb

conf/local.conf:
BB_NUMBER_THREADS = "8"
PARALLEL_MAKE = "-j 8"
MACHINE ??= "qemux86"
DISTRO ?= "poky"
PACKAGE_CLASSES = "package_ipk" EXTRA_IMAGE_FEATURES = "debug-tweaks" USER_CLASSES ?= "buildstats image-mklibs image-prelink" PATCHRESOLVE = "noop"

BB_DISKMON_DIRS = "\
     STOPTASKS,${TMPDIR},1G,100K \
     STOPTASKS,${DL_DIR},1G,100K \
     STOPTASKS,${SSTATE_DIR},1G,100K \
     ABORT,${TMPDIR},100M,1K \
     ABORT,${DL_DIR},100M,1K \
     ABORT,${SSTATE_DIR},100M,1K"

CONF_VERSION = "1"
DISTRO_FEATURES_append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
IMAGE_FSTYPES = "ext4"

# bitbake core-image-minimal
# fsck.ext4 -fn tmp/deploy/images/core-image-minimal-qemux86.ext4

Regards,
Jonathan

Quoted 291 lines

Quoted 291 lines

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11" IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 265 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 257 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 75 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

  meta/classes/image_types.bbclass                   | 46 ++++----
  .../e2fsprogs-1.42.7/debugfs-too-short.patch       | 28 +++++
  .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh   | 93 ++++++++++++++++
  .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch   | 114
++++++++++++++++++++
  .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 4 +
  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Regards,
Jonathan

Quoted 2 lines · Jonathan Liu

Any updates?

Hi Jonathan,

I've updated the patches, now they are working well, the "fsck -fn" finds no errors any more, but I have to send the patches to the ext4 mailing list firstly, you can try it if you are interested in it atm.:

git://git.pokylinux.org/poky-contrib robert/image
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/image

Robert Yang (5):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: only update the icache for ext2_inode
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

 meta/classes/image_types.bbclass                   |  46 +++---
 .../e2fsprogs-1.42.8/debugfs-too-short.patch       |  28 ++++
 .../e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch    |  69 ++++++++
 .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |  96 +++++++++++
 .../e2fsprogs/e2fsprogs-1.42.8/sparse_copy.patch   | 177 
+++++++++++++++++++++
 .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb |   5 +
 6 files changed, 393 insertions(+), 28 deletions(-)
 create mode 100644 
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/debugfs-too-short.patch
 create mode 100644 
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch
 create mode 100644 
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
 create mode 100644 

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/sparse_copy.patch

// Robert

Quoted 341 lines

Regards,
Jonathan

Quoted 335 lines

Quoted 335 lines

meta: f7afeeb75993b159bb8959e0309bc5eb3978a8fb

conf/local.conf:
BB_NUMBER_THREADS = "8"
PARALLEL_MAKE = "-j 8"
MACHINE ??= "qemux86"
DISTRO ?= "poky"
PACKAGE_CLASSES = "package_ipk" EXTRA_IMAGE_FEATURES = "debug-tweaks" USER_CLASSES ?= "buildstats image-mklibs image-prelink" PATCHRESOLVE = "noop"

BB_DISKMON_DIRS = "\
     STOPTASKS,${TMPDIR},1G,100K \
     STOPTASKS,${DL_DIR},1G,100K \
     STOPTASKS,${SSTATE_DIR},1G,100K \
     ABORT,${TMPDIR},100M,1K \
     ABORT,${DL_DIR},100M,1K \
     ABORT,${SSTATE_DIR},100M,1K"

CONF_VERSION = "1"
DISTRO_FEATURES_append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
IMAGE_FSTYPES = "ext4"

# bitbake core-image-minimal
# fsck.ext4 -fn tmp/deploy/images/core-image-minimal-qemux86.ext4

Regards,
Jonathan

Quoted 302 lines

Quoted 302 lines

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11" IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 276 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 268 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0, max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 86 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the
common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no
impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the
mke2fs when it
supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3
to 1.4.

I have done some simple runtime testing on core-image-sato
and
core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 

+0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

meta/classes/image_types.bbclass | 46 ++++---- .../e2fsprogs-1.42.7/debugfs-too-short.patch | 28 +++++ .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh | 93
++++++++++++++++
.../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch | 114
++++++++++++++++++++
.../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 4 +

  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

Signature · 7 lines

1.7.10.4


_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core 

Regards,
Jonathan

Quoted 38 lines · Robert Yang

Quoted 2 lines · Jonathan Liu

Any updates?

Hi Jonathan,

I've updated the patches, now they are working well, the "fsck -fn" finds no errors any more, but I have to send the patches to the ext4 mailing list firstly, you can try it if you are interested in it atm.:

git://git.pokylinux.org/poky-contrib robert/image
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/image

Robert Yang (5):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: only update the icache for ext2_inode
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

 meta/classes/image_types.bbclass                   |  46 +++---
 .../e2fsprogs-1.42.8/debugfs-too-short.patch       |  28 ++++
 .../e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch    |  69 ++++++++
 .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |  96 +++++++++++
 .../e2fsprogs/e2fsprogs-1.42.8/sparse_copy.patch   | 177 +++++++++++++++++++++
 .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb |   5 +
 6 files changed, 393 insertions(+), 28 deletions(-)
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/debugfs-too-short.patch
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
 create mode 100644

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/sparse_copy.patch

Quoted 1 line

// Robert

Thanks, I will test it tomorrow. "yes | mkfs.$fstype" could probably be replaced with "mkfs.$fstype -F".

Regards,
Jonathan

Quoted 360 lines

Quoted 360 lines

Regards,
Jonathan

Quoted 354 lines

Quoted 354 lines

meta: f7afeeb75993b159bb8959e0309bc5eb3978a8fb

conf/local.conf:
BB_NUMBER_THREADS = "8"
PARALLEL_MAKE = "-j 8"
MACHINE ??= "qemux86"
DISTRO ?= "poky"
PACKAGE_CLASSES = "package_ipk" EXTRA_IMAGE_FEATURES = "debug-tweaks" USER_CLASSES ?= "buildstats image-mklibs image-prelink" PATCHRESOLVE = "noop"

BB_DISKMON_DIRS = "\
     STOPTASKS,${TMPDIR},1G,100K \
     STOPTASKS,${DL_DIR},1G,100K \
     STOPTASKS,${SSTATE_DIR},1G,100K \
     ABORT,${TMPDIR},100M,1K \
     ABORT,${DL_DIR},100M,1K \
     ABORT,${SSTATE_DIR},100M,1K"

CONF_VERSION = "1"
DISTRO_FEATURES_append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
IMAGE_FSTYPES = "ext4"

# bitbake core-image-minimal
# fsck.ext4 -fn tmp/deploy/images/core-image-minimal-qemux86.ext4

Regards,
Jonathan

Quoted 321 lines

Quoted 321 lines

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11" IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 295 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 287 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3). Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5% non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-machine: bad header/extent: invalid magic - magic 0, entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0,
max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883: comm
systemd-journal: bad header/extent: invalid magic - magic 0, entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
login: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810: comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max 0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB DESCRIPTION
machineid.service        loaded failed failed Machine ID first boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too. To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 75 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs when it supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to 1.4.

I have done some simple runtime testing on core-image-sato and core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

meta/classes/image_types.bbclass | 46 ++++---- .../e2fsprogs-1.42.7/debugfs-too-short.patch | 28 +++++ .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh | 93 ++++++++++++++++ .../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch | 114
++++++++++++++++++++
.../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 4 +

  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Regards,
Jonathan

Hi Jonathan,

I've updated it a little, please make sure that you get the newest patches, I've payed most of the time on e2fsprogs itself atm, so I didn't do enough testing of the image (I will do it sooner) thank you very much for focusing on this.

// Robert

Quoted 493 lines · Jonathan Liu

Quoted 40 lines · Robert Yang

Quoted 3 lines · Jonathan Liu

Any updates?

Hi Jonathan,

I've updated the patches, now they are working well, the "fsck -fn" finds no errors any more, but I have to send the patches to the ext4 mailing list
firstly, you can try it if you are interested in it atm.:

git://git.pokylinux.org/poky-contrib robert/image
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/image

Robert Yang (5):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: only update the icache for ext2_inode
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

 meta/classes/image_types.bbclass                   |  46 +++---
 .../e2fsprogs-1.42.8/debugfs-too-short.patch       |  28 ++++
 .../e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch    |  69 ++++++++
 .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |  96 +++++++++++
 .../e2fsprogs/e2fsprogs-1.42.8/sparse_copy.patch   | 177
+++++++++++++++++++++
 .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb |   5 +
 6 files changed, 393 insertions(+), 28 deletions(-)
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/debugfs-too-short.patch
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
 create mode 100644

Quoted 3 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/sparse_copy.patch

// Robert

Thanks, I will test it tomorrow. "yes | mkfs.$fstype" could probably be replaced
with "mkfs.$fstype -F".

Regards,
Jonathan

Quoted 438 lines

Quoted 438 lines

Regards,
Jonathan

Quoted 431 lines

Quoted 431 lines

meta: f7afeeb75993b159bb8959e0309bc5eb3978a8fb

conf/local.conf:
BB_NUMBER_THREADS = "8"
PARALLEL_MAKE = "-j 8"
MACHINE ??= "qemux86"
DISTRO ?= "poky"
PACKAGE_CLASSES = "package_ipk" EXTRA_IMAGE_FEATURES = "debug-tweaks" USER_CLASSES ?= "buildstats image-mklibs image-prelink" PATCHRESOLVE = "noop"

BB_DISKMON_DIRS = "\
     STOPTASKS,${TMPDIR},1G,100K \
     STOPTASKS,${DL_DIR},1G,100K \
     STOPTASKS,${SSTATE_DIR},1G,100K \
     ABORT,${TMPDIR},100M,1K \
     ABORT,${DL_DIR},100M,1K \
     ABORT,${SSTATE_DIR},100M,1K"

CONF_VERSION = "1"
DISTRO_FEATURES_append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
IMAGE_FSTYPES = "ext4"

# bitbake core-image-minimal
# fsck.ext4 -fn tmp/deploy/images/core-image-minimal-qemux86.ext4

Regards,
Jonathan

Quoted 397 lines

Quoted 397 lines

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11"
IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 369 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 361 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4,
should be
3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should
be 3).
Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5%
non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts:
(null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd: bad header/extent: invalid magic - magic 0, entries 0,
max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd: bad header/extent: invalid magic - magic 0, entries 0,
max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd: bad header/extent: invalid magic - magic 0, entries 0,
max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-machine: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-machine: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810:
comm
login: bad header/extent: invalid magic - magic 0, entries 0, max
0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810:
comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max
0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB DESCRIPTION
machineid.service        loaded failed failed Machine ID first
boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on
unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too.
To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 86 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the
common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no
impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs
when it
supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to
1.4.

I have done some simple runtime testing on core-image-sato
and
core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05

+0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

meta/classes/image_types.bbclass | 46 ++++---- .../e2fsprogs-1.42.7/debugfs-too-short.patch | 28 +++++ .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh | 93
++++++++++++++++
.../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch | 114
++++++++++++++++++++
.../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 4 +

  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
create mode 100644

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]

http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Regards,
Jonathan

Hi Robert,

I tested your patches with my ext4 image on Intel Atom D2500HN board and it is working well.
Previously I have been using custom image class which requires root privileges as I need to be able to specify custom options to mkfs.ext4 which are not available with genext2fs and cannot be set with tune2fs afterwards. Using your patches I just put the extra options in EXTRA_IMAGECMD with ext4 image class and I no longer need root privileges for building image. =)

Thanks for your efforts.

Regards,
Jonathan

Quoted 506 lines · Robert Yang

Hi Jonathan,

I've updated it a little, please make sure that you get the newest patches, I've payed most of the time on e2fsprogs itself atm, so I didn't do enough testing of the image (I will do it sooner) thank you very much for focusing on this.

// Robert

Quoted 493 lines · Jonathan Liu

Quoted 40 lines · Robert Yang

Quoted 3 lines · Jonathan Liu

Any updates?

Hi Jonathan,

I've updated the patches, now they are working well, the "fsck -fn" finds no errors any more, but I have to send the patches to the ext4 mailing list
firstly, you can try it if you are interested in it atm.:

git://git.pokylinux.org/poky-contrib robert/image
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/image

Robert Yang (5):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: only update the icache for ext2_inode
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

 meta/classes/image_types.bbclass                   |  46 +++---
 .../e2fsprogs-1.42.8/debugfs-too-short.patch       |  28 ++++
 .../e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch    |  69 ++++++++
 .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |  96 +++++++++++
 .../e2fsprogs/e2fsprogs-1.42.8/sparse_copy.patch   | 177
+++++++++++++++++++++
 .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb |   5 +
 6 files changed, 393 insertions(+), 28 deletions(-)
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/debugfs-too-short.patch
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/fix-icache.patch
 create mode 100644
meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
 create mode 100644

Quoted 3 lines

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/sparse_copy.patch

// Robert

Thanks, I will test it tomorrow. "yes | mkfs.$fstype" could probably be replaced
with "mkfs.$fstype -F".

Regards,
Jonathan

Quoted 438 lines

Quoted 438 lines

Regards,
Jonathan

Quoted 431 lines

Quoted 431 lines

meta: f7afeeb75993b159bb8959e0309bc5eb3978a8fb

conf/local.conf:
BB_NUMBER_THREADS = "8"
PARALLEL_MAKE = "-j 8"
MACHINE ??= "qemux86"
DISTRO ?= "poky"
PACKAGE_CLASSES = "package_ipk" EXTRA_IMAGE_FEATURES = "debug-tweaks" USER_CLASSES ?= "buildstats image-mklibs image-prelink" PATCHRESOLVE = "noop"

BB_DISKMON_DIRS = "\
     STOPTASKS,${TMPDIR},1G,100K \
     STOPTASKS,${DL_DIR},1G,100K \
     STOPTASKS,${SSTATE_DIR},1G,100K \
     ABORT,${TMPDIR},100M,1K \
     ABORT,${DL_DIR},100M,1K \
     ABORT,${SSTATE_DIR},100M,1K"

CONF_VERSION = "1"
DISTRO_FEATURES_append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
IMAGE_FSTYPES = "ext4"

# bitbake core-image-minimal
# fsck.ext4 -fn tmp/deploy/images/core-image-minimal-qemux86.ext4

Regards,
Jonathan

Quoted 397 lines

Quoted 397 lines

distro conf:
DISTRO_FEATURES_append = " largefile opengl systemd" DISTRO_FEATURES_BACKFILL_CONSIDERED = "sysvinit" VIRTUAL-RUNTIME_graphical_init_manager = "" VIRTUAL-RUNTIME_init_manager = "systemd" PACKAGE_CLASSES = "package_ipk"

image bb:
SYSLINUX_ROOT ?= "root=/dev/sda2"
SYSLINUX_PROMPT = "0"
SYSLINUX_TIMEOUT = "1"
SYSLINUX_LABELS = "boot"
LABELS_append = " ${SYSLINUX_LABELS} " do_bootdirectdisk[depends] += "${PN}:do_rootfs"
APPEND += "rootfstype=ext4 rw"
ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_BASENAME}-${MACHINE}.ext4" inherit boot-directdisk
IMAGE_FEATURES += "hwcodecs package-management ssh-server-openssh x11"
IMAGE_FSTYPES = "ext4"
IMAGE_LINGUAS = ""

Quoted 369 lines

My configuration:
MACHINE = "qemux86"
IMAGE_FSTYPES += "ext4"

// Robert

Quoted 361 lines · Jonathan Liu

Hi Robert,

I get the following errors doing filesystem check on the ext4 image:

# fsck.ext4 -fn tmp/deploy/images/custom-image-custom.ext4.ext4
e2fsck 1.42.7 (21-Jan-2013)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Entry 'mtd7' in /dev (2739) has an incorrect filetype (was 4,
should be
3).
Fix? no

Entry 'mtd4' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'fb0' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd5' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'tty6' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'random' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mtd1' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'urandom' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'zero' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'null' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'kmsg' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'kmem' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mtd6' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty7' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty4' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'apm_bios' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty5' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mtd0' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty0' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'ttySA0' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mem' in /dev (2739) has an incorrect filetype (was 4, should be 3).
Fix? no

Entry 'mtd2' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty8' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'console' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'ttyS0' in /dev (2739) has an incorrect filetype (was 4, should
be 3).
Fix? no

Entry 'tty2' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'mtd3' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty1' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Entry 'tty3' in /dev (2739) has an incorrect filetype (was 4, should be
3).
Fix? no

Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Inode 774 ref count is 9, should be 10. Fix? no

Pass 5: Checking group summary information

tmp/deploy/images/custom-image-custom.ext4.ext4: ********** WARNING:
Filesystem still has errors **********

tmp/deploy/images/custom-image-custom.ext4.ext4: 3899/21336 files (0.5%
non-contiguous), 131042/169656 blocks

After booting the image I get the following:

# dmesg | grep EXT4-fs
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts:
(null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd: bad header/extent: invalid magic - magic 0, entries 0,
max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd: bad header/extent: invalid magic - magic 0, entries 0,
max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd: bad header/extent: invalid magic - magic 0, entries 0,
max 0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-machine: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-machine: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs (sda2): re-mounted. Opts: (null)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #883:
comm
systemd-journal: bad header/extent: invalid magic - magic 0,
entries 0,
max
0(0), depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810:
comm
login: bad header/extent: invalid magic - magic 0, entries 0, max
0(0),
depth 0(0)
EXT4-fs error (device sda2): ext4_ext_check_inode:467: inode #810:
comm
sshd: bad header/extent: invalid magic - magic 0, entries 0, max
0(0),
depth 0(0)

# systemctl --failed | cat
UNIT                     LOAD   ACTIVE SUB DESCRIPTION
machineid.service        loaded failed failed Machine ID first
boot
configure
systemd-journald.service loaded failed failed Journal Service
systemd-journald.socket  loaded failed failed Journal Socket

LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on
unit type.

3 loaded units listed. Pass --all to see loaded but inactive units, too.
To show all installed unit files use 'systemctl list-unit-files'.

I am booting kernel with rootfstype=ext4. IMAGE_FSTYPES = "ext4".

Regards,
Jonathan

Quoted 86 lines · Robert Yang

* The benefits:
- Really support ext4
- Support the sparse file (the sparse file became into the
common file
before)
- Have a uniform code for ext2/3/4 generation
- Remove the depends on genext2fs-native

* Impact
- Build time:
a) If we build fresh core-image-sato, there is nearly no
impact.
b) If we do the image generation, which means:
$ bitbake core-image-sato
$ bitbake core-image-sato -ccleansstate
$ bitbake core-image-sato
About 50 extra seconds are needed, here is my test result:
Before the patches: 4m25s
After the patches: 5m17s
This is because the genext2fs is much faster than the populate-extfs.sh, we will replace this script by the mke2fs
when it
supports create the filesystem from a initial directory.

- Disk space (take core-image-sato as an example)
a) The image file size is the same as before (529M)
b) The disk usage is a little different: (du -sh)
before now
ext2: 364M 388M
ext3: 381M 404M
ext4: 380M 387M

We may need to adjust the IMAGE_OVERHEAD_FACTOR from 1.3 to
1.4.

I have done some simple runtime testing on core-image-sato
and
core-image-minimal, they worked well.

// Robert

The following changes since commit
3472c1f7ab409cd91c1d4782d9e00880b84e3ae8:

   grub-efi-native: Cleanup whitespace (2013-05-03 16:37:05

+0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib robert/ext4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/ext4

Robert Yang (4):
e2fsprogs: the max length of debugfs argument is too short
e2fsprogs: let debugfs do sparse copy
e2fsprogs: add populate-extfs.sh image_types.bbclass: replace genext2fs with populate-extfs.sh

meta/classes/image_types.bbclass | 46 ++++---- .../e2fsprogs-1.42.7/debugfs-too-short.patch | 28 +++++ .../e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh | 93
++++++++++++++++
.../e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch | 114
++++++++++++++++++++
.../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 4 +

  5 files changed, 257 insertions(+), 28 deletions(-)

create mode 100644

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch
create mode 100644

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/populate-extfs.sh
create mode 100644

meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/sparse_copy.patch

--
1.7.10.4

_______________________________________________
Openembedded-core mailing list
[email protected]

http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Regards,
Jonathan