Skip to contentSkip to conversation

copyleft_compliance fixes

PATCH In review Christopher Larson 2 participants 4 messages Jun 10, 2013

lore
Share & tools
lore
#0 lore raw

cover copyleft_compliance fixes

From: Christopher Larson <[email protected]>

The following changes since commit b4f208f418d18f2a4e78a56bebacef481061d917:

tar: don't mv tar for nativesdk (2013-06-10 18:06:33 +0100)

are available in the git repository at:

https://github.com/kergoth/oe-core.git copyleft-compliance-fixes
https://github.com//tree/copyleft-compliance-fixes

Christopher Larson (2):
copyleft_compliance: handle localpaths ending with '/'
copyleft_compliance: set 'dirs' flag on task

 meta/classes/copyleft_compliance.bbclass | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
1.8.3
#1 lore raw

PATCH 1/2 copyleft_compliance: handle localpaths ending with '/'

From: Christopher Larson <[email protected]>

---
 meta/classes/copyleft_compliance.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes/copyleft_compliance.bbclass +2 -0
index 06b0227..adb48be 100644
@@ -39,6 +39,8 @@ python do_prepare_copyleft_sources () {
         local = os.path.normpath(fetch.localpath(u.url))
         if local.endswith('.bb'):
             continue
+        elif local.endswith('/'):
+            local = local[:-1]
 
         if u.mirrortarball:
             tarball_path = os.path.join(dl_dir, u.mirrortarball)
Signature · 1 line
1.8.3
#2 lore raw

PATCH 2/2 copyleft_compliance: set 'dirs' flag on task

In reply to Christopher Larson

From: Christopher Larson <[email protected]>

Without this, due to bitbake defaulting to ${B}, it's possible to get ${S} inadvertantly created before do_unpack, breaking the unpack of git sources, which expect the destination to not exist.

---
 meta/classes/copyleft_compliance.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/copyleft_compliance.bbclass +1 -0
index adb48be..6b30b87 100644
@@ -63,4 +63,5 @@ python do_prepare_copyleft_sources () {
 }
 
 addtask prepare_copyleft_sources after do_fetch before do_build
+do_prepare_copyleft_sources[dirs] = "${WORKDIR}"
 do_build[recrdeptask] += 'do_prepare_copyleft_sources'
Signature · 1 line
1.8.3
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] copyleft_compliance: set 'dirs' flag on task

Quoted 8 lines · Christopher Larson

From: Christopher Larson <[email protected]>

Without this, due to bitbake defaulting to ${B}, it's possible to get ${S} inadvertantly created before do_unpack, breaking the unpack of git sources, which expect the destination to not exist.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750