plugin/sdk.ide: Pre-populate project specific profile form
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 plugin/sdk.ide: Pre-populate project specific profile form
From: Timo Mueller <[email protected]>
On initial setup the profile form is populated with the values from the previously selected target profile. This allows the user to quickly make project specific adaptions of an existing profile.
If a project specific profile is already defined the form will show the values from this configuration.
--- .../sdk/ide/preferences/YoctoSDKProjectPropertyPage.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/YoctoSDKProjectPropertyPage.java +12 -2
@@ -31,14 +31,15 @@ import org.osgi.service.prefs.BackingStoreException; import org.yocto.sdk.ide.YoctoProfileElement; import org.yocto.sdk.ide.YoctoProfileSetting; import org.yocto.sdk.ide.YoctoProjectSpecificSetting; +import org.yocto.sdk.ide.YoctoSDKChecker; import org.yocto.sdk.ide.YoctoSDKChecker.SDKCheckRequestFrom; import org.yocto.sdk.ide.YoctoSDKChecker.SDKCheckResults; import org.yocto.sdk.ide.YoctoSDKMessages; -import org.yocto.sdk.ide.utils.YoctoSDKUtils; -import org.yocto.sdk.ide.utils.YoctoSDKUtilsConstants; import org.yocto.sdk.ide.YoctoSDKPlugin; import org.yocto.sdk.ide.YoctoUIElement; import org.yocto.sdk.ide.YoctoUISetting; +import org.yocto.sdk.ide.utils.YoctoSDKUtils; +import org.yocto.sdk.ide.utils.YoctoSDKUtilsConstants; public class YoctoSDKProjectPropertyPage extends PropertyPage implements IWorkbenchPropertyPage {
@@ -288,6 +289,15 @@ public class YoctoSDKProjectPropertyPage extends PropertyPage implements public void switchToProjectSpecificProfile() { YoctoUIElement profileElement = getElemFromProjectPreferences(getProject()); + SDKCheckResults result = YoctoSDKChecker.checkYoctoSDK(profileElement); + + if ((result != SDKCheckResults.SDK_PASS)) { + /* Project specific profile has not yet been defined, + * leave settings from previously selected profile + */ + return; + } + yoctoUISetting.setCurrentInput(profileElement); }
Signature · 1 line
1.8.1.4
Hi Timo,
How am I supposed to apply this patch? I tried to apply it against master first, then the patch2 of your v3 patch series won't apply. If I apply your v3 patch series first, then this patch won't apply after that...
Thanks,
Jessica
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Timo Mueller
Sent: Tuesday, June 25, 2013 8:33 AM
To: [email protected]
Cc: Timo Mueller
Subject: [yocto] [PATCH][eclipse-poky] plugin/sdk.ide: Pre-populate project specific profile form
From: Timo Mueller <[email protected]>
On initial setup the profile form is populated with the values from the previously selected target profile. This allows the user to quickly make project specific adaptions of an existing profile.
If a project specific profile is already defined the form will show the values from this configuration.
--- .../sdk/ide/preferences/YoctoSDKProjectPropertyPage.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/YoctoS renamed from plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/YoctoSDKProjectPropertyPage.java +0 -0
+++ DKProjectPropertyPage.java
@@ -31,14 +31,15 @@ import org.osgi.service.prefs.BackingStoreException;
import org.yocto.sdk.ide.YoctoProfileElement;
import org.yocto.sdk.ide.YoctoProfileSetting;
import org.yocto.sdk.ide.YoctoProjectSpecificSetting;
+import org.yocto.sdk.ide.YoctoSDKChecker;
import org.yocto.sdk.ide.YoctoSDKChecker.SDKCheckRequestFrom;
import org.yocto.sdk.ide.YoctoSDKChecker.SDKCheckResults;
import org.yocto.sdk.ide.YoctoSDKMessages;
-import org.yocto.sdk.ide.utils.YoctoSDKUtils;
-import org.yocto.sdk.ide.utils.YoctoSDKUtilsConstants;
import org.yocto.sdk.ide.YoctoSDKPlugin; import org.yocto.sdk.ide.YoctoUIElement; import org.yocto.sdk.ide.YoctoUISetting;
+import org.yocto.sdk.ide.utils.YoctoSDKUtils;
+import org.yocto.sdk.ide.utils.YoctoSDKUtilsConstants;
public class YoctoSDKProjectPropertyPage extends PropertyPage implements
IWorkbenchPropertyPage {
@@ -288,6 +289,15 @@ public class YoctoSDKProjectPropertyPage extends PropertyPage implements
public void switchToProjectSpecificProfile()
{
YoctoUIElement profileElement = getElemFromProjectPreferences(getProject());+ SDKCheckResults result =
+YoctoSDKChecker.checkYoctoSDK(profileElement);
+
+ if ((result != SDKCheckResults.SDK_PASS)) {
+ /* Project specific profile has not yet been defined,
+ * leave settings from previously selected profile
+ */
+ return;
+ }
+
yoctoUISetting.setCurrentInput(profileElement);
}--
1.8.1.4
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
Hi Jessica,
Zhang, Jessica wrote, On 25.06.2013 23:52:
Quoted 3 lines
Hi Timo,
How am I supposed to apply this patch? I tried to apply it against
master first, then the patch2 of your v3 patch series won't apply. If I apply your v3 patch series first, then this patch won't apply after that...
I've messed up with the prefix, that's why it didn't apply. Sorry about that. I'll resend the patch that will apply to the master.
Quoted 63 lines
Thanks,
Jessica-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Timo Mueller
Sent: Tuesday, June 25, 2013 8:33 AM
To: [email protected]
Cc: Timo Mueller
Subject: [yocto] [PATCH][eclipse-poky] plugin/sdk.ide: Pre-populate project specific profile formFrom: Timo Mueller <[email protected]>
On initial setup the profile form is populated with the values from the previously selected target profile. This allows the user to quickly make project specific adaptions of an existing profile.
If a project specific profile is already defined the form will show the values from this configuration.
Signed-off-by Timo Mueller <[email protected]>--- .../sdk/ide/preferences/YoctoSDKProjectPropertyPage.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/YoctoS renamed from plugins/org.yocto.sdk.ide/src/org/yocto/sdk/ide/preferences/YoctoSDKProjectPropertyPage.java +14
-3+++ DKProjectPropertyPage.java@@ -31,14 +31,15 @@ import org.osgi.service.prefs.BackingStoreException; import org.yocto.sdk.ide.YoctoProfileElement; import org.yocto.sdk.ide.YoctoProfileSetting; import org.yocto.sdk.ide.YoctoProjectSpecificSetting; +import org.yocto.sdk.ide.YoctoSDKChecker; import org.yocto.sdk.ide.YoctoSDKChecker.SDKCheckRequestFrom; import org.yocto.sdk.ide.YoctoSDKChecker.SDKCheckResults; import org.yocto.sdk.ide.YoctoSDKMessages; -import org.yocto.sdk.ide.utils.YoctoSDKUtils; -import org.yocto.sdk.ide.utils.YoctoSDKUtilsConstants; import org.yocto.sdk.ide.YoctoSDKPlugin; import org.yocto.sdk.ide.YoctoUIElement; import org.yocto.sdk.ide.YoctoUISetting; +import org.yocto.sdk.ide.utils.YoctoSDKUtils; +import org.yocto.sdk.ide.utils.YoctoSDKUtilsConstants; public class YoctoSDKProjectPropertyPage extends PropertyPage implements IWorkbenchPropertyPage {@@ -288,6 +289,15 @@ public class YoctoSDKProjectPropertyPage extends PropertyPage implements public void switchToProjectSpecificProfile() { YoctoUIElement profileElement = getElemFromProjectPreferences(getProject()); + SDKCheckResults result = +YoctoSDKChecker.checkYoctoSDK(profileElement); + + if ((result != SDKCheckResults.SDK_PASS)) { + /* Project specific profile has not yet been defined, + * leave settings from previously selected profile + */ + return; + } + yoctoUISetting.setCurrentInput(profileElement); } --1.8.1.4
Quoted 5 lines
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
If this is merged, the "Add target profile quick switch" patch series has to be adapted slightly. I'll send a rework of the series in that case.
Best regards,
Timo