Skip to contentSkip to conversation

base-files: media directory cleanup

PATCH In review [email protected] 2 participants 3 messages Jun 28, 2013

lore
Share & tools
lore
#0 lore raw

cover base-files: media directory cleanup

From: Chen Qi <[email protected]>

The following changes since commit 10e44f162c8ac71965faaeb70b8bfdeb264ba76c:

bitbake: bitbake: python funcname can not include special character @ (2013-06-27 10:06:09 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib ChenQi/media-dir-cleanup
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/media-dir-cleanup

Chen Qi (1):
base-files: remove the unnecessary /media/xxx directories

 meta/recipes-core/base-files/base-files/fstab     |    1 -
 meta/recipes-core/base-files/base-files_3.0.14.bb |    7 +------
 2 files changed, 1 insertion(+), 7 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 base-files: remove the unnecessary /media/xxx directories

From: Chen Qi <[email protected]>

A few directories under /media were created by default, /media/card, /media/ram, /media/realroot, etc.

These directories actually have no real usage now, thus removing them.

The /media/ram entry in the fstab is also removed, as mounting a tmpfs over /media/ram in our system brings no benefit.

Note that a duplicate '/mnt' entry in dirs755 are also removed.

[Yocto #4774]

---
 meta/recipes-core/base-files/base-files/fstab     |    1 -
 meta/recipes-core/base-files/base-files_3.0.14.bb |    7 +------
 2 files changed, 1 insertion(+), 7 deletions(-)
meta/recipes-core/base-files/base-files/fstab +0 -1
index dd613a1..e625ebc 100644
@@ -6,7 +6,6 @@ devpts               /dev/pts             devpts     mode=0620,gid=5       0  0
 usbdevfs             /proc/bus/usb        usbdevfs   noauto                0  0
 tmpfs                /run                 tmpfs      mode=0755,nodev,nosuid,strictatime 0  0
 tmpfs                /var/volatile        tmpfs      defaults              0  0
-tmpfs                /media/ram           tmpfs      defaults              0  0
 
 # uncomment this if your device has a SD/MMC/Transflash slot
 #/dev/mmcblk0p1       /media/card          auto       defaults,sync,noauto  0  0
meta/recipes-core/base-files/base-files_3.0.14.bb +1 -6
index 88d1ac9..054fefa 100644
@@ -43,9 +43,7 @@ dirs755 = "/bin /boot /dev ${sysconfdir} ${sysconfdir}/default \
            /sys ${localstatedir}/lib/misc ${localstatedir}/spool \
            ${localstatedir}/volatile \
            ${localstatedir}/volatile/log \
-           /mnt /media /media/card /media/cf /media/net /media/ram \
-           /media/union /media/realroot /media/hdd \
-           /media/mmc1"
+           /media"
 dirs3755 = "/srv  \
             ${prefix}/local ${prefix}/local/bin ${prefix}/local/games \
             ${prefix}/local/include ${prefix}/local/lib ${prefix}/local/sbin \
@@ -79,9 +77,6 @@ do_install () {
 	for d in ${volatiles}; do
 		ln -sf volatile/$d ${D}${localstatedir}/$d
 	done
-	for d in card cf net ram; do
-		ln -sf /media/$d ${D}/mnt/$d
-	done
 	ln -snf ../run ${D}${localstatedir}/run
 	ln -snf ../run/lock ${D}${localstatedir}/lock
 
Signature · 1 line
1.7.9.5
#2 lore raw

Re: [PATCH 1/1] base-files: remove the unnecessary /media/xxx directories

Quoted 7 lines · On Fri, 2013-06-28 at 15:48 +0800, [email protected] wrote:

From: Chen Qi <[email protected]>

A few directories under /media were created by default, /media/card, /media/ram, /media/realroot, etc.

These directories actually have no real usage now, thus removing them.

Quoted 8 lines

The /media/ram entry in the fstab is also removed, as mounting a tmpfs over /media/ram in our system brings no benefit.

Note that a duplicate '/mnt' entry in dirs755 are also removed.

[Yocto #4774]

Just to be clear, most of these date around 10 years from OpenZaurus and similar times. We now automount media and there is no real need for these specific directories or the ramfs. If there is some need in legacy systems (I did wonder about opie), I'd suggest they get created by them rather than the core base-files.

Cheers,

Richard