Poky QA warning/error config fixes
PATCH 1/2 poky.conf: remove la2 check which no longer exists from ERROR_QA
In reply to Paul EggletonThis check was actually removed a very long time ago in 6656381714c5956f71ca634f5a5f4aa4661bbf7e, before we even changed the QA checks to use names instead of numbers - the name was probably added ERROR_QA mistakenly because it hadn't also been removed from the comment listing the QA checks or the function that determined which ones were errors.
--- meta-yocto/conf/distro/poky.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto/conf/distro/poky.conf +1 -1
@@ -101,6 +101,6 @@ INHERIT += "poky-sanity" #WARN_QA = "unsafe-references-in-binaries unsafe-references-in-scripts" WARN_QA = "textrel pkgvarcheck" -ERROR_QA = "dev-so debug-deps dev-deps debug-files arch la2 pkgconfig la perms useless-rpaths rpaths staticdev ldflags" +ERROR_QA = "dev-so debug-deps dev-deps debug-files arch pkgconfig la perms useless-rpaths rpaths staticdev ldflags" include conf/distro/include/seperatebuilddir.inc
Signature · 1 line
1.8.1.2
cover Poky QA warning/error config fixes
The following changes since commit 67f76e6fc2d8476bdaaf500432198670b883138a:
python-multiprocessing: adding runtime dependencies (2013-06-28 11:02:41 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib paule/qa-config
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=paule/qa-config
Paul Eggleton (2):
poky.conf: remove la2 check which no longer exists from ERROR_QA poky.conf: fix WARN_QA and ERROR_QA settings
meta-yocto/conf/distro/poky.conf | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.1.2
PATCH 2/2 poky.conf: fix WARN_QA and ERROR_QA settings
In OE-Core master revision 8f5675e6d3eb the bug that tests we did not mention in ERROR_QA were being shown as warnings even if they weren't in WARN_QA was fixed; however a number of warnings we want to be enabled weren't in Poky's WARN_QA and thus were not shown after that change; additionally some of these were set in the default value of ERROR_QA in insane.bbclass (i.e. OE-Core's default) but would have previously shown up as warnings in Poky because they weren't in ERROR_QA there.
To fix this, put the appropriate values back into WARN_QA / ERROR_QA with a lean towards ERROR_QA - we want to be strict so that we keep OE-Core clean of QA issues during recipe maintenance.
Fixes [YOCTO #4752].
--- meta-yocto/conf/distro/poky.conf | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
meta-yocto/conf/distro/poky.conf +7 -3
@@ -99,8 +99,12 @@ OELAYOUT_ABI = "8" # add poky sanity bbclass INHERIT += "poky-sanity" -#WARN_QA = "unsafe-references-in-binaries unsafe-references-in-scripts" -WARN_QA = "textrel pkgvarcheck" -ERROR_QA = "dev-so debug-deps dev-deps debug-files arch pkgconfig la perms useless-rpaths rpaths staticdev ldflags" +# QA check settings - a little stricter than the OE-Core defaults +WARN_QA = "textrel files-invalid incompatible-license xorg-driver-abi" +ERROR_QA = "dev-so debug-deps dev-deps debug-files arch pkgconfig la perms \ + useless-rpaths rpaths staticdev ldflags pkgvarcheck already-stripped \ + compile-host-path dep-cmp installed-vs-shipped install-host-path \ + libdir packages-list perm-config perm-line perm-link pkgv-undefined \ + pn-overrides split-strip var-undefined" include conf/distro/include/seperatebuilddir.inc
Signature · 1 line
1.8.1.2