Skip to contentSkip to conversation

qt-mobility: fix build in the absence of xvideo

PATCH In review Hongxu Jia 2 participants 3 messages Jul 2, 2013 – Jul 9, 2013

lore
Share & tools
lore

Hongxu Jia

author
#0 lore raw

cover qt-mobility: fix build in the absence of xvideo

The following changes since commit 80b263430453896189b704d0997943642eec6fef:

classes/insane: remove la2 check which no longer exists from ERROR_QA (2013-06-28 16:33:08 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-qt4
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-adt

Hongxu Jia (1):
qt-mobility: fix build in the absence of xvideo

 .../qt-mobility-1.2.0/qt-mobility-no-xvideo.patch  | 26 ++++++++++++++++++++++
 meta/recipes-qt/qt4/qt-mobility_1.2.0.inc          |  3 ++-
 2 files changed, 28 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-qt/qt4/qt-mobility-1.2.0/qt-mobility-no-xvideo.patch
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 1/1 qt-mobility: fix build in the absence of xvideo

QMake pro files don't explicitly define QT_NO_XVIDEO if the configuration lacks xvideo, but plugins code relies on this define.

[YOCTO #4775]

Signed-off-by Hongxu Jia <[email protected]>
---
 .../qt-mobility-1.2.0/qt-mobility-no-xvideo.patch  | 26 ++++++++++++++++++++++
 meta/recipes-qt/qt4/qt-mobility_1.2.0.inc          |  3 ++-
 2 files changed, 28 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-qt/qt4/qt-mobility-1.2.0/qt-mobility-no-xvideo.patch
meta/recipes-qt/qt4/qt-mobility-1.2.0/qt-mobility-no-xvideo.patch new file +26 -0
new file mode 100644
index 0000000..6046752
@@ -0,0 +1,26 @@
+QMake pro files don't explicitly define QT_NO_XVIDEO if the
+configuration lacks xvideo, but plugins code relies on this define.
+
+Signed-off-by: Hongxu Jia <[email protected]>
+Upstream-Status: Inappropriate [configuration]
+---
+ plugins/multimedia/gstreamer/gstreamer.pro | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/plugins/multimedia/gstreamer/gstreamer.pro b/plugins/multimedia/gstreamer/gstreamer.pro
+--- a/plugins/multimedia/gstreamer/gstreamer.pro
++++ b/plugins/multimedia/gstreamer/gstreamer.pro
+@@ -19,6 +19,10 @@ LIBS += \
+     -lasound
+ }
+ 
++unix:!contains(QT_CONFIG, xvideo) {
++    DEFINES += QT_NO_XVIDEO
++}
++
+ CONFIG += link_pkgconfig
+ 
+ PKGCONFIG += \
+-- 
+1.8.1.2
+
meta/recipes-qt/qt4/qt-mobility_1.2.0.inc +2 -1
index aba84ab..2ce9ca2 100644
@@ -12,7 +12,8 @@ SRC_URI = "http://get.qt.nokia.com/qt/add-ons/qt-mobility-opensource-src-${PV}.t
            file://0001-gstvideoconnector-fixed-buffers-allocation.patch \
            file://0002-Remove-unnecessary-rpaths-from-qml_device-example.patch \
            file://qt-mobility-no-opengl.patch \
-	   file://gcc-scope.patch \
+           file://gcc-scope.patch \
+           file://qt-mobility-no-xvideo.patch \
 	   "
 
 SRC_URI[md5sum]="ea5db5a8d3dd4709c2926dceda646bd8"
Signature · 1 line
1.8.1.2
#2 lore raw
Quoted 2 lines · Hongxu Jia

QMake pro files don't explicitly define QT_NO_XVIDEO if the configuration lacks xvideo, but plugins code relies on this define.

You just described a clear and obvious bug in the build system...

Quoted 1 line

+Upstream-Status: Inappropriate [configuration]

...so why is this inappropriate to send upstream?

Ross