Skip to contentSkip to conversation

mc packaging fixes & udev cache fix

PATCH In review Saul Wold 3 participants 7 messages Jul 1, 2013 – Jul 2, 2013

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

v2 cover mc packaging fixes & udev cache fix

This set contains some packaging changes for mc (both gplv2 and v3) and enables udev-cache via an RRECOMMENDS

Sau!

The following changes since commit ff65497cd9a96d5ab49b16ba1f7e30a216ff4a42:

classes/insane: remove la2 check which no longer exists from ERROR_QA (2013-06-28 16:33:05 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib sgw/fix
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/fix

Saul Wold (4):
mc: Don't remove libdir and split helpers into packages
packagegroups: Update for split mc packages
packagegroup-core-basic: remove hardcode udev
udev: Add RRECOMMENDS for udev-cache to enable the cache

 .../packagegroups/packagegroup-self-hosted.bb      |  4 ++++
 meta/recipes-core/udev/udev.inc                    |  2 +-
 meta/recipes-extended/mc/mc_4.7.5.2.bb             | 22 ++++++++++++++++++++++
 meta/recipes-extended/mc/mc_4.8.8.bb               | 22 +++++++++++++++++++++-
 .../packagegroups/packagegroup-core-basic.bb       |  5 ++++-
 .../packagegroups/packagegroup-core-lsb.bb         |  4 ++++
 6 files changed, 56 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.1.4
author
#1 lore raw

PATCH v2 1/4 mc: Don't remove libdir and split helpers into packages

It contains helper programs that are needed to make mc do the right actions for the various file formats it understands.

The helpers are perl, python and shell scripts, split them out so the core mc does not try to pull in perl and python, it will still run without these helpers.

[YOCTO #4432]

---
 meta/recipes-extended/mc/mc_4.7.5.2.bb | 22 ++++++++++++++++++++++
 meta/recipes-extended/mc/mc_4.8.8.bb   | 22 +++++++++++++++++++++-
 2 files changed, 43 insertions(+), 1 deletion(-)
meta/recipes-extended/mc/mc_4.7.5.2.bb +22 -0
index e7ccc77..818e971 100644
@@ -23,3 +23,25 @@ do_install_append () {
        sed -i -e '1s,#!.*perl,#!${bindir}/env perl,' ${D}${libexecdir}/mc/extfs.d/*
        
 }
+
+PACKAGES =+ "${BPN}-helpers-perl ${BPN}-helpers-python ${BPN}-helpers ${BPN}-fish"
+
+DESCRIPTION_${BPN}-helpers-perl = "Midnight Commander perl based helper scripts" 
+FILES_${BPN}-helpers-perl = "${libexecdir}/mc/extfs.d/a+ ${libexecdir}/mc/extfs.d/apt+ \
+                             ${libexecdir}/mc/extfs.d/deb ${libexecdir}/mc/extfs.d/deba \
+                             ${libexecdir}/mc/extfs.d/debd ${libexecdir}/mc/extfs.d/dpkg+ \
+                             ${libexecdir}/mc/extfs.d/mailfs ${libexecdir}/mc/extfs.d/patchfs \ 
+                             ${libexecdir}/mc/extfs.d/rpms+ ${libexecdir}/mc/extfs.d/ulib \ 
+                             ${libexecdir}/mc/extfs.d/uzip"
+RDEPENDS_${BPN}-helpers-perl = "perl"
+
+DESCRIPTION_${BPN}-helpers-python = "Midnight Commander python based helper scripts" 
+FILES_${BPN}-helpers-python = "${libexecdir}/mc/extfs.d/s3+ ${libexecdir}/mc/extfs.d/uc1541"
+RDEPENDS_${BPN}-helpers-python = "python"
+
+DESCRIPTION_${BPN}-helpers = "Midnight Commander shell helper scripts" 
+FILES_${BPN}-helpers = "${libexecdir}/mc/extfs.d/* ${libexecdir}/mc/ext.d/*"
+
+DESCRIPTION_${BPN}-fish = "Midnight Commander Fish scripts"
+FILES_${BPN}-fish = "${libexecdir}/mc/fish"
+
meta/recipes-extended/mc/mc_4.8.8.bb +21 -1
index 20ae797..b2851bb 100644
@@ -19,5 +19,25 @@ FILES_${PN}-dbg += "${libexecdir}/mc/.debug/"
 
 do_install_append () {
 	sed -i -e '1s,#!.*perl,#!${bindir}/env perl,' ${D}${libexecdir}/mc/extfs.d/*
-	rm -rf ${D}${libdir}
 }
+
+PACKAGES =+ "${BPN}-helpers-perl ${BPN}-helpers-python ${BPN}-helpers ${BPN}-fish"
+
+DESCRIPTION_${BPN}-helpers-perl = "Midnight Commander perl based helper scripts" 
+FILES_${BPN}-helpers-perl = "${libexecdir}/mc/extfs.d/a+ ${libexecdir}/mc/extfs.d/apt+ \
+                             ${libexecdir}/mc/extfs.d/deb ${libexecdir}/mc/extfs.d/deba \
+                             ${libexecdir}/mc/extfs.d/debd ${libexecdir}/mc/extfs.d/dpkg+ \
+                             ${libexecdir}/mc/extfs.d/mailfs ${libexecdir}/mc/extfs.d/patchfs \ 
+                             ${libexecdir}/mc/extfs.d/rpms+ ${libexecdir}/mc/extfs.d/ulib \ 
+                             ${libexecdir}/mc/extfs.d/uzip"
+RDEPENDS_${BPN}-helpers-perl = "perl"
+
+DESCRIPTION_${BPN}-helpers-python = "Midnight Commander python based helper scripts" 
+FILES_${BPN}-helpers-python = "${libexecdir}/mc/extfs.d/s3+ ${libexecdir}/mc/extfs.d/uc1541"
+RDEPENDS_${BPN}-helpers-python = "python"
+
+DESCRIPTION_${BPN}-helpers = "Midnight Commander shell helper scripts" 
+FILES_${BPN}-helpers = "${libexecdir}/mc/extfs.d/* ${libexecdir}/mc/ext.d/*"
+
+DESCRIPTION_${BPN}-fish = "Midnight Commander Fish scripts"
+FILES_${BPN}-fish = "${libexecdir}/mc/fish"
Signature · 1 line
1.8.1.4
author
#2 lore raw

PATCH v2 2/4 packagegroups: Update for split mc packages

In reply to Saul Wold
---
 meta/recipes-core/packagegroups/packagegroup-self-hosted.bb    | 4 ++++
 meta/recipes-extended/packagegroups/packagegroup-core-basic.bb | 4 ++++
 meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb   | 4 ++++
 3 files changed, 12 insertions(+)
meta/recipes-core/packagegroups/packagegroup-self-hosted.bb +4 -0
index ed73617..d4e89a1 100644
@@ -39,6 +39,10 @@ RDEPENDS_packagegroup-self-hosted-host-tools = "\
     iptables \
     lsb \
     mc \
+    mc-fish \
+    mc-helpers \
+    mc-helpers-perl \
+    mc-helpers-python \
     parted \
     pseudo \
     screen \
meta/recipes-extended/packagegroups/packagegroup-core-basic.bb +4 -0
index 00405d6..47b980e 100644
@@ -59,6 +59,10 @@ RDEPENDS_packagegroup-core-basic-utils = "\
     grep \
     makedevs \
     mc \
+    mc-fish \
+    mc-helpers \
+    mc-helpers-perl \
+    mc-helpers-python \
     mktemp \
     ncurses \
     net-tools \
meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb +4 -0
index ed854b8..d71db26 100644
@@ -50,6 +50,10 @@ RDEPENDS_packagegroup-core-sys-extended = "\
     lrzsz \
     lzo \
     mc \
+    mc-fish \
+    mc-helpers \
+    mc-helpers-perl \
+    mc-helpers-python \
     mdadm \
     minicom \
     neon \
Signature · 1 line
1.8.1.4
author
#3 lore raw

PATCH v2 3/4 packagegroup-core-basic: remove hardcode udev

In reply to Saul Wold

udev is brought in via packagegroup-core-boot

---
 meta/recipes-extended/packagegroups/packagegroup-core-basic.bb | 1 -
 1 file changed, 1 deletion(-)
meta/recipes-extended/packagegroups/packagegroup-core-basic.bb +0 -1
index 47b980e..e802a02 100644
@@ -73,7 +73,6 @@ RDEPENDS_packagegroup-core-basic-utils = "\
     sed \
     tar \
     time \
-    udev \
     util-linux \
     zlib \
     "
Signature · 1 line
1.8.1.4
author
#4 lore raw

PATCH v2 4/4 udev: Add RRECOMMENDS for udev-cache to enable the cache

In reply to Saul Wold

This will enable the udev cache for sysvinit systems, which does improve post-first boots.

---
 meta/recipes-core/udev/udev.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/udev/udev.inc +1 -1
index d30f7de..6606707 100644
@@ -54,7 +54,7 @@ INITSCRIPT_NAME_udev-cache = "udev-cache"
 INITSCRIPT_PARAMS_udev-cache = "start 36 S ."
 
 FILES_${PN} += "${libexecdir} ${libdir}/ConsoleKit ${nonarch_base_libdir}/udev"
-RRECOMMENDS_${PN} += "udev-utils"
+RRECOMMENDS_${PN} += "udev-utils udev-cache"
 
 FILES_${PN}-dbg += "${libexecdir}/.debug"
 FILES_${PN}-dbg += "${base_libdir}/udev/.debug/"
Signature · 1 line
1.8.1.4
#5 lore raw

Re: [PATCH 4/4 v2] udev: Add RRECOMMENDS for udev-cache to enable the cache

Op 1 jul. 2013, om 22:48 heeft Saul Wold <[email protected]> het volgende geschreven:

Quoted 2 lines

This will enable the udev cache for sysvinit systems, which does improve post-first boots.

Can I please get some numbers on that? I haven't used it for years since it actually slowed down boot when I started measuring it and besides that, it's flakey as hell.

regards,

Koen

#6 lore raw

Re: [PATCH 4/4 v2] udev: Add RRECOMMENDS for udev-cache to enable the cache

Quoted 5 lines · Koen Kooi

Op 1 jul. 2013, om 22:48 heeft Saul Wold <[email protected]> het volgende geschreven:

Quoted 2 lines

This will enable the udev cache for sysvinit systems, which does improve post-first boots.

Can I please get some numbers on that? I haven't used it for years since it actually slowed down boot when I started measuring it and besides that, it's flakey as hell.

On my machine, a minimal image for qemux86 takes about 5 to 6 seconds for the udev to finish, with udev cache enabled, it takes less than 1 second (of course, not for first boot).

//Chen Qi

Quoted 10 lines

regards,

Koen
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core