tar: remove erroneous patch
cover tar: remove erroneous patch
From: Chen Qi <[email protected]>
The following changes since commit 3dee534f1e25109e0bdb681de0746c336f4b8840:
lib/oeqa: fix dependecy check (2013-07-16 10:04:17 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib ChenQi/tar-remove-erroneous-patch
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/tar-remove-erroneous-patch
Chen Qi (1):
tar: remove an erroneous patch
.../tar-1.26/tar-1.26-fortifysourcessigabrt.patch | 36 -------------------- meta/recipes-extended/tar/tar_1.26.bb | 1 - 2 files changed, 37 deletions(-) delete mode 100644 meta/recipes-extended/tar/tar-1.26/tar-1.26-fortifysourcessigabrt.patch
Signature · 1 line
1.7.9.5
PATCH 1/1 tar: remove an erroneous patch
From: Chen Qi <[email protected]>
This removed patch is a workaround for gcc-4.5 manifests buffer overflow with app-arch/tar-1.{22,23}, according to the information from https://bugs.gentoo.org/show_bug.cgi?id=317139.
The problem with that patch is that it's only setting the magic field of the header while the original statement sets both the magic and the version field of the header. Because of this, all tar balls created by the tar package in OE will be treated as old V7 format tar balls.
As a negative effect of this behaviour, the tar package in OE cannot handle device files correctly. This in turn leads to the udev cache failure in images like core-image-lsb-sdk.
[YOCTO #4815]
--- .../tar-1.26/tar-1.26-fortifysourcessigabrt.patch | 36 -------------------- meta/recipes-extended/tar/tar_1.26.bb | 1 - 2 files changed, 37 deletions(-) delete mode 100644 meta/recipes-extended/tar/tar-1.26/tar-1.26-fortifysourcessigabrt.patch
meta/recipes-extended/tar/tar-1.26/tar-1.26-fortifysourcessigabrt.patch deleted +0 -36
@@ -1,36 +0,0 @@ -port fedora patch for fortify sources sigabort. See -https://qa.mandriva.com/show_bug.cgi?id=61419 for details. - -Upstream-Status: Pending - -Signed-off-by: Christopher Larson <[email protected]> -Signed-off-by: Fahad Usman <[email protected]> - ---- - src/create.c | 8 ++++---- - 1 file changed, 4 insertions(+), 4 deletions(-) - ---- tar-1.26.orig/src/create.c -+++ tar-1.26/src/create.c -@@ -562,8 +562,8 @@ write_gnu_long_link (struct tar_stat_inf - GNAME_TO_CHARS (tmpname, header->header.gname); - free (tmpname); - -- strcpy (header->buffer + offsetof (struct posix_header, magic), -- OLDGNU_MAGIC); -+ strncpy (header->buffer + offsetof (struct posix_header, magic), -+ OLDGNU_MAGIC, sizeof(header->header.magic)); - header->header.typeflag = type; - finish_header (st, header, -1); - -@@ -900,8 +900,8 @@ start_header (struct tar_stat_info *st) - case OLDGNU_FORMAT: - case GNU_FORMAT: /*FIXME?*/ - /* Overwrite header->header.magic and header.version in one blow. */ -- strcpy (header->buffer + offsetof (struct posix_header, magic), -- OLDGNU_MAGIC); -+ strncpy (header->buffer + offsetof (struct posix_header, magic), -+ OLDGNU_MAGIC, sizeof(header->header.magic)); - break; - - case POSIX_FORMAT:
meta/recipes-extended/tar/tar_1.26.bb +0 -1
@@ -6,7 +6,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504" PR = "r5" SRC_URI += "file://remove-gets.patch \ - file://tar-1.26-fortifysourcessigabrt.patch\ " SRC_URI[md5sum] = "2cee42a2ff4f1cd4f9298eeeb2264519"
Signature · 1 line
1.7.9.5