Skip to contentSkip to conversation

ccache: allow CCACHE_DIR to be overriden

PATCH In review [email protected] 2 participants 3 messages Jul 26, 2013 – Jul 31, 2013

lore
Share & tools
lore
#0 lore raw

cover ccache: allow CCACHE_DIR to be overriden

From: Wenzong Fan <[email protected]>

Use weaker assignment for CCACHE_DIR to allow users to override it if desired.

The following changes since commit 67864ca79da08df752487a3a4e1a975546da123d:

systemd: Remove systemd_unitdir if systemd is not in distro features (2013-07-24 11:35:39 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib wenzong/ccache_bbclass
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/ccache_bbclass

Wenzong Fan (1):
ccache: allow CCACHE_DIR to be overriden

 meta/classes/ccache.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ccache: allow CCACHE_DIR to be overriden

From: Wenzong Fan <[email protected]>

Use weaker assignment for CCACHE_DIR to allow users to override it if desired.

---
 meta/classes/ccache.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/ccache.bbclass +1 -1
index cd06a4b..ca3ca43 100644
@@ -1,5 +1,5 @@
 CCACHE = "${@bb.which(d.getVar('PATH', True), 'ccache') and 'ccache '}"
-export CCACHE_DIR = "${TMPDIR}/ccache/${MULTIMACH_HOST_SYS}/${PN}"
+export CCACHE_DIR ?= "${TMPDIR}/ccache/${MULTIMACH_HOST_SYS}/${PN}"
 CCACHE_DISABLE[unexport] = "1"
 
 do_configure[dirs] =+ "${CCACHE_DIR}"
Signature · 1 line
1.7.9.5
#2 lore raw

meta/classes/ccache.bbclass line 2

Quoted 5 lines · <[email protected]> writes:

Use weaker assignment for CCACHE_DIR to allow users to override it if desired.

meta/classes/ccache.bbclass +1 -1
-export CCACHE_DIR = "${TMPDIR}/ccache/${MULTIMACH_HOST_SYS}/${PN}"
+export CCACHE_DIR ?= "${TMPDIR}/ccache/${MULTIMACH_HOST_SYS}/${PN}"

This can be a dangerous change and probably does not have the intended effect ((project) global ccache dir) due to

| do_clean[cleandirs] += "${CCACHE_DIR}"

imo, this class should be removed completely (${PN} local ccache dirs do not make any sense) and the only useful part

| CCACHE_DISABLE[unexport] = "1"

should be solved by http://patchwork.openembedded.org/patch/32787/

Enrico