Skip to contentSkip to conversation

tiny-init: fix bashism

PATCH Superseded [email protected] 2 participants 3 messages Aug 2, 2013 – Aug 5, 2013 1 message not in the archive

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 tiny-init: fix bashism

In reply to a message not in the archive

From: Chen Qi <[email protected]>

---
 meta-yocto/recipes-core/tiny-init/files/init |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto/recipes-core/tiny-init/files/init +1 -1
index 4b78f01..9140e95 100644
@@ -15,7 +15,7 @@ ifup lo
 
 # Allow for distro or local customizations
 if [ -f /etc/rc.local ] ; then
-	source /etc/rc.local
+	. /etc/rc.local
 fi
 
 # Become session leader and try to find a real tty (e.g. ttyS0)
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#2 lore raw
Quoted 1 line · On Fri, 2013-08-02 at 15:56 +0800, [email protected] wrote:

From: Chen Qi <[email protected]>

I understand this is a simple fix, but please provide a commit log. In this case, something like the following would suffice:

"source" is a bashism, replace it with the posix shell compliant "."

Quoted 1 line
Quoted 17 lines
---
 meta-yocto/recipes-core/tiny-init/files/init |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto/recipes-core/tiny-init/files/init +1 -1
index 4b78f01..9140e95 100644
@@ -15,7 +15,7 @@ ifup lo
 
 # Allow for distro or local customizations
 if [ -f /etc/rc.local ] ; then
-	source /etc/rc.local
+	. /etc/rc.local
 fi
 
 # Become session leader and try to find a real tty (e.g. ttyS0)
Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
author
#3 lore raw
Quoted 6 lines · Darren Hart
Quoted 1 line · On Fri, 2013-08-02 at 15:56 +0800, [email protected] wrote:

From: Chen Qi <[email protected]>

I understand this is a simple fix, but please provide a commit log. In this case, something like the following would suffice:

"source" is a bashism, replace it with the posix shell compliant "."

Thanks.
Comment added and V2 sent.

Best Regards,
Chen Qi

Quoted 21 lines
Quoted 1 line
Quoted 17 lines
---
  meta-yocto/recipes-core/tiny-init/files/init |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto/recipes-core/tiny-init/files/init +1 -1
index 4b78f01..9140e95 100644
@@ -15,7 +15,7 @@ ifup lo
 
  # Allow for distro or local customizations
  if [ -f /etc/rc.local ] ; then
-	source /etc/rc.local
+	. /etc/rc.local
  fi
 
  # Become session leader and try to find a real tty (e.g. ttyS0)