oe/path.py: call /bin/cp directly
cover oe/path.py: call /bin/cp directly
From: Wenzong Fan <[email protected]>
This avoids running cp with interactive mode on some hosts if defined:
alias cp='cp -i'
The following changes since commit 16d522bcd1f1b7741577fa31fab7e2129da0cae9:
maintainers.inc: reassign maintainers, remove obsolete recipes (2013-08-12 13:13:05 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib wenzong/fix_alias_cp
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/fix_alias_cp
Wenzong Fan (1):
oe/path.py: call /bin/cp directly
meta/lib/oe/path.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
PATCH 1/1 oe/path.py: call /bin/cp directly
From: Wenzong Fan <[email protected]>
This avoids running cp with interactive mode if defined:
alias cp='cp -i'
--- meta/lib/oe/path.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/path.py +1 -1
@@ -97,7 +97,7 @@ def copyhardlinktree(src, dst): check_output(cmd, shell=True, stderr=subprocess.STDOUT) if os.path.isdir(src): src = src + "/*" - cmd = 'cp -afl %s %s' % (src, dst) + cmd = '/bin/cp -afl %s %s' % (src, dst) check_output(cmd, shell=True, stderr=subprocess.STDOUT) else: copytree(src, dst)
Signature · 1 line
1.7.9.5
Quoted 16 lines · On 08/13/2013 12:09 AM, [email protected] wrote:
From: Wenzong Fan <[email protected]>
This avoids running cp with interactive mode if defined:
alias cp='cp -i'
Signed-off-by Wenzong Fan <[email protected]>--- meta/lib/oe/path.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/lib/oe/path.py +0
-0
meta/lib/oe/path.py def copyhardlinktree(src, dst): · line 100
Quoted 5 lines
meta/lib/oe/path.py +1
-1@@ -97,7 +97,7 @@ def copyhardlinktree(src, dst): check_output(cmd, shell=True, stderr=subprocess.STDOUT) if os.path.isdir(src): src = src + "/*" - cmd = 'cp -afl %s %s' % (src, dst) + cmd = '/bin/cp -afl %s %s' % (src, dst)
As Richard points out in the Consolidated Pull, this is the wrong way to go about this, there are possibly other places that will have similar issues and we can't fix then all this way.
A better solution is to add a sanity check and suggest that the user needs to fix their environment to ensure the build will succeed.
Sau!
Quoted 4 lines
meta/lib/oe/path.py +0
-0check_output(cmd, shell=True, stderr=subprocess.STDOUT) else: copytree(src, dst)
Quoted 27 lines · Saul Wold
Quoted 16 lines · On 08/13/2013 12:09 AM, [email protected] wrote:
From: Wenzong Fan <[email protected]>
This avoids running cp with interactive mode if defined:
alias cp='cp -i'
Signed-off-by Wenzong Fan <[email protected]>--- meta/lib/oe/path.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/lib/oe/path.py +0
-0meta/lib/oe/path.py def copyhardlinktree(src, dst): · line 100
Quoted 5 lines
meta/lib/oe/path.py +1
-1@@ -97,7 +97,7 @@ def copyhardlinktree(src, dst): check_output(cmd, shell=True, stderr=subprocess.STDOUT) if os.path.isdir(src): src = src + "/*" - cmd = 'cp -afl %s %s' % (src, dst) + cmd = '/bin/cp -afl %s %s' % (src, dst)As Richard points out in the Consolidated Pull, this is the wrong way to go about this, there are possibly other places that will have similar issues and we can't fix then all this way.
Quoted 2 lines
A better solution is to add a sanity check and suggest that the user needs to fix their environment to ensure the build will succeed.
Ok, I will update the patch for this issue.
Thanks
Wenzong
Quoted 7 lines
Sau!
Quoted 4 lines
meta/lib/oe/path.py +0
-0check_output(cmd, shell=True, stderr=subprocess.STDOUT) else: copytree(src, dst)