Skip to contentSkip to conversation

YB2370: Build Appliance integrates PCManFM filemanager

PATCH Superseded Cristian Iorga 3 participants 10 messages Aug 20, 2013 – Aug 23, 2013

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Cristian Iorga

author
#0 lore raw

cover YB2370: Build Appliance integrates PCManFM filemanager

PCManFM filemanager is integrated into Build Appliance; PCManFM is used to display build results from Hob interface.

The following changes since commit fe227a023e30f6651618423ab527cde21a350d1a:

genext2fs: fix memory corruption on powerpc (2013-08-20 15:31:26 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ciorga/YB2370
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ciorga/YB2370

Cristian Iorga (3):
Build Appliance: pcmanfm integration
build-appliance-image: changing the icon theme to sato
builder: register directories with pcmanfm

 meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 6 +++++-
 meta/recipes-graphics/builder/builder_0.1.bb                | 2 +-
 meta/recipes-graphics/builder/files/builder_hob_start.sh    | 9 +++++++++
 3 files changed, 15 insertions(+), 2 deletions(-)
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 1/3 Build Appliance: pcmanfm integration

PCManFm file manager is integrated in Build Appliance xprop, xdg-utils are also integrated for file association support.

Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-core/packagegroups/packagegroup-self-hosted.bb +3 -0
index 6a0722a..b58d238 100644
@@ -38,11 +38,14 @@ RDEPENDS_packagegroup-self-hosted-host-tools = "\
     hdparm \
     iptables \
     lsb \
+    xprop \
+    xdg-utils \
     mc \
     mc-fish \
     mc-helpers \
     mc-helpers-perl \
     mc-helpers-python \
+    pcmanfm \
     parted \
     pseudo \
     screen \
Signature · 1 line
1.8.1.2
#2 lore raw

Re: [PATCH 1/3] Build Appliance: pcmanfm integration

Quoted 1 line · Cristian Iorga

+ xprop \

As discussed on Jabber, this should be a rdepends of xdg-utils.

Ross

author
#3 lore raw

Re: [PATCH 1/3] Build Appliance: pcmanfm integration

ACK, fixing now. Thanks, Ross.

-----Original Message-----
From: Burton, Ross [mailto:[email protected]]
Sent: Thursday, August 22, 2013 6:52 PM
To: Iorga, Cristian
Cc: OE-core
Subject: Re: [OE-core] [PATCH 1/3] Build Appliance: pcmanfm integration

Quoted 1 line · Cristian Iorga

+ xprop \

As discussed on Jabber, this should be a rdepends of xdg-utils.

Ross

author
#4 lore raw

PATCH 2/3 build-appliance-image: changing the icon theme to sato

In reply to Cristian Iorga

Hicolor icon theme does not properly displays icons for folders. Sato icon theme is working correctly.
Also, settings-daemon needs to be added to image in order to properly display folder icons.

Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-core/packagegroups/packagegroup-self-hosted.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/packagegroups/packagegroup-self-hosted.bb +2 -1
index b58d238..c1e2951 100644
@@ -124,7 +124,8 @@ RDEPENDS_packagegroup-self-hosted-extended = "\
     grep \
     groff \
     gzip \
-    hicolor-icon-theme \
+    settings-daemon \
+    sato-icon-theme \
     libaio \
     libusb1 \
     libxml2 \
Signature · 1 line
1.8.1.2
author
#5 lore raw

PATCH 3/3 builder: register directories with pcmanfm

In reply to Cristian Iorga

Register directories to be opened with PCManFM
filemanager using xdg-open in Build Appliance.

Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-graphics/builder/builder_0.1.bb             | 2 +-
 meta/recipes-graphics/builder/files/builder_hob_start.sh | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)
meta/recipes-graphics/builder/builder_0.1.bb +1 -1
index 78d41e5..1e8c977 100644
@@ -1,7 +1,7 @@
 SUMMARY = "New user to do specific job"
 DESCRIPTION = "This recipe create a new user named ${PN}, who is used for specific jobs like building. The task can be auto started via mini X"
 SECTION = "x11"
-PR = "r6"
+PR = "r7"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://builder_hob_start.sh;endline=5;md5=84796c3c41785d86100fdabcbdade00e"
meta/recipes-graphics/builder/files/builder_hob_start.sh +9 -0
index 40616f5..b3a0540 100644
@@ -9,6 +9,15 @@ export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo
 export PSEUDO_LIBDIR=/usr/lib/pseudo/lib64
 export GIT_PROXY_COMMAND=/home/builder/poky/scripts/oe-git-proxy
 
+#start pcmanfm in daemon mode to allow asynchronous launch
+pcmanfm -d&
+
+#register folders to open with PCManFM filemanager
+if [ ! -d /home/ubik/tmp/.local/share/applications ]; then
+    mkdir -p /home/builder/.local/share/applications/
+    xdg-mime default pcmanfm.desktop inode/directory
+fi
+
 cd /home/builder/poky
 . ./oe-init-build-env
Signature · 1 line
1.8.1.2
#6 lore raw

Re: [PATCH 3/3] builder: register directories with pcmanfm

Quoted 14 lines · Cristian Iorga

Register directories to be opened with PCManFM
filemanager using xdg-open in Build Appliance.

Signed-off-by Cristian Iorga <[email protected]>
---
  meta/recipes-graphics/builder/builder_0.1.bb             | 2 +-
  meta/recipes-graphics/builder/files/builder_hob_start.sh | 9 +++++++++
  2 files changed, 10 insertions(+), 1 deletion(-)
meta/recipes-graphics/builder/builder_0.1.bb +0 -0
index 78d41e5..1e8c977 100644

meta/recipes-graphics/builder/builder_0.1.bb line 4

Quoted 5 lines
meta/recipes-graphics/builder/builder_0.1.bb +1 -1
@@ -1,7 +1,7 @@
  SUMMARY = "New user to do specific job"
  DESCRIPTION = "This recipe create a new user named ${PN}, who is used for specific jobs like building. The task can be auto started via mini X"
  SECTION = "x11"
-PR = "r6"
+PR = "r7"

No PR Bumps!

Quoted 8 lines
meta/recipes-graphics/builder/builder_0.1.bb +0 -0
  LICENSE = "MIT"
  LIC_FILES_CHKSUM = "file://builder_hob_start.sh;endline=5;md5=84796c3c41785d86100fdabcbdade00e"
meta/recipes-graphics/builder/files/builder_hob_start.sh +0 -0
index 40616f5..b3a0540 100644

meta/recipes-graphics/builder/files/builder_hob_start.sh export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo · line 16

Quoted 8 lines
meta/recipes-graphics/builder/files/builder_hob_start.sh +5 -0
@@ -9,6 +9,15 @@ export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo
  export PSEUDO_LIBDIR=/usr/lib/pseudo/lib64
  export GIT_PROXY_COMMAND=/home/builder/poky/scripts/oe-git-proxy
 
+#start pcmanfm in daemon mode to allow asynchronous launch
+pcmanfm -d&
+
+#register folders to open with PCManFM filemanager
+if [ ! -d /home/ubik/tmp/.local/share/applications ]; then

                  ^^^^^

What's that user? Should it be builder?

Quoted 8 lines
meta/recipes-graphics/builder/files/builder_hob_start.sh +4 -0
+    mkdir -p /home/builder/.local/share/applications/
+    xdg-mime default pcmanfm.desktop inode/directory
+fi
+
  cd /home/builder/poky
  . ./oe-init-build-env
author
#7 lore raw

Re: [PATCH 3/3] builder: register directories with pcmanfm

Sould I remove PR entirely?
Or just leave it at version 6?
That's no mistake, I did change the PR because there are no external sources in this case, so there is not really a new version. Just an evolution.

-----Original Message-----
From: Saul Wold [mailto:[email protected]]
Sent: Tuesday, August 20, 2013 7:38 PM
To: Iorga, Cristian
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 3/3] builder: register directories with pcmanfm

Quoted 15 lines · Cristian Iorga

Register directories to be opened with PCManFM filemanager using xdg-open in Build Appliance.

Signed-off-by Cristian Iorga <[email protected]>
---
  meta/recipes-graphics/builder/builder_0.1.bb             | 2 +-
  meta/recipes-graphics/builder/files/builder_hob_start.sh | 9 +++++++++
  2 files changed, 10 insertions(+), 1 deletion(-)
meta/recipes-graphics/builder/builder_0.1.bb +0 -0
index 78d41e5..1e8c977 100644

meta/recipes-graphics/builder/builder_0.1.bb line 4

Quoted 5 lines
meta/recipes-graphics/builder/builder_0.1.bb +1 -1
@@ -1,7 +1,7 @@
  SUMMARY = "New user to do specific job"
  DESCRIPTION = "This recipe create a new user named ${PN}, who is used for specific jobs like building. The task can be auto started via mini X"
  SECTION = "x11"
-PR = "r6"
+PR = "r7"

No PR Bumps!

Quoted 9 lines
meta/recipes-graphics/builder/builder_0.1.bb +0 -0
  LICENSE = "MIT"
  LIC_FILES_CHKSUM = "file://builder_hob_start.sh;endline=5;md5=84796c3c41785d86100fdabcbdade00e"
meta/recipes-graphics/builder/files/builder_hob_start.sh +0 -0
index 40616f5..b3a0540 100644

meta/recipes-graphics/builder/files/builder_hob_start.sh export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo · line 16

Quoted 8 lines
meta/recipes-graphics/builder/files/builder_hob_start.sh +5 -0
@@ -9,6 +9,15 @@ export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo
  export PSEUDO_LIBDIR=/usr/lib/pseudo/lib64
  export GIT_PROXY_COMMAND=/home/builder/poky/scripts/oe-git-proxy
 
+#start pcmanfm in daemon mode to allow asynchronous launch pcmanfm 
+-d&
+
+#register folders to open with PCManFM filemanager if [ ! -d 
+/home/ubik/tmp/.local/share/applications ]; then

                   ^^^^^

What's that user? Should it be builder?

Quoted 7 lines
meta/recipes-graphics/builder/files/builder_hob_start.sh +3 -0
+    mkdir -p /home/builder/.local/share/applications/
+    xdg-mime default pcmanfm.desktop inode/directory fi
+
  cd /home/builder/poky
  . ./oe-init-build-env
#8 lore raw

Re: [PATCH 3/3] builder: register directories with pcmanfm

Quoted 5 lines · Cristian

Sould I remove PR entirely?
Or just leave it at version 6?
That's no mistake, I did change the PR because there are no external sources in this case, so there is not really a new version. Just an evolution.

Please try to do inline replies, as we prefer them to keep the context.

It should stay at PR="r6" to preserve the package version and upgradability. Removing PR would cause the package version to go backwards.

Sau!

Quoted 59 lines

-----Original Message-----
From: Saul Wold [mailto:[email protected]]
Sent: Tuesday, August 20, 2013 7:38 PM
To: Iorga, Cristian
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 3/3] builder: register directories with pcmanfm

Quoted 15 lines · Cristian Iorga

Register directories to be opened with PCManFM filemanager using xdg-open in Build Appliance.

Signed-off-by Cristian Iorga <[email protected]>
---
   meta/recipes-graphics/builder/builder_0.1.bb             | 2 +-
   meta/recipes-graphics/builder/files/builder_hob_start.sh | 9 +++++++++
   2 files changed, 10 insertions(+), 1 deletion(-)
meta/recipes-graphics/builder/builder_0.1.bb +0 -0
index 78d41e5..1e8c977 100644

meta/recipes-graphics/builder/builder_0.1.bb line 4

Quoted 5 lines
meta/recipes-graphics/builder/builder_0.1.bb +1 -1
@@ -1,7 +1,7 @@
   SUMMARY = "New user to do specific job"
   DESCRIPTION = "This recipe create a new user named ${PN}, who is used for specific jobs like building. The task can be auto started via mini X"
   SECTION = "x11"
-PR = "r6"
+PR = "r7"

No PR Bumps!

Quoted 9 lines
meta/recipes-graphics/builder/builder_0.1.bb +0 -0
   LICENSE = "MIT"
   LIC_FILES_CHKSUM = "file://builder_hob_start.sh;endline=5;md5=84796c3c41785d86100fdabcbdade00e"
meta/recipes-graphics/builder/files/builder_hob_start.sh +0 -0
index 40616f5..b3a0540 100644

meta/recipes-graphics/builder/files/builder_hob_start.sh export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo · line 16

Quoted 8 lines
meta/recipes-graphics/builder/files/builder_hob_start.sh +5 -0
@@ -9,6 +9,15 @@ export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo
   export PSEUDO_LIBDIR=/usr/lib/pseudo/lib64
   export GIT_PROXY_COMMAND=/home/builder/poky/scripts/oe-git-proxy
 
+#start pcmanfm in daemon mode to allow asynchronous launch pcmanfm
+-d&
+
+#register folders to open with PCManFM filemanager if [ ! -d
+/home/ubik/tmp/.local/share/applications ]; then

                    ^^^^^

What's that user? Should it be builder?

Quoted 7 lines
meta/recipes-graphics/builder/files/builder_hob_start.sh +3 -0
+    mkdir -p /home/builder/.local/share/applications/
+    xdg-mime default pcmanfm.desktop inode/directory fi
+
   cd /home/builder/poky
   . ./oe-init-build-env
author
#9 lore raw

Re: [PATCH 3/3] builder: register directories with pcmanfm

In reply to Saul Wold

Hmm, of course it should be builder.
Let me check what happened.
Regards,
Cristian

-----Original Message-----
From: Saul Wold [mailto:[email protected]]
Sent: Tuesday, August 20, 2013 7:38 PM
To: Iorga, Cristian
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 3/3] builder: register directories with pcmanfm

Quoted 15 lines · Cristian Iorga

Register directories to be opened with PCManFM filemanager using xdg-open in Build Appliance.

Signed-off-by Cristian Iorga <[email protected]>
---
  meta/recipes-graphics/builder/builder_0.1.bb             | 2 +-
  meta/recipes-graphics/builder/files/builder_hob_start.sh | 9 +++++++++
  2 files changed, 10 insertions(+), 1 deletion(-)
meta/recipes-graphics/builder/builder_0.1.bb +0 -0
index 78d41e5..1e8c977 100644

meta/recipes-graphics/builder/builder_0.1.bb line 4

Quoted 5 lines
meta/recipes-graphics/builder/builder_0.1.bb +1 -1
@@ -1,7 +1,7 @@
  SUMMARY = "New user to do specific job"
  DESCRIPTION = "This recipe create a new user named ${PN}, who is used for specific jobs like building. The task can be auto started via mini X"
  SECTION = "x11"
-PR = "r6"
+PR = "r7"

No PR Bumps!

Quoted 9 lines
meta/recipes-graphics/builder/builder_0.1.bb +0 -0
  LICENSE = "MIT"
  LIC_FILES_CHKSUM = "file://builder_hob_start.sh;endline=5;md5=84796c3c41785d86100fdabcbdade00e"
meta/recipes-graphics/builder/files/builder_hob_start.sh +0 -0
index 40616f5..b3a0540 100644

meta/recipes-graphics/builder/files/builder_hob_start.sh export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo · line 16

Quoted 8 lines
meta/recipes-graphics/builder/files/builder_hob_start.sh +5 -0
@@ -9,6 +9,15 @@ export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo
  export PSEUDO_LIBDIR=/usr/lib/pseudo/lib64
  export GIT_PROXY_COMMAND=/home/builder/poky/scripts/oe-git-proxy
 
+#start pcmanfm in daemon mode to allow asynchronous launch pcmanfm 
+-d&
+
+#register folders to open with PCManFM filemanager if [ ! -d 
+/home/ubik/tmp/.local/share/applications ]; then

                   ^^^^^

What's that user? Should it be builder?

Quoted 7 lines
meta/recipes-graphics/builder/files/builder_hob_start.sh +3 -0
+    mkdir -p /home/builder/.local/share/applications/
+    xdg-mime default pcmanfm.desktop inode/directory fi
+
  cd /home/builder/poky
  . ./oe-init-build-env