drm/i915: vlv backlight, per-pipe power sequencing fixes
Subsystems (2)
PATCH v2 1/4 drm/i915: name intel dp hooks per platform
In reply to Jani NikulaIn line with the rest of the code base. No functional changes.
--- drivers/gpu/drm/i915/intel_dp.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +8 -6
@@ -1720,6 +1720,11 @@ static void intel_enable_dp(struct intel_encoder *encoder)ironlake_edp_backlight_on (intel_dp); } +static void g4x_enable_dp (struct intel_encoder *encoder) +{ +intel_enable_dp (encoder); +} +static void vlv_enable_dp (struct intel_encoder *encoder) { }
@@ -1764,7 +1769,7 @@ static void vlv_pre_enable_dp(struct intel_encoder *encoder)vlv_wait_port_ready (dev_priv, port); } -static void intel_dp_pre_pll_enable (struct intel_encoder *encoder) +static void vlv_dp_pre_pll_enable (struct intel_encoder *encoder) {struct intel_digital_port *dport =enc_to_dig_port (&encoder->base);struct drm_device *dev = encoder->base.dev;
@@ -1774,9 +1779,6 @@ static void intel_dp_pre_pll_enable(struct intel_encoder *encoder)int port =vlv_dport_to_channel (dport);int pipe = intel_crtc->pipe; -if (!IS_VALLEYVIEW (dev)) -return ; -/* Program Tx lane resets to default */ mutex_lock (&dev_priv->dpio_lock); vlv_dpio_write(dev_priv, pipe, DPIO_PCS_TX(port),
@@ -3549,12 +3551,12 @@ intel_dp_init(struct drm_device *dev, int output_reg, enum port port) intel_encoder->get_hw_state = intel_dp_get_hw_state; intel_encoder->get_config = intel_dp_get_config;if (IS_VALLEYVIEW (dev)) { - intel_encoder->pre_pll_enable = intel_dp_pre_pll_enable; + intel_encoder->pre_pll_enable = vlv_dp_pre_pll_enable; intel_encoder->pre_enable = vlv_pre_enable_dp; intel_encoder->enable = vlv_enable_dp; }else { intel_encoder->pre_enable = intel_pre_enable_dp; - intel_encoder->enable = intel_enable_dp; + intel_encoder->enable = g4x_enable_dp; } intel_dig_port->port = port;
Signature · 1 line
1.7.9.5
v2 cover drm/i915: vlv backlight, per-pipe power sequencing fixes
v2 of http://mid.gmane.org/[email protected]
BR,
Jani.
Jani Nikula (4):
drm/i915: name intel dp hooks per platform
drm/i915: move backlight enable later in vlv enable sequence drm/i915: clean up power sequencing register port select definitions drm/i915: add support for per-pipe power sequencing on vlv
drivers/gpu/drm/i915/i915_reg.h | 8 +- drivers/gpu/drm/i915/intel_dp.c | 164 +++++++++++++++++++++++++++------------ 2 files changed, 116 insertions(+), 56 deletions(-)
Signature · 1 line
1.7.9.5
PATCH v2 2/4 drm/i915: move backlight enable later in vlv enable sequence
Follow-up to
commit 5004945f1d6c0282c0288afa89ad85d7f2bea4d5
Author: Jani Nikula <[email protected]> Date: Tue Jul 30 12:20:32 2013 +0300
drm/i915: move encoder->enable callback later in VLV crtc enable
v2: Rebase on the renamed enable hooks, adding clarity (Ville)
Reference: http://mid.gmane.org/CAKMK7uFs9EMvMW8BnS24e5UNm1D7JrfVg3SD5SDFtVEamGfOOg@mail.gmail.com
--- drivers/gpu/drm/i915/intel_dp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp.c +6 -1
@@ -1717,16 +1717,21 @@ static void intel_enable_dp(struct intel_encoder *encoder)ironlake_edp_panel_vdd_off (intel_dp, true);intel_dp_complete_link_train (intel_dp);intel_dp_stop_link_train (intel_dp); -ironlake_edp_backlight_on (intel_dp); }static void g4x_enable_dp (struct intel_encoder *encoder) { +struct intel_dp *intel_dp =enc_to_intel_dp (&encoder->base); +intel_enable_dp (encoder); +ironlake_edp_backlight_on (intel_dp); }static void vlv_enable_dp (struct intel_encoder *encoder) { +struct intel_dp *intel_dp =enc_to_intel_dp (&encoder->base); + +ironlake_edp_backlight_on (intel_dp); }static void intel_pre_enable_dp (struct intel_encoder *encoder)
Signature · 1 line
1.7.9.5
PATCH v2 3/4 drm/i915: clean up power sequencing register port select definitions
In reply to Jani NikulaRemove duplicates, add VLV specific macros for port B and C.
v2: also add PANEL_PORT_SELECT_DPC_VLV for clarity (Ville)
--- drivers/gpu/drm/i915/i915_reg.h | 8 ++------ drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +2 -6
@@ -4449,6 +4449,8 @@#define PIPEA_PP_STATUS (VLV_DISPLAY_BASE + 0x61200)#define PIPEA_PP_CONTROL (VLV_DISPLAY_BASE + 0x61204)#define PIPEA_PP_ON_DELAYS (VLV_DISPLAY_BASE + 0x61208) +#define PANEL_PORT_SELECT_DPB_VLV (1 << 30) +#define PANEL_PORT_SELECT_DPC_VLV (2 << 30)#define PIPEA_PP_OFF_DELAYS (VLV_DISPLAY_BASE + 0x6120c)#define PIPEA_PP_DIVISOR (VLV_DISPLAY_BASE + 0x61210)
@@ -4480,7 +4482,6 @@#define PANEL_PORT_SELECT_MASK (3 << 30)#define PANEL_PORT_SELECT_LVDS (0 << 30)#define PANEL_PORT_SELECT_DPA (1 << 30) -#define EDP_PANEL (1 << 30)#define PANEL_PORT_SELECT_DPC (2 << 30)#define PANEL_PORT_SELECT_DPD (3 << 30)#define PANEL_POWER_UP_DELAY_MASK (0x1fff0000)
@@ -4489,11 +4490,6 @@#define PANEL_LIGHT_ON_DELAY_SHIFT 0#define PCH_PP_OFF_DELAYS 0xc720c -#define PANEL_POWER_PORT_SELECT_MASK (0x3 << 30) -#define PANEL_POWER_PORT_LVDS (0 << 30) -#define PANEL_POWER_PORT_DP_A (1 << 30) -#define PANEL_POWER_PORT_DP_C (2 << 30) -#define PANEL_POWER_PORT_DP_D (3 << 30)#define PANEL_POWER_DOWN_DELAY_MASK (0x1fff0000)#define PANEL_POWER_DOWN_DELAY_SHIFT 16#define PANEL_LIGHT_OFF_DELAY_MASK (0x1fff)
drivers/gpu/drm/i915/intel_dp.c +2 -2
@@ -3288,9 +3288,9 @@ intel_dp_init_panel_power_sequencer_registers(struct drm_device *dev, port_sel =I915_READ (pp_on_reg) &0xc0000000 ; }else if (HAS_PCH_IBX (dev) ||HAS_PCH_CPT (dev)) {if (dp_to_dig_port (intel_dp)->port ==PORT_A ) - port_sel =PANEL_POWER_PORT_DP_A ; + port_sel =PANEL_PORT_SELECT_DPA ;else - port_sel =PANEL_POWER_PORT_DP_D ; + port_sel =PANEL_PORT_SELECT_DPD ; } pp_on |= port_sel;
Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 4/4 drm/i915: add support for per-pipe power sequencing on vlv
In reply to Jani NikulaVLV has per-pipe PP registers. Set up power sequencing on mode set. The connector init time setup is problematic, since we don't have a pipe at that time. Cook up something.
v2:
- use vlv_power_sequencer_pipe() also in _pp_{ctrl,stat}_reg()
- use PANEL_PORT_SELECT_DPC_VLV (Ville)
--- drivers/gpu/drm/i915/intel_dp.c | 141 +++++++++++++++++++++++++++------------ 1 file changed, 99 insertions(+), 42 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +99 -42
@@ -237,24 +237,77 @@ intel_hrawclk(struct drm_device *dev) } } +static void +intel_dp_init_panel_power_sequencer (struct drm_device *dev, +struct intel_dp *intel_dp, +struct edp_power_seq *out); +static void +intel_dp_init_panel_power_sequencer_registers (struct drm_device *dev, +struct intel_dp *intel_dp, +struct edp_power_seq *out); + +static enum pipe +vlv_power_sequencer_pipe (struct intel_dp *intel_dp) +{ +struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); +struct drm_crtc *crtc = intel_dig_port->base.base.crtc; +struct drm_device *dev = intel_dig_port->base.base.dev; +struct drm_i915_private *dev_priv = dev->dev_private; +enum port port = intel_dig_port->port; +enum pipe pipe; + +/* modeset should have pipe */ +if (crtc) +return to_intel_crtc (crtc)->pipe; + +/* init time, try to find a pipe with this port selected */ +for (pipe =PIPE_A ; pipe <=PIPE_B ; pipe++) { +u32 port_sel =I915_READ (VLV_PIPE_PP_ON_DELAYS (pipe)) & +PANEL_PORT_SELECT_MASK ; +if (port_sel ==PANEL_PORT_SELECT_DPB_VLV && port ==PORT_B ) +return pipe; +else if (port_sel ==PANEL_PORT_SELECT_DPC_VLV && port ==PORT_C ) +return pipe; + } + +/* shrug */ +return PIPE_A ; +} + +static u32 _pp_ctrl_reg (struct intel_dp *intel_dp) +{ +struct drm_device *dev =intel_dp_to_dev (intel_dp); + +if (HAS_PCH_SPLIT (dev)) +return PCH_PP_CONTROL ; +else +return VLV_PIPE_PP_CONTROL (vlv_power_sequencer_pipe (intel_dp)); +} + +static u32 _pp_stat_reg (struct intel_dp *intel_dp) +{ +struct drm_device *dev =intel_dp_to_dev (intel_dp); + +if (HAS_PCH_SPLIT (dev)) +return PCH_PP_STATUS ; +else +return VLV_PIPE_PP_STATUS (vlv_power_sequencer_pipe (intel_dp)); +} +static bool ironlake_edp_have_panel_power (struct intel_dp *intel_dp) {struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private; -u32 pp_stat_reg; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; -return (I915_READ (pp_stat_reg) &PP_ON ) !=0 ; +return (I915_READ (_pp_stat_reg (intel_dp)) &PP_ON ) !=0 ; }static bool ironlake_edp_have_panel_vdd (struct intel_dp *intel_dp) {struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private; -u32 pp_ctrl_reg; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; -return (I915_READ (pp_ctrl_reg) &EDP_FORCE_VDD ) !=0 ; +return (I915_READ (_pp_ctrl_reg (intel_dp)) &EDP_FORCE_VDD ) !=0 ; } static void
@@ -262,19 +315,15 @@ intel_dp_check_edp(struct intel_dp *intel_dp) {struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private; -u32 pp_stat_reg, pp_ctrl_reg;if (!is_edp (intel_dp))return ; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; -if (!ironlake_edp_have_panel_power (intel_dp) && !ironlake_edp_have_panel_vdd (intel_dp)) {WARN (1 ,"eDP powered off while attempting aux channel communication.\n" );DRM_DEBUG_KMS ("Status 0x%08x Control 0x%08x\n" , -I915_READ (pp_stat_reg), -I915_READ (pp_ctrl_reg)); +I915_READ (_pp_stat_reg (intel_dp)), +I915_READ (_pp_ctrl_reg (intel_dp))); } }
@@ -948,8 +997,8 @@ static void ironlake_wait_panel_status(struct intel_dp *intel_dp,struct drm_i915_private *dev_priv = dev->dev_private;u32 pp_stat_reg, pp_ctrl_reg; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_stat_reg =_pp_stat_reg (intel_dp); + pp_ctrl_reg =_pp_ctrl_reg (intel_dp); DRM_DEBUG_KMS("mask %08x value %08x status %08x control %08x\n", mask, value,
@@ -991,11 +1040,8 @@ static u32 ironlake_get_pp_control(struct intel_dp *intel_dp)struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private;u32 control; -u32 pp_ctrl_reg; - - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; - control =I915_READ (pp_ctrl_reg); + control =I915_READ (_pp_ctrl_reg (intel_dp)); control &= ~PANEL_UNLOCK_MASK ; control |=PANEL_UNLOCK_REGS ;return control;
@@ -1028,8 +1074,8 @@ void ironlake_edp_panel_vdd_on(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp |=EDP_FORCE_VDD ; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_stat_reg =_pp_stat_reg (intel_dp); + pp_ctrl_reg =_pp_ctrl_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1057,8 +1103,8 @@ static void ironlake_panel_vdd_off_sync(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp &= ~EDP_FORCE_VDD ; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_stat_reg =_pp_ctrl_reg (intel_dp); + pp_ctrl_reg =_pp_stat_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1123,20 +1169,19 @@ void ironlake_edp_panel_on(struct intel_dp *intel_dp)ironlake_wait_panel_power_cycle (intel_dp); + pp_ctrl_reg =_pp_ctrl_reg (intel_dp); pp =ironlake_get_pp_control (intel_dp);if (IS_GEN5 (dev)) {/* ILK workaround: disable reset around power sequence */ pp &= ~PANEL_POWER_RESET ; -I915_WRITE (PCH_PP_CONTROL , pp); -POSTING_READ (PCH_PP_CONTROL ); +I915_WRITE (pp_ctrl_reg, pp); +POSTING_READ (pp_ctrl_reg); } pp |=POWER_TARGET_ON ;if (!IS_GEN5 (dev)) pp |=PANEL_POWER_RESET ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; -I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1144,8 +1189,8 @@ void ironlake_edp_panel_on(struct intel_dp *intel_dp)if (IS_GEN5 (dev)) { pp |=PANEL_POWER_RESET ;/* restore panel reset bit */ -I915_WRITE (PCH_PP_CONTROL , pp); -POSTING_READ (PCH_PP_CONTROL ); +I915_WRITE (pp_ctrl_reg, pp); +POSTING_READ (pp_ctrl_reg); } }
@@ -1168,7 +1213,7 @@ void ironlake_edp_panel_off(struct intel_dp *intel_dp)* panels get very unhappy and cease to work. */ pp &= ~(POWER_TARGET_ON |EDP_FORCE_VDD |PANEL_POWER_RESET |EDP_BLC_ENABLE ); - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_ctrl_reg =_pp_ctrl_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1201,7 +1246,7 @@ void ironlake_edp_backlight_on(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp |=EDP_BLC_ENABLE ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_ctrl_reg =_pp_ctrl_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1225,7 +1270,7 @@ void ironlake_edp_backlight_off(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp &= ~EDP_BLC_ENABLE ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_ctrl_reg =_pp_ctrl_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1752,6 +1797,7 @@ static void vlv_pre_enable_dp(struct intel_encoder *encoder)struct intel_crtc *intel_crtc =to_intel_crtc (encoder->base.crtc);int port =vlv_dport_to_channel (dport);int pipe = intel_crtc->pipe; +struct edp_power_seq power_seq;u32 val;mutex_lock (&dev_priv->dpio_lock);
@@ -1769,6 +1815,10 @@ static void vlv_pre_enable_dp(struct intel_encoder *encoder)mutex_unlock (&dev_priv->dpio_lock); +/* init power sequencer on this pipe and port */ +intel_dp_init_panel_power_sequencer (dev, intel_dp, &power_seq); +intel_dp_init_panel_power_sequencer_registers (dev, intel_dp, &power_seq); +intel_enable_dp (encoder);vlv_wait_port_ready (dev_priv, port);
@@ -3161,24 +3211,26 @@ intel_dp_init_panel_power_sequencer(struct drm_device *dev,struct drm_i915_private *dev_priv = dev->dev_private;struct edp_power_seq cur, vbt, spec, final;u32 pp_on, pp_off, pp_div, pp; -int pp_control_reg, pp_on_reg, pp_off_reg, pp_div_reg; +int pp_ctrl_reg, pp_on_reg, pp_off_reg, pp_div_reg;if (HAS_PCH_SPLIT (dev)) { - pp_control_reg =PCH_PP_CONTROL ; + pp_ctrl_reg =PCH_PP_CONTROL ; pp_on_reg =PCH_PP_ON_DELAYS ; pp_off_reg =PCH_PP_OFF_DELAYS ; pp_div_reg =PCH_PP_DIVISOR ; }else { - pp_control_reg =PIPEA_PP_CONTROL ; - pp_on_reg =PIPEA_PP_ON_DELAYS ; - pp_off_reg =PIPEA_PP_OFF_DELAYS ; - pp_div_reg =PIPEA_PP_DIVISOR ; +enum pipe pipe =vlv_power_sequencer_pipe (intel_dp); + + pp_ctrl_reg =VLV_PIPE_PP_CONTROL (pipe); + pp_on_reg =VLV_PIPE_PP_ON_DELAYS (pipe); + pp_off_reg =VLV_PIPE_PP_OFF_DELAYS (pipe); + pp_div_reg =VLV_PIPE_PP_DIVISOR (pipe); }/* Workaround: Need to write PP_CONTROL with the unlock key as * the very first thing. */ pp =ironlake_get_pp_control (intel_dp); -I915_WRITE (pp_control_reg, pp); +I915_WRITE (pp_ctrl_reg, pp); pp_on =I915_READ (pp_on_reg); pp_off =I915_READ (pp_off_reg);
@@ -3266,9 +3318,11 @@ intel_dp_init_panel_power_sequencer_registers(struct drm_device *dev, pp_off_reg =PCH_PP_OFF_DELAYS ; pp_div_reg =PCH_PP_DIVISOR ; }else { - pp_on_reg =PIPEA_PP_ON_DELAYS ; - pp_off_reg =PIPEA_PP_OFF_DELAYS ; - pp_div_reg =PIPEA_PP_DIVISOR ; +enum pipe pipe =vlv_power_sequencer_pipe (intel_dp); + + pp_on_reg =VLV_PIPE_PP_ON_DELAYS (pipe); + pp_off_reg =VLV_PIPE_PP_OFF_DELAYS (pipe); + pp_div_reg =VLV_PIPE_PP_DIVISOR (pipe); }/* And finally store the new values in the power sequencer. */
@@ -3285,7 +3339,10 @@ intel_dp_init_panel_power_sequencer_registers(struct drm_device *dev,/* Haswell doesn't have any port selection bits for the panel * power sequencer any more. */ if (IS_VALLEYVIEW (dev)) { - port_sel =I915_READ (pp_on_reg) &0xc0000000 ; +if (dp_to_dig_port (intel_dp)->port ==PORT_B ) + port_sel =PANEL_PORT_SELECT_DPB_VLV ; +else + port_sel =PANEL_PORT_SELECT_DPC_VLV ; }else if (HAS_PCH_IBX (dev) ||HAS_PCH_CPT (dev)) {if (dp_to_dig_port (intel_dp)->port ==PORT_A ) port_sel =PANEL_PORT_SELECT_DPA ;
Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 1/4] drm/i915: name intel dp hooks per platform
In reply to Jani NikulaQuoted 43 lines · Jani Nikula
In line with the rest of the code base. No functional changes.
Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/intel_dp.c +6
-4@@ -1720,6 +1720,11 @@ static void intel_enable_dp(struct intel_encoder *encoder)ironlake_edp_backlight_on (intel_dp); } +static void g4x_enable_dp (struct intel_encoder *encoder) +{ +intel_enable_dp (encoder); +} +static void vlv_enable_dp (struct intel_encoder *encoder) { }@@ -1764,7 +1769,7 @@ static void vlv_pre_enable_dp(struct intel_encoder *encoder)vlv_wait_port_ready (dev_priv, port); } -static void intel_dp_pre_pll_enable (struct intel_encoder *encoder) +static void vlv_dp_pre_pll_enable (struct intel_encoder *encoder) {struct intel_digital_port *dport =enc_to_dig_port (&encoder->base);struct drm_device *dev = encoder->base.dev;@@ -1774,9 +1779,6 @@ static void intel_dp_pre_pll_enable(struct intel_encoder *encoder)int port =vlv_dport_to_channel (dport);int pipe = intel_crtc->pipe; -if (!IS_VALLEYVIEW (dev)) -return ; -/* Program Tx lane resets to default */ mutex_lock (&dev_priv->dpio_lock); vlv_dpio_write(dev_priv, pipe, DPIO_PCS_TX(port),
drivers/gpu/drm/i915/intel_dp.c intel_dp_init(struct drm_device *dev, int output_reg, enum port port) · line 3558
Quoted 9 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -3549,12 +3551,12 @@ intel_dp_init(struct drm_device *dev, int output_reg, enum port port) intel_encoder->get_hw_state = intel_dp_get_hw_state; intel_encoder->get_config = intel_dp_get_config;if (IS_VALLEYVIEW (dev)) { - intel_encoder->pre_pll_enable = intel_dp_pre_pll_enable; + intel_encoder->pre_pll_enable = vlv_dp_pre_pll_enable; intel_encoder->pre_enable = vlv_pre_enable_dp; intel_encoder->enable = vlv_enable_dp; }else { intel_encoder->pre_enable = intel_pre_enable_dp;
^^^^^
Should get renamed to g4x too for consistency.
Quoted 7 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1- intel_encoder->enable = intel_enable_dp; + intel_encoder->enable = g4x_enable_dp; } intel_dig_port->port = port;Signature · 1 line
1.7.9.5
Signature · 2 lines
Ville Syrjälä Intel OTC
PATCH 1/1 drm/i915: name intel dp hooks per platform
In line with the rest of the code base. No functional changes.
v2: also s/intel_pre_enable_dp/g4x_pre_enable_dp/ for consistency (Ville)
--- drivers/gpu/drm/i915/intel_dp.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +10 -8
@@ -1720,11 +1720,16 @@ static void intel_enable_dp(struct intel_encoder *encoder)ironlake_edp_backlight_on (intel_dp); } +static void g4x_enable_dp (struct intel_encoder *encoder) +{ +intel_enable_dp (encoder); +} +static void vlv_enable_dp (struct intel_encoder *encoder) { } -static void intel_pre_enable_dp (struct intel_encoder *encoder) +static void g4x_pre_enable_dp (struct intel_encoder *encoder) {struct intel_dp *intel_dp =enc_to_intel_dp (&encoder->base);struct intel_digital_port *dport =dp_to_dig_port (intel_dp);
@@ -1764,7 +1769,7 @@ static void vlv_pre_enable_dp(struct intel_encoder *encoder)vlv_wait_port_ready (dev_priv, port); } -static void intel_dp_pre_pll_enable (struct intel_encoder *encoder) +static void vlv_dp_pre_pll_enable (struct intel_encoder *encoder) {struct intel_digital_port *dport =enc_to_dig_port (&encoder->base);struct drm_device *dev = encoder->base.dev;
@@ -1774,9 +1779,6 @@ static void intel_dp_pre_pll_enable(struct intel_encoder *encoder)int port =vlv_dport_to_channel (dport);int pipe = intel_crtc->pipe; -if (!IS_VALLEYVIEW (dev)) -return ; -/* Program Tx lane resets to default */ mutex_lock (&dev_priv->dpio_lock); vlv_dpio_write(dev_priv, pipe, DPIO_PCS_TX(port),
@@ -3549,12 +3551,12 @@ intel_dp_init(struct drm_device *dev, int output_reg, enum port port) intel_encoder->get_hw_state = intel_dp_get_hw_state; intel_encoder->get_config = intel_dp_get_config;if (IS_VALLEYVIEW (dev)) { - intel_encoder->pre_pll_enable = intel_dp_pre_pll_enable; + intel_encoder->pre_pll_enable = vlv_dp_pre_pll_enable; intel_encoder->pre_enable = vlv_pre_enable_dp; intel_encoder->enable = vlv_enable_dp; }else { - intel_encoder->pre_enable = intel_pre_enable_dp; - intel_encoder->enable = intel_enable_dp; + intel_encoder->pre_enable = g4x_pre_enable_dp; + intel_encoder->enable = g4x_enable_dp; } intel_dig_port->port = port;
Signature · 1 line
1.7.10.4
PATCH 1/1 drm/i915: add support for per-pipe power sequencing on vlv
In reply to Jani NikulaVLV has per-pipe PP registers. Set up power sequencing on mode set. The connector init time setup is problematic, since we don't have a pipe at that time. Cook up something.
v2:
- use vlv_power_sequencer_pipe() also in _pp_{ctrl,stat}_reg()
- use PANEL_PORT_SELECT_DPC_VLV (Ville)
v3: make checkpatch happier
--- drivers/gpu/drm/i915/intel_dp.c | 141 +++++++++++++++++++++++++++------------ 1 file changed, 99 insertions(+), 42 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +99 -42
@@ -237,24 +237,77 @@ intel_hrawclk(struct drm_device *dev) } } +static void +intel_dp_init_panel_power_sequencer (struct drm_device *dev, +struct intel_dp *intel_dp, +struct edp_power_seq *out); +static void +intel_dp_init_panel_power_sequencer_registers (struct drm_device *dev, +struct intel_dp *intel_dp, +struct edp_power_seq *out); + +static enum pipe +vlv_power_sequencer_pipe (struct intel_dp *intel_dp) +{ +struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); +struct drm_crtc *crtc = intel_dig_port->base.base.crtc; +struct drm_device *dev = intel_dig_port->base.base.dev; +struct drm_i915_private *dev_priv = dev->dev_private; +enum port port = intel_dig_port->port; +enum pipe pipe; + +/* modeset should have pipe */ +if (crtc) +return to_intel_crtc (crtc)->pipe; + +/* init time, try to find a pipe with this port selected */ +for (pipe =PIPE_A ; pipe <=PIPE_B ; pipe++) { +u32 port_sel =I915_READ (VLV_PIPE_PP_ON_DELAYS (pipe)) & +PANEL_PORT_SELECT_MASK ; +if (port_sel ==PANEL_PORT_SELECT_DPB_VLV && port ==PORT_B ) +return pipe; +else if (port_sel ==PANEL_PORT_SELECT_DPC_VLV && port ==PORT_C ) +return pipe; + } + +/* shrug */ +return PIPE_A ; +} + +static u32 _pp_ctrl_reg (struct intel_dp *intel_dp) +{ +struct drm_device *dev =intel_dp_to_dev (intel_dp); + +if (HAS_PCH_SPLIT (dev)) +return PCH_PP_CONTROL ; +else +return VLV_PIPE_PP_CONTROL (vlv_power_sequencer_pipe (intel_dp)); +} + +static u32 _pp_stat_reg (struct intel_dp *intel_dp) +{ +struct drm_device *dev =intel_dp_to_dev (intel_dp); + +if (HAS_PCH_SPLIT (dev)) +return PCH_PP_STATUS ; +else +return VLV_PIPE_PP_STATUS (vlv_power_sequencer_pipe (intel_dp)); +} +static bool ironlake_edp_have_panel_power (struct intel_dp *intel_dp) {struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private; -u32 pp_stat_reg; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; -return (I915_READ (pp_stat_reg) &PP_ON ) !=0 ; +return (I915_READ (_pp_stat_reg (intel_dp)) &PP_ON ) !=0 ; }static bool ironlake_edp_have_panel_vdd (struct intel_dp *intel_dp) {struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private; -u32 pp_ctrl_reg; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; -return (I915_READ (pp_ctrl_reg) &EDP_FORCE_VDD ) !=0 ; +return (I915_READ (_pp_ctrl_reg (intel_dp)) &EDP_FORCE_VDD ) !=0 ; } static void
@@ -262,19 +315,15 @@ intel_dp_check_edp(struct intel_dp *intel_dp) {struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private; -u32 pp_stat_reg, pp_ctrl_reg;if (!is_edp (intel_dp))return ; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; -if (!ironlake_edp_have_panel_power (intel_dp) && !ironlake_edp_have_panel_vdd (intel_dp)) {WARN (1 ,"eDP powered off while attempting aux channel communication.\n" );DRM_DEBUG_KMS ("Status 0x%08x Control 0x%08x\n" , -I915_READ (pp_stat_reg), -I915_READ (pp_ctrl_reg)); +I915_READ (_pp_stat_reg (intel_dp)), +I915_READ (_pp_ctrl_reg (intel_dp))); } }
@@ -948,8 +997,8 @@ static void ironlake_wait_panel_status(struct intel_dp *intel_dp,struct drm_i915_private *dev_priv = dev->dev_private;u32 pp_stat_reg, pp_ctrl_reg; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_stat_reg =_pp_stat_reg (intel_dp); + pp_ctrl_reg =_pp_ctrl_reg (intel_dp); DRM_DEBUG_KMS("mask %08x value %08x status %08x control %08x\n", mask, value,
@@ -991,11 +1040,8 @@ static u32 ironlake_get_pp_control(struct intel_dp *intel_dp)struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private;u32 control; -u32 pp_ctrl_reg; - - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; - control =I915_READ (pp_ctrl_reg); + control =I915_READ (_pp_ctrl_reg (intel_dp)); control &= ~PANEL_UNLOCK_MASK ; control |=PANEL_UNLOCK_REGS ;return control;
@@ -1028,8 +1074,8 @@ void ironlake_edp_panel_vdd_on(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp |=EDP_FORCE_VDD ; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_stat_reg =_pp_stat_reg (intel_dp); + pp_ctrl_reg =_pp_ctrl_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1057,8 +1103,8 @@ static void ironlake_panel_vdd_off_sync(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp &= ~EDP_FORCE_VDD ; - pp_stat_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_STATUS :PCH_PP_STATUS ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_stat_reg =_pp_ctrl_reg (intel_dp); + pp_ctrl_reg =_pp_stat_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1123,20 +1169,19 @@ void ironlake_edp_panel_on(struct intel_dp *intel_dp)ironlake_wait_panel_power_cycle (intel_dp); + pp_ctrl_reg =_pp_ctrl_reg (intel_dp); pp =ironlake_get_pp_control (intel_dp);if (IS_GEN5 (dev)) {/* ILK workaround: disable reset around power sequence */ pp &= ~PANEL_POWER_RESET ; -I915_WRITE (PCH_PP_CONTROL , pp); -POSTING_READ (PCH_PP_CONTROL ); +I915_WRITE (pp_ctrl_reg, pp); +POSTING_READ (pp_ctrl_reg); } pp |=POWER_TARGET_ON ;if (!IS_GEN5 (dev)) pp |=PANEL_POWER_RESET ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; -I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1144,8 +1189,8 @@ void ironlake_edp_panel_on(struct intel_dp *intel_dp)if (IS_GEN5 (dev)) { pp |=PANEL_POWER_RESET ;/* restore panel reset bit */ -I915_WRITE (PCH_PP_CONTROL , pp); -POSTING_READ (PCH_PP_CONTROL ); +I915_WRITE (pp_ctrl_reg, pp); +POSTING_READ (pp_ctrl_reg); } }
@@ -1168,7 +1213,7 @@ void ironlake_edp_panel_off(struct intel_dp *intel_dp)* panels get very unhappy and cease to work. */ pp &= ~(POWER_TARGET_ON |EDP_FORCE_VDD |PANEL_POWER_RESET |EDP_BLC_ENABLE ); - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_ctrl_reg =_pp_ctrl_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1201,7 +1246,7 @@ void ironlake_edp_backlight_on(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp |=EDP_BLC_ENABLE ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_ctrl_reg =_pp_ctrl_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1225,7 +1270,7 @@ void ironlake_edp_backlight_off(struct intel_dp *intel_dp) pp =ironlake_get_pp_control (intel_dp); pp &= ~EDP_BLC_ENABLE ; - pp_ctrl_reg =IS_VALLEYVIEW (dev) ?PIPEA_PP_CONTROL :PCH_PP_CONTROL ; + pp_ctrl_reg =_pp_ctrl_reg (intel_dp);I915_WRITE (pp_ctrl_reg, pp);POSTING_READ (pp_ctrl_reg);
@@ -1752,6 +1797,7 @@ static void vlv_pre_enable_dp(struct intel_encoder *encoder)struct intel_crtc *intel_crtc =to_intel_crtc (encoder->base.crtc);int port =vlv_dport_to_channel (dport);int pipe = intel_crtc->pipe; +struct edp_power_seq power_seq;u32 val;mutex_lock (&dev_priv->dpio_lock);
@@ -1769,6 +1815,10 @@ static void vlv_pre_enable_dp(struct intel_encoder *encoder)mutex_unlock (&dev_priv->dpio_lock); +/* init power sequencer on this pipe and port */ +intel_dp_init_panel_power_sequencer (dev, intel_dp, &power_seq); +intel_dp_init_panel_power_sequencer_registers (dev, intel_dp, &power_seq); +intel_enable_dp (encoder);vlv_wait_port_ready (dev_priv, port);
@@ -3161,24 +3211,26 @@ intel_dp_init_panel_power_sequencer(struct drm_device *dev,struct drm_i915_private *dev_priv = dev->dev_private;struct edp_power_seq cur, vbt, spec, final;u32 pp_on, pp_off, pp_div, pp; -int pp_control_reg, pp_on_reg, pp_off_reg, pp_div_reg; +int pp_ctrl_reg, pp_on_reg, pp_off_reg, pp_div_reg;if (HAS_PCH_SPLIT (dev)) { - pp_control_reg =PCH_PP_CONTROL ; + pp_ctrl_reg =PCH_PP_CONTROL ; pp_on_reg =PCH_PP_ON_DELAYS ; pp_off_reg =PCH_PP_OFF_DELAYS ; pp_div_reg =PCH_PP_DIVISOR ; }else { - pp_control_reg =PIPEA_PP_CONTROL ; - pp_on_reg =PIPEA_PP_ON_DELAYS ; - pp_off_reg =PIPEA_PP_OFF_DELAYS ; - pp_div_reg =PIPEA_PP_DIVISOR ; +enum pipe pipe =vlv_power_sequencer_pipe (intel_dp); + + pp_ctrl_reg =VLV_PIPE_PP_CONTROL (pipe); + pp_on_reg =VLV_PIPE_PP_ON_DELAYS (pipe); + pp_off_reg =VLV_PIPE_PP_OFF_DELAYS (pipe); + pp_div_reg =VLV_PIPE_PP_DIVISOR (pipe); }/* Workaround: Need to write PP_CONTROL with the unlock key as * the very first thing. */ pp =ironlake_get_pp_control (intel_dp); -I915_WRITE (pp_control_reg, pp); +I915_WRITE (pp_ctrl_reg, pp); pp_on =I915_READ (pp_on_reg); pp_off =I915_READ (pp_off_reg);
@@ -3266,9 +3318,11 @@ intel_dp_init_panel_power_sequencer_registers(struct drm_device *dev, pp_off_reg =PCH_PP_OFF_DELAYS ; pp_div_reg =PCH_PP_DIVISOR ; }else { - pp_on_reg =PIPEA_PP_ON_DELAYS ; - pp_off_reg =PIPEA_PP_OFF_DELAYS ; - pp_div_reg =PIPEA_PP_DIVISOR ; +enum pipe pipe =vlv_power_sequencer_pipe (intel_dp); + + pp_on_reg =VLV_PIPE_PP_ON_DELAYS (pipe); + pp_off_reg =VLV_PIPE_PP_OFF_DELAYS (pipe); + pp_div_reg =VLV_PIPE_PP_DIVISOR (pipe); }/* And finally store the new values in the power sequencer. */
@@ -3285,7 +3339,10 @@ intel_dp_init_panel_power_sequencer_registers(struct drm_device *dev,/* Haswell doesn't have any port selection bits for the panel * power sequencer any more. */ if (IS_VALLEYVIEW (dev)) { - port_sel =I915_READ (pp_on_reg) &0xc0000000 ; +if (dp_to_dig_port (intel_dp)->port ==PORT_B ) + port_sel =PANEL_PORT_SELECT_DPB_VLV ; +else + port_sel =PANEL_PORT_SELECT_DPC_VLV ; }else if (HAS_PCH_IBX (dev) ||HAS_PCH_CPT (dev)) {if (dp_to_dig_port (intel_dp)->port ==PORT_A ) port_sel =PANEL_PORT_SELECT_DPA ;
Signature · 6 lines
1.7.10.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] drm/i915: name intel dp hooks per platform
In reply to Jani NikulaQuoted 5 lines · Jani Nikula
In line with the rest of the code base. No functional changes.
v2: also s/intel_pre_enable_dp/g4x_pre_enable_dp/ for consistency (Ville)
Signed-off-by Jani Nikula <[email protected]>
for the series.
Quoted 63 lines
--- drivers/gpu/drm/i915/intel_dp.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)drivers/gpu/drm/i915/intel_dp.c +10
-8@@ -1720,11 +1720,16 @@ static void intel_enable_dp(struct intel_encoder *encoder)ironlake_edp_backlight_on (intel_dp); } +static void g4x_enable_dp (struct intel_encoder *encoder) +{ +intel_enable_dp (encoder); +} +static void vlv_enable_dp (struct intel_encoder *encoder) { } -static void intel_pre_enable_dp (struct intel_encoder *encoder) +static void g4x_pre_enable_dp (struct intel_encoder *encoder) {struct intel_dp *intel_dp =enc_to_intel_dp (&encoder->base);struct intel_digital_port *dport =dp_to_dig_port (intel_dp);@@ -1764,7 +1769,7 @@ static void vlv_pre_enable_dp(struct intel_encoder *encoder)vlv_wait_port_ready (dev_priv, port); } -static void intel_dp_pre_pll_enable (struct intel_encoder *encoder) +static void vlv_dp_pre_pll_enable (struct intel_encoder *encoder) {struct intel_digital_port *dport =enc_to_dig_port (&encoder->base);struct drm_device *dev = encoder->base.dev;@@ -1774,9 +1779,6 @@ static void intel_dp_pre_pll_enable(struct intel_encoder *encoder)int port =vlv_dport_to_channel (dport);int pipe = intel_crtc->pipe; -if (!IS_VALLEYVIEW (dev)) -return ; -/* Program Tx lane resets to default */ mutex_lock (&dev_priv->dpio_lock); vlv_dpio_write(dev_priv, pipe, DPIO_PCS_TX(port),@@ -3549,12 +3551,12 @@ intel_dp_init(struct drm_device *dev, int output_reg, enum port port) intel_encoder->get_hw_state = intel_dp_get_hw_state; intel_encoder->get_config = intel_dp_get_config;if (IS_VALLEYVIEW (dev)) { - intel_encoder->pre_pll_enable = intel_dp_pre_pll_enable; + intel_encoder->pre_pll_enable = vlv_dp_pre_pll_enable; intel_encoder->pre_enable = vlv_pre_enable_dp; intel_encoder->enable = vlv_enable_dp; }else { - intel_encoder->pre_enable = intel_pre_enable_dp; - intel_encoder->enable = intel_enable_dp; + intel_encoder->pre_enable = g4x_pre_enable_dp; + intel_encoder->enable = g4x_enable_dp; } intel_dig_port->port = port;Signature · 1 line
1.7.10.4
Signature · 2 lines
Ville Syrjälä Intel OTC
Re: [PATCH] drm/i915: add support for per-pipe power sequencing on vlv
In reply to Jani NikulaQuoted 4 lines · Jani Nikula
VLV has per-pipe PP registers. Set up power sequencing on mode set. The connector init time setup is problematic, since we don't have a pipe at that time. Cook up something.
Quoted 8 lines
v2:
- usevlv_power_sequencer_pipe()also in _pp_{ctrl,stat}_reg()
- usePANEL_PORT_SELECT_DPC_VLV(Ville)v3: make checkpatch happier
Signed-off-by Jani Nikula <[email protected]>Reviewed-by Ville Syrjälä <[email protected]>
Series merged, thanks for patches&review. Although I couldn't resist to make this one here completely checkpatch clean, after all you've bothered to resend it ;-)
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Re: [PATCH] drm/i915: add support for per-pipe power sequencing on vlv
Quoted 9 lines · Daniel Vetter
Quoted 8 lines · Jani Nikula
VLV has per-pipe PP registers. Set up power sequencing on mode set. The connector init time setup is problematic, since we don't have a pipe at that time. Cook up something.
v2:
- usevlv_power_sequencer_pipe()also in _pp_{ctrl,stat}_reg()
- usePANEL_PORT_SELECT_DPC_VLV(Ville)
Quoted 8 lines
Quoted 4 lines
v3: make checkpatch happier
Signed-off-by Jani Nikula <[email protected]>Reviewed-by Ville Syrjälä <[email protected]>Series merged, thanks for patches&review. Although I couldn't resist to make this one here completely checkpatch clean, after all you've bothered to resend it ;-)
Hah, I didn't bother with the 80-column rule. Nice of you to bring checkpatch flowers and all... though you cheated with the 'else if'! ;)
Cheers,
Jani.
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx