iproute2: explicitly add 'bash' to its RDEPENDS

PATCH In review [email protected] 3 participants 6 messages Oct 30, 2013 – Oct 31, 2013

lore

Share & tools

lore

[email protected]

author

2013-10-30 02:06 UTC #0 lore raw

cover iproute2: explicitly add 'bash' to its RDEPENDS

From: Chen Qi <[email protected]>

The following changes since commit d69931da48b9cc5082feb46c654b9861f30244d9:

scripts/oe-pkgdata-util: fix global name 'debug' is not defined (2013-10-29 15:24:07 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib ChenQi/iproute2
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/iproute2

Chen Qi (1):
iproute2: explicitly add 'bash' to its RDEPENDS

 meta/recipes-connectivity/iproute2/iproute2.inc |    1 +
 1 file changed, 1 insertion(+)

Signature · 1 line

1.7.9.5

[email protected]

author

2013-10-30 02:06 UTC #1 lore raw

PATCH 1/1 iproute2: explicitly add 'bash' to its RDEPENDS

From: Chen Qi <[email protected]>

If we build a minimal image with iproute2 installed, the following error will appear during rootfs.

error: Can't install iproute2-3.10.0-r0.0@i586: no package provides /bin/bash

The problem is that iproute2 has an implicit dependency on 'bash'. This dependency is from per-file dependency checking. But as 'bash' is not explicitly specified in the RDEPENDS in recipe, it's not built. This leads to the above error.

Fix this problem by explicitly adding 'bash' to the RDEPENDS.

[YOCTO #5415]

Signed-off-by Chen Qi <[email protected]>

---
 meta/recipes-connectivity/iproute2/iproute2.inc |    1 +
 1 file changed, 1 insertion(+)

meta/recipes-connectivity/iproute2/iproute2.inc +1 -0

index 3db21db..40f6a6c 100644
@@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
                     file://ip/ip.c;beginline=3;endline=8;md5=689d691d0410a4b64d3899f8d6e31817"
 
 DEPENDS = "flex-native bison-native iptables"
+RDEPENDS_${PN} = "bash"
 
 inherit update-alternatives

Signature · 1 line

1.7.9.5

Khem Raj

2013-10-31 03:32 UTC #2 lore raw

Quoted 11 lines · On Tue, Oct 29, 2013 at 7:07 PM, <[email protected]> wrote:

From: Chen Qi <[email protected]>
If we build a minimal image with iproute2 installed, the following error will appear during rootfs.
error: Can't install iproute2-3.10.0-r0.0@i586: no package provides /bin/bash
The problem is that iproute2 has an implicit dependency on 'bash'. This dependency is from per-file dependency checking. But as 'bash' is not explicitly specified in the RDEPENDS in recipe, it's not built. This leads to the above error.

To be a bit more surgical if you could figure out which script is it which is asking for it that will help
to determine if we can create a separate package for these scripts which have dependency on bash and then create a RDEPEND for this new package instead.

Quoted 29 lines

Fix this problem by explicitly adding 'bash' to the RDEPENDS.
[YOCTO #5415]
Signed-off-by Chen Qi <[email protected]>
---
 meta/recipes-connectivity/iproute2/iproute2.inc |    1 +
 1 file changed, 1 insertion(+)
meta/recipes-connectivity/iproute2/iproute2.inc +1 -1
index 3db21db..40f6a6c 100644
@@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
                     file://ip/ip.c;beginline=3;endline=8;md5=689d691d0410a4b64d3899f8d6e31817"
 
 DEPENDS = "flex-native bison-native iptables"
+RDEPENDS_${PN} = "bash"
 
 inherit update-alternatives
 
--
1.7.9.5
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

ChenQi

author

2013-10-31 04:40 UTC #3 lore raw

Quoted 8 lines · Khem Raj

Quoted 7 lines · On Tue, Oct 29, 2013 at 7:07 PM, <[email protected]> wrote:
From: Chen Qi <[email protected]>
If we build a minimal image with iproute2 installed, the following error will appear during rootfs.
error: Can't install iproute2-3.10.0-r0.0@i586: no package provides /bin/bash

Quoted 8 lines

Quoted 4 lines
The problem is that iproute2 has an implicit dependency on 'bash'. This dependency is from per-file dependency checking. But as 'bash' is not explicitly specified in the RDEPENDS in recipe, it's not built. This leads to the above error.
To be a bit more surgical if you could figure out which script is it which is asking for it that will help
to determine if we can create a separate package for these scripts which have dependency on bash and then create a RDEPEND for this new package instead.

/sbin/ifcfg and /sbin/rtpr.

Here's a grep result from the package/ directory of iproute2. iproute2/3.10.0-r0/package [1] $ grep -R '/bin/bash' ./* ./sbin/ifcfg:#! /bin/bash
./sbin/rtpr:#! /bin/bash ./usr/share/doc/iproute2/examples/cbq.init-v0.7.3:#!/bin/bash ./usr/share/doc/iproute2/examples/dhcp-client-script:#!/bin/bash ./usr/share/doc/iproute2/ip-cref.tex:#! /bin/bash ./usr/share/doc/iproute2/ip-cref.tex:#! /bin/bash

Best Regards,
Chen Qi

Quoted 29 lines

Quoted 28 lines
Fix this problem by explicitly adding 'bash' to the RDEPENDS.
[YOCTO #5415]
Signed-off-by Chen Qi <[email protected]>
---
  meta/recipes-connectivity/iproute2/iproute2.inc |    1 +
  1 file changed, 1 insertion(+)
meta/recipes-connectivity/iproute2/iproute2.inc +1 -1
index 3db21db..40f6a6c 100644
@@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
                      file://ip/ip.c;beginline=3;endline=8;md5=689d691d0410a4b64d3899f8d6e31817"
 
  DEPENDS = "flex-native bison-native iptables"
+RDEPENDS_${PN} = "bash"
 
  inherit update-alternatives
 
--
1.7.9.5
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Saul Wold

2013-10-31 05:39 UTC #4 lore raw

Quoted 20 lines · ChenQi

Quoted 13 lines · Khem Raj
Quoted 5 lines · On Tue, Oct 29, 2013 at 7:07 PM, <[email protected]> wrote:
From: Chen Qi <[email protected]>
If we build a minimal image with iproute2 installed, the following error will appear during rootfs.
Quoted 7 lines
error: Can't install iproute2-3.10.0-r0.0@i586: no package provides /bin/bash
The problem is that iproute2 has an implicit dependency on 'bash'. This dependency is from per-file dependency checking. But as 'bash' is not explicitly specified in the RDEPENDS in recipe, it's not built. This leads to the above error.
Quoted 5 lines
To be a bit more surgical if you could figure out which script is it which is asking for it that will help
to determine if we can create a separate package for these scripts which have dependency on bash and then create a RDEPEND for this new package instead.

Quoted 6 lines

/sbin/ifcfg and /sbin/rtpr.
Here's a grep result from the package/ directory of iproute2. iproute2/3.10.0-r0/package [1] $ grep -R '/bin/bash' ./* ./sbin/ifcfg:#! /bin/bash
./sbin/rtpr:#! /bin/bash

Can we de-bash these? Upstream might take a patch for that.

Quoted 2 lines

./usr/share/doc/iproute2/examples/cbq.init-v0.7.3:#!/bin/bash ./usr/share/doc/iproute2/examples/dhcp-client-script:#!/bin/bash

These are example scripts, can we move them to a seperate package instead of being part of the core package?

Quoted 3 lines

./usr/share/doc/iproute2/ip-cref.tex:#! /bin/bash
./usr/share/doc/iproute2/ip-cref.tex:#! /bin/bash

Same here can we de-bash them or is it more work?

Sau!

Quoted 43 lines

Best Regards,
Chen Qi
Quoted 25 lines
Quoted 25 lines
Fix this problem by explicitly adding 'bash' to the RDEPENDS.
[YOCTO #5415]
Signed-off-by Chen Qi <[email protected]>
---
  meta/recipes-connectivity/iproute2/iproute2.inc |    1 +
  1 file changed, 1 insertion(+)
meta/recipes-connectivity/iproute2/iproute2.inc +0 -0
index 3db21db..40f6a6c 100644
@@ -10,6 +10,7 @@ LIC_FILES_CHKSUM =
 "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
 
file://ip/ip.c;beginline=3;endline=8;md5=689d691d0410a4b64d3899f8d6e31817"
DEPENDS = "flex-native bison-native iptables"
+RDEPENDS_${PN} = "bash"
inherit update-alternatives
Quoted 8 lines
Quoted 7 lines
--
1.7.9.5
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

ChenQi

author

2013-10-31 05:53 UTC #5 lore raw

Quoted 32 lines · Saul Wold

Quoted 20 lines · ChenQi
Quoted 13 lines · Khem Raj
Quoted 5 lines · On Tue, Oct 29, 2013 at 7:07 PM, <[email protected]> wrote:
From: Chen Qi <[email protected]>
If we build a minimal image with iproute2 installed, the following error will appear during rootfs.
Quoted 7 lines
error: Can't install iproute2-3.10.0-r0.0@i586: no package provides /bin/bash
The problem is that iproute2 has an implicit dependency on 'bash'. This dependency is from per-file dependency checking. But as 'bash' is not explicitly specified in the RDEPENDS in recipe, it's not built. This leads to the above error.
Quoted 5 lines
To be a bit more surgical if you could figure out which script is it which is asking for it that will help
to determine if we can create a separate package for these scripts which have dependency on bash and then create a RDEPEND for this new package instead.
Quoted 6 lines
/sbin/ifcfg and /sbin/rtpr.
Here's a grep result from the package/ directory of iproute2. iproute2/3.10.0-r0/package [1] $ grep -R '/bin/bash' ./* ./sbin/ifcfg:#! /bin/bash
./sbin/rtpr:#! /bin/bash
Can we de-bash these? Upstream might take a patch for that.
Quoted 2 lines
./usr/share/doc/iproute2/examples/cbq.init-v0.7.3:#!/bin/bash ./usr/share/doc/iproute2/examples/dhcp-client-script:#!/bin/bash

Quoted 9 lines

These are example scripts, can we move them to a seperate package instead of being part of the core package?
Quoted 3 lines
./usr/share/doc/iproute2/ip-cref.tex:#! /bin/bash
./usr/share/doc/iproute2/ip-cref.tex:#! /bin/bash
Same here can we de-bash them or is it more work?
Sau!

Hi Saul,

I'll make a new patch to de-bash these scripts.

Best Regards,
Chen Qi

Quoted 46 lines

Quoted 44 lines
Best Regards,
Chen Qi
Quoted 26 lines
Quoted 26 lines
Fix this problem by explicitly adding 'bash' to the RDEPENDS.
[YOCTO #5415]
Signed-off-by Chen Qi <[email protected]>
---
  meta/recipes-connectivity/iproute2/iproute2.inc |    1 +
  1 file changed, 1 insertion(+)
meta/recipes-connectivity/iproute2/iproute2.inc +0 -0
index 3db21db..40f6a6c 100644
@@ -10,6 +10,7 @@ LIC_FILES_CHKSUM =
 "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
 
file://ip/ip.c;beginline=3;endline=8;md5=689d691d0410a4b64d3899f8d6e31817"
DEPENDS = "flex-native bison-native iptables"
+RDEPENDS_${PN} = "bash"
inherit update-alternatives
Quoted 8 lines
Quoted 7 lines
Signature · 6 lines
1.7.9.5

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core