flex: fix m4 issue on target
v2 cover flex: fix m4 issue on target
v2:
* changed the implementation as per Enrico Scholz's suggestion (thanks);
Laurentiu
The following changes since commit d6cc7c8ed76c8b1117cf03c7bd4b0742f98f79b3:
toolchain-scripts/meta-environment: Further cleanup code duplication (2013-11-06 11:02:27 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib lpalcu/b5329_flex_issue_target
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=lpalcu/b5329_flex_issue_target
Laurentiu Palcu (1):
flex: fix m4 issue on target
meta/recipes-devtools/flex/flex.inc | 5 +++++ 1 file changed, 5 insertions(+)
Signature · 1 line
1.7.9.5
PATCH v2 1/1 flex: fix m4 issue on target
Flex needs m4 to run (see below) and, since the create_wrapper introduces a bash dependency on target, give the path to m4 binary in the configure command line.
Snippet from the flex documentation:
"The macro processor m4 must be installed wherever flex is installed. <...>
m4 is only required at the time you run flex."
[YOCTO #5329]
--- meta/recipes-devtools/flex/flex.inc | 5 +++++ 1 file changed, 5 insertions(+)
meta/recipes-devtools/flex/flex.inc +5 -0
@@ -13,6 +13,9 @@ inherit autotools gettext M4 = "${bindir}/m4" M4_class-native = "${STAGING_BINDIR_NATIVE}/m4" +EXTRA_OECONF += "ac_cv_path_M4=${M4}" +EXTRA_OEMAKE += "m4=${STAGING_BINDIR_NATIVE}/m4" + do_install_append_class-native() { create_wrapper ${D}/${bindir}/flex M4=${M4} }
@@ -20,3 +23,5 @@ do_install_append_class-native() { do_install_append_class-nativesdk() { create_wrapper ${D}/${bindir}/flex M4=${M4} } + +RDEPENDS_${PN} += "m4"
Signature · 1 line
1.7.9.5
Even though this was in the last C-pull, for some reason, it didn't end up in master... Didn't see any comments on it either. Or maybe I missed them...
Thanks,
Laurentiu
Quoted 43 lines · Laurentiu Palcu
Flex needs m4 to run (see below) and, since the
create_wrapperintroduces a bash dependency on target, give the path to m4 binary in the configure command line.Snippet from the flex documentation:
"The macro processor m4 must be installed wherever flex is installed. <...>
m4 is only required at the time you run flex."[YOCTO #5329]
Signed-off-by Laurentiu Palcu <[email protected]>--- meta/recipes-devtools/flex/flex.inc | 5 +++++ 1 file changed, 5 insertions(+)meta/recipes-devtools/flex/flex.inc +5
-0@@ -13,6 +13,9 @@ inherit autotools gettext M4 = "${bindir}/m4" M4_class-native = "${STAGING_BINDIR_NATIVE}/m4" +EXTRA_OECONF += "ac_cv_path_M4=${M4}" +EXTRA_OEMAKE += "m4=${STAGING_BINDIR_NATIVE}/m4" + do_install_append_class-native() { create_wrapper ${D}/${bindir}/flex M4=${M4} }@@ -20,3 +23,5 @@ do_install_append_class-native() { do_install_append_class-nativesdk() { create_wrapper ${D}/${bindir}/flex M4=${M4} } + +RDEPENDS_${PN} += "m4"Signature · 6 lines
1.7.9.5 _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 3 lines · Laurentiu Palcu
Even though this was in the last C-pull, for some reason, it didn't end up in master... Didn't see any comments on it either. Or maybe I missed them...
In the target case, M4 should be compiled in as ${bindir}/m4 and there should be no need of a wrapper. Can someone confirm this is the case? Is the OEMAKE command only used for compilation and not built into the target?
Cheers,
Richard
Quoted 48 lines
Thanks,
LaurentiuQuoted 43 lines · Laurentiu Palcu
Flex needs m4 to run (see below) and, since the
create_wrapperintroduces a bash dependency on target, give the path to m4 binary in the configure command line.Snippet from the flex documentation:
"The macro processor m4 must be installed wherever flex is installed. <...>
m4 is only required at the time you run flex."[YOCTO #5329]
Signed-off-by Laurentiu Palcu <[email protected]>--- meta/recipes-devtools/flex/flex.inc | 5 +++++ 1 file changed, 5 insertions(+)meta/recipes-devtools/flex/flex.inc +5
-0@@ -13,6 +13,9 @@ inherit autotools gettext M4 = "${bindir}/m4" M4_class-native = "${STAGING_BINDIR_NATIVE}/m4" +EXTRA_OECONF += "ac_cv_path_M4=${M4}" +EXTRA_OEMAKE += "m4=${STAGING_BINDIR_NATIVE}/m4" + do_install_append_class-native() { create_wrapper ${D}/${bindir}/flex M4=${M4} }@@ -20,3 +23,5 @@ do_install_append_class-native() { do_install_append_class-nativesdk() { create_wrapper ${D}/${bindir}/flex M4=${M4} } + +RDEPENDS_${PN} += "m4"Signature · 6 lines
1.7.9.5 _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 9 lines · Richard Purdie
Quoted 3 lines · Laurentiu Palcu
Even though this was in the last C-pull, for some reason, it didn't end up in master... Didn't see any comments on it either. Or maybe I missed them...
In the target case, M4 should be compiled in as ${bindir}/m4 and there should be no need of a wrapper. Can someone confirm this is the case? Is the OEMAKE command only used for compilation and not built into the target?
The m4 variable set in EXTRA_OEMAKE is used to generate skel.c file. And, for that, it needs the native m4. It does not end into the target. The path set with ac_cv_path_M4=${M4} in EXTRA_OECONF ends into the target.
Laurentiu
Quoted 56 lines
Cheers,
Richard
Quoted 48 lines
Thanks,
LaurentiuQuoted 43 lines · Laurentiu Palcu
Flex needs m4 to run (see below) and, since the
create_wrapperintroduces a bash dependency on target, give the path to m4 binary in the configure command line.Snippet from the flex documentation:
"The macro processor m4 must be installed wherever flex is installed. <...>
m4 is only required at the time you run flex."[YOCTO #5329]
Signed-off-by Laurentiu Palcu <[email protected]>--- meta/recipes-devtools/flex/flex.inc | 5 +++++ 1 file changed, 5 insertions(+)meta/recipes-devtools/flex/flex.inc +5
-0@@ -13,6 +13,9 @@ inherit autotools gettext M4 = "${bindir}/m4" M4_class-native = "${STAGING_BINDIR_NATIVE}/m4" +EXTRA_OECONF += "ac_cv_path_M4=${M4}" +EXTRA_OEMAKE += "m4=${STAGING_BINDIR_NATIVE}/m4" + do_install_append_class-native() { create_wrapper ${D}/${bindir}/flex M4=${M4} }@@ -20,3 +23,5 @@ do_install_append_class-native() { do_install_append_class-nativesdk() { create_wrapper ${D}/${bindir}/flex M4=${M4} } + +RDEPENDS_${PN} += "m4"Signature · 6 lines
1.7.9.5 _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core