Skip to contentSkip to conversation

Dora backports

PATCH In review Martin Jansa 3 participants 8 messages Jan 8, 2014 – Jan 21, 2014

lore
Share & tools
lore
#0 lore raw

cover Dora backports

The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:

libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2

Martin Jansa (1):
ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script

Mike Crowe (2):
Revert "kernel.bbclass: move bundle_initramfs after
kernel_link_vmlinux"
kernel.bbclass: Stop bundle_initramfs thwarting sstate cache and fix
race

Richard Purdie (1):
eglibc-initial.inc: Drop duplicate include

 meta/classes/kernel.bbclass                        |  24 +--
 meta/conf/distro/include/default-providers.inc     |   2 +
 meta/recipes-core/eglibc/eglibc-initial.inc        |   2 -
 ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20130503.bb          |   4 +-
 5 files changed, 219 insertions(+), 15 deletions(-)
 create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
Signature · 1 line
1.8.5.2
#1 lore raw

PATCH 1/4 ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script

From: Martin Jansa <[email protected]>

* ltp installs 2 different runtests_noltp.sh files from different directories into /opt/ltp/testcases/bin/runtests_noltp.sh last one installed wins and causes unexpected changes in buildhistory's files-in-image.txt report, rename them to have unique name as other ltp scripts have.

* also define PREFERRED_PROVIDER to resolve note shown when building with meta-oe layer:
NOTE: multiple providers are available for ltp (ltp, ltp-ddt)
NOTE: consider defining a PREFERRED_PROVIDER entry to match ltp

* use patch generated without -M
in my builds both versions worked, but Saul reported that it fails to apply with:
Applying patch 0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
patch: **** Only garbage was found in the patch input.

Now I've see the same issue on different builder (with Ubuntu 12.04).

---
 meta/conf/distro/include/default-providers.inc     |   2 +
 ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20130503.bb          |   4 +-
 3 files changed, 207 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch
meta/conf/distro/include/default-providers.inc +2 -0
index d4b9db0..e2b0892 100644
@@ -43,3 +43,5 @@ PREFERRED_PROVIDER_udev ?= "${@base_contains('DISTRO_FEATURES','systemd','system
 # There are issues with runtime packages and PREFERRED_PROVIDER, see YOCTO #5044 for details
 # on this rather strange entry.
 PREFERRED_PROVIDER_bluez4 ?= "bluez4"
+# Alternative is ltp-ddt in meta-oe: meta-oe/recipes-devtools/ltp-ddt/ltp-ddt_0.0.4.bb
+PREFERRED_PROVIDER_ltp ?= "ltp"
meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch new file +202 -0

202 lines not on this page · raw message

meta/recipes-extended/ltp/ltp_20130503.bb +3 -1
index 387826d..9e1183c 100644
@@ -21,7 +21,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
 
 DEPENDS = "attr libaio libcap acl openssl"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2"
+SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2 \
+           file://0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch \
+"
 
 SRC_URI[md5sum] = "d448d9e9731d7ef45352fc74633cc97f"
 SRC_URI[sha256sum] = "afdb1479e73d4da7f0d4d5d3fe1570bc5fc96e3317d4a5c10c59c046d3dfa4a0"
Signature · 1 line
1.8.5.2
#2 lore raw

PATCH 2/4 eglibc-initial.inc: Drop duplicate include

In reply to Martin Jansa

From: Richard Purdie <[email protected]>

There is little point in including the file twice so lets not. The main recipe already included it.

---
 meta/recipes-core/eglibc/eglibc-initial.inc | 2 --
 1 file changed, 2 deletions(-)
meta/recipes-core/eglibc/eglibc-initial.inc +0 -2
index 83b1d2c..0f0e1cd 100644
@@ -1,5 +1,3 @@
-require eglibc-common.inc
-
 DEPENDS = "linux-libc-headers virtual/${TARGET_PREFIX}gcc-initial"
 PROVIDES = "virtual/${TARGET_PREFIX}libc-initial"
 
Signature · 1 line
1.8.5.2
#3 lore raw

PATCH 3/4 Revert "kernel.bbclass: move bundle_initramfs after kernel_link_vmlinux"

In reply to Martin Jansa

From: Mike Crowe <[email protected]>

This reverts commit 3baa63b4d588c3262254528b406ede265dd117bf. It broke builds that aren't using kernel-yocto.

---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel.bbclass +1 -1
index 61a6d10..1374e68 100644
@@ -152,7 +152,7 @@ python do_devshell_prepend () {
     os.environ["LDFLAGS"] = ''
 }
 
-addtask bundle_initramfs after do_kernel_link_vmlinux before do_build
+addtask bundle_initramfs after do_compile before do_build
 
 kernel_do_compile() {
 	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
Signature · 1 line
1.8.5.2
#4 lore raw

PATCH 4/4 kernel.bbclass: Stop bundle_initramfs thwarting sstate cache and fix race

In reply to Martin Jansa

From: Mike Crowe <[email protected]>

The new do_bundle_initramfs task introduced in 609d5a9ab9e58bb1c2bcc2145399fbc8b701b85a defeats using the sstate cache. The kernel is resurrected from the sstate cache but ends up being built again since do_bundle_initramfs depends on do_compile.

The task is no longer nostamp to avoid causing unnecessary rebuilds. The sstate checksum stamps should know when to rebuild.

The task now runs before do_deploy and part of the work has been moved to do_deploy where it now writes to ${DEPLOYDIR} rather than ${DEPLOY_DIR_IMAGE} so that the files end up in sstate.

The task can also race against do_install since both call into the kernel build system. This is fixed by making do_bundle_initramfs run after do_install (which therefore also fixes the problem that 3baa63b4d588c3262254528b406ede265dd117bf was addressing.)

---
 meta/classes/kernel.bbclass | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
meta/classes/kernel.bbclass +12 -12
index 1374e68..e639bd5 100644
@@ -134,25 +134,14 @@ do_bundle_initramfs () {
 		echo "There is kernel image bundled with initramfs: ${B}/${KERNEL_OUTPUT}.initramfs"
 		install -m 0644 ${B}/${KERNEL_OUTPUT}.initramfs ${D}/boot/${KERNEL_IMAGETYPE}-initramfs-${MACHINE}.bin
 		echo "${B}/${KERNEL_OUTPUT}.initramfs"
-		cd ${B}
-		# Update deploy directory
-		if [ -e "${KERNEL_OUTPUT}.initramfs" ]; then
-			echo "Copying deploy kernel-initramfs image and setting up links..."
-			initramfs_base_name=${INITRAMFS_BASE_NAME}
-			initramfs_symlink_name=${KERNEL_IMAGETYPE}-initramfs-${MACHINE}
-			install -m 0644 ${KERNEL_OUTPUT}.initramfs ${DEPLOY_DIR_IMAGE}/${initramfs_base_name}.bin
-			cd ${DEPLOY_DIR_IMAGE}
-			ln -sf ${initramfs_base_name}.bin ${initramfs_symlink_name}.bin
-		fi
 	fi
 }
-do_bundle_initramfs[nostamp] = "1"
 
 python do_devshell_prepend () {
     os.environ["LDFLAGS"] = ''
 }
 
-addtask bundle_initramfs after do_compile before do_build
+addtask bundle_initramfs after do_install before do_deploy
 
 kernel_do_compile() {
 	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
@@ -464,6 +453,17 @@ kernel_do_deploy() {
 	ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/${KERNEL_IMAGETYPE}
 
 	cp ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOYDIR}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
+
+	cd ${B}
+	# Update deploy directory
+	if [ -e "${KERNEL_OUTPUT}.initramfs" ]; then
+		echo "Copying deploy kernel-initramfs image and setting up links..."
+		initramfs_base_name=${INITRAMFS_BASE_NAME}
+		initramfs_symlink_name=${KERNEL_IMAGETYPE}-initramfs-${MACHINE}
+		install -m 0644 ${KERNEL_OUTPUT}.initramfs ${DEPLOYDIR}/${initramfs_base_name}.bin
+		cd ${DEPLOYDIR}
+		ln -sf ${initramfs_base_name}.bin ${initramfs_symlink_name}.bin
+	fi
 }
 do_deploy[dirs] = "${DEPLOYDIR} ${B}"
 do_deploy[prefuncs] += "package_get_auto_pr"
Signature · 1 line
1.8.5.2
#5 lore raw
In reply to Martin Jansa

Hi Martin,

Thank you ver much, I will merge them to dora-next.

// Robert

Quoted 29 lines · Martin Jansa

The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:

   libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2

Martin Jansa (1):
ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script

Mike Crowe (2):
Revert "kernel.bbclass: move bundle_initramfs after
kernel_link_vmlinux"
kernel.bbclass: Stop bundle_initramfs thwarting sstate cache and fix
race

Richard Purdie (1):
eglibc-initial.inc: Drop duplicate include

  meta/classes/kernel.bbclass                        |  24 +--
  meta/conf/distro/include/default-providers.inc     |   2 +
  meta/recipes-core/eglibc/eglibc-initial.inc        |   2 -
  ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
  meta/recipes-extended/ltp/ltp_20130503.bb          |   4 +-
  5 files changed, 219 insertions(+), 15 deletions(-)

create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch

#6 lore raw

Op 13 jan. 2014, om 03:02 heeft Robert Yang <[email protected]> het volgende geschreven:

Quoted 4 lines

Hi Martin,

Thank you ver much, I will merge them to dora-next.

What's the status on these?

regards,

Koen

Quoted 38 lines

// Robert

Quoted 21 lines · Martin Jansa

The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:

libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2

Martin Jansa (1):
ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script

Mike Crowe (2):
Revert "kernel.bbclass: move bundle_initramfs after
kernel_link_vmlinux"
kernel.bbclass: Stop bundle_initramfs thwarting sstate cache and fix
race

Richard Purdie (1):
eglibc-initial.inc: Drop duplicate include

Quoted 8 lines
 meta/classes/kernel.bbclass                        |  24 +--
 meta/conf/distro/include/default-providers.inc     |   2 +
 meta/recipes-core/eglibc/eglibc-initial.inc        |   2 -
 ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20130503.bb          |   4 +-
 5 files changed, 219 insertions(+), 15 deletions(-)
 create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#7 lore raw
Quoted 5 lines · Koen Kooi

Op 13 jan. 2014, om 03:02 heeft Robert Yang <[email protected]> het volgende geschreven:

Quoted 1 line
Quoted 7 lines
Quoted 3 lines

Hi Martin,

Thank you ver much, I will merge them to dora-next.

What's the status on these?

Hi Koen,

I will send out a branch with will the fixes for dora-next (1.5.2) by this week.

// Robert

Quoted 45 lines

regards,

Koen

Quoted 38 lines

// Robert

Quoted 21 lines · Martin Jansa

The following changes since commit e86622a932bbd0acdea67ecfb15c8b06c27353d8:

   libsoup-2.4: add intltool-native to DEPENDS (2013-12-19 14:59:47 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib jansa/dora-backports2
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/dora-backports2

Martin Jansa (1):
ltp: set PREFERRED_PROVIDER and rename runtests_noltp.sh script

Mike Crowe (2):
Revert "kernel.bbclass: move bundle_initramfs after
kernel_link_vmlinux"
kernel.bbclass: Stop bundle_initramfs thwarting sstate cache and fix
race

Richard Purdie (1):
eglibc-initial.inc: Drop duplicate include

Quoted 8 lines
  meta/classes/kernel.bbclass                        |  24 +--
  meta/conf/distro/include/default-providers.inc     |   2 +
  meta/recipes-core/eglibc/eglibc-initial.inc        |   2 -
  ...tests_noltp.sh-script-so-have-unique-name.patch | 202 +++++++++++++++++++++
  meta/recipes-extended/ltp/ltp_20130503.bb          |   4 +-
  5 files changed, 219 insertions(+), 15 deletions(-)

create mode 100644 meta/recipes-extended/ltp/ltp/0001-Rename-runtests_noltp.sh-script-so-have-unique-name.patch

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core