fixes for gcc and systemd
cover fixes for gcc and systemd
Hi RP,
This one doesn't on master since it is a backport from systemd 207, while dora is 206:
systemd: journald fix ignored disk space restrictions
// Robert
The following changes since commit 7ee4d9e1b29a1c0a2552a008fc264c592ef5ae4a:
pulseaudio: only package consolekit module when x11 is enabled (2014-02-13 12:35:45 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib robert/dora-next
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=robert/dora-next
Diego Sueiro (1):
systemd: journald fix ignored disk space restrictions
Holger Hans Peter Freyther (1):
gcc: Include patch scheduled for GCC 4.8.3 to fix epilogue on ARM
...ournald-fix-fd-leak-in-journal_file_empty.patch | 27 ++++++++++++++++ ...urnald-fix-vacuuming-of-archived-journals.patch | 37 ++++++++++++++++++++++ meta/recipes-core/systemd/systemd_206.bb | 2 ++ meta/recipes-devtools/gcc/gcc-4.8.inc | 1 + .../0048-PR58854_fix_arm_apcs_epilogue.patch | 23 ++++++++++++++ 5 files changed, 90 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/journald-fix-fd-leak-in-journal_file_empty.patch create mode 100644 meta/recipes-core/systemd/systemd/journald-fix-vacuuming-of-archived-journals.patch create mode 100644 meta/recipes-devtools/gcc/gcc-4.8/0048-PR58854_fix_arm_apcs_epilogue.patch
Signature · 1 line
1.8.3.1
PATCH 1/2 gcc: Include patch scheduled for GCC 4.8.3 to fix epilogue on ARM
From: Holger Hans Peter Freyther <[email protected]>
GCC 4.8.0, 4.8.1 and 4.8.2 can generate broken epilogues for the ABI used by the kernel. Apply the patch that is included for GCC 4.8.3 from http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58854.
The issue was found on Yocto/Dora and the patch should be backported to this branch. A kernel built with Dora's GCC 4.8.1 misbehaved on:
while true;
do
(for i in `seq 1 100`;
do
echo "Log message... $RANDOM";
done) | logger;done
busybox's syslogd would from time to read a huge negative value and then exit, strace would get stuck waiting on a syscall. After this patch it appears to work better.
(From OE-Core master rev: 3004eb3b7ee5fd8dfe9c4e5749b4e125d0bd4b59)
--- meta/recipes-devtools/gcc/gcc-4.8.inc | 1 + .../0048-PR58854_fix_arm_apcs_epilogue.patch | 23 ++++++++++++++++++++++ 2 files changed, 24 insertions(+) create mode 100644 meta/recipes-devtools/gcc/gcc-4.8/0048-PR58854_fix_arm_apcs_epilogue.patch
meta/recipes-devtools/gcc/gcc-4.8.inc +1 -0
@@ -78,6 +78,7 @@ SRC_URI = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \ file://0046-libatomic-deptracking.patch \ file://0047-repomembug.patch \ file://0048-PR57532.patch \ + file://0048-PR58854_fix_arm_apcs_epilogue.patch \ " SRC_URI[md5sum] = "3b2386c114cd74185aa3754b58a79304" SRC_URI[sha256sum] = "545b44be3ad9f2c4e90e6880f5c9d4f0a8f0e5f67e1ffb0d45da9fa01bb05813"
meta/recipes-devtools/gcc/gcc-4.8/0048-PR58854_fix_arm_apcs_epilogue.patch new file +23 -0
@@ -0,0 +1,23 @@ +Backport fix for PR target/58854 + +2013-11-11 Ramana Radhakrishnan <[email protected]> + + Backported from mainline + 2013-10-30 Ramana Radhakrishnan <[email protected]> + + PR target/58854 + * config/arm/arm.c (arm_expand_epilogue_apcs_frame): Emit blockage + + +Upstream-Status: Backport + +--- gcc-4_8-branch/gcc/config/arm/arm.c 2013/11/11 08:00:45 204664 ++++ gcc-4_8-branch/gcc/config/arm/arm.c 2013/11/11 09:38:14 204665 +@@ -23555,6 +23555,7 @@ + num_regs = bit_count (saved_regs_mask); + if ((offsets->outgoing_args != (1 + num_regs)) || cfun->calls_alloca) + { ++ emit_insn (gen_blockage ()); + /* Unwind the stack to just below the saved registers. */ + emit_insn (gen_addsi3 (stack_pointer_rtx, + hard_frame_pointer_rtx,
Signature · 1 line
1.8.3.1
PATCH 2/2 systemd: journald fix ignored disk space restrictions
In reply to Robert YangFrom: Diego Sueiro <[email protected]>
The upstream bug report can be seen at:
[Systemd #68161] -- https://bugs.freedesktop.org/show_bug.cgi?id=68161
This backports patches come from 207 and need to address this in the 206 version for dora branch.
--- ...ournald-fix-fd-leak-in-journal_file_empty.patch | 27 ++++++++++++++++ ...urnald-fix-vacuuming-of-archived-journals.patch | 37 ++++++++++++++++++++++ meta/recipes-core/systemd/systemd_206.bb | 2 ++ 3 files changed, 66 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/journald-fix-fd-leak-in-journal_file_empty.patch create mode 100644 meta/recipes-core/systemd/systemd/journald-fix-vacuuming-of-archived-journals.patch
meta/recipes-core/systemd/systemd/journald-fix-fd-leak-in-journal_file_empty.patch new file +27 -0
@@ -0,0 +1,27 @@ +journald: fix fd leak in journal_file_empty +Before my previous patch, journal_file_empty wasn't be called with the +correct filename. Now that it's being called with the correct filename +it leaks file descriptors. This patch closes the file descriptors before +returning. + +Signed-off-by: George McCollister <[email protected]> + + +Index: systemd-206/src/journal/journal-vacuum.c +=================================================================== +--- systemd-206.orig/src/journal/journal-vacuum.c 2013-07-21 19:43:28.146183128 -0300 ++++ systemd-206/src/journal/journal-vacuum.c 2014-01-29 20:43:27.492343295 -0200 +@@ -129,9 +129,9 @@ + } + + static int journal_file_empty(int dir_fd, const char *name) { +- int fd, r; ++ int r; + le64_t n_entries; +- ++ _cleanup_close_ int fd; + fd = openat(dir_fd, name, O_RDONLY|O_CLOEXEC|O_NOFOLLOW|O_NONBLOCK); + if (fd < 0) + return -errno; + +Upstream-Status: Backport [207]
meta/recipes-core/systemd/systemd/journald-fix-vacuuming-of-archived-journals.patch new file +37 -0
@@ -0,0 +1,37 @@ +journald: fix vacuuming of archived journals +d_name is modified on line 227 so if the entire journal name is needed +again p must be used. Before this change when journal_file_empty was called +on archived journals it would always return with -2. + +Signed-off-by: George McCollister <[email protected]> + +Index: systemd-206/src/journal/journal-vacuum.c +=================================================================== +--- systemd-206.orig/src/journal/journal-vacuum.c 2014-01-29 20:43:27.492343295 -0200 ++++ systemd-206/src/journal/journal-vacuum.c 2014-01-29 20:48:55.076356876 -0200 +@@ -265,18 +265,18 @@ + /* We do not vacuum active files or unknown files! */ + continue; + +- if (journal_file_empty(dirfd(d), de->d_name)) { ++ if (journal_file_empty(dirfd(d), p)) { + + /* Always vacuum empty non-online files. */ + +- if (unlinkat(dirfd(d), de->d_name, 0) >= 0) +- log_debug("Deleted empty journal %s/%s.", directory, de->d_name); ++ if (unlinkat(dirfd(d), p, 0) >= 0) ++ log_debug("Deleted empty journal %s/%s.", directory, p); + else if (errno != ENOENT) +- log_warning("Failed to delete %s/%s: %m", directory, de->d_name); ++ log_warning("Failed to delete %s/%s: %m", directory, p); + continue; + } + +- patch_realtime(directory, de->d_name, &st, &realtime); ++ patch_realtime(directory, p, &st, &realtime); + + GREEDY_REALLOC(list, n_allocated, n_list + 1); + + +Upstream-Status: Backport [207]
meta/recipes-core/systemd/systemd_206.bb +2 -0
@@ -21,6 +21,8 @@ SRC_URI = "http://www.freedesktop.org/software/systemd/systemd-${PV}.tar.xz \ file://0001-use-CAP_MKNOD-ConditionCapability.patch \ file://0001-Use-bin-mkdir-instead-of-host-mkdir-path.patch \ file://binfmt-install.patch \ + file://journald-fix-fd-leak-in-journal_file_empty.patch \ + file://journald-fix-vacuuming-of-archived-journals.patch \ file://touchscreen.rules \ ${UCLIBCPATCHES} \ file://00-create-volatile.conf \
Signature · 1 line
1.8.3.1