Skip to contentSkip to conversation

kernel AUDIT_LOGIN event is missing subject label

PATCH New Richard Guy Briggs 1 participant 3 messages Mar 11, 2014 Audit

lore
Share & tools
lore

Richard Guy Briggs

author
#0 lore raw

cover kernel AUDIT_LOGIN event is missing subject label

This was fixed in RHEL6 as BZ 670328, but never upstreamed.

Eric Paris (1):
audit: include subject in login records

Richard Guy Briggs (1):
audit: remove superfluous new- prefix in AUDIT_LOGIN messages

 kernel/auditsc.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
author
#1 lore raw

PATCH 1/2 audit: remove superfluous new- prefix in AUDIT_LOGIN messages

The new- prefix on ses and auid are un-necessary and break ausearch.

Signed-off-by Richard Guy Briggs <[email protected]>
---
 kernel/auditsc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/auditsc.c +1 -1
index eb01d47..3bc12d2 100644
@@ -1984,7 +1984,7 @@ static void audit_log_set_loginuid(kuid_t koldloginuid, kuid_t kloginuid,
 	if (!ab)
 		return;
 	audit_log_format(ab, "pid=%d uid=%u"
-			 " old-auid=%u new-auid=%u old-ses=%u new-ses=%u"
+			 " old-auid=%u auid=%u old-ses=%u ses=%u"
 			 " res=%d",
 			 task_pid_nr(current), uid,
 			 oldloginuid, loginuid, oldsessionid, sessionid,
Signature · 1 line
1.7.1
author
#2 lore raw

PATCH 2/2 audit: include subject in login records

In reply to Richard Guy Briggs

From: Eric Paris <[email protected]>

The login uid change record does not include the selinux context of the task logging in. Add that information.

(Updated from 2011-01: RHBZ:670328 -- RGB)

Reported-by Steve Grubb <[email protected]>
Acked-by James Morris <[email protected]>
Signed-off-by Eric Paris <[email protected]>
Signed-off-by Aristeu Rozanski <[email protected]>
Signed-off-by Richard Guy Briggs <[email protected]>
---
 kernel/auditsc.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
kernel/auditsc.c +4 -6
index 3bc12d2..d8a54ef 100644
@@ -1983,12 +1983,10 @@ static void audit_log_set_loginuid(kuid_t koldloginuid, kuid_t kloginuid,
 	ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_LOGIN);
 	if (!ab)
 		return;
-	audit_log_format(ab, "pid=%d uid=%u"
-			 " old-auid=%u auid=%u old-ses=%u ses=%u"
-			 " res=%d",
-			 task_pid_nr(current), uid,
-			 oldloginuid, loginuid, oldsessionid, sessionid,
-			 !rc);
+	audit_log_format(ab, "pid=%d uid=%u", task_pid_nr(current), uid);
+	audit_log_task_context(ab);
+	audit_log_format(ab, " old-auid=%u auid=%u old-ses=%u ses=%u res=%d",
+			 oldloginuid, loginuid, oldsessionid, sessionid, !rc);
 	audit_log_end(ab);
 }
Signature · 1 line
1.7.1