Fix for YB6073

PATCH In review Cristian Iorga 6 participants 11 messages Mar 31, 2014

lore

Share & tools

lore

Cristian Iorga

author

2014-03-31 09:48 UTC #0 lore raw

cover Fix for YB6073

The following changes since commit 8210928e847fda7dbc145a94372b0beaf653a4f9:

yocto-bsps: remove linux-yocto 3.8 bbappend (2014-03-30 23:53:00 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ciorga/lsb-pam-enforcing
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ciorga/lsb-pam-enforcing

Cristian Iorga (1):
core-image-lsb: enforce pam as a needed distro feature

 meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Signature · 1 line

1.8.3.2

Cristian Iorga

author

2014-03-31 09:48 UTC #1 lore raw

PATCH 1/1 core-image-lsb: enforce pam as a needed distro feature

core-image-lsb only gave a warning:
"WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly"
when the proper DISTRO was not set for it.
default choice would be DISTRO = "poky-lsb",
but not necessarily, depending on each custom distro.

This fix will enforce the proper usage of pam
as a distro feature for core-image-lsb by giving
an error instead of just a warning.

Fixes [YOCTO #6073]

Signed-off-by Cristian Iorga <[email protected]>

---
 meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

meta/recipes-extended/images/core-image-lsb.bb +3 -1

index ed316a6..ab61c6e 100644
@@ -9,4 +9,6 @@ IMAGE_INSTALL = "\
     packagegroup-core-lsb \
     "
 
-inherit core-image
+inherit core-image distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "pam"

Signature · 1 line

1.8.3.2

Richard Purdie

2014-03-31 09:58 UTC #2 lore raw

Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

Quoted 23 lines · Cristian Iorga

core-image-lsb only gave a warning:
"WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly"
when the proper DISTRO was not set for it.
default choice would be DISTRO = "poky-lsb",
but not necessarily, depending on each custom distro.
This fix will enforce the proper usage of pam
as a distro feature for core-image-lsb by giving
an error instead of just a warning.
Fixes [YOCTO #6073]
Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-extended/images/core-image-lsb.bb +0 -0
index ed316a6..ab61c6e 100644

meta/recipes-extended/images/core-image-lsb.bb IMAGE_INSTALL = "\ · line 14

Quoted 7 lines

meta/recipes-extended/images/core-image-lsb.bb +3 -1

@@ -9,4 +9,6 @@ IMAGE_INSTALL = "\
     packagegroup-core-lsb \
     "
 
-inherit core-image
+inherit core-image distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "pam"

I have a feeling the autobuilder builds core-image-lsb in situations where DISTRO=poky, although I could be wrong. Have you checked?

Cheers,

Richard

Iorga, Cristian

author

2014-03-31 10:10 UTC #3 lore raw

Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

No, but I will.

But is this a negative point of the patch, or the autobuilder should be changed?
I acted upon some personal observations, a discussion with Paul (he suggested the change) and also on this guide:
https://wiki.yoctoproject.org/wiki/LSB_Result (in which distro is set to poky-lsb).

Regards,
Cristian

-----Original Message-----
From: Richard Purdie [mailto:[email protected]]
Sent: Monday, March 31, 2014 12:58 PM
To: Iorga, Cristian
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

Quoted 23 lines · Cristian Iorga

core-image-lsb only gave a warning:
"WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly"
when the proper DISTRO was not set for it.
default choice would be DISTRO = "poky-lsb", but not necessarily, depending on each custom distro.
This fix will enforce the proper usage of pam as a distro feature for core-image-lsb by giving an error instead of just a warning.
Fixes [YOCTO #6073]
Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-extended/images/core-image-lsb.bb +0 -0
index ed316a6..ab61c6e 100644

meta/recipes-extended/images/core-image-lsb.bb IMAGE_INSTALL = "\ · line 14

Quoted 7 lines

meta/recipes-extended/images/core-image-lsb.bb +3 -1

@@ -9,4 +9,6 @@ IMAGE_INSTALL = "\
     packagegroup-core-lsb \
     "
 
-inherit core-image
+inherit core-image distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "pam"

I have a feeling the autobuilder builds core-image-lsb in situations where DISTRO=poky, although I could be wrong. Have you checked?

Cheers,

Richard

Iorga, Cristian

author

2014-03-31 10:41 UTC #4 lore raw

Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

Hello,
I have checked, on the autobuilder the right association between LSB-enabled images and proper distro (in our case, poky-lsb) is in place. As such, my patch should not cause any trouble.
Regards,
Cristian

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Iorga, Cristian
Sent: Monday, March 31, 2014 1:10 PM
To: Richard Purdie
Cc: [email protected]
Subject: Re: [OE-core] [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

No, but I will.

Regards,
Cristian

Quoted 23 lines · Cristian Iorga

core-image-lsb only gave a warning:
"WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly"
when the proper DISTRO was not set for it.
default choice would be DISTRO = "poky-lsb", but not necessarily, depending on each custom distro.
This fix will enforce the proper usage of pam as a distro feature for core-image-lsb by giving an error instead of just a warning.
Fixes [YOCTO #6073]
Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-extended/images/core-image-lsb.bb +0 -0
index ed316a6..ab61c6e 100644

meta/recipes-extended/images/core-image-lsb.bb IMAGE_INSTALL = "\ · line 14

Quoted 7 lines

meta/recipes-extended/images/core-image-lsb.bb +3 -1

@@ -9,4 +9,6 @@ IMAGE_INSTALL = "\
     packagegroup-core-lsb \
     "
 
-inherit core-image
+inherit core-image distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "pam"

I have a feeling the autobuilder builds core-image-lsb in situations where DISTRO=poky, although I could be wrong. Have you checked?

Cheers,

Richard

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Stanacar, StefanX

2014-03-31 11:59 UTC #5 lore raw

Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

In reply to Richard Purdie

Quoted 27 lines · Richard Purdie

Quoted 26 lines · Cristian Iorga
core-image-lsb only gave a warning:
"WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly"
when the proper DISTRO was not set for it.
default choice would be DISTRO = "poky-lsb",
but not necessarily, depending on each custom distro.
This fix will enforce the proper usage of pam
as a distro feature for core-image-lsb by giving
an error instead of just a warning.
Fixes [YOCTO #6073]
Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-extended/images/core-image-lsb.bb +0 -0
index ed316a6..ab61c6e 100644
@@ -9,4 +9,6 @@ IMAGE_INSTALL = "\
     packagegroup-core-lsb \
     "
 

Quoted 9 lines

meta/recipes-extended/images/core-image-lsb.bb IMAGE_INSTALL = "\ · line 14
Quoted 4 lines
meta/recipes-extended/images/core-image-lsb.bb +3 -1
-inherit core-image
+inherit core-image distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "pam"
I have a feeling the autobuilder builds core-image-lsb in situations where DISTRO=poky, although I could be wrong. Have you checked?

FWIW, all the -lsb buildsets are done with DISTRO=poky-lsb on the AB. Unfortuntely we do have one problematic build.
So the answer to your question is: we don't have core-image-lsb builds with DISTRO=poky but we do have a lib64-core-image-lsb-sdk image built with DISTRO=poky and no pam in DISTRO_FEATURES, see the last build on nightly-multilib... :(

Cheers,
Stefan

Quoted 4 lines

Cheers,
Richard

Paul Eggleton

2014-03-31 12:19 UTC #6 lore raw

Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

Quoted 39 lines · StefanX

Quoted 30 lines · Richard Purdie
Quoted 29 lines · Cristian Iorga
core-image-lsb only gave a warning:
"WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly"
when the proper DISTRO was not set for it.
default choice would be DISTRO = "poky-lsb",
but not necessarily, depending on each custom distro.
This fix will enforce the proper usage of pam
as a distro feature for core-image-lsb by giving
an error instead of just a warning.
Fixes [YOCTO #6073]
Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
(quoted diff) +0 -0
b/meta/recipes-extended/images/core-image-lsb.bb index ed316a6..ab61c6e 100644
meta/recipes-extended/images/core-image-lsb.bb +0 -0
@@ -9,4 +9,6 @@ IMAGE_INSTALL = "\
 
     packagegroup-core-lsb \
     "
 
Quoted 7 lines
meta/recipes-extended/images/core-image-lsb.bb IMAGE_INSTALL = "\ · line 14
Quoted 4 lines
meta/recipes-extended/images/core-image-lsb.bb +3 -1
-inherit core-image
+inherit core-image distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "pam"
I have a feeling the autobuilder builds core-image-lsb in situations where DISTRO=poky, although I could be wrong. Have you checked?

Quoted 6 lines

FWIW, all the -lsb buildsets are done with DISTRO=poky-lsb on the AB. Unfortuntely we do have one problematic build.
So the answer to your question is: we don't have core-image-lsb builds with DISTRO=poky but we do have a lib64-core-image-lsb-sdk image built with DISTRO=poky and no pam in DISTRO_FEATURES, see the last build on nightly-multilib... :(

If we're doing this then we should be changing the autobuilder so it doesn't. LSB images should not be built in non-LSB configuration.

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Richard Purdie

2014-03-31 17:09 UTC #7 lore raw

Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

Quoted 47 lines · Paul Eggleton

Quoted 39 lines · StefanX
Quoted 30 lines · Richard Purdie
Quoted 29 lines · Cristian Iorga
core-image-lsb only gave a warning:
"WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly"
when the proper DISTRO was not set for it.
default choice would be DISTRO = "poky-lsb",
but not necessarily, depending on each custom distro.
This fix will enforce the proper usage of pam
as a distro feature for core-image-lsb by giving
an error instead of just a warning.
Fixes [YOCTO #6073]
Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
(quoted diff) +0 -0
b/meta/recipes-extended/images/core-image-lsb.bb index ed316a6..ab61c6e 100644
meta/recipes-extended/images/core-image-lsb.bb +0 -0
@@ -9,4 +9,6 @@ IMAGE_INSTALL = "\
 
     packagegroup-core-lsb \
     "
 
Quoted 7 lines
meta/recipes-extended/images/core-image-lsb.bb IMAGE_INSTALL = "\ · line 14
Quoted 4 lines
meta/recipes-extended/images/core-image-lsb.bb +3 -1
-inherit core-image
+inherit core-image distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "pam"
I have a feeling the autobuilder builds core-image-lsb in situations where DISTRO=poky, although I could be wrong. Have you checked?
Quoted 6 lines
FWIW, all the -lsb buildsets are done with DISTRO=poky-lsb on the AB. Unfortuntely we do have one problematic build.
So the answer to your question is: we don't have core-image-lsb builds with DISTRO=poky but we do have a lib64-core-image-lsb-sdk image built with DISTRO=poky and no pam in DISTRO_FEATURES, see the last build on nightly-multilib... :(

Quoted 2 lines

If we're doing this then we should be changing the autobuilder so it doesn't. LSB images should not be built in non-LSB configuration.

I kind of disagree with that, the LSB image can take into account configuration in other parts of the system. If pam isn't configured, I'm not sure that should automatically make it completely unbuildable...

Cheers,

Richard

Paul Eggleton

2014-03-31 17:27 UTC #8 lore raw

Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

Quoted 49 lines · On Monday 31 March 2014 18:03:32 Richard Purdie wrote:

Quoted 48 lines · Paul Eggleton
Quoted 46 lines · StefanX
Quoted 31 lines · Richard Purdie
Quoted 30 lines · Cristian Iorga
core-image-lsb only gave a warning:
"WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, PAM won't work correctly"
when the proper DISTRO was not set for it.
default choice would be DISTRO = "poky-lsb",
but not necessarily, depending on each custom distro.
This fix will enforce the proper usage of pam
as a distro feature for core-image-lsb by giving
an error instead of just a warning.
Fixes [YOCTO #6073]
Signed-off-by Cristian Iorga <[email protected]>
---
 meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
(quoted diff) +0 -0
b/meta/recipes-extended/images/core-image-lsb.bb index ed316a6..ab61c6e
100644
meta/recipes-extended/images/core-image-lsb.bb +0 -0
@@ -9,4 +9,6 @@ IMAGE_INSTALL = "\
 
     packagegroup-core-lsb \
     "
 
Quoted 7 lines
meta/recipes-extended/images/core-image-lsb.bb IMAGE_INSTALL = "\ · line 14
Quoted 4 lines
meta/recipes-extended/images/core-image-lsb.bb +3 -1
-inherit core-image
+inherit core-image distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "pam"
I have a feeling the autobuilder builds core-image-lsb in situations where DISTRO=poky, although I could be wrong. Have you checked?
FWIW, all the -lsb buildsets are done with DISTRO=poky-lsb on the AB. Unfortuntely we do have one problematic build.
So the answer to your question is: we don't have core-image-lsb builds with DISTRO=poky but we do have a lib64-core-image-lsb-sdk image built with DISTRO=poky and no pam in DISTRO_FEATURES, see the last build on nightly-multilib... :(

Quoted 6 lines

Quoted 2 lines
If we're doing this then we should be changing the autobuilder so it doesn't. LSB images should not be built in non-LSB configuration.
I kind of disagree with that, the LSB image can take into account configuration in other parts of the system. If pam isn't configured, I'm not sure that should automatically make it completely unbuildable...

For other situations I would agree, but the fact that the image has "lsb" in its name will naturally lead users to assume that that the output will be something LSB-compliant, but if poky-lsb or some other similar distro configuration is not used to build it then it will not be. Building something that's almost-LSB but not quite but is still labelled LSB just dilutes the meaning of LSB, and therefore doesn't seem to me to be particularly desirable.

Since we can't just check if DISTRO is "poky-lsb", an alternative check would be to look for "linuxstdbase" in OVERRIDES since we ought to be able to rely upon that given usage within other recipes.

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Burton, Ross

2014-03-31 17:31 UTC #9 lore raw

Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

In reply to Richard Purdie

Quoted 3 lines · Richard Purdie

I kind of disagree with that, the LSB image can take into account configuration in other parts of the system. If pam isn't configured, I'm not sure that should automatically make it completely unbuildable...

An image that claims to be LSB compliant but due to not-immediately-obvious DISTRO_FEATURES isn't actually doesn't seem like a good idea to me, fwiw. If the LSB image requires PAM, X11 and so on then it should require the features.

Ross

Mark Hatle

2014-03-31 17:57 UTC #10 lore raw

Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

Quoted 10 lines · Ross

Quoted 3 lines · Richard Purdie
I kind of disagree with that, the LSB image can take into account configuration in other parts of the system. If pam isn't configured, I'm not sure that should automatically make it completely unbuildable...
An image that claims to be LSB compliant but due to not-immediately-obvious DISTRO_FEATURES isn't actually doesn't seem like a good idea to me, fwiw. If the LSB image requires PAM, X11 and so on then it should require the features.

I agree the image with the name LSB should enforce the items it knows the LSB depends on. If the user patches that away then it becomes their issue.

--Mark

Quoted 2 lines

Ross