Skip to contentSkip to conversation

iproute2: show counter of carrier on<->off transitions

PATCH Superseded David Decotigny 2 participants 2 messages Apr 2, 2014 – Apr 22, 2014 1 message not in the archive

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 iproute2: show counter of carrier on<->off transitions

This patch allows to display the current counter of carrier on<->off transitions (IFLA_CARRIER_CHANGES, see kernel commit "expose number of carrier on/off changes"):

ip -s -s link show dev eth0
...
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 etc.
link/ether ............ brd ff:ff:ff:ff:ff:ff
RX: bytes packets errors dropped overrun mcast
134705 758 0 0 0 0
RX errors: length crc frame fifo missed
0 0 0 0 0
TX: bytes packets errors dropped carrier collsns
77374 731 0 0 0 0
TX errors: aborted fifo window heartbeat
0 0 0 0
link: carrier_changes 4

Tested:
- kernel with patch "net-sysfs: expose number of carrier on/off changes": see above
- kernel wthout the patch: line "link:" not displayed (as expected)

---
 include/linux/if_link.h | 1 +
 ip/ipaddress.c          | 5 +++++
 2 files changed, 6 insertions(+)
include/linux/if_link.h +1 -0
index f08505c..84fca1e 100644
@@ -144,6 +144,7 @@ enum {
 	IFLA_NUM_RX_QUEUES,
 	IFLA_CARRIER,
 	IFLA_PHYS_PORT_ID,
+	IFLA_CARRIER_CHANGES,
 	__IFLA_MAX
 };
 
ip/ipaddress.c +5 -0
index 14d1720..78b80ee 100644
@@ -527,6 +527,11 @@ int print_linkinfo(const struct sockaddr_nl *who,
 			print_link_stats(fp, RTA_DATA(tb[IFLA_STATS]));
 	}
 
+	if (do_link && (show_stats > 1) && tb[IFLA_CARRIER_CHANGES]) {
+		fprintf(fp, "%s    link: carrier_changes %u", _SL_,
+			*(int*)RTA_DATA(tb[IFLA_CARRIER_CHANGES]));
+	}
+
 	if (do_link && tb[IFLA_VFINFO_LIST] && tb[IFLA_NUM_VF]) {
 		struct rtattr *i, *vflist = tb[IFLA_VFINFO_LIST];
 		int rem = RTA_PAYLOAD(vflist);
Signature · 1 line
1.9.1.423.g4596e3a
#2 lore raw
Quoted 4 lines · On Wed, 2 Apr 2014 09:19:00 -0700 David Decotigny <[email protected]> wrote:

This patch allows to display the current counter of carrier on<->off transitions (IFLA_CARRIER_CHANGES, see kernel commit "expose number of carrier on/off changes"):

Quoted 14 lines

ip -s -s link show dev eth0
...
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 etc.
link/ether ............ brd ff:ff:ff:ff:ff:ff
RX: bytes packets errors dropped overrun mcast
134705 758 0 0 0 0
RX errors: length crc frame fifo missed
0 0 0 0 0
TX: bytes packets errors dropped carrier collsns
77374 731 0 0 0 0
TX errors: aborted fifo window heartbeat
0 0 0 0
link: carrier_changes 4

I wonder if putting it under TX errors would make sense. This is where Juniper classifies the error, and it would also fit on same line, avoiding adding more clutter.

2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 etc.
link/ether ............ brd ff:ff:ff:ff:ff:ff
RX: bytes packets errors dropped overrun mcast
134705 758 0 0 0 0
RX errors: length crc frame fifo missed
0 0 0 0 0
TX: bytes packets errors dropped carrier collsns
77374 731 0 0 0 0
TX errors: aborted fifo window heartbeat transition
0 0 0 0 4

The risk is break some screen scraping script, but that doesn't seem to be that big an issue for adding one column.

The columns also need some re-aligning here but that is different correctness issue.