kernelshark/trace-cmd: fix syntax error of shell

PATCH Superseded Chong Lu 2 participants 8 messages Apr 4, 2014 – Apr 9, 2014

lore

Share & tools

lore

Chong Lu

author

2014-04-04 08:33 UTC #0 lore raw

cover kernelshark/trace-cmd: fix syntax error of shell

The following changes since commit a5775abb1951ec6cdc7afacd1ae87189e398cff8:

bitbake: user-manual-metadata.xml: Added new section on mapping functions. (2014-04-02 14:15:35 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib chonglu/kernelshark
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/kernelshark

Chong Lu (1):
kernelshark/trace-cmd: fix syntax error of shell

 meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |  3 ++-
 .../kernelshark-fix-syntax-error-of-shell.patch    | 30 ++++++++++++++++++++++
 .../trace-cmd-fix-syntax-error-of-shell.patch      | 30 ++++++++++++++++++++++
 meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb     |  1 +
 4 files changed, 63 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
 create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch

Signature · 1 line

1.8.1.2

Chong Lu

author

2014-04-04 08:33 UTC #1 lore raw

PATCH 1/1 kernelshark/trace-cmd: fix syntax error of shell

Delete "<<<" syntax of bash in Makefile, else we would get following error:

Syntax error: redirection unexpected

[YOCTO #6112]

Signed-off-by Chong Lu <[email protected]>

---
 meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |  3 ++-
 .../kernelshark-fix-syntax-error-of-shell.patch    | 30 ++++++++++++++++++++++
 .../trace-cmd-fix-syntax-error-of-shell.patch      | 30 ++++++++++++++++++++++
 meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb     |  1 +
 4 files changed, 63 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
 create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch

meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb +2 -1

index 9268a50..d61097d 100644
@@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
 SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
            file://addldflags.patch \
            file://make-docs-optional.patch \
-           file://blktrace-api-compatibility.patch"
+           file://blktrace-api-compatibility.patch \
+           file://kernelshark-fix-syntax-error-of-shell.patch"
 S = "${WORKDIR}/git"
 
 EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"

meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +30 -0

new file mode 100644
index 0000000..994a9fa
@@ -0,0 +1,30 @@
+kernelshark: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+	Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
+
+Signed-off-by: Chong Lu <[email protected]>
+---
+ Makefile |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index c1fa906..be84415 100644
+--- a/Makefile
++++ b/Makefile
+@@ -89,8 +89,7 @@ endif
+ 
+ # $(call test-build, snippet, ret) -> ret if snippet compiles
+ #                                  -> empty otherwise
+-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
+-	                  <<<'$1' && echo y), $2)
++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
+ 
+ # have udis86 disassembler library?
+ udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
+-- 
+1.7.9.5
+

meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch new file +30 -0

new file mode 100644
index 0000000..79abad5
@@ -0,0 +1,30 @@
+trace-cmd: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+       Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
+
+Signed-off-by: Chong Lu <[email protected]>
+---
+ Makefile |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index c1fa906..7973c53 100644
+--- a/Makefile
++++ b/Makefile
+@@ -89,8 +89,7 @@ endif
+ 
+ # $(call test-build, snippet, ret) -> ret if snippet compiles
+ #                                  -> empty otherwise
+-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
+-	                  <<<'$1' && echo y), $2)
++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
+ 
+ # have udis86 disassembler library?
+ udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
+-- 
+1.7.9.5
+

meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb +1 -0

index 74eafbb..a0c823b 100644
@@ -18,6 +18,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
            file://trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch \
            file://trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch \
            file://trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch \
+           file://trace-cmd-fix-syntax-error-of-shell.patch \
 "
 S = "${WORKDIR}/git"

Signature · 1 line

1.8.1.2

Richard Purdie

2014-04-04 10:41 UTC #2 lore raw

Quoted 36 lines · Chong Lu

Delete "<<<" syntax of bash in Makefile, else we would get following error:

Syntax error: redirection unexpected

[YOCTO #6112]

Signed-off-by Chong Lu <[email protected]>

---
 meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |  3 ++-
 .../kernelshark-fix-syntax-error-of-shell.patch    | 30 ++++++++++++++++++++++
 .../trace-cmd-fix-syntax-error-of-shell.patch      | 30 ++++++++++++++++++++++
 meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb     |  1 +
 4 files changed, 63 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
 create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch

meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb +2 -1

index 9268a50..d61097d 100644
@@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
 SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
            file://addldflags.patch \
            file://make-docs-optional.patch \
-           file://blktrace-api-compatibility.patch"
+           file://blktrace-api-compatibility.patch \
+           file://kernelshark-fix-syntax-error-of-shell.patch"
 S = "${WORKDIR}/git"
 
 EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"

meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +0 -0

new file mode 100644
index 0000000..994a9fa

meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch line 7

Quoted 7 lines

meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +7 -0

@@ -0,0 +1,30 @@
+kernelshark: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+	Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]

How is this embedded specific?

Cheers,

Richard

Quoted 73 lines

meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +22 -0

+Signed-off-by: Chong Lu <[email protected]>
+---
+ Makefile |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index c1fa906..be84415 100644
+--- a/Makefile
++++ b/Makefile
+@@ -89,8 +89,7 @@ endif
+ 
+ # $(call test-build, snippet, ret) -> ret if snippet compiles
+ #                                  -> empty otherwise
+-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
+-	                  <<<'$1' && echo y), $2)
++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
+ 
+ # have udis86 disassembler library?
+ udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
+-- 
+1.7.9.5
+

meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch new file +30 -0

new file mode 100644
index 0000000..79abad5
@@ -0,0 +1,30 @@
+trace-cmd: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+       Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
+
+Signed-off-by: Chong Lu <[email protected]>
+---
+ Makefile |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index c1fa906..7973c53 100644
+--- a/Makefile
++++ b/Makefile
+@@ -89,8 +89,7 @@ endif
+ 
+ # $(call test-build, snippet, ret) -> ret if snippet compiles
+ #                                  -> empty otherwise
+-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
+-	                  <<<'$1' && echo y), $2)
++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
+ 
+ # have udis86 disassembler library?
+ udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
+-- 
+1.7.9.5
+

meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb +1 -0

index 74eafbb..a0c823b 100644
@@ -18,6 +18,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
            file://trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch \
            file://trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch \
            file://trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch \
+           file://trace-cmd-fix-syntax-error-of-shell.patch \
 "
 S = "${WORKDIR}/git"

Signature · 1 line

1.8.1.2

Chong Lu

author

2014-04-08 01:40 UTC #3 lore raw

Quoted 46 lines · Richard Purdie

Quoted 36 lines · Chong Lu
Delete "<<<" syntax of bash in Makefile, else we would get following error:
Syntax error: redirection unexpected
[YOCTO #6112]
Signed-off-by Chong Lu <[email protected]>
---
  meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |  3 ++-
  .../kernelshark-fix-syntax-error-of-shell.patch    | 30 ++++++++++++++++++++++
  .../trace-cmd-fix-syntax-error-of-shell.patch      | 30 ++++++++++++++++++++++
  meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb     |  1 +
  4 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb +2 -1
index 9268a50..d61097d 100644
@@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
  SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
             file://addldflags.patch \
             file://make-docs-optional.patch \
-           file://blktrace-api-compatibility.patch"
+           file://blktrace-api-compatibility.patch \
+           file://kernelshark-fix-syntax-error-of-shell.patch"
  S = "${WORKDIR}/git"
 
  EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +0 -0
new file mode 100644
index 0000000..994a9fa
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch line 7
Quoted 7 lines
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +7 -0
@@ -0,0 +1,30 @@
+kernelshark: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+	Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
How is this embedded specific?

Quoted 3 lines

Cheers,
Richard

This issue only produced in yocto.
It is not problem for kernelshark and trace-cmd itself. So I think this is embedded specific.

Best Regards
Chong

Quoted 76 lines

Quoted 73 lines

meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +22 -0

+Signed-off-by: Chong Lu <[email protected]>
+---
+ Makefile |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index c1fa906..be84415 100644
+--- a/Makefile
++++ b/Makefile
+@@ -89,8 +89,7 @@ endif
+
+ # $(call test-build, snippet, ret) -> ret if snippet compiles
+ #                                  -> empty otherwise
+-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
+-	                  <<<'$1' && echo y), $2)
++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
+
+ # have udis86 disassembler library?
+ udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
+--
+1.7.9.5
+

meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch new file +30 -0

new file mode 100644
index 0000000..79abad5
@@ -0,0 +1,30 @@
+trace-cmd: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+       Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
+
+Signed-off-by: Chong Lu <[email protected]>
+---
+ Makefile |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index c1fa906..7973c53 100644
+--- a/Makefile
++++ b/Makefile
+@@ -89,8 +89,7 @@ endif
+
+ # $(call test-build, snippet, ret) -> ret if snippet compiles
+ #                                  -> empty otherwise
+-test-build = $(if $(shell $(CC) -o /dev/null -c -x c - > /dev/null 2>&1 \
+-	                  <<<'$1' && echo y), $2)
++test-build = $(if $(shell echo '$1' |$(CC) -o /dev/null -c -x c - > /dev/null 2>&1 && echo y), $2)
+
+ # have udis86 disassembler library?
+ udis86-flags := $(call test-build,\#include <udis86.h>,-DHAVE_UDIS86 -ludis86)
+--
+1.7.9.5
+

meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb +1 -0

index 74eafbb..a0c823b 100644
@@ -18,6 +18,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
             file://trace-cmd-Add-checks-for-invalid-pointers-to-fix-seg.patch \
             file://trace-cmd-Do-not-call-stop_threads-if-doing-latency-.patch \
             file://trace-cmd-Setting-plugin-to-nop-clears-data-before-i.patch \
+           file://trace-cmd-fix-syntax-error-of-shell.patch \
  "
  S = "${WORKDIR}/git"

Signature · 1 line

1.8.1.2

Richard Purdie

2014-04-08 10:08 UTC #4 lore raw

Quoted 47 lines · Chong Lu

Quoted 46 lines · Richard Purdie
Quoted 36 lines · Chong Lu
Delete "<<<" syntax of bash in Makefile, else we would get following error:
Syntax error: redirection unexpected
[YOCTO #6112]
Signed-off-by Chong Lu <[email protected]>
---
  meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |  3 ++-
  .../kernelshark-fix-syntax-error-of-shell.patch    | 30 ++++++++++++++++++++++
  .../trace-cmd-fix-syntax-error-of-shell.patch      | 30 ++++++++++++++++++++++
  meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb     |  1 +
  4 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb +2 -1
index 9268a50..d61097d 100644
@@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
  SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
             file://addldflags.patch \
             file://make-docs-optional.patch \
-           file://blktrace-api-compatibility.patch"
+           file://blktrace-api-compatibility.patch \
+           file://kernelshark-fix-syntax-error-of-shell.patch"
  S = "${WORKDIR}/git"
 
  EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +0 -0
new file mode 100644
index 0000000..994a9fa
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch line 7
Quoted 7 lines
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +7 -0
@@ -0,0 +1,30 @@
+kernelshark: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+	Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
How is this embedded specific?

Quoted 6 lines

Quoted 3 lines
Cheers,
Richard
This issue only produced in yocto.
It is not problem for kernelshark and trace-cmd itself. So I think this is embedded specific.

I'm afraid I don't accept this explanation. Is Yocto's make different somehow which causes this error?

I don't understand why yocto would see this error yet other systems (which use the same make as far as I know) would not.

Cheers,

Richard

Chong Lu

author

2014-04-09 07:49 UTC #5 lore raw

Quoted 57 lines · Richard Purdie

Quoted 47 lines · Chong Lu
Quoted 46 lines · Richard Purdie
Quoted 36 lines · Chong Lu
Delete "<<<" syntax of bash in Makefile, else we would get following error:
Syntax error: redirection unexpected
[YOCTO #6112]
Signed-off-by Chong Lu <[email protected]>
---
   meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |  3 ++-
   .../kernelshark-fix-syntax-error-of-shell.patch    | 30 ++++++++++++++++++++++
   .../trace-cmd-fix-syntax-error-of-shell.patch      | 30 ++++++++++++++++++++++
   meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb     |  1 +
   4 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb +2 -1
index 9268a50..d61097d 100644
@@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
   SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
              file://addldflags.patch \
              file://make-docs-optional.patch \
-           file://blktrace-api-compatibility.patch"
+           file://blktrace-api-compatibility.patch \
+           file://kernelshark-fix-syntax-error-of-shell.patch"
   S = "${WORKDIR}/git"
 
   EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +0 -0
new file mode 100644
index 0000000..994a9fa
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch line 7
Quoted 7 lines
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +7 -0
@@ -0,0 +1,30 @@
+kernelshark: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+	Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
How is this embedded specific?
Quoted 6 lines
Quoted 3 lines
Cheers,
Richard
This issue only produced in yocto.
It is not problem for kernelshark and trace-cmd itself. So I think this is embedded specific.
I'm afraid I don't accept this explanation. Is Yocto's make different somehow which causes this error?

Quoted 7 lines

I don't understand why yocto would see this error yet other systems (which use the same make as far as I know) would not.
Cheers,
Richard

Hi Richard,

I built kernelshark and trace-cmd in Ubuntu 12.04.
The dash is default shell in this distrobution.
So, this issue would produce only on host that the default shell is not bash.

Best Regards
Chong

Quoted 2 lines

Richard Purdie

2014-04-09 09:28 UTC #6 lore raw

Quoted 63 lines · Chong Lu

Quoted 62 lines · Richard Purdie
Quoted 47 lines · Chong Lu
Quoted 46 lines · Richard Purdie
Quoted 36 lines · Chong Lu
Delete "<<<" syntax of bash in Makefile, else we would get following error:
Syntax error: redirection unexpected
[YOCTO #6112]
Signed-off-by Chong Lu <[email protected]>
---
   meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |  3 ++-
   .../kernelshark-fix-syntax-error-of-shell.patch    | 30 ++++++++++++++++++++++
   .../trace-cmd-fix-syntax-error-of-shell.patch      | 30 ++++++++++++++++++++++
   meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb     |  1 +
   4 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb +2 -1
index 9268a50..d61097d 100644
@@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
   SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
              file://addldflags.patch \
              file://make-docs-optional.patch \
-           file://blktrace-api-compatibility.patch"
+           file://blktrace-api-compatibility.patch \
+           file://kernelshark-fix-syntax-error-of-shell.patch"
   S = "${WORKDIR}/git"
 
   EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +0 -0
new file mode 100644
index 0000000..994a9fa
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch line 7
Quoted 7 lines
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +7 -0
@@ -0,0 +1,30 @@
+kernelshark: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+	Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
How is this embedded specific?
Quoted 6 lines
Quoted 3 lines
Cheers,
Richard
This issue only produced in yocto.
It is not problem for kernelshark and trace-cmd itself. So I think this is embedded specific.
I'm afraid I don't accept this explanation. Is Yocto's make different somehow which causes this error?
I don't understand why yocto would see this error yet other systems (which use the same make as far as I know) would not.
Cheers,

Quoted 8 lines

Quoted 2 lines
Richard
Hi Richard,
I built kernelshark and trace-cmd in Ubuntu 12.04.
The dash is default shell in this distrobution.
So, this issue would produce only on host that the default shell is not bash.

Right, so the Upstream-Status is not "embedded specific", its a general problems for shells which are not bash?

Cheers,

Richard

Chong Lu

author

2014-04-09 09:36 UTC #7 lore raw

Quoted 72 lines · Richard Purdie

Quoted 63 lines · Chong Lu
Quoted 62 lines · Richard Purdie
Quoted 47 lines · Chong Lu
Quoted 46 lines · Richard Purdie
Quoted 36 lines · Chong Lu
Delete "<<<" syntax of bash in Makefile, else we would get following error:
Syntax error: redirection unexpected
[YOCTO #6112]
Signed-off-by Chong Lu <[email protected]>
---
    meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb   |  3 ++-
    .../kernelshark-fix-syntax-error-of-shell.patch    | 30 ++++++++++++++++++++++
    .../trace-cmd-fix-syntax-error-of-shell.patch      | 30 ++++++++++++++++++++++
    meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb     |  1 +
    4 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb +2 -1
index 9268a50..d61097d 100644
@@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
    SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
               file://addldflags.patch \
               file://make-docs-optional.patch \
-           file://blktrace-api-compatibility.patch"
+           file://blktrace-api-compatibility.patch \
+           file://kernelshark-fix-syntax-error-of-shell.patch"
    S = "${WORKDIR}/git"
 
    EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +0 -0
new file mode 100644
index 0000000..994a9fa
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch line 7
Quoted 7 lines
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch new file +7 -0
@@ -0,0 +1,30 @@
+kernelshark: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+	Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
How is this embedded specific?
Quoted 6 lines
Quoted 3 lines
Cheers,
Richard
This issue only produced in yocto.
It is not problem for kernelshark and trace-cmd itself. So I think this is embedded specific.
I'm afraid I don't accept this explanation. Is Yocto's make different somehow which causes this error?
I don't understand why yocto would see this error yet other systems (which use the same make as far as I know) would not.
Cheers,
Quoted 8 lines
Quoted 2 lines
Richard
Hi Richard,
I built kernelshark and trace-cmd in Ubuntu 12.04.
The dash is default shell in this distrobution.
So, this issue would produce only on host that the default shell is not bash.

Quoted 7 lines

Right, so the Upstream-Status is not "embedded specific", its a general problems for shells which are not bash?
Cheers,
Richard

Ok, thanks. I got it. I will resend V2.

Best Regards
Chong

Quoted 1 line