populate_sdk_base: modify the recrdeptask of do_populate_sdk
cover populate_sdk_base: modify the recrdeptask of do_populate_sdk
The following changes since commit b77494025b3d47fd5130ae6c445ac84cabb1f91e:
sstatetests: Use TUNE_ARCH instead of TARGET_ARCH (2014-05-04 17:36:14 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib ChenQi/populate_sdk_rm_work
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/populate_sdk_recrdeptask
Chen Qi (1):
populate_sdk_base: modify the recrdeptask of do_populate_sdk
meta/classes/populate_sdk_base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
PATCH 1/1 populate_sdk_base: modify the recrdeptask of do_populate_sdk
If 'rm_work' is enabled, `bitbake core-image-xxx -c populate_sdk' doesn't clean things up for the nativesdk packages.
This patch modifies the 'recrdeptask' for do_populate_sdk to fix this problem.
--- meta/classes/populate_sdk_base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/populate_sdk_base.bbclass +1 -1
@@ -333,5 +333,5 @@ populate_sdk_log_check() { do_populate_sdk[dirs] = "${TOPDIR}" do_populate_sdk[depends] += "${@' '.join([x + ':do_populate_sysroot' for x in d.getVar('SDK_DEPENDS', True).split()])}" do_populate_sdk[rdepends] = "${@' '.join([x + ':do_populate_sysroot' for x in d.getVar('SDK_RDEPENDS', True).split()])}" -do_populate_sdk[recrdeptask] += "do_packagedata do_package_write_rpm do_package_write_ipk do_package_write_deb" +do_populate_sdk[recrdeptask] += "do_packagedata do_${BB_DEFAULT_TASK}" addtask populate_sdk
Signature · 1 line
1.7.9.5
Quoted 16 lines · Chen Qi
If '
rm_work' is enabled, `bitbake core-image-xxx -cpopulate_sdk' doesn't clean things up for the nativesdk packages.This patch modifies the 'recrdeptask' for
do_populate_sdkto fix this problem.Signed-off-by Chen Qi <[email protected]>--- meta/classes/populate_sdk_base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/populate_sdk_base.bbclass +0
-0
meta/classes/populate_sdk_base.bbclass populate_sdk_log_check() { · line 336
Quoted 5 lines
meta/classes/populate_sdk_base.bbclass +1
-1@@ -333,5 +333,5 @@ populate_sdk_log_check() { do_populate_sdk[dirs] = "${TOPDIR}" do_populate_sdk[depends] += "${@' '.join([x + ':do_populate_sysroot' for x in d.getVar('SDK_DEPENDS', True).split()])}" do_populate_sdk[rdepends] = "${@' '.join([x + ':do_populate_sysroot' for x in d.getVar('SDK_RDEPENDS', True).split()])}" -do_populate_sdk[recrdeptask] += "do_packagedata do_package_write_rpm do_package_write_ipk do_package_write_deb" +do_populate_sdk[recrdeptask] += "do_packagedata do_${BB_DEFAULT_TASK}"
No. This task has no such dependency on do_build of the other tasks. We don't create invalid dependencies just for the sake of it.
If you run "bitbake X -c populate_sysroot" or -c package_write_ipk or 101 other options, it will not run rm_work either. Are you proposing we add do_${BB_DEFAULT_TASK} to every task in the system?
Cheers,
Richard
Quoted 25 lines · Richard Purdie
Quoted 16 lines · Chen Qi
If '
rm_work' is enabled, `bitbake core-image-xxx -cpopulate_sdk' doesn't clean things up for the nativesdk packages.This patch modifies the 'recrdeptask' for
do_populate_sdkto fix this problem.Signed-off-by Chen Qi <[email protected]>--- meta/classes/populate_sdk_base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/populate_sdk_base.bbclass +0
-0meta/classes/populate_sdk_base.bbclass populate_sdk_log_check() { · line 336
Quoted 5 lines
meta/classes/populate_sdk_base.bbclass +1
-1@@ -333,5 +333,5 @@ populate_sdk_log_check() { do_populate_sdk[dirs] = "${TOPDIR}" do_populate_sdk[depends] += "${@' '.join([x + ':do_populate_sysroot' for x in d.getVar('SDK_DEPENDS', True).split()])}" do_populate_sdk[rdepends] = "${@' '.join([x + ':do_populate_sysroot' for x in d.getVar('SDK_RDEPENDS', True).split()])}" -do_populate_sdk[recrdeptask] += "do_packagedata do_package_write_rpm do_package_write_ipk do_package_write_deb" +do_populate_sdk[recrdeptask] += "do_packagedata do_${BB_DEFAULT_TASK}"No. This task has no such dependency on
do_buildof the other tasks. We don't create invalid dependencies just for the sake of it.
Quoted 10 lines
If you run "bitbake X -c
populate_sysroot" or -cpackage_write_ipkor 101 other options, it will not runrm_workeither. Are you proposing we add do_${BB_DEFAULT_TASK} to every task in the system?Cheers,
Richard
Thanks for making things clear.
Best Regards,
Chen Qi