Skip to contentSkip to conversation

strace: fix ptest execution failure

PATCH In review Chong Lu 3 participants 6 messages May 27, 2014 – May 28, 2014

lore
Share & tools
lore

Chong Lu

author
#0 lore raw

cover strace: fix ptest execution failure

The following changes since commit 894df445fa71a170397c6e0b4960a89ef20a4230:

guile: Update to 2.0.11 version (2014-05-21 19:50:21 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib chonglu/strace
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/strace

Chong Lu (1):
strace: fix ptest execution failure

 meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
 meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 1/1 strace: fix ptest execution failure

Modify ptest suite to make it execute successfully.

---
 meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
 meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
meta/recipes-devtools/strace/strace-4.8/run-ptest +1 -1
index 133cf92..66639fb 100755
@@ -1,2 +1,2 @@
 #!/bin/sh
-make -C tests -k runtest-TESTS
+make -C tests -k check-TESTS
meta/recipes-devtools/strace/strace_4.8.bb +6 -0
index 71563d4..9769cd4 100644
@@ -41,6 +41,12 @@ do_compile_ptest() {
 
 do_install_ptest() {
 	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B} DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
+	install ${S}/test-driver ${D}${PTEST_PATH}
+	sed -e 's/bash/sh/' \
+	    -e 's/gawk/awk/' \
+	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
+	    -e '/^all:/a\\t@:' \
+	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
 }
 
 BBCLASSEXTEND = "native"
Signature · 1 line
1.8.1.2
#2 lore raw
Quoted 24 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Chong Lu
Sent: Tuesday, May 27, 2014 10:03
To: [email protected]
Subject: [OE-core] [PATCH 1/1] strace: fix ptest execution failure

Modify ptest suite to make it execute successfully.

---
 meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
 meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
meta/recipes-devtools/strace/strace-4.8/run-ptest +0 -0
index 133cf92..66639fb 100755

meta/recipes-devtools/strace/strace-4.8/run-ptest line 2

Quoted 3 lines
meta/recipes-devtools/strace/strace-4.8/run-ptest +1 -1
@@ -1,2 +1,2 @@
 #!/bin/sh
-make -C tests -k runtest-TESTS
+make -C tests -k check-TESTS

I have the same comment as in the previous patch. I'd rather use serial-tests in configure.ac file instead of this change.

Quoted 27 lines
meta/recipes- renamed from meta/recipes-devtools/strace/strace_4.8.bb +0 -0

devtools/strace/strace_4.8.bb
index 71563d4..9769cd4 100644

meta/recipes-devtools/strace/strace_4.8.bb +6 -0
@@ -41,6 +41,12 @@ do_compile_ptest() {
 
 do_install_ptest() {
 	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B}
 DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
+	install ${S}/test-driver ${D}${PTEST_PATH}
+	sed -e 's/bash/sh/' \
+	    -e 's/gawk/awk/' \
+	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
+	    -e '/^all:/a\\t@:' \
+	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
 }
 

BBCLASSEXTEND = "native"
--
1.8.1.2

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 18 lines · Tudor Florea
Quoted 18 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Chong Lu
Sent: Tuesday, May 27, 2014 10:03
To: [email protected]
Subject: [OE-core] [PATCH 1/1] strace: fix ptest execution failure

Modify ptest suite to make it execute successfully.

---
  meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
  meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
  2 files changed, 7 insertions(+), 1 deletion(-)
Quoted 11 lines

meta/recipes-devtools/strace/strace-4.8/run-ptest line 2

Quoted 9 lines
meta/recipes-devtools/strace/strace-4.8/run-ptest +1 -1
index 133cf92..66639fb 100755
@@ -1,2 +1,2 @@
  #!/bin/sh
-make -C tests -k runtest-TESTS
+make -C tests -k check-TESTS

I have the same comment as in the previous patch. I'd rather use serial-tests in configure.ac file instead of this change.

You mentioned a past patch not merged, can you rebase against master and resent if it's still appropriate?

Thanks
Sau!

Quoted 27 lines
Quoted 27 lines
meta/recipes- renamed from meta/recipes-devtools/strace/strace_4.8.bb +0 -0

devtools/strace/strace_4.8.bb
index 71563d4..9769cd4 100644

meta/recipes-devtools/strace/strace_4.8.bb +6 -0
@@ -41,6 +41,12 @@ do_compile_ptest() {
 
  do_install_ptest() {
  	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B}
 DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
+	install ${S}/test-driver ${D}${PTEST_PATH}
+	sed -e 's/bash/sh/' \
+	    -e 's/gawk/awk/' \
+	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
+	    -e '/^all:/a\\t@:' \
+	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
  }
 

BBCLASSEXTEND = "native"
--
1.8.1.2

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#5 lore raw
In reply to Tudor Florea
Quoted 17 lines · Tudor Florea
Quoted 17 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Chong Lu
Sent: Tuesday, May 27, 2014 10:03
To: [email protected]
Subject: [OE-core] [PATCH 1/1] strace: fix ptest execution failure

Modify ptest suite to make it execute successfully.

---
  meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
  meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
  2 files changed, 7 insertions(+), 1 deletion(-)
Quoted 10 lines

meta/recipes-devtools/strace/strace-4.8/run-ptest line 2

Quoted 9 lines
meta/recipes-devtools/strace/strace-4.8/run-ptest +1 -1
index 133cf92..66639fb 100755
@@ -1,2 +1,2 @@
  #!/bin/sh
-make -C tests -k runtest-TESTS
+make -C tests -k check-TESTS

I have the same comment as in the previous patch. I'd rather use serial-tests in configure.ac file instead of this change.

Ok. Thanks for your suggestion.

Best Regards
Chong

Quoted 29 lines
Quoted 28 lines
meta/recipes- renamed from meta/recipes-devtools/strace/strace_4.8.bb +0 -0

devtools/strace/strace_4.8.bb
index 71563d4..9769cd4 100644

meta/recipes-devtools/strace/strace_4.8.bb +6 -0
@@ -41,6 +41,12 @@ do_compile_ptest() {
 
  do_install_ptest() {
  	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B}
 DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
+	install ${S}/test-driver ${D}${PTEST_PATH}
+	sed -e 's/bash/sh/' \
+	    -e 's/gawk/awk/' \
+	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
+	    -e '/^all:/a\\t@:' \
+	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
  }
 

BBCLASSEXTEND = "native"
--
1.8.1.2

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw
In reply to Saul Wold
Quoted 38 lines

-----Original Message-----
From: Saul Wold [mailto:[email protected]]
Sent: Tuesday, May 27, 2014 18:23
To: Tudor Florea; Chong Lu; [email protected]
Subject: Re: [OE-core] [PATCH 1/1] strace: fix ptest execution failure

Quoted 5 lines · Tudor Florea
Quoted 5 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On

Behalf

Quoted 13 lines
Quoted 13 lines

Of Chong Lu
Sent: Tuesday, May 27, 2014 10:03
To: [email protected]
Subject: [OE-core] [PATCH 1/1] strace: fix ptest execution failure

Modify ptest suite to make it execute successfully.

---
  meta/recipes-devtools/strace/strace-4.8/run-ptest | 2 +-
  meta/recipes-devtools/strace/strace_4.8.bb        | 6 ++++++
  2 files changed, 7 insertions(+), 1 deletion(-)
Quoted 10 lines

meta/recipes-devtools/strace/strace-4.8/run-ptest line 2

Quoted 9 lines
meta/recipes-devtools/strace/strace-4.8/run-ptest +1 -1
index 133cf92..66639fb 100755
@@ -1,2 +1,2 @@
  #!/bin/sh
-make -C tests -k runtest-TESTS
+make -C tests -k check-TESTS

I have the same comment as in the previous patch. I'd rather use serial-

Quoted 8 lines

tests in configure.ac file instead of this change.

Quoted 1 line

You mentioned a past patch not merged, can you rebase against master and resent if it's still appropriate?

Thanks
Sau!

I'll review and resend the patch I a couple of days. Regards,
Tudor.

Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
meta/recipes- renamed from meta/recipes-devtools/strace/strace_4.8.bb +0 -0

devtools/strace/strace_4.8.bb
index 71563d4..9769cd4 100644

meta/recipes-devtools/strace/strace_4.8.bb +6 -0
@@ -41,6 +41,12 @@ do_compile_ptest() {
 
  do_install_ptest() {
  	oe_runmake -C ${TESTDIR} install-ptest BUILDDIR=${B}
 DESTDIR=${D}${PTEST_PATH} TESTDIR=${TESTDIR}
+	install ${S}/test-driver ${D}${PTEST_PATH}
+	sed -e 's/bash/sh/' \
+	    -e 's/gawk/awk/' \
+	    -e 's/^top_srcdir = \(.*\)/top_srcdir = ../' \
+	    -e '/^all:/a\\t@:' \
+	    -i ${D}${PTEST_PATH}/${TESTDIR}/Makefile
  }
 

BBCLASSEXTEND = "native"
--
1.8.1.2

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core