Skip to contentSkip to conversation

webmin: Drop allarch

PATCH In review Anders Darander 3 participants 5 messages Jun 24, 2014 – Jun 25, 2014

lore
Share & tools
lore
#0 lore raw

cover webmin: Drop allarch

webmin: Drop the allarch as the package gets rebuild when changing MACHINE, due to it having an RDEPENDS on perl (TUNE_PKGARCH).

Reported by Martin Jansa.

The following changes since commit 4fcc5cc1cca20d7c772f7c8b1999ef15fd2dc260:

python-cython: upgrade to 2.20.2 and fix packaging QA issue (2014-06-21 19:22:29 +0200)

are available in the git repository at:

git://github.com/darander/meta-oe 1b5c27f39444bed435c8c050b2fb6def74a5adb8
https://github.com/darander/meta-oe/tree/webmin-noallarch

Anders Darander (1):
webmin: drop allarch

 meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.0.0
#1 lore raw

PATCH 1/1 webmin: drop allarch

* runtime dependencies are TUNE_PKGARCH causing do_package_write_* task to have different signature for MACHINEs with different TUNE_PKGARCH

---
 meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb +1 -1
index 7eb1d63..0f8781f 100644
@@ -20,7 +20,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/webadmin/webmin-${PV}.tar.gz \
 SRC_URI[md5sum] = "e93bc5057a5b7d7e31ecb2bb228d7044"
 SRC_URI[sha256sum] = "3d36153406d8e5d3dcaeadba34dfb5cdbc4060b75c38339174ac97b2277f284b"
 
-inherit allarch perlnative update-rc.d
+inherit perlnative update-rc.d
 
 do_configure() {
     # Remove binaries and plugins for other platforms
Signature · 1 line
2.0.0
#2 lore raw

Re: [meta-webserver][PATCH 1/1] webmin: drop allarch

Quoted 20 lines · On Tuesday 24 June 2014 09:54:12 Anders Darander wrote:

* runtime dependencies are TUNE_PKGARCH causing do_package_write_* task to have different signature for MACHINEs with different TUNE_PKGARCH

---
 meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb index 7eb1d63..0f8781f 100644

meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb +0 -0
@@ -20,7 +20,7 @@ SRC_URI =

"${SOURCEFORGE_MIRROR}/webadmin/webmin-${PV}.tar.gz \ SRC_URI[md5sum] = "e93bc5057a5b7d7e31ecb2bb228d7044"
SRC_URI[sha256sum] =
"3d36153406d8e5d3dcaeadba34dfb5cdbc4060b75c38339174ac97b2277f284b"

meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb SRC_URI = "${SOURCEFORGE_MIRROR}/webadmin/webmin-${PV}.tar.gz \ · line 26

Quoted 5 lines
meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb +1 -1
-inherit allarch perlnative update-rc.d
+inherit perlnative update-rc.d
 
 do_configure() {
     # Remove binaries and plugins for other platforms

So apart from me being reticent to make this change at all (for reasons that we've discussed before), there is another issue - allarch.bbclass does more than just setting PACKAGE_ARCH, it also disables certain other functionality such as debug symbol splitting which is superfluous for these kinds of recipes; in my testing when I originally wrote the webmin recipe this significantly reduced the time required to build the recipe. We can't just drop this inherit without regard to that. (I'm sure the same applies elsewhere, it's just that the size of webmin makes the impact significant.)

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#3 lore raw

Re: [meta-webserver][PATCH 1/1] webmin: drop allarch

Quoted 10 lines · Paul Eggleton

meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb SRC_URI = "${SOURCEFORGE_MIRROR}/webadmin/webmin-${PV}.tar.gz \ · line 23

Quoted 6 lines · On Tuesday 24 June 2014 09:54:12 Anders Darander wrote:

* runtime dependencies are TUNE_PKGARCH causing do_package_write_* task to have different signature for MACHINEs with different TUNE_PKGARCH

meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb +1 -1
-inherit allarch perlnative update-rc.d
+inherit perlnative update-rc.d

So apart from me being reticent to make this change at all (for reasons that we've discussed before),

Yes, I'm well aware of those discussions. I was actually thinking about CC:ing you on my reply to Martin, after he suggested something like this change.

Quoted 8 lines

there is another issue - allarch.bbclass does more than just setting PACKAGE_ARCH, it also disables certain other functionality such as debug symbol splitting which is superfluous for these kinds of recipes; in my testing when I originally wrote the webmin recipe this significantly reduced the time required to build the recipe. We can't just drop this inherit without regard to that. (I'm sure the same applies elsewhere, it's just that the size of webmin makes the impact significant.)

I'm all for saving time! (And I'm not personally concerned by this issue, as I'm currently only using webmin in a build tree for a signle machine).

Though, to get back to Martin Jansa's issue; if there isn't already an enhancment request file to the Yocto bugzilla, maybe it's time to file one regarding the possibillity of having an allarch package RDEPENDS/RRECOMMNEND a package with an ARCH or MACHINE tune...

Paul, what do you think about the feasibility of finding such a solution?

Cheers,
Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB / eStorm AB
#4 lore raw

Re: [meta-webserver][PATCH 1/1] webmin: drop allarch

Quoted 26 lines · Anders Darander
Quoted 10 lines · Paul Eggleton

meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb SRC_URI = "${SOURCEFORGE_MIRROR}/webadmin/webmin-${PV}.tar.gz \ · line 23

Quoted 6 lines · On Tuesday 24 June 2014 09:54:12 Anders Darander wrote:

* runtime dependencies are TUNE_PKGARCH causing do_package_write_* task to have different signature for MACHINEs with different TUNE_PKGARCH

meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb +1 -1
-inherit allarch perlnative update-rc.d
+inherit perlnative update-rc.d

So apart from me being reticent to make this change at all (for reasons that we've discussed before),

Yes, I'm well aware of those discussions. I was actually thinking about CC:ing you on my reply to Martin, after he suggested something like this change.

Quoted 8 lines

there is another issue - allarch.bbclass does more than just setting PACKAGE_ARCH, it also disables certain other functionality such as debug symbol splitting which is superfluous for these kinds of recipes; in my testing when I originally wrote the webmin recipe this significantly reduced the time required to build the recipe. We can't just drop this inherit without regard to that. (I'm sure the same applies elsewhere, it's just that the size of webmin makes the impact significant.)

Quoted 3 lines

I'm all for saving time! (And I'm not personally concerned by this issue, as I'm currently only using webmin in a build tree for a signle machine).

you can probably use allarch and assign
PACKAGE_ARCH = "${TUNE_PKGARCH}"
I don't remember how many savings will be disabled by this combination.

For multimachine builds these savings could be worse, because better to spend a bit more time building everything just once per TUNE_PKGARCH and don't touch it again (until the signature is changed) than keeping it allarch, but still building it once per TUNE_PKGARCH (because of different signature and then unpacking it from sstate *every-single-time* you're building image for different MACHINE (so even without any change to webmin recipe).

Quoted 4 lines

Though, to get back to Martin Jansa's issue; if there isn't already an enhancment request file to the Yocto bugzilla, maybe it's time to file one regarding the possibillity of having an allarch package RDEPENDS/RRECOMMNEND a package with an ARCH or MACHINE tune...

There is one already:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5970

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]