Skip to contentSkip to conversation

Fix for YB6502

PATCH In review Roxana Ciobanu 3 participants 4 messages Jul 9, 2014 – Jul 13, 2014

lore
Share & tools
lore
#0 lore raw

cover Fix for YB6502

The following changes since commit 6879c3c903ec7d08cf0240281c83d85b4a42b6db:

maintainers.inc: add info for libical (2014-07-08 11:20:14 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib roxana/YB6502
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=roxana/YB6502

Roxana Ciobanu (1):
image.bbclass: add ROOTFS_POSTPROCESS_COMMAND to rootfs[vardeps]

 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 image.bbclass: add ROOTFS_POSTPROCESS_COMMAND to rootfs[vardeps]

Changes to ROOTFS_POSTPROCESS_COMMAND require the rootfs for the image to be rebuilt.

[YOCTO #6502]

---
 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/image.bbclass +1 -1
index a03b880..e088bdb 100644
@@ -75,7 +75,7 @@ LDCONFIGDEPEND_libc-musl = ""
 do_rootfs[depends] += "makedevs-native:do_populate_sysroot virtual/fakeroot-native:do_populate_sysroot ${LDCONFIGDEPEND}"
 do_rootfs[depends] += "virtual/update-alternatives-native:do_populate_sysroot update-rc.d-native:do_populate_sysroot"
 do_rootfs[recrdeptask] += "do_packagedata"
-do_rootfs[vardeps] += "BAD_RECOMMENDATIONS NO_RECOMMENDATIONS"
+do_rootfs[vardeps] += "BAD_RECOMMENDATIONS NO_RECOMMENDATIONS ROOTFS_POSTPROCESS_COMMAND"
 
 do_build[depends] += "virtual/kernel:do_deploy"
 
Signature · 1 line
1.9.1
#2 lore raw

Re: [PATCH 1/1] image.bbclass: add ROOTFS_POSTPROCESS_COMMAND to rootfs[vardeps]

Quoted 15 lines · Roxana Ciobanu

Changes to ROOTFS_POSTPROCESS_COMMAND require the rootfs for the image to be rebuilt.

[YOCTO #6502]

---
 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/image.bbclass +0 -0
index a03b880..e088bdb 100644

meta/classes/image.bbclass LDCONFIGDEPEND_libc-musl = "" · line 80

Quoted 7 lines
meta/classes/image.bbclass +1 -1
@@ -75,7 +75,7 @@ LDCONFIGDEPEND_libc-musl = ""
 do_rootfs[depends] += "makedevs-native:do_populate_sysroot virtual/fakeroot-native:do_populate_sysroot ${LDCONFIGDEPEND}"
 do_rootfs[depends] += "virtual/update-alternatives-native:do_populate_sysroot update-rc.d-native:do_populate_sysroot"
 do_rootfs[recrdeptask] += "do_packagedata"
-do_rootfs[vardeps] += "BAD_RECOMMENDATIONS NO_RECOMMENDATIONS"
+do_rootfs[vardeps] += "BAD_RECOMMENDATIONS NO_RECOMMENDATIONS ROOTFS_POSTPROCESS_COMMAND"
 
 do_build[depends] += "virtual/kernel:do_deploy"

Are there other variables we look at in the rootfs process we also need to list here?

As background, the move to lib/oe has moved the variables outside the scope of bitbake's function parsing code so we need to handle that manually now...

Cheers,

Richard

#3 lore raw

Re: [PATCH 1/1] image.bbclass: add ROOTFS_POSTPROCESS_COMMAND to rootfs[vardeps]

Quoted 22 lines · Richard Purdie
Quoted 21 lines · Roxana Ciobanu

Changes to ROOTFS_POSTPROCESS_COMMAND require the rootfs for the image to be rebuilt.

[YOCTO #6502]

---
 meta/classes/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/image.bbclass +1 -1
index a03b880..e088bdb 100644
@@ -75,7 +75,7 @@ LDCONFIGDEPEND_libc-musl = ""
 do_rootfs[depends] += "makedevs-native:do_populate_sysroot virtual/fakeroot-native:do_populate_sysroot ${LDCONFIGDEPEND}"
 do_rootfs[depends] += "virtual/update-alternatives-native:do_populate_sysroot update-rc.d-native:do_populate_sysroot"
 do_rootfs[recrdeptask] += "do_packagedata"
-do_rootfs[vardeps] += "BAD_RECOMMENDATIONS NO_RECOMMENDATIONS"
+do_rootfs[vardeps] += "BAD_RECOMMENDATIONS NO_RECOMMENDATIONS ROOTFS_POSTPROCESS_COMMAND"
 
Quoted 9 lines

meta/classes/image.bbclass LDCONFIGDEPEND_libc-musl = "" · line 80

Quoted 1 line
meta/classes/image.bbclass +0 -0
 do_build[depends] += "virtual/kernel:do_deploy"

Are there other variables we look at in the rootfs process we also need to list here?

As background, the move to lib/oe has moved the variables outside the scope of bitbake's function parsing code so we need to handle that manually now...

I was hit by this recently, and talked to kergoth on IRC about it. As he suggested, perhaps we should also do

ROOTFS_POSTPROCESS_COMMAND[func] = "1"

to inform bitbake that it is a shell script, so that it invokes its shell dependency parsing. I would guess most people add a function, and append this to ROOTFS_POSTPROCESS_COMMAND. Without marking it as a function, changes in the actual function body would not trigger rootfs rebuilds.

/Jacob