Skip to contentSkip to conversation

image-ucode.bbclass: a new bbclass for initramfs images

PATCH Kamble, Nitin A 1 participant 1 message Jul 25, 2014 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 8153ac4d137126ac86039128af8ad464af2d21e3.1405728594.git.nitin.a.kamble@intel.com

A message that is not in the archive (sent off-list or not yet received): CAJTo0LbN=VXEp2t+mBm9a8A4XHz6P+N4zAbV63a=6t6ojka7zw@mail.gmail.com

#3 lore raw
Quoted 19 lines

-----Original Message-----
From: Burton, Ross [mailto:[email protected]]
Sent: Monday, July 21, 2014 12:30 PM
To: Kamble, Nitin A
Cc: Zanussi, Tom; Hart, Darren; Purdie, Richard; [email protected]
Subject: Re: [Patch v4 4/6] image-ucode.bbclass: a new bbclass for initramfs images

Review

Quoted 3 lines · On 19 July 2014 01:18, <[email protected]> wrote:
(quoted diff) +3 -0
+IMAGE_TYPES += "cpio.gz.ucode"
+COMPRESSIONTYPES += "gz.ucode"
+COMPRESS_CMD_gz.ucode = "${COMPRESS_CMD_gz}; cat

${EARLY_UCODE_CPIO} ${IMAGE_NAME}.rootfs.${type}.gz > ${IMAGE_NAME}.rootfs.${type}.gz.ucode"

Quoted 1 line

+COMPRESS_DEPENDS_gz.ucode = "${COMPRESS_DEPENDS_gz} intel-

microcode"

Quoted 8 lines

Something about this has always bugged me and I just realised what it is. As I understand it the kernel allows an arbitrary number of cpio archives to be appended to the kernel, but our image creation code expects one. This class is basically working around that limitation by being a specialised image type that appends another hard-coded file.

If the image creation code was changed to expect a list, then we wouldn't need this class at all but could simply do INITRD += $(EARLY_UCODE_CPIO).

As this change will be in oecore layer, adding oecore mailing list to this thread.

The INITRD variable is used at different places like grub-efi.bbclass, syslinux.bbclass, bootimg.bbclass, gummyboot.bbclass, boot-directdisk.bbclass, image-live.bbclass . So extending INITRD var is going to be bit invasive. Let me see if this can be handled in less invasive way.

Nitin

Quoted 2 lines

Ross