Skip to contentSkip to conversation

wic: A few minor fixes

PATCH New Tom Zanussi 1 participant 4 messages Jul 22, 2014

lore
Share & tools
lore
#0 lore raw

cover wic: A few minor fixes

Just a few minor fixes for the recently added help text and a couple fixes noticed while testing related things.

The following changes since commit 8b7116d25ed6255a03895d835e5a0560858ab496:

bitbake: Updated the the example 'bitbake -h' output to match the actual output, which has been recently patched to fix the '-S SIGNATURE_HANDLER, --dump-signatures=SIGNATURE_HANDLER' option. (2014-07-22 08:33:25 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib.git tzanussi/wic-fixes
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/wic-fixes

Tom Zanussi (3):
wic: Fix bad directory name in bootimg-efi
wic: Add help entry for wic kickstart
wic: Remove fstype from mkefidisk canned wks

 scripts/lib/image/canned-wks/mkefidisk.wks    | 2 +-
 scripts/lib/image/help.py                     | 1 +
 scripts/lib/mic/plugins/source/bootimg-efi.py | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/3 wic: Fix bad directory name in bootimg-efi

The original move of the mkefidisk code to the bootimg-efi plugin resulted in a bad hdddir - fix it.

---
 scripts/lib/mic/plugins/source/bootimg-efi.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/lib/mic/plugins/source/bootimg-efi.py +1 -1
index 2cc179a..0dd9152 100644
@@ -112,7 +112,7 @@ class BootimgEFIPlugin(SourcePlugin):
         staging_kernel_dir = kernel_dir
         staging_data_dir = bootimg_dir
 
-        hdddir = "%s/hdd" % cr_workdir
+        hdddir = "%s/hdd/boot" % cr_workdir
 
         install_cmd = "install -m 0644 %s/bzImage %s/bzImage" % \
             (staging_kernel_dir, hdddir)
Signature · 1 line
1.8.3.1
#2 lore raw

PATCH 2/3 wic: Add help entry for wic kickstart

Previous patches added help for 'wic kickstart' but forgot to add an entry in the main help page showing its availability. Add an entry for it.

---
 scripts/lib/image/help.py | 1 +
 1 file changed, 1 insertion(+)
scripts/lib/image/help.py +1 -0
index a7e7830..848aa9a 100644
@@ -90,6 +90,7 @@ wic_usage = """
  Help topics:
     overview           wic overview - General overview of wic
     plugins            wic plugins - Overview and API
+    kickstart          wic kickstart - wic kickstart reference
 
  See 'wic help <COMMAND or HELP TOPIC>' for more information on a specific
  command or help topic.
Signature · 1 line
1.8.3.1
#3 lore raw

PATCH 3/3 wic: Remove fstype from mkefidisk canned wks

In reply to Tom Zanussi

The bootimg-efi plugin specifies the fstype internally, so remove it from the partition definition.

---
 scripts/lib/image/canned-wks/mkefidisk.wks | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/lib/image/canned-wks/mkefidisk.wks +1 -1
index e976bc8..db86caa 100644
@@ -2,7 +2,7 @@
 # long-description: Creates a partitioned EFI disk image that the user
 # can directly dd to boot media.
 
-part /boot --source bootimg-efi --ondisk sda --fstype=msdos --label msdos --active --align 1024
+part /boot --source bootimg-efi --ondisk sda --label msdos --active --align 1024
 
 part / --source rootfs --ondisk sda --fstype=ext3 --label platform --align 1024
 
Signature · 1 line
1.8.3.1