Add Freescale ASRC driver

sound/soc/fsl/fsl_asrc.c new file +4 -0

+		return -EINVAL;
+	}
+
+	clk = asrc_priv->asrck_clk[clk_index[OUT]];

sound/soc/fsl/fsl_asrc.c new file +4 -0

+		return -EINVAL;
+	}
+
+	

sound/soc/fsl/fsl_asrc.c new file +14 -0

+static int fsl_asrc_init(struct fsl_asrc *asrc_priv)
+{
+	/* Halt ASRC internal FP when input FIFO needs data for pair A, B, C */
+	regmap_write(asrc_priv->regmap, REG_ASRCTR, ASRCTR_ASRCEN);
+
+	/* Disable interrupt by default */
+	regmap_write(asrc_priv->regmap, REG_ASRIER, 0x0);
+
+	/* Apply recommended settings for parameters from Reference Manual */
+	regmap_write(asrc_priv->regmap, REG_ASRPM1, 0x7fffff);
+	regmap_write(asrc_priv->regmap, REG_ASRPM2, 0x255555);
+	regmap_write(asrc_priv->regmap, REG_ASRPM3, 0xff7280);
+	regmap_write(asrc_priv->regmap, REG_ASRPM4, 0xff7280);
+	regmap_write(asrc_priv->regmap, REG_ASRPM5, 0xff7280);

sound/soc/fsl/fsl_asrc.c new file +8 -0

+
+	return 0;
+}
+
+/**
+ * Interrupt handler for ASRC
+ */
+

sound/soc/fsl/fsl_asrc.c new file +9 -0

+	}, {
+		.compatible = "fsl,imx53-asrc",
+		.data = &fsl_asrc_devtype[IMX53_ASRC],
+	}, {
+		/* sentinel */
+	}
+};
+MODULE_DEVICE_TABLE(of, fsl_asrc_ids);
+

On 07/25/2014 12:49 PM, Nicolin Chen wrote:
(...)

sound/soc/fsl/fsl_asrc.c line 798

Quoted 13 lines

sound/soc/fsl/fsl_asrc.c new file +13 -0

+static const struct platform_device_id fsl_asrc_devtype[] = {
+	{
+		.name = "imx35-asrc",
+		.driver_data = IMX35_ASRC,
+	}, {
+		.name = "imx53-asrc",
+		.driver_data = IMX53_ASRC,
+	}, {
+		/* sentinel */
+	}
+};
+MODULE_DEVICE_TABLE(platform, fsl_asrc_devtype);
+

where are you using fsl_asrc_devtype,,,?

sound/soc/fsl/fsl_asrc.c line 802

Quoted 4 lines

sound/soc/fsl/fsl_asrc.c new file +4 -0

+static const struct of_device_id fsl_asrc_ids[] = {
+	{
+		.compatible = "fsl,imx35-asrc",
+		.data = &fsl_asrc_devtype[IMX35_ASRC],

Ya here ... but what is the use...?

sound/soc/fsl/fsl_asrc.c line 864

Quoted 2 lines

sound/soc/fsl/fsl_asrc.c new file +2 -0

+	asrc_priv->regmap = devm_regmap_init_mmio_clk(&pdev->dev,
+			"mem", regs, &fsl_asrc_regmap_config);

devm_regmap_init_mmio_clk(&pdev->dev,

			  "mem", regs,
			  &fsl_asrc_regmap_config);

Quoted 4 lines

sound/soc/fsl/fsl_asrc.c new file +3 -0

+	if (IS_ERR(asrc_priv->regmap)) {
+		dev_err(&pdev->dev, "failed to init regmap\n");
+		return PTR_ERR(asrc_priv->regmap);

sound/soc/fsl/fsl_asrc.c line 877

Quoted 10 lines

sound/soc/fsl/fsl_asrc.c new file +10 -0

+	}
+
+	irq = platform_get_irq(pdev, 0);
+	if (irq < 0) {
+		dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
+		return irq;
+	}
+
+	ret = devm_request_irq(&pdev->dev, irq, fsl_asrc_isr, 0,
+			       asrc_priv->name, asrc_priv);

same...

Quoted 14 lines · Nicolin Chen

Quoted 14 lines

sound/soc/fsl/fsl_asrc.c line 877

Quoted 13 lines

sound/soc/fsl/fsl_asrc.c new file +13 -0

+	if (IS_ERR(asrc_priv->regmap)) {
+		dev_err(&pdev->dev, "failed to init regmap\n");
+		return PTR_ERR(asrc_priv->regmap);
+	}
+
+	irq = platform_get_irq(pdev, 0);
+	if (irq < 0) {
+		dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
+		return irq;
+	}
+
+	ret = devm_request_irq(&pdev->dev, irq, fsl_asrc_isr, 0,
+			       asrc_priv->name, asrc_priv);

same...

Quoted 1 line

Sorry I don't see any problem with this devm_request_irq()...

Ohhh... This is the problem with my email client... Sorry...

Hi Varka,

Thank you for the comments!

Quoted 18 lines · Varka Bhadram

On 07/25/2014 12:49 PM, Nicolin Chen wrote:
(...)

sound/soc/fsl/fsl_asrc.c line 798

Quoted 13 lines

sound/soc/fsl/fsl_asrc.c new file +13 -0

+static const struct platform_device_id fsl_asrc_devtype[] = {
+	{
+		.name = "imx35-asrc",
+		.driver_data = IMX35_ASRC,
+	}, {
+		.name = "imx53-asrc",
+		.driver_data = IMX53_ASRC,
+	}, {
+		/* sentinel */
+	}
+};
+MODULE_DEVICE_TABLE(platform, fsl_asrc_devtype);
+

where are you using fsl_asrc_devtype,,,?

Quoted 5 lines

sound/soc/fsl/fsl_asrc.c line 802

Quoted 4 lines

sound/soc/fsl/fsl_asrc.c new file +4 -0

+static const struct of_device_id fsl_asrc_ids[] = {
+	{
+		.compatible = "fsl,imx35-asrc",
+		.data = &fsl_asrc_devtype[IMX35_ASRC],

Ya here ... but what is the use...?

I got your point. I will drop all these and move ids behind probe/remove() as you suggested at the first place and then use of_device_is_compatible() inside the probe() instead.

Quoted 5 lines

sound/soc/fsl/fsl_asrc.c line 864

Quoted 2 lines

sound/soc/fsl/fsl_asrc.c new file +2 -0

+	asrc_priv->regmap = devm_regmap_init_mmio_clk(&pdev->dev,
+			"mem", regs, &fsl_asrc_regmap_config);

devm_regmap_init_mmio_clk(&pdev->dev,

			  "mem", regs,
			  &fsl_asrc_regmap_config);

I'll refine to

devm_regmap_init_mmio_clk(&pdev->dev, "mem", regs,

                            &fsl_asrc_regmap_config);

Quoted 6 lines

Quoted 6 lines

sound/soc/fsl/fsl_asrc.c new file +6 -0

+	if (IS_ERR(asrc_priv->regmap)) {
+		dev_err(&pdev->dev, "failed to init regmap\n");
+		return PTR_ERR(asrc_priv->regmap);
+	}
+
+	irq = platform_get_irq(pdev, 0);

Quoted 8 lines

sound/soc/fsl/fsl_asrc.c line 877

Quoted 7 lines

sound/soc/fsl/fsl_asrc.c new file +7 -0

+	if (irq < 0) {
+		dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
+		return irq;
+	}
+
+	ret = devm_request_irq(&pdev->dev, irq, fsl_asrc_isr, 0,
+			       asrc_priv->name, asrc_priv);

same...

Sorry I don't see any problem with this devm_request_irq()...