Skip to contentSkip to conversation

piglit: add bash to RDEPENDS_piglit

PATCH In review Robert Yang 3 participants 7 messages Sep 2, 2014

lore
Share & tools
lore
#0 lore raw

cover piglit: add bash to RDEPENDS_piglit

The following changes since commit 4c0a9ccbad2889b27b4b1d2ab91215a4bdcca3ce:

python-numpy: Fix build for mips64 (2014-09-01 18:00:32 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/piglit
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/piglit

Robert Yang (1):
piglit: add bash to RDEPENDS_piglit

 meta/recipes-graphics/piglit/piglit_git.bb |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 piglit: add bash to RDEPENDS_piglit

Bash:
piglit/usr/lib/piglit/tests/asmparsertest/make_test_list.sh:#!/bin/bash piglit/usr/lib/piglit/tests/asmparsertest/vp-tex.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-read.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-write.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/arb_shader_texture_lod/compiler/make_tex_lod_tests.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct-const.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.20/compiler/built-in-functions/outerProduct-invalid-parameters.sh:#!/bin/bash piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_lod_tests.sh:#!/bin/bash piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_rect_tests.sh:#!/bin/bash

The bash scripts are in the tests directory, we had planned to move the tests into the ptest pkg, but that would make piglit unusable without installing piglit-ptest.

---
 meta/recipes-graphics/piglit/piglit_git.bb |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-graphics/piglit/piglit_git.bb +4 -1
index 5c013ef..f468120 100644
@@ -45,4 +45,7 @@ do_install() {
 
 FILES_${PN}-dbg += "${libdir}/piglit/*/.debug/"
 
-RDEPENDS_${PN} = "python waffle python-json python-subprocess python-multiprocessing python-textutils python-netserver python-shell mesa-demos"
+RDEPENDS_${PN} = "python waffle python-json python-subprocess \
+	python-multiprocessing python-textutils python-netserver python-shell \
+	mesa-demos bash \
+	"
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 27 lines · Robert Yang

Bash:
piglit/usr/lib/piglit/tests/asmparsertest/make_test_list.sh:#!/bin/bash piglit/usr/lib/piglit/tests/asmparsertest/vp-tex.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-read.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-write.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/arb_shader_texture_lod/compiler/make_tex_lod_tests.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct-const.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.20/compiler/built-in-functions/outerProduct-invalid-parameters.sh:#!/bin/bash piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_lod_tests.sh:#!/bin/bash piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_rect_tests.sh:#!/bin/bash

The bash scripts are in the tests directory, we had planned to move the tests into the ptest pkg, but that would make piglit unusable without installing piglit-ptest.

---
 meta/recipes-graphics/piglit/piglit_git.bb |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-graphics/piglit/piglit_git.bb +0 -0
index 5c013ef..f468120 100644

meta/recipes-graphics/piglit/piglit_git.bb do_install() { · line 51

Quoted 8 lines
meta/recipes-graphics/piglit/piglit_git.bb +4 -1
@@ -45,4 +45,7 @@ do_install() {
 
 FILES_${PN}-dbg += "${libdir}/piglit/*/.debug/"
 
-RDEPENDS_${PN} = "python waffle python-json python-subprocess python-multiprocessing python-textutils python-netserver python-shell mesa-demos"
+RDEPENDS_${PN} = "python waffle python-json python-subprocess \
+	python-multiprocessing python-textutils python-netserver python-shell \
+	mesa-demos bash \
+	"

Hi Robert,

how about to split out the tests into an extra package and let the package depends on bash?

Bye Henning

#3 lore raw
Quoted 39 lines · Henning Heinold
Quoted 26 lines · Robert Yang

Bash:
piglit/usr/lib/piglit/tests/asmparsertest/make_test_list.sh:#!/bin/bash piglit/usr/lib/piglit/tests/asmparsertest/vp-tex.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-read.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.10/variable-index-write.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/arb_shader_texture_lod/compiler/make_tex_lod_tests.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct-const.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.20/execution/outerProduct.sh:#!/bin/bash piglit/usr/lib/piglit/tests/spec/glsl-1.20/compiler/built-in-functions/outerProduct-invalid-parameters.sh:#!/bin/bash piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_lod_tests.sh:#!/bin/bash piglit/usr/lib/piglit/tests/glslparsertest/glsl2/make_tex_rect_tests.sh:#!/bin/bash

The bash scripts are in the tests directory, we had planned to move the tests into the ptest pkg, but that would make piglit unusable without installing piglit-ptest.

---
  meta/recipes-graphics/piglit/piglit_git.bb |    5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-graphics/piglit/piglit_git.bb +0 -0
index 5c013ef..f468120 100644

meta/recipes-graphics/piglit/piglit_git.bb do_install() {

Quoted 9 lines
meta/recipes-graphics/piglit/piglit_git.bb +4 -2
@@ -45,4 +45,7 @@ do_install() {
 
  FILES_${PN}-dbg += "${libdir}/piglit/*/.debug/"
 
-RDEPENDS_${PN} = "python waffle python-json python-subprocess python-multiprocessing python-textutils python-netserver python-shell mesa-demos"
+RDEPENDS_${PN} = "python waffle python-json python-subprocess \
+	python-multiprocessing python-textutils python-netserver python-shell \
+	mesa-demos bash \
+	"
--

Hi Robert,

Quoted 1 line

how about to split out the tests into an extra package and let the package depends on bash?

That was the initial plan, but it didn't work as Ross commented, please see this thread for more info:

http://lists.openembedded.org/pipermail/openembedded-core/2014-August/096438.html

// Robert

Quoted 3 lines

Bye Henning

#4 lore raw
In reply to Henning Heinold
Quoted 1 line · Henning Heinold

how about to split out the tests into an extra package and let the package depends on bash?

Piglit is a test suite. A test suite without tests doesn't make sense. :)

Ross

#5 lore raw
In reply to Robert Yang
Quoted 3 lines · Robert Yang

The bash scripts are in the tests directory, we had planned to move the tests into the ptest pkg, but that would make piglit unusable without installing piglit-ptest.

Will there be a follow-up to add the ptest support?

Ross

#6 lore raw
Quoted 6 lines · Ross
Quoted 3 lines · Robert Yang

The bash scripts are in the tests directory, we had planned to move the tests into the ptest pkg, but that would make piglit unusable without installing piglit-ptest.

Will there be a follow-up to add the ptest support?

Yes, I think so, Chong had done that, he will update the ptest patch.

// Robert

Quoted 4 lines

Ross