Enable ADC support for Colibri VF61 modules
PATCH v2 1/1 Enable ADC support for Colibri VF61 modules
Changes since v1:
Sorted the nodes alphabetically
Initial discussion over here
[1]: https://lkml.org/lkml/2014/9/19/145
Sanchayan Maity (1):
ARM: dts: vf610-colibri: Add ADC support
arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
Signature · 1 line
1.7.9.5
PATCH v2 1/1 ARM: dts: vf610-colibri: Add ADC support
Enable ADC support for Colibri VF61 modules
--- arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/vf610-colibri.dtsi +10 -0
@@ -27,6 +27,16 @@ }; +&adc0 { + pinctrl-names = "default"; + status = "okay"; +}; + +&adc1 { + pinctrl-names = "default"; + status = "okay"; +}; + &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>;
Signature · 1 line
1.7.9.5
Re: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
Am 2014-09-19 13:26, schrieb Sanchayan Maity:
Quoted 19 lines
Enable ADC support for Colibri VF61 modules
Signed-off-by Sanchayan Maity <[email protected]>--- arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/vf610-colibri.dtsi +3
-0@@ -27,6 +27,16 @@ }; +&adc0 { + pinctrl-names = "default"; + status = "okay";
arch/arm/boot/dts/vf610-colibri.dtsi line 42
Quoted 10 lines
arch/arm/boot/dts/vf610-colibri.dtsi +7
-0+}; + +&adc1 { + pinctrl-names = "default"; + status = "okay"; +}; + &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>;
--
Stefan
Re: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
In reply to Sanchayan MaityQuoted 12 lines · Sanchayan Maity
Enable ADC support for Colibri VF61 modules
Signed-off-by Sanchayan Maity <[email protected]>--- arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/vf610-colibri.dtsi +0
-0
arch/arm/boot/dts/vf610-colibri.dtsi line 31
Quoted 5 lines
arch/arm/boot/dts/vf610-colibri.dtsi +2
-0@@ -27,6 +27,16 @@ }; +&adc0 { + pinctrl-names = "default";
Sorry for missing it, but I would expect properties pinctrl-names and pinctrl-0 appear as a couple. Should we drop property pinctrl-names here?
Shawn
Quoted 14 lines
arch/arm/boot/dts/vf610-colibri.dtsi +8
-0+ status = "okay"; +}; + +&adc1 { + pinctrl-names = "default"; + status = "okay"; +}; + &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>;Signature · 1 line
1.7.9.5
Re: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
Quoted 16 lines · Shawn Guo
Quoted 15 lines · Sanchayan Maity
Enable ADC support for Colibri VF61 modules
Signed-off-by Sanchayan Maity <[email protected]>--- arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/vf610-colibri.dtsi +0
-0@@ -27,6 +27,16 @@ };
Quoted 8 lines
arch/arm/boot/dts/vf610-colibri.dtsi line 31
Quoted 2 lines
arch/arm/boot/dts/vf610-colibri.dtsi +2
-0+&adc0 { + pinctrl-names = "default";Sorry for missing it, but I would expect properties pinctrl-names and pinctrl-0 appear as a couple. Should we drop property pinctrl-names here?
Shawn
We can actually drop this here. Vybrid has dedicated pads for 4 ADC channels. Since we are using only these dedicated ADC channels, no pin multiplexing is required. So we can drop the pinctrl-names property. Will clean and send out a v3 patch. Thanks for pointing this out.
- Sanchayan
Quoted 15 lines
Quoted 15 lines
arch/arm/boot/dts/vf610-colibri.dtsi +8
-0+ status = "okay"; +}; + +&adc1 { + pinctrl-names = "default"; + status = "okay"; +}; + &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>;Signature · 1 line
1.7.9.5