Skip to contentSkip to conversation

dhcp: fix for systemd service file

PATCH Superseded Chen Qi 2 participants 5 messages Sep 28, 2014 – Dec 18, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
author
#1 lore raw

PATCH 1/1 dhcp: fix for systemd service file

In reply to Chen Qi

1. Set Type=forking for dhcpd.service to make it start up correctly.
2. Add PIDFile=/var/run/dhcpd.pid
3. Do not force existence of the environment file.

Signed-off-by Chen Qi <[email protected]>
---
 meta/recipes-connectivity/dhcp/files/dhcpd.service | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-connectivity/dhcp/files/dhcpd.service +3 -1
index 8648f1a..4215173 100644
@@ -4,7 +4,9 @@ After=network.target
 After=time-sync.target
 
 [Service]
-EnvironmentFile=@SYSCONFDIR@/default/dhcp-server
+Type=forking
+PIDFile=/var/run/dhcpd.pid
+EnvironmentFile=-@SYSCONFDIR@/default/dhcp-server
 ExecStart=-@SBINDIR@/dhcpd -q $INTERFACES
 
 [Install]
Signature · 1 line
1.9.1

Chen Qi

author
#0 lore raw

cover dhcp: fix for systemd service file

The following changes since commit e6c6d3fcfd2faf867e8145d25c1ba197fb9ee6b5:

build-appliance-image: Update to dizzy head revision (2014-09-23 22:10:21 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib ChenQi/systemd-dhcpd
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/systemd-dhcpd

Chen Qi (1):
dhcp: fix for systemd service file

 meta/recipes-connectivity/dhcp/files/dhcpd.service | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
1.9.1
author
#2 lore raw
In reply to Chen Qi

ping

Quoted 24 lines · Chen Qi

1. Set Type=forking for dhcpd.service to make it start up correctly.
2. Add PIDFile=/var/run/dhcpd.pid
3. Do not force existence of the environment file.

Signed-off-by Chen Qi <[email protected]>
---
  meta/recipes-connectivity/dhcp/files/dhcpd.service | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-connectivity/dhcp/files/dhcpd.service +3 -1
index 8648f1a..4215173 100644
@@ -4,7 +4,9 @@ After=network.target
  After=time-sync.target
 
  [Service]
-EnvironmentFile=@SYSCONFDIR@/default/dhcp-server
+Type=forking
+PIDFile=/var/run/dhcpd.pid
+EnvironmentFile=-@SYSCONFDIR@/default/dhcp-server
  ExecStart=-@SBINDIR@/dhcpd -q $INTERFACES
 
  [Install]
#3 lore raw
Quoted 2 lines · ChenQi
Quoted 2 lines

1. Set Type=forking for dhcpd.service to make it start up correctly.
2. Add PIDFile=/var/run/dhcpd.pid

why forking? Starting dhcpd with '-f --no-pid' should chose the more simple non-forking variant without a clumsy.pidfile.

Enrico

author
#4 lore raw
Quoted 9 lines · Enrico Scholz
Quoted 2 lines · ChenQi
Quoted 2 lines

1. Set Type=forking for dhcpd.service to make it start up correctly.
2. Add PIDFile=/var/run/dhcpd.pid

why forking? Starting dhcpd with '-f --no-pid' should chose the more simple non-forking variant without a clumsy.pidfile.

Enrico

V2 sent, using '-f --no-pid'.

Regards,
Chen Qi