Skip to contentSkip to conversation

compress_doc.bbclass: improve manual file detection

PATCH In review Hongxu Jia 1 participant 3 messages Nov 8, 2014 – Nov 25, 2014

lore
Share & tools
lore

Hongxu Jia

author
#0 lore raw

cover compress_doc.bbclass: improve manual file detection

The following changes since commit 7bd03ac24114b2c6015144a37e0c3fb4037baea6:

bitbake: toastergui: fix invalid build url usage (2014-11-06 16:45:23 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-doc
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-doc

Hongxu Jia (1):
compress_doc.bbclass: improve manual file detection

 meta/classes/compress_doc.bbclass | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 compress_doc.bbclass: improve manual file detection

The previous detection missing the following manual file:
...
gawk-doc/usr/share/man/man3/readfile.3am libpcap-doc/usr/share/man/man3/pcap_dump_open.3pcap
...

We use re to imporve it.

---
 meta/classes/compress_doc.bbclass | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
meta/classes/compress_doc.bbclass +7 -4
index 6a4e635..afa9cd6 100644
@@ -136,11 +136,14 @@ def _is_info(file):
     return False
 
 def _is_man(file):
+    import re
+
     # It refers MANSECT-var in man(1.6g)'s man.config
-    flags = '.1:.1p:.8:.2:.3:.3p:.4:.5:.6:.7:.9:.0p:.tcl:.n:.l:.p:.o'.split(':')
-    for flag in flags:
-        if os.path.basename(file).endswith(flag):
-            return True
+    # ".1:.1p:.8:.2:.3:.3p:.4:.5:.6:.7:.9:.0p:.tcl:.n:.l:.p:.o"
+    # Not start with '.', and contain the above colon-seperate element
+    p = re.compile(r'[^\.]+\.([1-9lnop]|0p|tcl)')
+    if p.search(file):
+        return True
 
     return False
 
Signature · 1 line
1.9.1
author
#2 lore raw
In reply to Hongxu Jia
Quoted 8 lines · Hongxu Jia

The following changes since commit 7bd03ac24114b2c6015144a37e0c3fb4037baea6:

bitbake: toastergui: fix invalid build url usage (2014-11-06 16:45:23 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-doc
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-doc

Ping

//Hongxu

Quoted 6 lines

Hongxu Jia (1):
compress_doc.bbclass: improve manual file detection

  meta/classes/compress_doc.bbclass | 11 +++++++----
  1 file changed, 7 insertions(+), 4 deletions(-)