Skip to contentSkip to conversation

fix archiver missing tasks between do_unpack and do_patch

PATCH In review Hongxu Jia 1 participant 3 messages Dec 5, 2014 – Jan 8, 2015

lore
Share & tools
lore

Hongxu Jia

author
#0 lore raw

v2 cover fix archiver missing tasks between do_unpack and do_patch

Changed in V2:
As Richard Purdie suggested, use 'BB_TASKDEPDATA' to instead of bitbake internal variable '_task_deps'.

//Hongxu

The following changes since commit b8631416f12b8a904ce3deb036f9d5ce632937b0:

package_regex.inc: Update REGEX'es in order to find upstream versions correctly (2014-11-28 14:03:02 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-archiver
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-archiver

Hongxu Jia (1):
archiver: execute the probable tasks between do_unpack and do_patch

 meta/classes/archiver.bbclass | 119 +++++++++++++++++++++++++++++++++++++++---
 1 file changed, 112 insertions(+), 7 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH v2 1/1 archiver: execute the probable tasks between do_unpack and do_patch

While archiver inherited, we edit a recipe (such as gzip) to insert four tasks between do_patch and do_unpack:
...
addtask test1 after do_unpack before do_patch addtask test2 after do_unpack before do_test1 addtask test3 after do_test2 before do_test1 addtask test4 after do_test2 before do_test1
...

While building the recipe, the archiver will missing these four task in do_unpack_and_patch. Because it is hardcoded to execute do_unpach and do_patch, did not consider the probable tasks between them.

We make use of the value of BB_TASKDEPDATA which provided by metadata to compute the probable tasks between do_unpack and do_patch and execute them.

[Yocto #7018]

---
 meta/classes/archiver.bbclass | 119 +++++++++++++++++++++++++++++++++++++++---
 1 file changed, 112 insertions(+), 7 deletions(-)
meta/classes/archiver.bbclass +112 -7
index b598aa3..d52fe99 100644
@@ -269,6 +269,113 @@ def create_diff_gz(d, src_orig, src, ar_outdir):
     subprocess.call(diff_cmd, shell=True)
     bb.utils.remove(src_patched, recurse=True)
 
+# It helps to compute task dependencies between begin and end.
+# Here is an example, in a recipe we insert four tasks between do_patch
+# and do_unpack:
+# addtask test1 after do_unpack before do_patch
+# addtask test2 after do_unpack before do_test1
+# addtask test3 after do_test2 before do_test1
+# addtask test4 after do_test2 before do_test1
+#
+# We want to list the order of task dependencies:
+# ['do_unpack', 'do_test2', 'do_test3', 'do_test4', 'do_test1', 'do_patch']
+def list_sorted_tasks(begin, end, d):
+    parent_graph = construct_parent_graph(begin, end, d)
+
+    # Sort tasks according to the number of parent tasks incrementally
+    return [x[0] for x in sorted(parent_graph.iteritems(), key = lambda d:len(d[1]))]
+
+# List all parents for each tasks, such as:
+# From
+# task_deps = {
+#   'do_patch': ['do_test1', 'do_unpack'],
+#   'do_test1': ['do_test4', 'do_test3', 'do_test2', 'do_unpack']
+#   'do_test2': ['do_unpack'],
+#   'do_test3': ['do_test2'],
+#   'do_test4': ['do_test2']
+# }
+# to the parent graph we counstruct:
+# parent_graph = {
+#   'do_patch': ['do_test1', 'do_test2', 'do_test3', 'do_test4', 'do_unpack'],
+#   'do_test1': ['do_test4', 'do_test3', 'do_test2', 'do_unpack'],
+#   'do_test2': ['do_unpack'],
+#   'do_test3': ['do_test2', 'do_unpack'],
+#   'do_test4': ['do_test2', 'do_unpack'],
+#   'do_unpack': []
+# }
+#
+# We are not care about circualar dependency, the bitbake parser will do the
+# checking.
+def construct_parent_graph(begin, end, d):
+    task_deps = construct_task_deps(d)
+    def list_parents(task):
+        if task == begin:
+            return []
+        parents = task_deps[task]
+        for ptask in task_deps[task]:
+            parents += [x for x in list_parents(ptask) if x not in parents]
+        return parents
+
+    parent_graph = dict()
+    # All the tasks we need listed in the end's parent
+    end_parent = list_parents(end)
+    parent_graph[end] = end_parent
+    for task in end_parent:
+        parent_graph[task] = list_parents(task)
+
+    return parent_graph
+
+# Construct task_deps from BB_TASKDEPDATA, it lists parents for each
+# task within the current recipe, such as:
+# From
+# BB_TASKDEPDATA = {
+#   0: ['gzip', 'do_test1', '**/gzip_1.6.bb', set([1, 18, 19, 20])],
+#   1: ['gzip', 'do_unpack', '**/gzip_1.6.bb', set([5, 6])],
+#   2: ['gzip', 'do_patch', '**/gzip_1.6.bb', set([0, 1, 24])],
+#   ...
+#   5: ['gzip', 'do_fetch', '**/gzip_1.6.bb', set([])],
+#   6: ['gzip', 'do_wrlbuildlink', '**/gzip_1.6.bb', set([])],
+#   ...
+#   14: ['gzip', 'do_unpack_and_patch', '**/gzip_1.6.bb', set([2, 14])]
+#   ...
+#   18: ['gzip', 'do_test4', '**/gzip_1.6.bb', set([20])],
+#   19: ['gzip', 'do_test3', '**/gzip_1.6.bb', set([20])],
+#   20: ['gzip', 'do_test2', '**/gzip_1.6.bb', set([1])],
+#   ...
+#   24: ['quilt-native', 'do_populate_sysroot', '**/quilt-native_0.63.bb', set([23])],
+# }
+# to the task deps we counstruct:
+# task_deps = {
+#   'do_test2': ['do_unpack'],
+#   'do_test3': ['do_test2'],
+#   'do_fetch': [],
+#   'do_test1': ['do_unpack', 'do_test4', 'do_test3', 'do_test2'],
+#   'do_test4': ['do_test2'],
+#   'do_patch': ['do_test1', 'do_unpack'],
+#   'do_unpack_and_patch': ['do_patch'],
+#   'do_unpack': ['do_fetch', 'do_wrlbuildlink'],
+#   'do_wrlbuildlink': []
+# }
+def construct_task_deps(d):
+    taskdepdata = d.getVar('BB_TASKDEPDATA', True)
+    pn = d.getVar('PN', True)
+    task_deps = dict()
+    for task_id in taskdepdata:
+        # Filter out dep task which is not in the current recipe
+        if pn != taskdepdata[task_id][0]:
+            continue
+
+        task =  taskdepdata[task_id][1]
+        dep_ids = taskdepdata[task_id][3]
+        task_deps[task] = list()
+        for dep_id in dep_ids:
+            if pn != taskdepdata[dep_id][0] or dep_id == task_id:
+                continue
+            dep_task = taskdepdata[dep_id][1]
+            task_deps[task].append(dep_task)
+
+    return task_deps
+
 # Run do_unpack and do_patch
 python do_unpack_and_patch() {
     if d.getVarFlag('ARCHIVER_MODE', 'src', True) not in \
@@ -286,13 +393,11 @@ python do_unpack_and_patch() {
     # do_patch required 'B' existed).
     bb.utils.mkdirhier(d.getVar('B', True))
 
-    # The kernel source is ready after do_validate_branches
-    if bb.data.inherits_class('kernel-yocto', d):
-        bb.build.exec_func('do_unpack', d)
-        bb.build.exec_func('do_kernel_checkout', d)
-        bb.build.exec_func('do_validate_branches', d)
-    else:
-        bb.build.exec_func('do_unpack', d)
+    tasks = list_sorted_tasks('do_unpack', 'do_patch', d)
+    bb.note('execute %s in do_unpack_and_patch' % tasks)
+    # Do not execute 'do_patch' here
+    for task in tasks[0:-1]:
+        bb.build.exec_func(task, d)
 
     # Save the original source for creating the patches
     if d.getVarFlag('ARCHIVER_MODE', 'diff', True) == '1':
Signature · 1 line
1.9.1
author
#2 lore raw
In reply to Hongxu Jia
Quoted 3 lines · Hongxu Jia

Changed in V2:
As Richard Purdie suggested, use 'BB_TASKDEPDATA' to instead of bitbake internal variable '_task_deps'.

Ping

//Hongxu

Quoted 18 lines

//Hongxu

The following changes since commit b8631416f12b8a904ce3deb036f9d5ce632937b0:

package_regex.inc: Update REGEX'es in order to find upstream versions correctly (2014-11-28 14:03:02 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib hongxu/fix-archiver
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/fix-archiver

Hongxu Jia (1):
archiver: execute the probable tasks between do_unpack and do_patch

  meta/classes/archiver.bbclass | 119 +++++++++++++++++++++++++++++++++++++++---
  1 file changed, 112 insertions(+), 7 deletions(-)